From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 18:06:15 2024 Received: (at submit) by debbugs.gnu.org; 23 Nov 2024 23:06:15 +0000 Received: from localhost ([127.0.0.1]:59849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEzCh-0003w0-0o for submit@debbugs.gnu.org; Sat, 23 Nov 2024 18:06:15 -0500 Received: from lists.gnu.org ([209.51.188.17]:52550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEzCf-0003vq-Bs for submit@debbugs.gnu.org; Sat, 23 Nov 2024 18:06:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEzCf-0002nJ-5x for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 18:06:13 -0500 Received: from fout-a2-smtp.messagingengine.com ([103.168.172.145]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEzCa-0006YC-IC for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 18:06:12 -0500 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfout.phl.internal (Postfix) with ESMTP id 73F8713801DE for ; Sat, 23 Nov 2024 18:06:05 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Sat, 23 Nov 2024 18:06:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm3; t=1732403165; x=1732489565; bh=ckwfl7VTBFpOppLAErmCcUveaOCiDFRD TDNEUrvlpuw=; b=VoaTrjnvAuKcZ0fez/SF6mWLiYlWnkwJ2ZJttAuxT5OBdIpX rluqSA5hDulROrCp/GlV+5ij8k3o4eVspk7ANjRPgedIgdhfBESjSwbM0geLjmfO omEGplKYyAfMKSlHrSZ/VKJu5mSZBxdk0JXNAyYBgg1LDb5q8ygleAdDdeRIywTc kHi5W42Ihxf4/riDwgSiDFh+KGtfl0HZdWnGle+tWYABdsXWn7amVPGkZp0ukEZR 43Z40p5rns0o0/6RH8gaDQ0VizEspPRTp+gzF79b4R740uwN2Dw9B3rVGZsxAnS8 qzctBi5UTtR6+OSVWyQvmBjK5OFqMEWW1DJ/xw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1732403165; x= 1732489565; bh=ckwfl7VTBFpOppLAErmCcUveaOCiDFRDTDNEUrvlpuw=; b=B wa5ymQEOYwecILNxd7MMk8EJkIn2gnGui5Bka24+Z1412iEIJOYbuVbnUJl/+64P GeDruxVD1b4YodhZmggEX5bymxaDvewsY+dkfRHCnWWzKFS7d5lIKkvSuPvC5vi/ XDayTmEK0NkfRjd2MbAvThWwjd9KCdxNSy46Lq1GnFmo2vnMRx21ANYjtdj0K8SJ YWT01ZkNqF8UF2CmFOcCnhytsSieeSc4Bx/MQXYUEM8a99x8B3wJO1y4BUs8UlHA FdchZnGLqR5I2j0HLf1HmLycerG8QdRFwzxNxAuX30m7V9GAbA4QTL36PAjCJcnV oB4ASfZu7ZQBOUxFLjA8A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrgedvgddthecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkf ggtgesthdtredttddttdenucfhrhhomhepjhhohhhnuchmuhhhlhcuoehjmhesphhusgdr phhinhhkqeenucggtffrrghtthgvrhhnpeeghfdukeeuheduuefghffggeefvefhteejhe fhueelfffggeeutdffvdetueetudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehjmhesphhusgdrphhinhhkpdhnsggprhgtphhtthhopedupd hmohguvgepshhmthhpohhuthdprhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehg nhhurdhorhhg X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Sat, 23 Nov 2024 18:06:04 -0500 (EST) From: john muhl To: bug-gnu-emacs@gnu.org Subject: [PATCH] Avoid loading 'rx' at runtime in 'lua-ts-mode' X-Debbugs-Cc: philipk@posteo.net Date: Sat, 23 Nov 2024 17:06:03 -0600 Message-ID: <87o725czz8.fsf@pub.pink> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=103.168.172.145; envelope-from=jm@pub.pink; helo=fout-a2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Tags: patch Philip mentioned changing these rx-to-string forms to use literal over in bug#74235. I meant to include them there but guess it slipped my mind. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 18:08:45 2024 Received: (at 74499) by debbugs.gnu.org; 23 Nov 2024 23:08:45 +0000 Received: from localhost ([127.0.0.1]:59862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEzF7-00040t-AD for submit@debbugs.gnu.org; Sat, 23 Nov 2024 18:08:45 -0500 Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]:40953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEzF5-00040b-Fp for 74499@debbugs.gnu.org; Sat, 23 Nov 2024 18:08:44 -0500 Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id 5A2771140083; Sat, 23 Nov 2024 18:08:38 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-10.internal (MEProxy); Sat, 23 Nov 2024 18:08:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1732403318; x=1732489718; bh=2ReLPKnVPi 8yIPjgIYjUBNo7rjS53yUn4K4KjNv2ekI=; b=VfSE3O+BeL3FwZ0zjj1zGaq6r8 in9knNuahfDVTTeyvJ2cgZB7PxHyGEYNANN3wrMGQkyH6KJ+5ojd0t0xugImqLXU qORtl5QpNFr+IQuNBTN11Jb309YWMFMryXSsYW6H/Mzb522crEVwM1jqVbCOxGpH YOq3v5qV4LdcxsXZAiC0ESqrnfzSljMGn5e5ob56zsgo4AbfdEGK4xXi/LU033PM TBQWHxCsNY6ZH2LsO6KdSXVX9lOeiaWXjc3XrmVWT/PjSkU7a9FbFFZhgRvRUJFu yRiLCsXmdx5KOgbQ9kgG7+Q3MlXE0IiC2nuaqddtwa3gJHcuQpnw6BGhMvYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1732403318; x=1732489718; bh=2ReLPKnVPi8yIPjgIYjUBNo7rjS53yUn4K4 KjNv2ekI=; b=xpXlWj06pgF5ZbCSpawzGH48OCVR6a9iXfHZOtToFkNEMDpipqR Y8d3wFQtYOQynKMQr5hEhBJjP6F/bLbiqGahEmhez+wn4+ggw9+geDzBZ6AgpDD0 ZnFD+P/GZC5T6cz+A6KYVwunOfVI3svGRAI/ETUbDT6RMVADNTAjgimJRVy8D09Y INyOqRDqW1K28ACYnSbJQhpGe43cah58U7JX4lRRT8FcrYQgKT8p7AMKi6C3z78l NGamDp2e4ClmNUskHTiveCcFJj9XicMvFl8chPRmCO9lomlKhqBtRMICkTPPzqQt BFaztmjM3MzvJqglM42/1zVw2oyROzv7oXA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrgedvgddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefujg hffgffkfggtgesmhdtreertdertdenucfhrhhomhepjhhohhhnuchmuhhhlhcuoehjmhes phhusgdrphhinhhkqeenucggtffrrghtthgvrhhnpeffudeltdffhfejudehgefhfeeltd efteffgfdtveelieduheeuffdujeevffdvtdenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehjmhesphhusgdrphhinhhkpdhnsggprhgtphhtth hopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehphhhilhhiphhksehpohhs thgvohdrnhgvthdprhgtphhtthhopeejgeegleelseguvggssghughhsrdhgnhhurdhorh hg X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 23 Nov 2024 18:08:37 -0500 (EST) From: john muhl To: 74499@debbugs.gnu.org Subject: Re: bug#74499: [PATCH] Avoid loading 'rx' at runtime in 'lua-ts-mode' In-Reply-To: <87o725czz8.fsf@pub.pink> (john muhl's message of "Sat, 23 Nov 2024 17:06:03 -0600") References: <87o725czz8.fsf@pub.pink> User-Agent: mu4e 1.12.1; emacs 31.0.50 Date: Sat, 23 Nov 2024 17:08:37 -0600 Message-ID: <87h67xczuy.fsf@pub.pink> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74499 Cc: philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Avoid-loading-rx-at-runtime-in-lua-ts-mode.patch >From 309e80a336bce5c4a9191c87af636b8adfc04b97 Mon Sep 17 00:00:00 2001 From: john muhl Date: Sat, 23 Nov 2024 14:08:21 -0600 Subject: [PATCH] Avoid loading 'rx' at runtime in 'lua-ts-mode' * lisp/progmodes/lua-ts-mode.el (lua-ts-inferior-lua): Replace 'rx-to-string' and substitution with 'rx' and 'literal'. (Bug#74499) --- lisp/progmodes/lua-ts-mode.el | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el index f88fe0e49af..828636f359d 100644 --- a/lisp/progmodes/lua-ts-mode.el +++ b/lisp/progmodes/lua-ts-mode.el @@ -659,9 +659,9 @@ lua-ts-inferior-lua (setq-local comint-input-ignoredups t comint-input-ring-file-name lua-ts-inferior-history comint-prompt-read-only t - comint-prompt-regexp (rx-to-string `(: bol - ,lua-ts-inferior-prompt - (1+ space)))) + comint-prompt-regexp (rx bol + (literal lua-ts-inferior-prompt) + (1+ space))) (comint-read-input-ring t) (add-hook 'comint-preoutput-filter-functions (lambda (string) @@ -672,11 +672,11 @@ lua-ts-inferior-lua ;; accumulate in the output when sending regions ;; to the inferior process. (replace-regexp-in-string - (rx-to-string `(: bol - (* ,lua-ts-inferior-prompt - (? ,lua-ts-inferior-prompt) - (1+ space)) - (group (* nonl)))) + (rx bol + (* (literal lua-ts-inferior-prompt) + (? (literal lua-ts-inferior-prompt)) + (1+ space)) + (group (* nonl))) "\\1" string) ;; Re-add the prompt for the next line. lua-ts-inferior-prompt " "))) -- 2.47.0 --=-=-= Content-Type: text/plain john muhl writes: > Tags: patch > > Philip mentioned changing these rx-to-string forms to use literal > over in bug#74235. I meant to include them there but guess it > slipped my mind. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 20:22:32 2024 Received: (at 74499-done) by debbugs.gnu.org; 24 Nov 2024 01:22:32 +0000 Received: from localhost ([127.0.0.1]:60063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tF1KZ-0001yy-LS for submit@debbugs.gnu.org; Sat, 23 Nov 2024 20:22:31 -0500 Received: from mail-ed1-f53.google.com ([209.85.208.53]:58651) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tF1KX-0001yi-62 for 74499-done@debbugs.gnu.org; Sat, 23 Nov 2024 20:22:30 -0500 Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5cecbddb574so4541480a12.1 for <74499-done@debbugs.gnu.org>; Sat, 23 Nov 2024 17:22:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732411283; x=1733016083; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=1l1QtWQT0ltbgycgtgVi/KKjyKGuyN3VJ0ik6Oe3gik=; b=QIE+9rcr+z3e1/wVunoiyjSCvb+80bCNHVr73IGvPRjaysNaYaOP4fX5BNdPff3U1f QlVfe8QOlWhumVxt5AAdG0b5TVyIIztyemx1v6QDU3IFYy7UMnaGuqBmFLSn3Rsvrd8R GWpQnSU0io67DQLk4KB7e35WpSTUKVWnWg+Aumf971nR0wLtY8FnrNC3i5+crNh1Oztp iAaM0jE/FkGHz+cGM8MjMlCmbPni55Hd8NWF4oQ1c6iK7K0ovyu7Md/sYtVyjLALzThv Yt443wCIQnMvVa6myl4Haz9I4csiO0EKLiSo53YYB9x0gRd5R/rDcgXhluTz1Wy/MvIc QxPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732411283; x=1733016083; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1l1QtWQT0ltbgycgtgVi/KKjyKGuyN3VJ0ik6Oe3gik=; b=HdwqV6828KPlKyiq5eKwJpR55OJFYIro9edadLC8EtmmkZtt3iqvVFRaFGAANxdC9e O89oRG+ZimuMeqffqscLSBJv2JKkOHWuaWO9R27pt+K3XlzIsUj3TTUfR3MCKIXI39Rw dZ8UpuNSuBT/VqytUmCIj1l0ghuuADXJ4UM6vsCNYb5BGnIgWNNZz5BKOPovl+bSqu2o LK9JHcyy2pi+lf6RaXVrx4HbRc/I+DIHt5R+ZIi3IhGzJmxL2Gj7cZhS1AGnCCNdNVdA 15mKjBlSVn9cipj0rfBaGGiaQ3vSSQUXq3dfACPm0Q6xWrjh7G3XNWXRL8VoTRVPEl6/ sTVA== X-Forwarded-Encrypted: i=1; AJvYcCXp9MUn/Y4h8U//FI9iN21BdSNAAIJ3b4n5Pg5WgcEUaiIqulYhjayTRmqr4sKSXHEmaqALln/16cqW@debbugs.gnu.org X-Gm-Message-State: AOJu0YxLS9RDlpQv2p5ygUhjxk87oDjOnngmB0VmybHKQWtsTZ5dcWSh 83kDQ4+jX+URO9oWdWpVkMWQ0ihaAkByyFZcGKUEo3BNqhHEjqrDa9AEm4TbMhBO6oS9a5SlA5u M5hlbQvlxuh+CLbGAUWHTQD0EXqM= X-Gm-Gg: ASbGncvL1chbC6JQQq3fGPS8QCnaWLYexwUR6vWYAplRP2+2nP81lVBJAOlEXmeXTZX AZAlDYbVw0YzrqzCaDZOPhDipfmckeFN0Yg== X-Google-Smtp-Source: AGHT+IHbrmFdbCCLq8tdoka1w3tu/jMCtme3NCVuf1uuICj1LC/U5M64CvRgfTFrF4vptFdCOzjFRf9auDtkg4tGUgo= X-Received: by 2002:a05:6402:2789:b0:5cf:a1c1:5289 with SMTP id 4fb4d7f45d1cf-5d020695205mr6732919a12.21.1732411282987; Sat, 23 Nov 2024 17:21:22 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 23 Nov 2024 20:21:22 -0500 From: Stefan Kangas In-Reply-To: <87h67xczuy.fsf@pub.pink> References: <87o725czz8.fsf@pub.pink> <87h67xczuy.fsf@pub.pink> MIME-Version: 1.0 Date: Sat, 23 Nov 2024 20:21:22 -0500 Message-ID: Subject: Re: bug#74499: [PATCH] Avoid loading 'rx' at runtime in 'lua-ts-mode' To: john muhl , 74499-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74499-done Cc: philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) john muhl writes: > From 309e80a336bce5c4a9191c87af636b8adfc04b97 Mon Sep 17 00:00:00 2001 > From: john muhl > Date: Sat, 23 Nov 2024 14:08:21 -0600 > Subject: [PATCH] Avoid loading 'rx' at runtime in 'lua-ts-mode' > > * lisp/progmodes/lua-ts-mode.el (lua-ts-inferior-lua): > Replace 'rx-to-string' and substitution with 'rx' and 'literal'. > > (Bug#74499) Thanks for the patch, now installed on master as commit e71d714a815. I'm therefore closing this bug report. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 24 03:42:55 2024 Received: (at 74499) by debbugs.gnu.org; 24 Nov 2024 08:42:55 +0000 Received: from localhost ([127.0.0.1]:32793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tF8Ck-000703-Of for submit@debbugs.gnu.org; Sun, 24 Nov 2024 03:42:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tF8Ci-0006zo-ND for 74499@debbugs.gnu.org; Sun, 24 Nov 2024 03:42:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tF8Cc-0007Ov-T4; Sun, 24 Nov 2024 03:42:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=AOCabyNYY7qgdAFNUEDzXCohC3kIdtkbq5jRxZ/EWP4=; b=fSKcIHeoC8To b/HeMFihfS0bTQLLHBiBAlM8RBy8pg/qeaybQirFqvQ7FoleFVZ8Odq6ysxTFFFv0kOzMRrjeA3G3 XjZruOIaDBzGC9TwEuY2MrdfyD5hBm3j0ZBAo3Oh6rdr/BT2jilYI+MQgbRaF/zCJQyK0qjG2c1gU Wx3o7oTc0rnywJKGWZNp8NlIchk84PTtlXAWGFMZBup+cLSwXG+L3kEqIFqJB1sMhd7QtmfMbsZs4 njPOzQgzYPFNKlayhxdIkJ3wBuP3tfogPnfxzMvPCUpMXqzF1V0ExZY/AAKCsQKjmQr69M3sgqfzX D2r2LGpcpO1yh+T82lBT9w==; Date: Sun, 24 Nov 2024 10:42:41 +0200 Message-Id: <86jzctja4e.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Sat, 23 Nov 2024 20:21:22 -0500) Subject: Re: bug#74499: [PATCH] Avoid loading 'rx' at runtime in 'lua-ts-mode' References: <87o725czz8.fsf@pub.pink> <87h67xczuy.fsf@pub.pink> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74499 Cc: 74499@debbugs.gnu.org, jm@pub.pink X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Resent-To: bug-gnu-emacs@gnu.org > Cc: philipk@posteo.net > From: Stefan Kangas > Date: Sat, 23 Nov 2024 20:21:22 -0500 > > john muhl writes: > > > From 309e80a336bce5c4a9191c87af636b8adfc04b97 Mon Sep 17 00:00:00 2001 > > From: john muhl > > Date: Sat, 23 Nov 2024 14:08:21 -0600 > > Subject: [PATCH] Avoid loading 'rx' at runtime in 'lua-ts-mode' > > > > * lisp/progmodes/lua-ts-mode.el (lua-ts-inferior-lua): > > Replace 'rx-to-string' and substitution with 'rx' and 'literal'. > > > > (Bug#74499) > > Thanks for the patch, now installed on master as commit e71d714a815. lua-ts-mode is new in Emacs 30, so changes in it should generally be installed on the emacs-30 branch, unless they are dangerous or depend on functionality we only have on master. So I've now cherry-picked this change to the emacs-30 branch. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 24 05:38:17 2024 Received: (at 74499) by debbugs.gnu.org; 24 Nov 2024 10:38:17 +0000 Received: from localhost ([127.0.0.1]:33000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFA0P-0003ux-BB for submit@debbugs.gnu.org; Sun, 24 Nov 2024 05:38:17 -0500 Received: from mail-ed1-f44.google.com ([209.85.208.44]:48365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFA0N-0003un-V6 for 74499@debbugs.gnu.org; Sun, 24 Nov 2024 05:38:16 -0500 Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5cf6f367f97so4368424a12.0 for <74499@debbugs.gnu.org>; Sun, 24 Nov 2024 02:38:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732444635; x=1733049435; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=9M6fK1t7AMtAGfARYZM4t1RDOnv1kc96ywoHR5eZSFY=; b=MV5cQPGh7PpmhG/F1Owzr6TypyllAew7r8TzGlY/Pe8izMbTHxznRyKUdUzyEIlq4Z 0W4cxF+hdTHHq1qtRqOrEfTY5k1ZbUMhM+pNiUi+FQVDDZaMMtybdFtCP/rY4DXBkn8U XiEg1UAYgHXFqPlDzqw+RvfEa204yBbc/cDndQ7KAWWbZqIMCCO+8Qb4sYxNuH3k2cYg 3JQguhRX8LA/2JYHX8zsfGCzdgBuDiQveXXPpfTupv+yxtlaxPMbpI0QyGGe3wANrete RSjj7A5b8xHeGiG+Sx6+4HEjU4kJ7h9hZNbmYGZaNmA/DQkKu4z7X9TIjfNK8gtuXgl2 LbSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732444635; x=1733049435; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9M6fK1t7AMtAGfARYZM4t1RDOnv1kc96ywoHR5eZSFY=; b=moGcQXgTONrMP9CDihB3wHpUjdo6KxZD4GOw5rZagv0FAFshEgmPZQNCpwVR3gIXg/ 7Run1F0HGqPiAJreyzTjQCACNZJUpWjGv4dKYYif+W45wMF1zh69ri+cqkADkY84P2EL Mu7Emr+2N4FuU9dfJMaRFsLBXHjPCMF9RTzfG7wsAYVpJ1BQzVkLnqJMERFosSXefWed As4T3ytAcacO4N/J7gAZlQqJV/1hrsuXAa/vBjwq1wAtt/kbmyDwV76oYNvd2iFg0chC slYldCwJQ5nWy6rj2QcTyORd1hHRGKIuUS1EkERtXZ0azM3VXmGwYfAsHaer8C5vXFgU bKWA== X-Gm-Message-State: AOJu0Yz93cpaZd8D4YlOpYmNqgf1FBr0rGunoTnjR2iZPpJRM+wJKxI6 ON0b6BcCvKAlu8ATRz2CxYz8rKIqn61t/wsVwaTPt2w9C90relN7BRrVwE+JhrSeKsDpvD4m9VH P6FHN8Fa3S6s+Wt1D1CEQrpH8lcQ= X-Gm-Gg: ASbGncuX2udEy1mNzhLjDXLaE8SYRJHjpF85nUhecg/maxiKaEbC9POULMLR1FZFwLK ReY2PtjZBxUHXKR4nBCO4PtU17GGOXmddwA== X-Google-Smtp-Source: AGHT+IHVUrpvHrqpTDz+rjSrCgKEL0leWI6RHSibwk56deiPYgW12nOb7JZlTslBArtCqmdBkDJgxWlqNN5xSVkZ7cc= X-Received: by 2002:a50:cc9e:0:b0:5d0:2859:e919 with SMTP id 4fb4d7f45d1cf-5d02859ec56mr5688627a12.0.1732444634866; Sun, 24 Nov 2024 02:37:14 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 24 Nov 2024 02:37:14 -0800 From: Stefan Kangas In-Reply-To: <86jzctja4e.fsf@gnu.org> References: <87o725czz8.fsf@pub.pink> <87h67xczuy.fsf@pub.pink> <86jzctja4e.fsf@gnu.org> MIME-Version: 1.0 Date: Sun, 24 Nov 2024 02:37:14 -0800 Message-ID: Subject: Re: bug#74499: [PATCH] Avoid loading 'rx' at runtime in 'lua-ts-mode' To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74499 Cc: 74499@debbugs.gnu.org, jm@pub.pink X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > lua-ts-mode is new in Emacs 30, so changes in it should generally be > installed on the emacs-30 branch, unless they are dangerous or depend > on functionality we only have on master. So I've now cherry-picked > this change to the emacs-30 branch. Thanks for doing that. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 24 14:37:36 2024 Received: (at 74499) by debbugs.gnu.org; 24 Nov 2024 19:37:36 +0000 Received: from localhost ([127.0.0.1]:36092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFIQK-0007IZ-0y for submit@debbugs.gnu.org; Sun, 24 Nov 2024 14:37:36 -0500 Received: from mout01.posteo.de ([185.67.36.65]:39541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFIQG-0007IG-GZ for 74499@debbugs.gnu.org; Sun, 24 Nov 2024 14:37:34 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 53049240027 for <74499@debbugs.gnu.org>; Sun, 24 Nov 2024 20:37:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1732477045; bh=/4qEP/VWvkibGT8jzzxtxN8u/tgPvuTSueHfdhmMgco=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=Iyfjq4O0B5gYhf0pThfkNg8jn5EHsoeyZnatgZ2ijTDTYw6mcYWuBUKTkaWsST2rL QVcsc+09a34CHWccYvYt6PoHlQVATvvEMyRFlwAkmNFtgaGwEnNthZ4fJGKZXrQFM2 /47Fptvw9qO8Xhl7K+PJ+snYPOBi76o72T9btNQWYhABm4nl8D7mnbp/d6uUEtUIzK Q5Io00ndUOmxJhSFSV1ZRMp5CS40LCcqHMv+lJSj7wqSMVWrfBsSauywt6/LjCI6UH 8CRDQBUmDuQC0lpmS3a2TE6NFzehgMAPVgrQ6l9gcLFUUSyNeIucYviV5Dc9+dK5b7 JRN2jUNwEoPfg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XxJyD4SCpz6tvr; Sun, 24 Nov 2024 20:37:24 +0100 (CET) From: Philip Kaludercic To: john muhl Subject: Re: bug#74499: [PATCH] Avoid loading 'rx' at runtime in 'lua-ts-mode' In-Reply-To: <87h67xczuy.fsf@pub.pink> (john muhl's message of "Sat, 23 Nov 2024 17:08:37 -0600") References: <87o725czz8.fsf@pub.pink> <87h67xczuy.fsf@pub.pink> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Date: Sun, 24 Nov 2024 19:37:23 +0000 Message-ID: <87ttbwtocs.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74499 Cc: 74499@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) john muhl writes: > From 309e80a336bce5c4a9191c87af636b8adfc04b97 Mon Sep 17 00:00:00 2001 > From: john muhl > Date: Sat, 23 Nov 2024 14:08:21 -0600 > Subject: [PATCH] Avoid loading 'rx' at runtime in 'lua-ts-mode' > > * lisp/progmodes/lua-ts-mode.el (lua-ts-inferior-lua): > Replace 'rx-to-string' and substitution with 'rx' and 'literal'. > > (Bug#74499) > --- > lisp/progmodes/lua-ts-mode.el | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el > index f88fe0e49af..828636f359d 100644 > --- a/lisp/progmodes/lua-ts-mode.el > +++ b/lisp/progmodes/lua-ts-mode.el > @@ -659,9 +659,9 @@ lua-ts-inferior-lua > (setq-local comint-input-ignoredups t > comint-input-ring-file-name lua-ts-inferior-history > comint-prompt-read-only t > - comint-prompt-regexp (rx-to-string `(: bol > - ,lua-ts-inferior-prompt > - (1+ space)))) > + comint-prompt-regexp (rx bol > + (literal lua-ts-inferior-prompt) > + (1+ space))) Strictly speaking this could have introduced a regression, since literal quotes the string, and it might be that someone has set `lua-ts-inferior-prompt' to a quoted regular expression that is now double-quoted, but I assume that this is an acceptable edge-case? > (comint-read-input-ring t) > (add-hook 'comint-preoutput-filter-functions > (lambda (string) > @@ -672,11 +672,11 @@ lua-ts-inferior-lua > ;; accumulate in the output when sending regions > ;; to the inferior process. > (replace-regexp-in-string > - (rx-to-string `(: bol > - (* ,lua-ts-inferior-prompt > - (? ,lua-ts-inferior-prompt) > - (1+ space)) > - (group (* nonl)))) > + (rx bol > + (* (literal lua-ts-inferior-prompt) > + (? (literal lua-ts-inferior-prompt)) > + (1+ space)) > + (group (* nonl))) > "\\1" string) > ;; Re-add the prompt for the next line. > lua-ts-inferior-prompt " "))) From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 25 21:04:27 2024 Received: (at 74499) by debbugs.gnu.org; 26 Nov 2024 02:04:27 +0000 Received: from localhost ([127.0.0.1]:43467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFkwE-0002wl-Il for submit@debbugs.gnu.org; Mon, 25 Nov 2024 21:04:26 -0500 Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]:34591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFkw5-0002wM-CO for 74499@debbugs.gnu.org; Mon, 25 Nov 2024 21:04:23 -0500 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfhigh.phl.internal (Postfix) with ESMTP id B22E511400B4; Mon, 25 Nov 2024 21:04:11 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Mon, 25 Nov 2024 21:04:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1732586651; x=1732673051; bh=TEKO77iRJn1N9pTPNfjn1jBSca5TBOg/Ww/tjv9I7YE=; b= H6hLVJ7NRWPpfpHs5ThlKtYP+6JMIrr5aS6Wux1FedCZ+STXYm/ZaizSOkTaOHD/ 9xgpFeWj1WBQdbFBNBtez63LZeoG6QSPKTgtRPkENFcK77uRtZvWkeVW6VQfoWsl uZawKK2RyS03EuDkVT8UZKODmMOI2Utt7lMJn+EWRCpBpLN4RgE5CtMxOicTYxZl OMbuNG+L6TyTGSwH+jieVABKcXmYK4Ww56x+ZTCT/YBaFKNs5iPYf9J/K+TViS6A md1aKABy6N0ozTEUOKQ8EwZVHKoIdU5jymLSdW8+AIcaQZYwO/EGk5UtopaE8sIe 45utBs9hYd/1loyYSfN+Ow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1732586651; x= 1732673051; bh=TEKO77iRJn1N9pTPNfjn1jBSca5TBOg/Ww/tjv9I7YE=; b=V NcHl+/tqtxmFvlIl08j7j/DctkM1FpZqX2dBuISUK166PtoUkuQ85LvgfBO5rkd3 EJyEcvb+SHx0CXvZiI7Lt8zRpnasbmzxoPoGUe/dlnZcSylGNsNyn9XSKSpKnz0F 9WoZBeW8L80JeA9b39vD5vufqKNCVqZeXTwOXfMSEeMWPskhIzy42sc/rWVQgQjr /nLpfB/oAbRkqK26pSax6QGvp6/qTSf8s5t8KHWdK3XItvXd9tN1UZoeSEmIN6zn tH88iWM7ty2WQpKXqqGo9DpFHL+Bbs/TzlwCVEVxm4VH3f/MAWC7OxsweUEkF8hV +OyyAwfV7A9gfaCyqx1lg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrgeeigdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtgfesthhqredttderjeen ucfhrhhomhepjhhohhhnuchmuhhhlhcuoehjmhesphhusgdrphhinhhkqeenucggtffrrg htthgvrhhnpeegveehvddttedvkeduvddttdehhfdvgffgvdfgiedtjeduhefhffejtddv veevkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hjmhesphhusgdrphhinhhkpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhu thdprhgtphhtthhopeejgeegleelseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpth htohepphhhihhlihhpkhesphhoshhtvghordhnvght X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Nov 2024 21:04:10 -0500 (EST) From: john muhl To: Philip Kaludercic Subject: Re: bug#74499: [PATCH] Avoid loading 'rx' at runtime in 'lua-ts-mode' In-Reply-To: <87ttbwtocs.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 24 Nov 2024 19:37:23 +0000") References: <87o725czz8.fsf@pub.pink> <87h67xczuy.fsf@pub.pink> <87ttbwtocs.fsf@posteo.net> User-Agent: mu4e 1.12.1; emacs 31.0.50 Date: Mon, 25 Nov 2024 20:04:09 -0600 Message-ID: <87a5dm92ee.fsf@pub.pink> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74499 Cc: 74499@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Philip Kaludercic writes: > john muhl writes: > >> From 309e80a336bce5c4a9191c87af636b8adfc04b97 Mon Sep 17 00:00:00 2001 >> From: john muhl >> Date: Sat, 23 Nov 2024 14:08:21 -0600 >> Subject: [PATCH] Avoid loading 'rx' at runtime in 'lua-ts-mode' >> >> * lisp/progmodes/lua-ts-mode.el (lua-ts-inferior-lua): >> Replace 'rx-to-string' and substitution with 'rx' and 'literal'. >> >> (Bug#74499) >> --- >> lisp/progmodes/lua-ts-mode.el | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.= el >> index f88fe0e49af..828636f359d 100644 >> --- a/lisp/progmodes/lua-ts-mode.el >> +++ b/lisp/progmodes/lua-ts-mode.el >> @@ -659,9 +659,9 @@ lua-ts-inferior-lua >> (setq-local comint-input-ignoredups t >> comint-input-ring-file-name lua-ts-inferior-history >> comint-prompt-read-only t >> - comint-prompt-regexp (rx-to-string `(: bol >> - ,lua-ts-infe= rior-prompt >> - (1+ space)))) >> + comint-prompt-regexp (rx bol >> + (literal lua-ts-inferior-p= rompt) >> + (1+ space))) > > Strictly speaking this could have introduced a regression, since literal > quotes the string, and it might be that someone has set > `lua-ts-inferior-prompt' to a quoted regular expression that is now > double-quoted, but I assume that this is an acceptable edge-case? It doesn=E2=80=99t strike me as a significant issue but I don=E2=80=99t cus= tomize prompts so maybe it=E2=80=99s in my blind spot. Feel free to revert it or not as you see fit. From unknown Fri Jun 20 07:22:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 24 Dec 2024 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator