GNU bug report logs - #74481
[PATCH 0/2] Handle corner cases of 'guix import go'

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: Christopher Baines <guix <at> cbaines.net>, Josselin Poiret <dev <at> jpoiret.xyz>, Tobias Geerinckx-Rice <me <at> tobias.gr>, Mathieu Othacehe <othacehe <at> gnu.org>, 74481 <at> debbugs.gnu.org
Subject: [bug#74481] [PATCH 1/2] git: Catch Git errors when updating cached checkout.
Date: Thu, 26 Dec 2024 22:17:32 +0100

Simon Tournier <zimon.toutoune <at> gmail.com> skribis:

> On Tue, 17 Dec 2024 at 11:55, Ludovic Courtès <ludo <at> gnu.org> wrote:
>
>> We have something that can now return #f instead of throwing an
>> exception.  The many users of this interface are not prepared for this;
>> worse, getting #f instead of an exception means we lose information as
>> to why ‘update-cached-checkout’ or similar failed.
>
> Thanks for explaining.
>
> Well, I’d say “mouais“ :-) about « lose information » since I added some
> ’pk’ here or there before finding the relevant piece of code.  So the
> exception is not very helpful, not to say fully useless, IMHO.

The exception conveys information about the failure: no space left on
device, host unreachable, invalid certificate, etc.

Often ‘with-git-error-handling’ is used at the top-level because the
error is not recoverable so we just want to print an error message and
exit.

In other cases, we explicitly want to catch, say, GIT_ENOTFOUND because
there’s a fallback path in this case.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.