GNU bug report logs - #74481
[PATCH 0/2] Handle corner cases of 'guix import go'

Previous Next

Full log

Message #38 received at 74481 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 74481 <at> debbugs.gnu.org, Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: Re: [bug#74481] [PATCH v2] import: go: Warn instead of error out
 when Git fails.
Date: Thu, 26 Dec 2024 22:14:41 +0100

Simon Tournier <zimon.toutoune <at> gmail.com> skribis:

> * guix/import/go.scm (git-checkout-hash): Return some hash although updating
> the cache fails.
>
> Change-Id: I87e7701023a5f76f5d1494827473616e6a1275aa

[...]

> +                  (catch 'git-error
> +                    (lambda ()
> +                      (update-cached-checkout url
> +                                              #:ref
> +                                              `(tag-or-commit . ,reference)))
> +                    (lambda (key err)
> +                      (warning (G_ "update-cached-checkout: ~s ~s~%") key err)

Rather something like:

  (warning (G_ "failed to check out ~s from Git repository at '~a': ~a~%")
           reference url (git-error-message err))

Apart from that LGTM!

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.