From unknown Tue Jun 17 20:14:24 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#74474 <74474@debbugs.gnu.org> To: bug#74474 <74474@debbugs.gnu.org> Subject: Status: 30.0.92; treesit-defun-prefer-top-level is still used in js, ruby-ts-mode, typescript-ts-mode, c-ts-mode and php-ts-mode Reply-To: bug#74474 <74474@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:14:24 +0000 retitle 74474 30.0.92; treesit-defun-prefer-top-level is still used in js, = ruby-ts-mode, typescript-ts-mode, c-ts-mode and php-ts-mode reassign 74474 emacs submitter 74474 Vincenzo Pupillo severity 74474 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 08:35:59 2024 Received: (at submit) by debbugs.gnu.org; 22 Nov 2024 13:35:59 +0000 Received: from localhost ([127.0.0.1]:53671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tETpH-0002cP-EG for submit@debbugs.gnu.org; Fri, 22 Nov 2024 08:35:59 -0500 Received: from lists.gnu.org ([209.51.188.17]:49394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tETpF-0002cH-E4 for submit@debbugs.gnu.org; Fri, 22 Nov 2024 08:35:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tETpF-0005JI-4d for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2024 08:35:57 -0500 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tETpD-0002E5-HR for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2024 08:35:56 -0500 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2ffa8092e34so7869101fa.1 for ; Fri, 22 Nov 2024 05:35:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732282552; x=1732887352; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=lbS5edI0je6U465TUTXD7AZnzx8WZnkmg06IvCCfbxc=; b=ma64zZwTMpwLX0VZCuvZeAi4/cX78HYJWISNpNCp17w6GknjJkiD2EfFWcQhVitNdz rPMi9haOtbFtOaVbTt3jPh78HvbrgB5ZtMNyDjENQd6cRGIWVuSG+pEjZYi/VuWGqwWV vPcqc3HEycU/Tp7uDPqh3Fy4bQTm2lgiWR/2ZG+RyB6ch6+oCCKk5Ew4ytmhXS3v/7n5 a089Lt2+y98E2ugJDpFi1UP0qxuT0X40eYwJm9zeb2HsrLwcJwOESfCgDzoTZ1lvdJ0E mKhzjqroAB86ZEl+VDY7DjdqznvQcssnKaeIXIt13HEiFR227hbS0YjT8LLwdQpndaHV jBsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732282552; x=1732887352; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lbS5edI0je6U465TUTXD7AZnzx8WZnkmg06IvCCfbxc=; b=n/CpKS/KRGD+TI3anVOwCPC6cKHSgUig1yCIRnQh1A9qphR3Jk18NUgt5xDRlu8+Am 3zAjMs0wha9zsf5E5PQtEBP4OdkyFoL0TPZ2x847yPioiqMg1s53omibe0DbYiG9/Bjv wMpUZRCh2tFfJ+dHjWDnb12fr4QfDi2323Vqts/92eZdw8HH9fX0TEooHJpOJfHdtruc hSWPvZZXbFKWJKFQjTzKRIc6d6XfKI2JuNyLAk7eTd4/ItN/44rAmf9G04+FN9C7zfvz M8UN9vZ03J0s1+aTCv/4bI7CAUUFVrLkcHq49RoWsIjGRvurqT/UrGjp1SKJ+UUw85ro m+iA== X-Gm-Message-State: AOJu0Yz7wcr1BzrnVtYC2nJvQ/9RxsOlh+N+tEf1j0RMz75fW6oCpXfU 1QVbMZYTjO5t8o8YK8Fop2Zngi8PZiTH74WQTmfM5lLFOOpW/ZCUp0s+4g== X-Gm-Gg: ASbGnctk/rZoERtKozbq7zVDa5LBpl5EaKxQsqYT4ZCciO9UnUryqPB7yuaGNxCOJPk zgC+V9Aoz+AYr6M7Y+nLpUBqLYmRnc69jDGtbjqXGKsfA/A1XOrZTBKA9H5grHSi6NDvRbHyCdW AgAu9HRonKFj3CHnk1orHFwIokfd1oKPfNuZLSISZ9S+P6NU2LlIrF1D/UH239Ew37HH4e6FGxC v/Ry4G/VRlgB45pnCT5Oe7yrSIhwlhB8Qvprbcpeg5HTPaH0mnNmaDqQEraJRiUoTcnqiLfK/Gn 0oKtqv41ie8fwg== X-Google-Smtp-Source: AGHT+IHDXSfLe7dPFU+xGC7ZKKJoXmPg/4bmHRn7oc+u/fpcEdlFUtiIAz0lunqy+zaHd+JbBvyW2w== X-Received: by 2002:a2e:bd16:0:b0:2ff:a665:8d6d with SMTP id 38308e7fff4ca-2ffa712ab38mr15697711fa.22.1732282552298; Fri, 22 Nov 2024 05:35:52 -0800 (PST) Received: from fedora.localnet (2-230-139-124.ip202.fastwebnet.it. [2.230.139.124]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa50b532688sm101700266b.125.2024.11.22.05.35.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2024 05:35:51 -0800 (PST) From: Vincenzo Pupillo To: Bug Emacs Subject: 30.0.92; treesit-defun-prefer-top-level is still used in js, ruby-ts-mode, typescript-ts-mode, c-ts-mode and php-ts-mode Date: Fri, 22 Nov 2024 14:35:50 +0100 Message-ID: <1951718.7Z3S40VBb9@fedora> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Received-SPF: pass client-ip=2a00:1450:4864:20::22b; envelope-from=v.pupillo@gmail.com; helo=mail-lj1-x22b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Ciao, I am writing a treesitter-based version of mhtml (email threads https:// lists.gnu.org/archive/html/emacs-devel/2024-11/msg00079.html). I started from what I did for php-ts-mode. In php-ts-mode the variable treesit-defun-prefer-top-level is initialized to t. This variable, whose use I had borrowed from c-ts-mode, no longer exists. >From the Changelog.4 : 2022-12-19 Stefan Kangas Merge from origin/emacs-29 67bc96c9d94 Remove treesit-defun-prefer-top-level and friends 4f9bccef556 Add yaml-ts-mode (Bug#60105) f9cb144d45a Fix indentation in json-ts-mode (bug#60123) 3d348c46e78 ; Handle nil ARG in treesit-beginning/end-of-defun 1a66435dda3 New input method 'cyrillic-chuvash' b9227c502d7 ; Improve wording of 'format' doc string This variable is also used by other major modes, with different value: lisp/progmodes/c-ts-mode.el 1259: (setq-local treesit-defun-prefer-top-level t) lisp/progmodes/typescript-ts-mode.el 465: (setq-local treesit-defun-prefer-top-level t) lisp/progmodes/ruby-ts-mode.el 1202: (setq-local treesit-defun-prefer-top-level nil) lisp/progmodes/js.el 3919: (setq-local treesit-defun-prefer-top-level t) treesit-defun-prefer-top-level should have been replaced by treesit-defun- tactic which, however, is initialized by default with a value that should match only (setq treesit-defun-prefer-top-level nil). Is it possible that this is related to problems similar to those indicated in bug#73404? Thank you. Vincenzo From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 09:08:22 2024 Received: (at 74474) by debbugs.gnu.org; 22 Nov 2024 14:08:22 +0000 Received: from localhost ([127.0.0.1]:53718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEUKb-0003yA-8o for submit@debbugs.gnu.org; Fri, 22 Nov 2024 09:08:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEUKV-0003xr-LX for 74474@debbugs.gnu.org; Fri, 22 Nov 2024 09:08:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEUKQ-0002tR-9d; Fri, 22 Nov 2024 09:08:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=r19Zb/BqWmJZRFC9+hb2fM+yivG/x7RQdyDXkRxx0Eg=; b=dmVtakWgixsA tITeCdIiUZ2PYSXZYiGYiGauDXePbpLtVp2102pvCH2z7M9FSTEeJyKmD8kgNxrIntLUZMsNdC1R5 mhHo4zCUatxz+24+xJUkOP3r5phoFQLGPBX1JmSq9+KCiZUvcM4s1Ou8EgFrZr/vWeu8OrMh7RYAB XSYwwcfkNkbyoWQgjGzL/N/8D1aAfeGnv6p7MHZQA/A2Uil4rMTmThX81VB3h5ItFzqXRnUy9tKmv AWL7rAvnjJ/AEFbNLFfendvl4yB+WzUp6nfXYLIEesWg4J/fWZShgPYYWy6Zt/K8ExttFGUGDFmit 8Z1NZ/HFmSOztl/WKXkLJQ==; Date: Fri, 22 Nov 2024 16:08:03 +0200 Message-Id: <865xofnyyk.fsf@gnu.org> From: Eli Zaretskii To: Vincenzo Pupillo , Yuan Fu In-Reply-To: <1951718.7Z3S40VBb9@fedora> (message from Vincenzo Pupillo on Fri, 22 Nov 2024 14:35:50 +0100) Subject: Re: bug#74474: 30.0.92; treesit-defun-prefer-top-level is still used in js, ruby-ts-mode, typescript-ts-mode, c-ts-mode and php-ts-mode References: <1951718.7Z3S40VBb9@fedora> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74474 Cc: 74474@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Vincenzo Pupillo > Date: Fri, 22 Nov 2024 14:35:50 +0100 > > Ciao, > I am writing a treesitter-based version of mhtml (email threads https:// > lists.gnu.org/archive/html/emacs-devel/2024-11/msg00079.html). > I started from what I did for php-ts-mode. > In php-ts-mode the variable treesit-defun-prefer-top-level is initialized to > t. > This variable, whose use I had borrowed from c-ts-mode, no longer exists. > >From the Changelog.4 : > 2022-12-19 Stefan Kangas > > Merge from origin/emacs-29 > > 67bc96c9d94 Remove treesit-defun-prefer-top-level and friends > 4f9bccef556 Add yaml-ts-mode (Bug#60105) > f9cb144d45a Fix indentation in json-ts-mode (bug#60123) > 3d348c46e78 ; Handle nil ARG in treesit-beginning/end-of-defun > 1a66435dda3 New input method 'cyrillic-chuvash' > b9227c502d7 ; Improve wording of 'format' doc string > > This variable is also used by other major modes, with different value: > > lisp/progmodes/c-ts-mode.el > 1259: (setq-local treesit-defun-prefer-top-level t) > > lisp/progmodes/typescript-ts-mode.el > 465: (setq-local treesit-defun-prefer-top-level t) > > lisp/progmodes/ruby-ts-mode.el > 1202: (setq-local treesit-defun-prefer-top-level nil) > > lisp/progmodes/js.el > 3919: (setq-local treesit-defun-prefer-top-level t) > > treesit-defun-prefer-top-level should have been replaced by treesit-defun- > tactic which, however, is initialized by default with a value that should > match only (setq treesit-defun-prefer-top-level nil). > > Is it possible that this is related to problems similar to those indicated in > bug#73404? Yuan, any comments? From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 24 00:59:48 2024 Received: (at 74474) by debbugs.gnu.org; 24 Nov 2024 05:59:48 +0000 Received: from localhost ([127.0.0.1]:60384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tF5et-0006nE-O3 for submit@debbugs.gnu.org; Sun, 24 Nov 2024 00:59:48 -0500 Received: from mail-pl1-f175.google.com ([209.85.214.175]:49580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tF5er-0006n5-W8 for 74474@debbugs.gnu.org; Sun, 24 Nov 2024 00:59:46 -0500 Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-21285c1b196so33345425ad.3 for <74474@debbugs.gnu.org>; Sat, 23 Nov 2024 21:59:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732427925; x=1733032725; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kwgXi5/nSoZshChAXzxxzJzeregWZismaSRGlp41Whc=; b=d19//kYnLg2ixS/t04BefqKWh/Ql65hEh6gAHo1D96mXu1+Ih1ACMk2/iRsmo8Asgt bJbrouefOm84m94f/g2m5aG6kDzjqERgDLULbTfxIkb7t2xJ/aUdmnLbaSAGKLtbMImU IELjZQJ5vugXB84oWxY9Llr35LX/5BTQo/qBZx3pAWrzTopgllwriP91yAFWcAVxU2jF V1Hd9P+X67rptz5XlhIwJKZV1a7ro0t5SDUT5z7Sth4ykoGGmXzfL+2g9o3OWCQNANwh z92znn2xAJNxgCkKXvKNhy5DC9fzfdExDf3RKEEqIb/oevboONIWMT+eTS8/MOHhVIvK by4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732427925; x=1733032725; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kwgXi5/nSoZshChAXzxxzJzeregWZismaSRGlp41Whc=; b=pGqTTXPDkR8iFOEdGYEdT99SlRiUViyUu65mf0gOB9lGmitQSxj9tm6ugZy1D2rsjx IaGhNkOFpICcaVM9GhSz1oziMdMbeCX1qbHTNkQ9hJTm4gjg5ZSK7aBCQ1RJTcawGIr8 eENd3p/3PkEZBqRAxM4jXuhfWIyOCf3bxgLNaMGwExctoqowKfnYnOTF2ctLy1GefkAA r0SWIicIYTAg8AoFOD/AiJr9OMwbVCf7/olutp1vkfSYkp8oD6iDC97dYoeOAlvmPkyV vXAPRyx2tA7/0R0pHLjbkaEwYh8Cq8qpQRi5sZAM+4OFOteDZ/VngYrb5KLLFugFSA3Y BVwQ== X-Forwarded-Encrypted: i=1; AJvYcCW0AidaaqJZR5ut8CI+fGnl98ICTLcjuPspWt8Ip/YjReF5itxu8H5IyvMgGSBBtLOorRvkCg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzKvFIR5fKGAodSM1Nt0MRaH/nc9u7sbV7Z7lWrqjDPVLaOnbCd zqSUjOBBNbgSCQV0u5oS2AWgiuV4xhYzmlOWjvZScxM7s/COBSU7 X-Gm-Gg: ASbGncuiPsZ1GAnoc9F7T+m8GqeSeih16tmaJ4QM9IQtru9c5ekvc9bPHadjS/wRgcO ZW7NkYFMLpRNJekEbPi0FJQcmoum0aCTyEFkiFjvdx4PbG7Cc6fSpZsOuZXzxCBWM4Yp0GrJ2vV JfrLA86DGPJKh9z/umohj7OcQTCYFU9ZKatJgbmeT49AYUyZj98dYMo8N39XV7NYjGBFno/JXDf AmAhk/y8v+dxtAQqZoJUDEpSjB9xWv/kXwYF6u1Z34sXJBSP0ZEtqi3iZ0mV0CS8YOl6lP5TA== X-Google-Smtp-Source: AGHT+IHiAacMTwUpsRWLWHtp7coc3+EfBMqKVHrPvZByNb8n3y8WVL82wTTT6nzCr2HID9Sm7rUeYA== X-Received: by 2002:a17:902:dad1:b0:20b:c17f:9dad with SMTP id d9443c01a7336-2129f75b590mr118058245ad.53.1732427924987; Sat, 23 Nov 2024 21:58:44 -0800 (PST) Received: from smtpclient.apple ([2601:646:8f81:6120:9db4:d34c:247c:f36b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2129db8d449sm41166995ad.28.2024.11.23.21.58.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Nov 2024 21:58:43 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: bug#74474: 30.0.92; treesit-defun-prefer-top-level is still used in js, ruby-ts-mode, typescript-ts-mode, c-ts-mode and php-ts-mode From: Yuan Fu In-Reply-To: <865xofnyyk.fsf@gnu.org> Date: Sat, 23 Nov 2024 21:58:32 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <314BA6F4-E5A2-4137-A635-B578B67AADEE@gmail.com> References: <1951718.7Z3S40VBb9@fedora> <865xofnyyk.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3776.700.51) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74474 Cc: Vincenzo Pupillo , 74474@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Nov 22, 2024, at 6:08=E2=80=AFAM, Eli Zaretskii = wrote: >=20 >> From: Vincenzo Pupillo >> Date: Fri, 22 Nov 2024 14:35:50 +0100 >>=20 >> Ciao, >> I am writing a treesitter-based version of mhtml (email threads = https:// >> lists.gnu.org/archive/html/emacs-devel/2024-11/msg00079.html).=20 >> I started from what I did for php-ts-mode.=20 >> In php-ts-mode the variable treesit-defun-prefer-top-level is = initialized to=20 >> t.=20 >> This variable, whose use I had borrowed from c-ts-mode, no longer = exists. >>> =46rom the Changelog.4 : =20 >> 2022-12-19 Stefan Kangas >>=20 >> Merge from origin/emacs-29 >>=20 >> 67bc96c9d94 Remove treesit-defun-prefer-top-level and friends >> 4f9bccef556 Add yaml-ts-mode (Bug#60105) >> f9cb144d45a Fix indentation in json-ts-mode (bug#60123) >> 3d348c46e78 ; Handle nil ARG in treesit-beginning/end-of-defun >> 1a66435dda3 New input method 'cyrillic-chuvash' >> b9227c502d7 ; Improve wording of 'format' doc string >>=20 >> This variable is also used by other major modes, with different = value: >>=20 >> lisp/progmodes/c-ts-mode.el >> 1259: (setq-local treesit-defun-prefer-top-level t) >>=20 >> lisp/progmodes/typescript-ts-mode.el >> 465: (setq-local treesit-defun-prefer-top-level t) >>=20 >> lisp/progmodes/ruby-ts-mode.el >> 1202: (setq-local treesit-defun-prefer-top-level nil) >>=20 >> lisp/progmodes/js.el >> 3919: (setq-local treesit-defun-prefer-top-level t) >>=20 >> treesit-defun-prefer-top-level should have been replaced by = treesit-defun- >> tactic which, however, is initialized by default with a value that = should=20 >> match only (setq treesit-defun-prefer-top-level nil).=20 Ohhh, yes. That=E2=80=99s my bad, I should=E2=80=99ve scanned for this = variable and remove them. Fortunately, just setting this variable = doesn=E2=80=99t do any harm. Also, IIRC, this variable lived and died = before we released Emacs 29, so there=E2=80=99s no = backward-compatibility breakage. For context, treesit-defun-prefer-top-level was replaced by = treesit-defun-tactic. treesit-defun-tactic is supposed to be set by the = user. So major mode don=E2=80=99t need to worry about it, unless they = want to. TBH major modes didn=E2=80=99t need to set = treesit-defun-prefer-top-level either, people probably copied it from = c-ts-mode, which do need to set it. >>=20 >> Is it possible that this is related to problems similar to those = indicated in=20 >> bug#73404? Not quite, that one is about sexp navigation, which this variable = doesn=E2=80=99t affect. Plus this variable isn=E2=80=99t used now = anyway. >=20 > Yuan, any comments? Thanks for the ping! I was going to push the change to emacs-30, but = want to check with you first. Is it ok to push to emacs-30? As I = described, the change is cosmetic, we stopped using that variable before = Emacs 29 released. Yuan= From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 24 02:50:27 2024 Received: (at 74474) by debbugs.gnu.org; 24 Nov 2024 07:50:27 +0000 Received: from localhost ([127.0.0.1]:60603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tF7Nz-0004EE-2U for submit@debbugs.gnu.org; Sun, 24 Nov 2024 02:50:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tF7Nw-0004Dz-PM for 74474@debbugs.gnu.org; Sun, 24 Nov 2024 02:50:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tF7Nr-0000h7-IO; Sun, 24 Nov 2024 02:50:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+84z0ImypNsfpE4lH3Ba65rvp9lgAWC5M5ayErk70b4=; b=BZJV/vM5FDyG bdaZbPeQSH3SMEvv2SunjC9zVYq4agSdzRQ19a1kHLZWbmUaZJZf4vTNCTn9jJuPSZ47IXYDq9WYJ iFdgNlubscqFcJbyJnBo2oTHgVAHkCurjK6UQimCY3ceQILvOveOkirO4iklF5fioyf2NjmTY4xd5 H18cfOUcJs2jX4Q5sgRTo5zX4+B082vRd9zUmr6lRW6j4BWYHsxRF3ikPew9veWZT5MaSgn+Z16Lz QoK7lW+i4GIYip6ShbO6QasADyxuRjn/YKPm+1W/fTIl+ESTu8lWJUNiROjubrMZ6u3ihMc3b7h5b wD+GzJbgPSs7O+h6/bEW9A==; Date: Sun, 24 Nov 2024 09:50:17 +0200 Message-Id: <86r071jcjq.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: <314BA6F4-E5A2-4137-A635-B578B67AADEE@gmail.com> (message from Yuan Fu on Sat, 23 Nov 2024 21:58:32 -0800) Subject: Re: bug#74474: 30.0.92; treesit-defun-prefer-top-level is still used in js, ruby-ts-mode, typescript-ts-mode, c-ts-mode and php-ts-mode References: <1951718.7Z3S40VBb9@fedora> <865xofnyyk.fsf@gnu.org> <314BA6F4-E5A2-4137-A635-B578B67AADEE@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74474 Cc: v.pupillo@gmail.com, 74474@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Sat, 23 Nov 2024 21:58:32 -0800 > Cc: Vincenzo Pupillo , > 74474@debbugs.gnu.org > > > Yuan, any comments? > > Thanks for the ping! I was going to push the change to emacs-30, but want to check with you first. Is it ok to push to emacs-30? As I described, the change is cosmetic, we stopped using that variable before Emacs 29 released. If you mean the change which removes this variable from those 4 files, then yes, please install on emacs-30, and thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 24 20:50:38 2024 Received: (at 74474-done) by debbugs.gnu.org; 25 Nov 2024 01:50:38 +0000 Received: from localhost ([127.0.0.1]:36649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFOFK-0008GT-0m for submit@debbugs.gnu.org; Sun, 24 Nov 2024 20:50:38 -0500 Received: from mail-pl1-f177.google.com ([209.85.214.177]:57351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFOFH-0008GE-KD for 74474-done@debbugs.gnu.org; Sun, 24 Nov 2024 20:50:36 -0500 Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2124ccf03edso36887065ad.2 for <74474-done@debbugs.gnu.org>; Sun, 24 Nov 2024 17:50:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732499370; x=1733104170; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=x+jXVEdM/VK2rHcNzx8kh87fyI7b7w4HmbyK1tUPUsI=; b=NrkqN0K9PeEWq439f/1fg6e0SjPVES4TN0r9IrO7kuJUK+mT2rCTr/1WX9XW8N/jnv RhB572ZoFq33oh0T/mP6EO4zlK0GGMDNT2AZ5zWpe/+nCuczgrcJVWO4fiD9W0JMfXO7 bI0FaOd6fu8l2arlKzuXJENtIGB2+RL4/2rmy8SR1ZxVmhyNUn0hu7Mir2ZDPh6Hmul9 zPXf8ss0aVK7YgPKkr/y/Sz4PMYL3fIov8c4oLo3w96uSAYDSv+Gv5F+D28luf7/mQ5R 4ejKzkgfhDKU+SlsAjBNGcCQmQN0R09ETrcZ2QlxJnKpWo7l8TUTkh54Iel4OeUOsr3C 1ZKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732499370; x=1733104170; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x+jXVEdM/VK2rHcNzx8kh87fyI7b7w4HmbyK1tUPUsI=; b=s3erMPpD8NHjQMAFUe7NXmqCSnpJQ701Ho2CbUQWMO/hejA15G5zJNRKfy51ILFEyD 9dPVh+NPfbVpFIDBqHtKHfhevpP4VwMGziQ0H6XMkN+oa14qcOXAlhTO5ek0ppWuEgc4 rXVll6/AMS7OKfqvH2qoDejevOS6NGatYtD6cFOtFhKc8Bu5CmBBpo7gysLi8cBapqT1 zP0JNgyyToAHiCS62Wz/amaK/qMDa/AwZZPgs7rzcRk4JG1qaoWwk+djSPs9OqefD+Or LxizEa77TskIbMlZktvszhBDsAhwylA8zUrRBEoebjVIn3khtpP6Qdpn+gN6dfnEMcE3 iHKw== X-Forwarded-Encrypted: i=1; AJvYcCVMn6oRPa8yigHgTPZNjHeNdrgq0updgZ6UCWOuSjsdXQY9txgVHgbvbmVYmisOPhUghcHUBE4Ac8/H@debbugs.gnu.org X-Gm-Message-State: AOJu0YyGtxdeBvpB69mLlyhpUFBmXsqNZsYJpq9L0zQrAdeX5fiqspM8 FFPXS8n3x7zH14m6h0g5K5LxRUaPjDK/Dp3VT8WhKQ4Jeoox3MyC X-Gm-Gg: ASbGnctVAGy7F5c0FiUo4vKAKNfpLl3FpZTHMi2iGVrOusAZ8zJ3mCQJuyUHFiWDVrZ vJ7Z283zFHFKeKGAkWrHCiidC4Iv5Uq/yk3Un0HPffragycLnhcmDTtXWKt98U1jyL6RcmYLuIh bSbHqE3yIzf3506zE4pI+qgFUNLiArRcl/EoD1EzIJjbGBLyMtvVOELzVe6CeIUP3EXo1ZjO5kx EJ3T5oFGgbrclNWpkblckD7vxhs344qzrj4Ytnxi9bYNqukooiDaFTU/CfGXdPdMS9CAbEyhQ== X-Google-Smtp-Source: AGHT+IHMTzNHO4OFGt6oW4ARXq6BQs3iJM+hj8jESXJVoi1gfUvjbBc+SFwjt6zVjNM0KUu7SvfTEw== X-Received: by 2002:a17:902:e80b:b0:202:26d:146c with SMTP id d9443c01a7336-2129f72e2demr157302575ad.5.1732499369992; Sun, 24 Nov 2024 17:49:29 -0800 (PST) Received: from smtpclient.apple ([2601:646:8f81:6120:9db4:d34c:247c:f36b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2129dc147c9sm53116035ad.211.2024.11.24.17.49.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Nov 2024 17:49:29 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: bug#74474: 30.0.92; treesit-defun-prefer-top-level is still used in js, ruby-ts-mode, typescript-ts-mode, c-ts-mode and php-ts-mode From: Yuan Fu In-Reply-To: <86r071jcjq.fsf@gnu.org> Date: Sun, 24 Nov 2024 17:49:18 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <3FC3389C-20A2-4CCC-B995-8E92A6A8591C@gmail.com> References: <1951718.7Z3S40VBb9@fedora> <865xofnyyk.fsf@gnu.org> <314BA6F4-E5A2-4137-A635-B578B67AADEE@gmail.com> <86r071jcjq.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3776.700.51) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74474-done Cc: Vincenzo Pupillo , 74474-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Nov 23, 2024, at 11:50=E2=80=AFPM, Eli Zaretskii = wrote: >=20 >> From: Yuan Fu >> Date: Sat, 23 Nov 2024 21:58:32 -0800 >> Cc: Vincenzo Pupillo , >> 74474@debbugs.gnu.org >>=20 >>> Yuan, any comments? >>=20 >> Thanks for the ping! I was going to push the change to emacs-30, but = want to check with you first. Is it ok to push to emacs-30? As I = described, the change is cosmetic, we stopped using that variable before = Emacs 29 released. >=20 > If you mean the change which removes this variable from those 4 files, > then yes, please install on emacs-30, and thanks. Great, I pushed the change to emacs-30. Yuan= From unknown Tue Jun 17 20:14:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 23 Dec 2024 12:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator