GNU bug report logs - #74473
[PATCH 1/1] gnu: geteltorito: Use new home page and origin.

Previous Next

Full log

View this message in rfc822 format

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Julian Flake <flake <at> uni-koblenz.de>, 74473 <at> debbugs.gnu.org
Subject: [bug#74473] [PATCH 1/1] gnu: geteltorito: Use new home page and origin.
Date: Fri, 22 Nov 2024 13:03:13 +0100

Am Freitag, dem 22.11.2024 um 12:26 +0100 schrieb Julian Flake:
> * gnu/packages/cdrom.scm
> (geteltorito)[https://github.com/rainer042/geteltorito]:
Should be [home-page].
> Use new URI.
> 
> Change-Id: Idc5c2b935419855805b5f9727540192de093b1b4
> ---
>  gnu/packages/cdrom.scm | 25 ++++++++++++++++---------
>  1 file changed, 16 insertions(+), 9 deletions(-)
> 
> diff --git a/gnu/packages/cdrom.scm b/gnu/packages/cdrom.scm
> index ef02787465..9f9acf19a2 100644
> --- a/gnu/packages/cdrom.scm
> +++ b/gnu/packages/cdrom.scm
> @@ -15,6 +15,7 @@
>  ;;; Copyright © 2019 Eric Bavier <bavier <at> member.fsf.org>
>  ;;; Copyright © 2020 Timotej Lazar <timotej.lazar <at> araneo.si>
>  ;;; Copyright © 2023 Zheng Junjie <873216071 <at> qq.com>
> +;;; Copyright © 2024 Julian Flake <flake <at> uni-koblenz.de>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -725,13 +726,16 @@ (define-public geteltorito
>      (name "geteltorito")
>      (version "0.6")
>      (home-page
> -    
> "https://userpages.uni-koblenz.de/~krienke/ftp/noarch/geteltorito/")
> -    (source (origin
> -              (method url-fetch)
> -              (uri (string-append home-page name "-" version
> ".tar.gz"))
> -              (sha256
> -               (base32
> -               
> "1gkbm9ahj2mgqrkrfpibzclsriqgsbsvjh19fr815vpd9f6snkxv"))))
> +     "https://github.com/rainer042/geteltorito")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/rainer042/geteltorito")
> +             (commit "d6c7ba03c3c4c5bc4cb68e3602c9427b0912f16f")))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> "15dh5ibmqr3pyxyiica4r9nn1xk1j0gr3xy2s3n8b4n7b2mn8n01"))))
Nitpick: home-page should be below arguments.  Prefer to keep the
changes small unless making deliberate format changes.

Also, do use git-version when referring to a particular commit.
>      (build-system gnu-build-system)
>      (arguments
>       `(#:tests? #f ; No tests.
> @@ -742,8 +746,11 @@ (define-public geteltorito
>           (replace 'install
>             (lambda* (#:key outputs #:allow-other-keys)
>               (let ((out (assoc-ref outputs "out")))
> -               (install-file "geteltorito"
> -                             (string-append out "/bin"))))))))
> +               (install-file "geteltorito.pl"
> +                             (string-append out "/bin"))
> +               (rename-file (string-append out
> "/bin/geteltorito.pl")
> +                            (string-append out "/bin/geteltorito"))
> +               (chmod (string-append out "/bin/geteltorito")
> #o555)))))))
These changes are not mentioned anywhere in the ChangeLog and I presume
become necessary due to actual code changes.

Cheers.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.