GNU bug report logs - #74470
Bug: guile-fibers@1.1.1 arm crosscompile fails due to patch on 1.3.1 version

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74470 in the body.
You can then email your comments to 74470 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Razvan Lixandru <razlix77 <at> gmail.com>
To: bug-guix <at> gnu.org
Subject: Bug: guile-fibers <at> 1.1.1 arm crosscompile fails due to patch on 1.3.1
 version
Date: Fri, 22 Nov 2024 10:46:13 +0200

Hello,

It looks like this commit:
https://git.savannah.gnu.org/cgit/guix.git/commit/gnu/packages/guile-xyz.scm?id=20c7b8dd04e421a139a02438cf1ddfdfe544a446
causes guile-fiber <at> 1.1.1 which is pulled by shepherd to fail:

phase `unpack' succeeded after 0.0 seconds
starting phase `apply-cross-build-fix-patch'
patching file build-aux/guile.am
Hunk #1 FAILED at 22.
1 out of 1 hunk FAILED -- saving rejects to file build-aux/guile.am.rej
error: in phase 'apply-cross-build-fix-patch': uncaught exception:
%exception #<&invoke-error program: "patch" arguments: ("--force"
"-p1" "-i" "/gnu/store/97r1rrxa9ghrj5qp3din1pg6p2lcpzyv-guile-fibers-cross-build-fix.patch")
exit-status: 1 term-signal: #f stop-signal: #f>
phase `apply-cross-build-fix-patch' failed after 0.0 seconds
command "patch" "--force" "-p1" "-i"
"/gnu/store/97r1rrxa9ghrj5qp3din1pg6p2lcpzyv-guile-fibers-cross-build-fix.patch"
failed with status 1
build process 18 exited with status 256

This happens on both arm-linux-gnueabihf and arm64-linux-gnu.
I think it is happening because the 1.1.1 version inherits 1.3.1.
package and it overrides the source, but the patch is still being
applied.

I guess this brakes all arm* crossbuilds.

Cheers,
Razvan

Message #8 received at 74470 <at> debbugs.gnu.org (full text, mbox):

From: <janneke <at> gnu.org>
To: Razvan Lixandru <razlix77 <at> gmail.com>
Cc: 74470 <at> debbugs.gnu.org
Subject: Re: bug#74470: Bug: guile-fibers <at> 1.1.1 arm crosscompile fails due
 to patch on 1.3.1 version
Date: Fri, 22 Nov 2024 13:15:58 +0100

Razvan Lixandru writes:

Hi,

> It looks like this commit:
> https://git.savannah.gnu.org/cgit/guix.git/commit/gnu/packages/guile-xyz.scm?id=20c7b8dd04e421a139a02438cf1ddfdfe544a446
> causes guile-fiber <at> 1.1.1 which is pulled by shepherd to fail:
[..]
> starting phase `apply-cross-build-fix-patch'
> patching file build-aux/guile.am
> Hunk #1 FAILED at 22.

Oops.  What about something like this patch (untested)

--8<---------------cut here---------------start------------->8---
diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 044a491259..a21289d368 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -937,6 +937,13 @@ (define-public guile-fibers-1.1
            guile-3.0            ;for 'guild compile
            ;; Gettext brings 'AC_LIB_LINKFLAGS_FROM_LIBS'
            gettext-minimal))
+    (arguments
+     (if (%current-target-system)
+         (substitute-keyword-arguments (package-arguments guile-fibers)
+           ((#:phases phases)
+            #~(modify-phases #$phases
+                (delete 'apply-cross-build-fix-patch))))
+         (package-arguments guile-fibers)))
     (inputs
      (list guile-3.0))                            ;for libguile-3.0.so
     (supported-systems
--8<---------------cut here---------------end--------------->8---

> This happens on both arm-linux-gnueabihf and arm64-linux-gnu.
> I think it is happening because the 1.1.1 version inherits 1.3.1.
> package and it overrides the source, but the patch is still being
> applied.

Yes.

> I guess this brakes all arm* crossbuilds.

Sorry!

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke <at> gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com

Message #13 received at 74470-done <at> debbugs.gnu.org (full text, mbox):

From: <janneke <at> gnu.org>
To: Razvan Lixandru <razlix77 <at> gmail.com>
Cc: 74470-done <at> debbugs.gnu.org
Subject: Re: bug#74470: Bug: guile-fibers <at> 1.1.1 arm crosscompile fails due
 to patch on 1.3.1 version
Date: Fri, 22 Nov 2024 22:21:59 +0100

Razvan Lixandru writes:

> This patch seems to fix the problem, I was able to crosscompile the
> package wit it added in my own channel, I could not get guix to use it
> but that is another issue :)

Ah, that's both good and bad :)

> Hope to see this merged soon :)

Pushed to master as 02477c6a4fe84058c6e06e3065363835c5be8f57.

Thanks for your report.
Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke <at> gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.