GNU bug report logs - #74467
31.0.50; org-protocol emacsclient.desktop change is not fully functional

Previous Next

Full log

View this message in rfc822 format

From: Björn Bidar <bjorn.bidar <at> thaodan.de>
To: Ihor Radchenko <yantar92 <at> posteo.net>
Cc: 74467 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, binarin <at> binarin.info
Subject: bug#74467: 31.0.50; org-protocol emacsclient.desktop change is not fully functional
Date: Sun, 05 Jan 2025 20:13:09 +0200

Ihor Radchenko <yantar92 <at> posteo.net> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>> ...  Ihor
>> seemed to say that if this can be supported, there could be an
>> alternative patch for fixing this issue, and I'd like to see that
>> alternative patch to decide which one is simpler and/or more elegant.
>
> See the attached.
> If Emacs can handle file URIs, we can simply use %U field code.
>
> diff --git a/etc/emacsclient.desktop b/etc/emacsclient.desktop
> index 4395d3b02bc..c339ac93687 100644
> --- a/etc/emacsclient.desktop
> +++ b/etc/emacsclient.desktop
> @@ -3,7 +3,7 @@ Name=Emacs (Client)
>  GenericName=Text Editor
>  Comment=Edit text
>  MimeType=text/english;text/plain;text/x-makefile;text/x-c++hdr;text/x-c++src;text/x-chdr;text/x-csrc;text/x-java;text/x-moc;text/x-pascal;text/x-tcl;text/x-tex;application/x-shellscript;text/x-c;text/x-c++;x-scheme-handler/org-protocol;
> -Exec=sh -c "if [ -n \\"\\$*\\" ]; then exec emacsclient --alternate-editor= --display=\\"\\$DISPLAY\\" \\"\\$@\\"; else exec emacsclient --alternate-editor= --create-frame; fi" sh %F
> +Exec=sh -c "if [ -n \\"\\$*\\" ]; then exec emacsclient --alternate-editor= --display=\\"\\$DISPLAY\\" \\"\\$@\\"; else exec emacsclient --alternate-editor= --create-frame; fi" sh %U

Do we need the shell code here? if DISPLAY is defined emacsclient could
shurely forward it to Emacs.

Shellcode is part of the issue.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.