GNU bug report logs - #74461
[PATCH] Add go-work-ts-mode

Previous Next

Package: emacs;

Reported by: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>

Date: Thu, 21 Nov 2024 13:59:02 UTC

Severity: wishlist

Tags: confirmed, patch

Fixed in version 31.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #99 received at 74461-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: 74461-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Gabriel Santos <gabrielsantosdesouza <at> disroot.org>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#74461: [PATCH] Add go-work-ts-mode
Date: Tue, 11 Feb 2025 21:54:11 -0800
Version: 31.1

Randy Taylor <dev <at> rjt.dev> writes:

> On Wednesday, January 1st, 2025 at 21:24, Gabriel Santos
> <gabrielsantosdesouza <at> disroot.org> wrote:
>>
>>
>> Updated the patch to follow the suggestions made by Randy:
>>
>> - Rename go-mod-ts-mode--in-directive-p
>> - Add latest grammar versions of go-mod and go-work
>> - Removed the mention of the now defunct go-work-ts-mode--syntax-table
>> - Added back the syntax table for the regular Go tree-sitter mode
>>
>> --
>> Gabriel Santos
>
> Thanks, looks good to me.
>
> Eli, please install if you have no further comments. Thanks in
> advance.

The patch LGTM also, so I installed it on master as commit aade1b707c6.
Please note the changes I did to the commit message for any future
contributions.  Thanks Gabriel, for the patch.

I'm consequently closing this bug report.




This bug report was last modified 103 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.