GNU bug report logs - #74461
[PATCH] Add go-work-ts-mode

Previous Next

Package: emacs;

Reported by: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>

Date: Thu, 21 Nov 2024 13:59:02 UTC

Severity: wishlist

Tags: confirmed, patch

Fixed in version 31.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #68 received at 74461 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Stefan Monnier <monnier <at> iro.umontreal.ca>,
 74461 <at> debbugs.gnu.org
Subject: Re: bug#74461: [PATCH] Add go-work-ts-mode
Date: Thu, 02 Jan 2025 00:53:00 +0000
On Wednesday, December 25th, 2024 at 15:17, Gabriel Santos <gabrielsantosdesouza <at> disroot.org> wrote:
> 
> 
> Actually, since it's not that big of an issue, I'll send in the patch now.
> 
> Em 22 de dezembro de 2024 09:12:21 BRT, Gabriel Santos gabrielsantosdesouza <at> disroot.org escreveu:
> 
> > > I'll make the changes you requested and send the updated patch after I'm done.
> > 
> > I just finished updating the patch,
> > but I think it's best to only send it after
> > the point about *--in-directive-p is clarified.

I just replied to that in another email.

> > --
> > Gabriel Santos
> 
> 
> --
> Gabriel Santos

Thanks, I've got a few comments.

Recently, a commentary section:
;;; Tree-sitter language versions
was added to go-ts-mode. Perhaps you can adapt what you wrote in
the commentary section to that?

-  :syntax-table go-ts-mode--syntax-table
Did you mean to remove this for go-work-ts-mode instead?
The commit also mentions `go-work-ts-mode--syntax-table'
which doesn't exist anymore.




This bug report was last modified 103 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.