From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 19 19:35:54 2010 Received: (at submit) by debbugs.gnu.org; 20 Nov 2010 00:35:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PJbQo-0004kL-5x for submit@debbugs.gnu.org; Fri, 19 Nov 2010 19:35:54 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PJbPi-0004jf-DL for submit@debbugs.gnu.org; Fri, 19 Nov 2010 19:34:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJbUg-0007DH-Bk for submit@debbugs.gnu.org; Fri, 19 Nov 2010 19:39:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:35510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJbUg-0007DD-9X for submit@debbugs.gnu.org; Fri, 19 Nov 2010 19:39:54 -0500 Received: from [140.186.70.92] (port=47472 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJbUf-0001C7-4D for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2010 19:39:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJbUe-0007Ci-0l for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2010 19:39:53 -0500 Received: from mail-ew0-f41.google.com ([209.85.215.41]:36407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJbUd-0007CL-S2 for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2010 19:39:51 -0500 Received: by ewy25 with SMTP id 25so3143382ewy.0 for ; Fri, 19 Nov 2010 16:39:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:content-type; bh=+bFaWRBpbD8ePUVfCthY93s6d3SNW11k36qe5S6bvYY=; b=CyzbsUj5VPk3cfHxWb6PdOmsGn3cmjD5uZqFbFlG3F4JX3BEsAICIuECAlfB/Pf0Ti LDIuRwdJF2KEzgmS+LuFMIUcbakt0N2Ebwn1FI/0kLXi7FQILYlzAyeFR6C7FtELD/XV urYFWOnV9XMgK5qRa6BllHblfwuWOWwfcWGmE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=A/WR/3hSyTKcVy/cNDDAot56F7g//YGy4Y3xbK471z97PBtW8Vl5TAak9Z8Qwr+RrT R/+zPegxMxhQp6QDXb1pRWg/MJ1qYwWFNS6CfE6w9ouBvFRHMLE5qZ3ZMD6XG/sJGrep kCmcTsZEQ5GzKy9e9wCBLumgmoyrUdckDW6SY= MIME-Version: 1.0 Received: by 10.213.33.74 with SMTP id g10mr2387309ebd.1.1290213589980; Fri, 19 Nov 2010 16:39:49 -0800 (PST) Received: by 10.213.21.196 with HTTP; Fri, 19 Nov 2010 16:39:49 -0800 (PST) Date: Fri, 19 Nov 2010 16:39:49 -0800 Message-ID: Subject: Emacs 23.2 [windows] - Buffer overrun bug with ebrowse.exe From: Joe Matarazzo To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 19 Nov 2010 19:35:52 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) When the input file ends with a C++ style "//" comment line, without a newline at the end, the parser will attempt to read past the end of the input buffer. This produces undefined results, among them putting the parser in a bogus state that makes all subsequent input files parse incorrectly. Here's a possible fix: --- old/ebrowse.c 2010-04-03 15:26:07 -0700 +++ new/ebrowse.c 2010-11-19 16:36:13 -0800 @@ -1784,6 +1784,10 @@ case '/': while (GET (c) && c != '\n') ; + + if (c == 0) + return YYEOF; + INCREMENT_LINENO; break; I'm not subscribed to the list. Please direct any follow up questions directly to my email. Thanks, Joe From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 21 14:22:11 2010 Received: (at control) by debbugs.gnu.org; 21 Nov 2010 19:22:11 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PKFUI-0003hI-I9 for submit@debbugs.gnu.org; Sun, 21 Nov 2010 14:22:11 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PKDPj-0001Ns-Fd for control@debbugs.gnu.org; Sun, 21 Nov 2010 12:09:20 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ap4PAGPi6ExMCqtq/2dsb2JhbAChW31xAYYitVOFSwSEWo1pgzoC X-IronPort-AV: E=Sophos;i="4.59,232,1288584000"; d="scan'208";a="83138262" Received: from 76-10-171-106.dsl.teksavvy.com (HELO ceviche.home) ([76.10.171.106]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 21 Nov 2010 12:14:31 -0500 Received: by ceviche.home (Postfix, from userid 20848) id B4B80660F5; Sun, 21 Nov 2010 12:14:31 -0500 (EST) From: Stefan Monnier Subject: Re: bug#7446: Emacs 23.2 [windows] - Buffer overrun bug with ebrowse.exe Message-ID: References: Date: Sun, 21 Nov 2010 12:14:31 -0500 In-Reply-To: (Joe Matarazzo's message of "Fri, 19 Nov 2010 16:39:49 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain To: undisclosed-recipients:; X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: control X-Mailman-Approved-At: Sun, 21 Nov 2010 14:22:08 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.1 (-) tags 7446 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 27 04:25:14 2010 Received: (at 7446-done) by debbugs.gnu.org; 27 Nov 2010 09:25:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PMH1u-0000kL-92 for submit@debbugs.gnu.org; Sat, 27 Nov 2010 04:25:14 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PMH1s-0000k5-8j for 7446-done@debbugs.gnu.org; Sat, 27 Nov 2010 04:25:12 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LCJ00H00DGH6500@a-mtaout20.012.net.il> for 7446-done@debbugs.gnu.org; Sat, 27 Nov 2010 11:29:56 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.63.39]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LCJ00HLGEDU9500@a-mtaout20.012.net.il>; Sat, 27 Nov 2010 11:29:55 +0200 (IST) Date: Sat, 27 Nov 2010 11:32:03 +0200 From: Eli Zaretskii Subject: Re: bug#7446: Emacs 23.2 [windows] - Buffer overrun bug with ebrowse.exe In-reply-to: X-012-Sender: halo1@inter.net.il To: Joe Matarazzo Message-id: <83tyj35cz0.fsf@gnu.org> References: X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 7446-done Cc: 7446-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > Date: Fri, 19 Nov 2010 16:39:49 -0800 > From: Joe Matarazzo > Cc: > > When the input file ends with a C++ style "//" comment line, without a > newline at the end, the parser will attempt to read past the end of > the input buffer. This produces undefined results, among them putting > the parser in a bogus state that makes all subsequent input files > parse incorrectly. Here's a possible fix: Thanks, I applied this patch to the Emacs 23 branch. From unknown Mon Aug 11 18:18:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 25 Dec 2010 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator