GNU bug report logs - #74448
30.0.92; c-ts-mode outlines only work with GNU or emacs style

Previous Next

Full log

Message #41 received at 74448 <at> debbugs.gnu.org (full text, mbox):

From: Filippo Argiolas <filippo.argiolas <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: 74448 <at> debbugs.gnu.org
Subject: Re: bug#74448: 30.0.92; c-ts-mode outlines only work with GNU or
 emacs style
Date: Thu, 13 Feb 2025 07:02:41 +0100

Juri Linkov <juri <at> linkov.net> writes:

>>> Do you remember why we removed this condition from
>>> 'c-ts-mode--defun-name':
>>>
>>>   (equal (treesit-node-type (treesit-node-parent node))
>>>          "function_definition")
>>
>> Don't remember the exact reason, seems a mistake looking at it
>> now. Probably got lost while trying to find a good matcher for
>> declarators and didn't have stand-alone prototypes in my test case to
>> show the issue.
>>
>> I'd say to restore that check. Did a brief test here and it does not
>> seem to break anything else.
>
> Now 'treesit-outline-search' was fixed that allowed
> to simplify 'c-ts-mode--defun-name' and also handle
> the case with "pointer_declarator" between "function_definition"
> and "function_declarator".

Looks good to me, thanks for working on this!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.