GNU bug report logs - #74436
[PATCH 0/2] Respect --cores build argument.

Previous Next

Package: guix-patches;

Reported by: Nicolas Graves <ngraves <at> ngraves.fr>

Date: Tue, 19 Nov 2024 14:14:01 UTC

Severity: normal

Tags: patch

Done: Sharlatan Hellseher <sharlatanus <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74436 in the body.
You can then email your comments to 74436 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#74436; Package guix-patches. (Tue, 19 Nov 2024 14:14:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Nicolas Graves <ngraves <at> ngraves.fr>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 19 Nov 2024 14:14:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [PATCH 0/2] Respect --cores build argument.
Date: Tue, 19 Nov 2024 15:12:06 +0100
This commit ensures that a user-provided --cores argument to guix
build is respected.

Nicolas Graves (2):
  gnu: python-botocore: Respect --cores build argument.
  gnu: python-boto3: Respect --cores build argument.

 gnu/packages/python-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.46.0





Information forwarded to guix-patches <at> gnu.org:
bug#74436; Package guix-patches. (Tue, 19 Nov 2024 14:23:01 GMT) Full text and rfc822 format available.

Message #8 received at 74436 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 74436 <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [PATCH 1/2] gnu: python-botocore: Respect --cores build argument.
Date: Tue, 19 Nov 2024 15:21:52 +0100
This commit ensures that a user-provided --cores argument to guix
build is respected.

* gnu/packages/python-xyz.scm (python-botocore)[arguments]
<#:test-flags>: Replace "auto" numprocesses by parallel-job-count.
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 576e0e626f..6394999b78 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -19340,7 +19340,7 @@ (define-public python-botocore
     (arguments
      (list
       #:test-flags
-      #~(list "--numprocesses" "auto"
+      #~(list "--numprocesses" (number->string (parallel-job-count))
               ;; It strugles to find 'botocore'.
               "--ignore" "tests/functional/leak/test_resource_leaks.py"
               ;; Tests require networking.
-- 
2.46.0





Information forwarded to guix-patches <at> gnu.org:
bug#74436; Package guix-patches. (Tue, 19 Nov 2024 14:23:02 GMT) Full text and rfc822 format available.

Message #11 received at 74436 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 74436 <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [PATCH 2/2] gnu: python-boto3: Respect --cores build argument.
Date: Tue, 19 Nov 2024 15:21:53 +0100
This commit ensures that a user-provided --cores argument to guix
build is respected.

* gnu/packages/python-xyz.scm (python-boto3)[arguments]
<#:test-flags>: Replace "auto" numprocesses by parallel-job-count.
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 6394999b78..1439c278bc 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -19379,7 +19379,7 @@ (define-public python-boto3
     (arguments
      (list
       #:test-flags
-      #~(list "--numprocesses" "auto"
+      #~(list "--numprocesses" (number->string (parallel-job-count))
               ;; Integration tests are trying to connect to AWS.
               "--ignore" "tests/integration")))
     (native-inputs
-- 
2.46.0





Information forwarded to guix-patches <at> gnu.org:
bug#74436; Package guix-patches. (Tue, 19 Nov 2024 15:28:01 GMT) Full text and rfc822 format available.

Message #14 received at 74436 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 74436 <at> debbugs.gnu.org
Subject: Nicolas Graves <ngraves <at> ngraves.fr>
Date: Tue, 19 Nov 2024 15:25:59 +0000
[Message part 1 (text/plain, inline)]
Hi Nicolas,

I see the regression in CI as well. Thanks for the patches I'll apply
them.

--
Oleg
[signature.asc (application/pgp-signature, inline)]

Reply sent to Sharlatan Hellseher <sharlatanus <at> gmail.com>:
You have taken responsibility. (Tue, 19 Nov 2024 19:46:01 GMT) Full text and rfc822 format available.

Notification sent to Nicolas Graves <ngraves <at> ngraves.fr>:
bug acknowledged by developer. (Tue, 19 Nov 2024 19:46:02 GMT) Full text and rfc822 format available.

Message #19 received at 74436-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 74436-done <at> debbugs.gnu.org
Subject: [PATCH 0/2] Respect --cores build argument.
Date: Tue, 19 Nov 2024 19:43:54 +0000
[Message part 1 (text/plain, inline)]
Hi,

Pushed as 20ecc8b5a995dd782891dcfe213dd3c67295fe30, and
3f6691b77bccc13c5038232c77f7f1bb780e1de5 to master.

--
Thanks,
Oleg
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 18 Dec 2024 12:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 261 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.