GNU bug report logs - #74413
[PATCH] Allow to store and read repository information of VCS builds

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74413: closed ([PATCH] Allow to store and read repository
 information of VCS builds)
Date: Thu, 13 Feb 2025 15:46:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 13 Feb 2025 09:45:51 -0600
with message-id <CADwFkmmeAhNAhZ3kjkx=M=1d1py3+u9W6NHZYsGOw9Q8Y3nT5g <at> mail.gmail.com>
and subject line Re: bug#74413: [PATCH] Allow to store and read repository information of VCS builds
has caused the debbugs.gnu.org bug report #74413,
regarding [PATCH] Allow to store and read repository information of VCS builds
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74413: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74413
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Björn Bidar <bjorn.bidar <at> thaodan.de>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Allow to store and read repository information of VCS builds
Date: Mon, 18 Nov 2024 10:18:11 +0200

[Message part 3 (text/plain, inline)]

Tags: patch


Emacs has the feature to read the repository version and
branch if git is installed during the build and afterwards if also
the sources including the VCS repository is present.

For the Android builds the feature was added to store and read the
information mentioned above in a special version file.

This patch reuses that mechanism so it can be reused on other platforms
to use for the same reasons its available for Android and to also be
able to use the information on CI workers without git installed and/or a
full source checkout.

The things I'm not sure about for this patch are:
- Is the generating of the version file in the right place in
Makefile.in
- Is the data directory the right place to store the file
- Should the creation of the version file be shared between the Android
  builds and the other platforms



In GNU Emacs 31.0.50 (build 1, x86_64-suse-linux-gnu, GTK+ Version
3.24.43, cairo version 1.18.2)
Repository revision: eee0ed8442aa78320a3e578ab290df145fb49624
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101014
System Description: openSUSE Tumbleweed

Configured using:
 'configure --disable-build-details --without-pop --with-mailutils
 --without-hesiod --with-gameuser=:games --with-kerberos
 --with-kerberos5 --with-file-notification=inotify --with-modules
 --enable-autodepend --enable-link-time-optimization --prefix=/usr
 --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share
 --localstatedir=/var --sharedstatedir=/var/lib
 --libexecdir=/usr/libexec --with-file-notification=yes
 --libdir=/usr/lib64 --with-native-compilation=aot
 --enable-locallisppath=/usr/share/emacs/31.0.50/site-lisp:/usr/share/emacs/site-lisp
 --with-x --with-xim --with-sound --with-xpm --with-jpeg --with-tiff
 --with-gif --with-png --with-rsvg --with-dbus --with-xft --without-gpm
 --with-tree-sitter --with-x-toolkit=gtk --without-pgtk
 --with-toolkit-scroll-bars --x-includes=/usr/include
 --x-libraries=/usr/lib64 --with-libotf --with-m17n-flt --with-cairo
 --build=x86_64-suse-linux --with-dumping=pdumper
 build_alias=x86_64-suse-linux 'CC=sccache cc' 'CFLAGS=-O2 -Wall
 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong
 -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection
 -Werror=return-type -flto=auto -march=znver3 -mmmx -mpopcnt -msse
 -msse2 -msse3 -mssse3 -msse4.1 -msse4.2 -mavx -mavx2 -msse4a -mno-fma4
 -mno-xop -mfma -mbmi -mbmi2 -maes -mpclmul -mno-gfni -mvpclmulqdq
 -mno-3dnow -madx -mabm -mno-cldemote -mclflushopt -mclwb -mclzero
 -mcx16 -mno-enqcmd -mf16c -mfsgsbase -mfxsr -mno-hle -msahf -mno-lwp
 -mlzcnt -mmovbe -mno-movdir64b -mno-movdiri -mmwaitx -mno-pconfig -mpku
 -mprfchw -mno-ptwrite -mrdpid -mrdrnd -mrdseed -mno-rtm -mno-serialize
 -mno-sgx -msha -mshstk -mno-tbm -mno-tsxldtrk -mvaes -mno-waitpkg
 -mwbnoinvd -mxsave -mxsavec -mxsaveopt -mxsaves -mno-amx-tile
 -mno-amx-int8 -mno-amx-bf16 -mno-uintr -mno-hreset -mno-kl -mno-widekl
 -mno-avxvnni -mno-avxifma -mno-avxvnniint8 -mno-avxneconvert
 -mno-cmpccxadd -mno-amx-fp16 -mno-prefetchi -mno-raoint
 -mno-amx-complex --param l1-cache-size=32 --param l1-cache-line-size=64
 --param l2-cache-size=512 -mtune=znver3 -fno-optimize-sibling-calls -O2
 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong
 -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection
 -Werror=return-type -flto=auto -g -D_GNU_SOURCE
 -DGDK_DISABLE_DEPRECATION_WARNINGS -DGLIB_DISABLE_DEPRECATION_WARNINGS
 -pipe -Wno-pointer-sign -Wno-unused-variable -Wno-unused-label
 -DPDMP_BASE='\''"emacs-gtk"'\''' LDFLAGS=-Wl,-O2 'CXX=sccache c++'
 PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig'

[0001-Allow-to-store-and-read-repository-information-of-VC.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 74413-done <at> debbugs.gnu.org,
 Björn Bidar <bjorn.bidar <at> thaodan.de>,
 Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#74413: [PATCH] Allow to store and read repository information
 of VCS builds
Date: Thu, 13 Feb 2025 09:45:51 -0600

Po Lu <luangruo <at> yahoo.com> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>> Björn Bidar <bjorn.bidar <at> thaodan.de> writes:
>>
>>> The Android builds obviously have the revision already integrated
>>> as the logic that I'm trying to reuse here have been already
>>> implemented for Android.
>>> I don't know about the Guix build process but for Arch git isn't
>>> into the change-root when building Emacs from the tarball that has been
>>> generated before hand.
>>>
>>> The OBS can build packages for all kinds of Linux distributions such as
>>> Flatpak, Debian, Fedora, SUSE, Ubuntu etc.
>>>
>>> So this change can help building test builds for all these distributions
>>> in theory. Personally just building for SUSE.
>>
>> Could you please see if you can't work around this in the OBS build
>> scripts themselves?  I'd really rather not introduce yet another
>> complication into our already extremely complex build process.  Even
>> understanding the use case here was a struggle, and having this in our
>> build process means that we have to continue maintaining it.  So for
>> now, I believe this is a wontfix.  Sorry, and thanks for understanding.
>>
>> Please let us know if all such efforts fail, however, and we might
>> reconsider.
>
> Might you explain what the request at hand _is_, and how it concerns the
> Android port?  I skimmed the issue but could not conclude anything.

I don't think I can answer that satisfactorily, sorry.  It has to do
with packaging using OBS on Suse, and reusing some Android data file
created during the build process for that purpose.

I'm closing the bug with this message.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.