Subject: Re: [bug#74411] [PATCH v2 4/5] gnu: Add freedict-dictionaries.

From: Ludovic Courtès <[email-masked]>
Date: Fri, 29 Nov 2024 14:28:08 +0100

Runciter <[email-masked]> skribis:

> * gnu/packages/dictionaries (freedict-dictionaries): New variable.
>
> Signed-off-by: Runciter <[email-masked]>

[...]

> +(define-public freedict-dictionaries
> +  (package
> +    (name "freedict-dictionaries")
> +    (version "914b5f7")

Regarding the version number of Git snapshots, see
<https://guix.gnu.org/manual/devel/en/html_node/Version-Numbers.html>.

> +    (inputs (list espeak-ng
> +                  python
> +                  perl
> +                  gzip
> +                  tar
> +                  libxslt
> +                  dictd-1.13.1
> +                  perl-libxml
> +                  freedict-tools-0.6.0))

You can remove ‘tar’ and ‘gzip’, they’re provided by ‘gnu-build-system’.

‘python’ and ‘perl’ should probably be in ‘native-inputs’, assuming
they’re used at build-time.

> +    (arguments
> +     (list
> +      #:tests? #f

Please add a short comment explaining why the test suite is skipped
(such as “no tests”).

> +    (synopsis "Freedict multilingual dictionaries compiled to the dictd
> +format")

Maybe: “Multilingual dictionaries compiled to the DICT format” (the
format is “DICT”, right?).