Subject: bug#74379: closed (Re: [PATCH] gnu: libx86emu: Fix build.)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 16 Nov 2024 10:22:02 +0000

Your bug report

#74379: [PATCH] gnu: libx86emu: Fix build.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
74379: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74379
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [PATCH] gnu: libx86emu: Fix build.
From: "Artyom V. Poptsov" <[email-masked]>
To: [email-masked]
Date: Sat, 16 Nov 2024 13:20:38 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Merged to the "master" branch as
b647d3a149c94ee84cde1af3af7442633afa3416.

- avp

-- 
Artyom "avp" Poptsov <[email-masked]>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

Subject: [PATCH] gnu: libx86emu: Fix build.
From: "Artyom V. Poptsov" <[email-masked]>
To: [email-masked]
Cc: "Artyom V. Poptsov" <[email-masked]>
Date: Sat, 16 Nov 2024 11:25:18 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/virtualization.scm (libx86emu): Fix build.
[arguments]: Add extra "make-x86test" phase to make sure that "x86test" exists
before running the parallel tests.

Change-Id: Iad8d3fca6d4c04f6df9eba88e33e47324f160083
---
 gnu/packages/virtualization.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index 5c9461745c..b76180c3c6 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -38,6 +38,7 @@
 ;;; Copyright © 2024 Ashish SHUKLA <[email-masked]>
 ;;; Copyright © 2024 Jakob Kirsch <[email-masked]>
 ;;; Copyright © 2024 Giacomo Leidi <[email-masked]>
+;;; Copyright © 2024 Artyom V. Poptsov <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -732,6 +733,12 @@ (define-public libx86emu
                            (string-append "LIBDIR = " lib "\n"))
                           (("/usr/include")
                            include)))))
+                  ;; XXX: "make -C test" fails because it cannot find "x86test"
+                  ;; executable due to parallel tests.  So we need to make sure that
+                  ;; this file is built before running the tests.
+                  (add-before 'check 'make-x86test
+                    (lambda _
+                      (invoke "make" "-C" "test" "x86test")))
                   (delete 'configure)))) ;no configure script
     (native-inputs (list nasm perl))
     (synopsis "Library for x86 emulation")

base-commit: 3e8d3d80f41e016cdfe80e488a78c2351c94fef8
-- 
2.46.0