GNU bug report logs - #74379
[PATCH] gnu: libx86emu: Fix build.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74379 in the body.
You can then email your comments to 74379 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: [PATCH] gnu: libx86emu: Fix build.
Date: Sat, 16 Nov 2024 11:25:18 +0300

* gnu/packages/virtualization.scm (libx86emu): Fix build.
[arguments]: Add extra "make-x86test" phase to make sure that "x86test" exists
before running the parallel tests.

Change-Id: Iad8d3fca6d4c04f6df9eba88e33e47324f160083
---
 gnu/packages/virtualization.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index 5c9461745c..b76180c3c6 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -38,6 +38,7 @@
 ;;; Copyright © 2024 Ashish SHUKLA <ashish.is <at> lostca.se>
 ;;; Copyright © 2024 Jakob Kirsch <jakob.kirsch <at> web.de>
 ;;; Copyright © 2024 Giacomo Leidi <goodoldpaul <at> autistici.org>
+;;; Copyright © 2024 Artyom V. Poptsov <poptsov.artyom <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -732,6 +733,12 @@ (define-public libx86emu
                            (string-append "LIBDIR = " lib "\n"))
                           (("/usr/include")
                            include)))))
+                  ;; XXX: "make -C test" fails because it cannot find "x86test"
+                  ;; executable due to parallel tests.  So we need to make sure that
+                  ;; this file is built before running the tests.
+                  (add-before 'check 'make-x86test
+                    (lambda _
+                      (invoke "make" "-C" "test" "x86test")))
                   (delete 'configure)))) ;no configure script
     (native-inputs (list nasm perl))
     (synopsis "Library for x86 emulation")

base-commit: 3e8d3d80f41e016cdfe80e488a78c2351c94fef8
-- 
2.46.0

Message #10 received at 74379-done <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: 74379-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: libx86emu: Fix build.
Date: Sat, 16 Nov 2024 13:20:38 +0300

[Message part 1 (text/plain, inline)]

Merged to the "master" branch as
b647d3a149c94ee84cde1af3af7442633afa3416.

- avp

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.