GNU bug report logs - #74361
[PATCH] New option xref-navigation-display-window-action

Previous Next

Full log

Message #200 received at 74361 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: martin rudalics <rudalics <at> gmx.at>, 74361 <at> debbugs.gnu.org
Subject: Re: bug#74361: [PATCH] New option
 xref-navigation-display-window-action
Date: Wed, 04 Dec 2024 09:35:27 +0200

> The replacement for xref--display-buffer-in-window seems easier to do, 
> IIUC this keeps all the current behavior (but it's also Emacs 31+ only):
>
> @@ -690,9 +690,9 @@ xref--show-pos-in-buf
>                     (window-live-p xref--original-window)
>                     (or (not (window-dedicated-p xref--original-window))
>                         (eq (window-buffer xref--original-window) buf)))
> -                 `((xref--display-buffer-in-window)
> +                 `((display-buffer-use-some-window)
>                      (category . xref-jump)
> -                   (window . ,xref--original-window)))
> +                   (some-window . ,(cl-constantly xref--original-window))))

I see no problems with this patch.  Even better would be if Martin agrees
to modify 'display-buffer-use-some-window' to accept a window in
'(some-window . WINDOW)'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.