GNU bug report logs - #74344
[PATCH 0/7] gnu: Add jamesdsp.

Previous Next

Package: guix-patches;

Reported by: Sughosha <sughosha <at> disroot.org>

Date: Wed, 13 Nov 2024 15:44:02 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #116 received at 74344 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Sughosha via Guix-patches via <guix-patches <at> gnu.org>
Cc: Gabriel Wicki <gabriel <at> erlikon.ch>, Sughosha <sughosha <at> disroot.org>,
 74344 <at> debbugs.gnu.org
Subject: Re: [bug#74344] [PATCH v3 7/7] gnu: Add jamesdsp.
Date: Sat, 15 Feb 2025 20:04:37 -0500

On Tue, Feb 11, 2025 at 07:50:51PM +0530, Sughosha via Guix-patches via wrote:
> * gnu/packages/audio.scm (jamesdsp): New variable.

> +       (modules '((guix build utils)))
> +       (snippet
> +        ;; Unbundle 3rd party libraries.

Okay

> +           #~(modify-phases %standard-phases
> +               (replace 'configure

Add a code comment explaining why this phase is replaced.

> +    (license (list license:gpl3+
> +                   license:gpl2      ;LiquidEqualizerWidget's 3rd party library
> +                   license:gpl2+     ;GraphicEQWidget
> +                   license:expat)))) ;QAnimatedSlider and QCodeEditor

The overall package is distributed by us as GPL3+, despite some
subcomponents bearing different licenses, so this field should only
include gpl3+. It's okay to keep the info about the other licenses in a
code comment.
This bug report was last modified 147 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.