GNU bug report logs - #74344
[PATCH 0/7] gnu: Add jamesdsp.

Previous Next

Full log

Message #104 received at 74344 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Sughosha via Guix-patches via <guix-patches <at> gnu.org>
Cc: 宋文武 <iyzsong <at> envs.net>,
 Zheng Junjie <z572 <at> z572.online>, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Sughosha <sughosha <at> disroot.org>, 74344 <at> debbugs.gnu.org
Subject: Re: [bug#74344] [PATCH v3 5/7] gnu: Add qtpromise.
Date: Sat, 15 Feb 2025 19:49:41 -0500

On Tue, Feb 11, 2025 at 07:50:49PM +0530, Sughosha via Guix-patches via wrote:
> * gnu/packages/qt.scm (qtpromise): New variable.

> +               (replace 'install

Please add a brief code comment explaining why the install phase is
replaced.

> +    (description
> +     "This package provides Promises/A+ implementation for Qt/C++.")

How about this: "This package provides an Qt/C++ implementation of the
Promises/A+ standard for the 'promises' programming paradigm."

I think it's more clear.

Otherwise LGTM

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.