Subject: Re: [bug#74344] [PATCH v3 3/7] gnu: Add qt-advanced-docking-system.

From: Maxim Cournoyer <[email-masked]>
Date: Sun, 16 Feb 2025 15:32:44 +0900

Hi,

Sughosha <[email-masked]> writes:

> * gnu/packages/qt.scm (qt-advanced-docking-system): New variable.

[...]

> +(define-public qt-advanced-docking-system
> +  (package
> +    (name "qt-advanced-docking-system")
> +    (version "4.3.1")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri
> +        (git-reference
> +          (url "https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System")
> +          (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "0xb4j5pva3qbbj01xp5y98544hgh14p60z2dfypq4ikz6n3ac0z7"))))
> +    (build-system qt-build-system)
> +    (arguments
> +     (list #:qtbase qtbase
> +           #:tests? #f ;no tests
> +           #:configure-flags
> +           #~(list ;; Examples requie qtdeclarative. Even if they are built,

s/requie/require  Please use two spaces between sentences, as
conventional in GNU and Guix.

Otherwise LGTM.

-- 
Thanks,
Maxim