GNU bug report logs - #74312
31.0.50; Cygw32 build break

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ken Brown <kbrown <at> cornell.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74312: closed (31.0.50; Cygw32 build break)
Date: Fri, 15 Nov 2024 22:22:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 15 Nov 2024 17:21:21 -0500
with message-id <9e7b39c5-a8bb-41c5-98de-89c6a27497a3 <at> cornell.edu>
and subject line Re: bug#74312: 31.0.50; Cygw32 build break
has caused the debbugs.gnu.org bug report #74312,
regarding 31.0.50; Cygw32 build break
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74312: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74312
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; Cygw32 build break
Date: Mon, 11 Nov 2024 23:51:33 +0900

Cygw32 build fails on  master

$ make
(snip)
  CC       w32fns.o
../../../emacs/src/w32fns.c: In function ‘process_dropfiles’:
../../../emacs/src/w32fns.c:2549:17: error: ‘MAX_UTF8_PATH’ undeclared (first use in this function); did you mean ‘MAX_ZONE_PATH’?
 2549 |   char filename[MAX_UTF8_PATH];
      |                 ^~~~~~~~~~~~~
      |                 MAX_ZONE_PATH
../../../emacs/src/w32fns.c:2549:17: note: each undeclared identifier is reported only once for each function it appears in
../../../emacs/src/w32fns.c:2557:11: warning: implicit declaration of function ‘filename_from_utf16’ [-Wimplicit-function-declaration]
 2557 |           filename_from_utf16 (p, filename);
      |           ^~~~~~~~~~~~~~~~~~~
../../../emacs/src/w32fns.c:2557:11: warning: nested extern declaration of ‘filename_from_utf16’ [-Wnested-externs]
../../../emacs/src/w32fns.c:2567:11: warning: implicit declaration of function ‘gifilename_from_ansi’ [-Wimplicit-function-declaration]
 2567 |           filename_from_ansi (p, filename);
      |           ^~~~~~~~~~~~~~~~~~
../../../emacs/src/w32fns.c:2567:11: warning: nested extern declaration of ‘filename_from_ansi’ [-Wnested-externs]
../../../emacs/src/w32fns.c:2549:8: warning: unused variable ‘filename’ [-Wunused-variable]
 2549 |   char filename[MAX_UTF8_PATH];
      |        ^~~~~~~~
make[2]: *** [Makefile:457: w32fns.o] Error 1


MAX_UTF8_PATH is defined in nt/inc/ms-w32.h and filename_from_*
functions are defined in src/w32.c


-- 
Kazuhiro Ito

[Message part 3 (message/rfc822, inline)]

From: Ken Brown <kbrown <at> cornell.edu>
To: Eli Zaretskii <eliz <at> gnu.org>, Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
Cc: cpardo <at> imayhem.com, 74312-done <at> debbugs.gnu.org
Subject: Re: bug#74312: 31.0.50; Cygw32 build break
Date: Fri, 15 Nov 2024 17:21:21 -0500

On 11/14/2024 11:07 AM, Eli Zaretskii wrote:
>> Date: Fri, 15 Nov 2024 00:00:40 +0900
>> From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
>> Cc: 74312 <at> debbugs.gnu.org,
>> 	Eli Zaretskii <eliz <at> gnu.org>
>>
>>>> As far as I tested, drag-n-drop from Microsoft Photo worked only the
>>>> first time.  Second operation was ignored.  Quick operation may fail
>>>> even at the first time.  Drag-n-drop from explorer worked expectedly.
>>>
>>> This should fix the Photo application problem.
>>
>> I confirmed the problem was fixed, thank you.
> 
> Thanks for testing, I installed the patch on the master branch.
> 
> I'm not closing this bug, to let Ken double-check the latest changes
> and see if something else broke Cygwin.
The Cygwin-w32 build seems fine AFAICT.  Closing.

Ken

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.