GNU bug report logs - #74302
[PATCH] gnu: python-crontab: Fix failing tests

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74302: closed ([PATCH] gnu: python-crontab: Fix failing tests)
Date: Thu, 14 Nov 2024 14:44:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 14 Nov 2024 15:43:04 +0100
with message-id <87r07doozr.fsf <at> gnu.org>
and subject line Re: [bug#74302] [PATCH] gnu: python-crontab: Fix failing tests
has caused the debbugs.gnu.org bug report #74302,
regarding [PATCH] gnu: python-crontab: Fix failing tests
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74302: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74302
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: TakeV <takev <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: TakeV <takev <at> disroot.org>
Subject: [PATCH] gnu: python-crontab: Fix failing tests
Date: Sun, 10 Nov 2024 15:54:43 -0500

* gnu/packages/python-xyz.scm (python-crontab) [arguments]: Turn off frequency
at month check

Change-Id: Ia6a8f703119dc61ddc6b359fca161dfb5a21319d
---

Apparently this check fails on leap years.

 gnu/packages/python-xyz.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 5083473c08..2d84bfa57e 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -29547,6 +29547,9 @@ (define-public python-crontab
                              "tests/test_frequency.py")
                 (("test_07_non_posix_shell")
                  "__off_test_07_non_posix_shell")
+                ;; Fails on leap years
+                (("test_19_frequency_at_month")
+                 "__off_test_19_frequency_at_month")
                 ;; AssertionError: 48 != 24
                 (("test_20_frequency_at_year")
                  "__off_test_20_frequency_at_year")))))))

base-commit: ee3219996b688d2c3336a7ea1e262308cf2d00b7
prerequisite-patch-id: 8e79e3033f6e8ae459eab31d7cf5149a8eb01e9c
prerequisite-patch-id: 2442dd8fbe7af78372dbf03871fb6c5506eb75fe
-- 
2.46.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: TakeV <takev <at> disroot.org>
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>,
 Munyoki Kilyungi <me <at> bonfacemunyoki.com>, Lars-Dominik Braun <lars <at> 6xq.net>,
 jgart <jgart <at> dismail.de>, Marius Bakke <marius <at> gnu.org>,
 Tanguy Le Carrour <tanguy <at> bioneland.org>, 74302-done <at> debbugs.gnu.org
Subject: Re: [bug#74302] [PATCH] gnu: python-crontab: Fix failing tests
Date: Thu, 14 Nov 2024 15:43:04 +0100

TakeV <takev <at> disroot.org> skribis:

> * gnu/packages/python-xyz.scm (python-crontab) [arguments]: Turn off frequency
> at month check
>
> Change-Id: Ia6a8f703119dc61ddc6b359fca161dfb5a21319d

Applied, thanks!

> +                ;; Fails on leap years
> +                (("test_19_frequency_at_month")
> +                 "__off_test_19_frequency_at_month")

An interesting time trap…

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.