From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 10 12:41:14 2024 Received: (at submit) by debbugs.gnu.org; 10 Nov 2024 17:41:15 +0000 Received: from localhost ([127.0.0.1]:56492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tABw2-0004r3-0y for submit@debbugs.gnu.org; Sun, 10 Nov 2024 12:41:14 -0500 Received: from lists.gnu.org ([209.51.188.17]:33366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tABA2-0002Ww-RR for submit@debbugs.gnu.org; Sun, 10 Nov 2024 11:51:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAB7s-0005Sl-Er for guix-patches@gnu.org; Sun, 10 Nov 2024 11:49:24 -0500 Received: from mail-108-mta192.mxroute.com ([136.175.108.192]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tAB7q-0004iM-IV for guix-patches@gnu.org; Sun, 10 Nov 2024 11:49:24 -0500 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta192.mxroute.com (ZoneMTA) with ESMTPSA id 19316f62b650003e01.001 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 10 Nov 2024 16:44:12 +0000 X-Zone-Loop: c0e23cf5828686970240dc77b29f1f29210425a1a7c5 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=icepic.de; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:Cc:To: From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=8FbC1P4uc1/RrCx4o+zv29ycjKiIKn6faK9ym9nXbQU=; b=f LO9OdfpWFRHfnOIiHxy5HoHhMOILb6hIGNbnHZgb4XGj0XsMpXEqHFDXbj0RCA715QKiXNMWo7E5Y 8RGt5YoKd/7lxTPQYshCs46U3fplaR7ZnIUO0MPFEPT2GWqBZ9i2Uxb4K/mtOC2vgrVnrYXGFEM95 TC6trox/0LV+zLJeFfV1gcSAxMddGEPzewnrOqGmB2Ee34Rat5BTZ/5jZVdgG3TnmcVGFmENR2YHo IUgpIMYFnRx1E7bg5XhWt9MWT1+XYcKyx5uHEd9uOt3oDOjAAxIFGKd1kEjlMFXCAguwXBTC7eI5l Ir42sHQ4+RzAZKzP9rOwN6X7FIcYezvQA==; From: Christoph Buck To: guix-patches@gnu.org Subject: [PATCH 0/1] Fix abi mismatch error on boot for cross-compiled images Date: Sun, 10 Nov 2024 17:43:39 +0100 Message-ID: MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Authenticated-Id: dev@icepic.de Received-SPF: pass client-ip=136.175.108.192; envelope-from=dev@icepic.de; helo=mail-108-mta192.mxroute.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 10 Nov 2024 12:41:09 -0500 Cc: Christoph Buck X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hi! The following patch fixes the `record-abi-mismatch-error` early on boot during execution of initrd.cpio.gz if the image was cross-compiled on x64 for an 32bit platform (e.g arm32 or i868). For a comprehensive analysis see the correspond thread [1] on the guix-help mailing list. The root cause of the issue is as follows: During compilation guix stores a hash of the record field names in the compiled go files. On runtime this has is recalcuated and checked against the stored hash to verify that no abi mismatch occured. As described in [1] this hash differs if the corresponding record was compiled in a cross-compiled context. Guile uses internally an `unsigned long` to store the hash, which results in hashes of different sizes depending on the platform the guile compiler is executed on. Guix already tries to work around this problem by limiting the size of the hash in a cross-compile context to the most positive fixnum size of the target, but this is insufficient, because, as one can look up in the guile source code, the size is limited by an modulo operation after the hash was already calculated for an 8byte unsigned long. Therefore the resulting hashes during compilation and execution are different and an abi mismatch error is erroneously reported during runtime. An easy workaround is documented in the guile src namely in an comment of the `JENKINS_LOOKUP3_HASHWORD2`, which is used to calculate the hash: > Scheme can access symbol-hash, which exposes this value. For >cross-compilation reasons, we ensure that the high 32 bits of the hash on a >64-bit system are equal to the hash on a 32-bit system. The low 32 bits just >add more entropy. This suggest the following workaround. Always limit the hash size to 32bit even if executed on a 64bit platform (or to be more specific a platform where ulong is 8bytes big). Do this by right shift the hash value 32bits and don't rely on the size parameter of the `string-hash` function. This is what this patch tries to accomplish. Imho this approach has two drawbacks. Lost entropy on 64 bit machines and the abi break because on new compilation the hash values on 64bit platforms will change. The lost entropy is irrelevant because the hash is not used in an cryptophically relevant context. For the abi break i am not sure how severe this change is. [1] ABI mismatch on boot on arm32 system (https://lists.gnu.org/archive/html/help-guix/2024-11/msg00022.html) Christoph Buck (1): guix: records: Fix abi check in cross compile context guix/records.scm | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) base-commit: 2a6d96425eea57dc6dd48a2bec16743046e32e06 -- 2.45.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 10 19:21:18 2024 Received: (at 74296) by debbugs.gnu.org; 11 Nov 2024 00:21:18 +0000 Received: from localhost ([127.0.0.1]:57105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAIBA-00061c-Ku for submit@debbugs.gnu.org; Sun, 10 Nov 2024 19:21:18 -0500 Received: from mail-108-mta139.mxroute.com ([136.175.108.139]:37047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tACaf-0006j8-9f for 74296@debbugs.gnu.org; Sun, 10 Nov 2024 13:23:14 -0500 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta139.mxroute.com (ZoneMTA) with ESMTPSA id 1931750bde60003e01.001 for <74296@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 10 Nov 2024 18:23:07 +0000 X-Zone-Loop: 4d0e7d944e28d7e4aa8b3ddbe5d3fb7fa6dd67c971fc X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=icepic.de; s=x; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZRkNCLClyWtVYK6HxjQoL9CpCL8SQgwD7BOBRUqZEIc=; b=Bn7QJHH9ibwijRkP9rC0/BQ9rV 1Wwc3oncyze2lrMeqQBHiSibAYGrAlwewaUO0rx3A+/DMpIQM8sZUO+CnGOf0m3yHIvJUrHWYhgkv qf2I2QXstUF+RFjark1wn4D+9/9E3XEYcEGn+1HEFVFBnURxYd39h+LO06V0namoB6CTEU3dcCJoN 2US0q5EvKqfVchLBBqx8RxzZbPTHOYTm1updTwhdq+rOmpEL7yysnnHCTCFLOU0OupXckALsVlwGd v9FUiy16A3Pmu3zHndrwo1F4MzVaisz7ayiQNb8pag5FoKCHoFtn3cArDIUSOAiL7HKkC+rl5+WXu v/PkJNcA==; From: Christoph Buck To: 74296@debbugs.gnu.org Subject: [PATCH 1/1] guix: records: Fix abi check in cross compile context Date: Sun, 10 Nov 2024 19:23:01 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Authenticated-Id: dev@icepic.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74296 X-Mailman-Approved-At: Sun, 10 Nov 2024 19:21:15 -0500 Cc: Christoph Buck X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * guix/records.scm: Use 32bit hash value for abi check to prevent `record-abi-mismatch-error` in a cross-compile context Change-Id: I889747b1a2837bee8bf9b4de5729fdcf1b165380 --- guix/records.scm | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/guix/records.scm b/guix/records.scm index dca1e3c2e7..2084499e36 100644 --- a/guix/records.scm +++ b/guix/records.scm @@ -415,11 +415,13 @@ (define-syntax define-record-type* ;; list of symbols. (syntax-case field-specs () (((field get properties ...) ...) - (string-hash (object->string - (syntax->datum #'((field properties ...) ...))) - (cond-expand - (guile-3 (target-most-positive-fixnum)) - (else most-positive-fixnum)))))) + (let ((hash-value + (string-hash + (object->string (syntax->datum #'((field properties ...) ...)))))) + (cond + ((< most-positive-fixnum (ash 1 32)) hash-value) + ((< most-positive-fixnum (ash 1 64)) (ash hash-value -32)) + (else (error "unexpected!" most-positive-fixnum))))))) (syntax-case s () ((_ type syntactic-ctor ctor pred -- 2.45.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 12 17:42:32 2024 Received: (at 74296) by debbugs.gnu.org; 12 Nov 2024 22:42:33 +0000 Received: from localhost ([127.0.0.1]:39821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAzai-0000fO-C4 for submit@debbugs.gnu.org; Tue, 12 Nov 2024 17:42:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAzag-0000fC-4n for 74296@debbugs.gnu.org; Tue, 12 Nov 2024 17:42:31 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAzYR-00032j-Vc; Tue, 12 Nov 2024 17:40:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=8zzF1Q9wqZZ8fAWC0n0dDDv7kBLrSxEeJO4a1FbiEKc=; b=CxJR7cOqTd3mpsaiAfTs mpWmuz+aW5JWQ5nnPus72O8pvnuiAlTQ7jYqQ9nBxLTlvP2wGP7w5A+5STa9vbhRbrzxWm5s1/T3v ZsZ5Mp4oTaVhWNNgkn0gzd1ksInLVDMLnXTTwLFnpK3bpngmqDHPsHC+ybpHGOQtoOIGlV876MLow YTmAwPaxienFdDEm2PK01emt733TsfS6nFxtC/xjzmuq4NmekokZnhxd98kFy2F7QBw4qRVvmUC35 4rV3DH7TndLxoiU9KFk+UOIObFS9wcSDwjL7SWki0EYIFDEBucOKQobOwvwrWggwjigzs26eL8x8l 0/Gz3waqiHyorw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Christoph Buck Subject: Re: [bug#74296] [PATCH 0/1] Fix abi mismatch error on boot for cross-compiled images In-Reply-To: (Christoph Buck's message of "Sun, 10 Nov 2024 17:43:39 +0100") References: Date: Tue, 12 Nov 2024 23:40:08 +0100 Message-ID: <87o72krs8n.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74296 Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 74296@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Christoph, Christoph Buck skribis: > During compilation guix stores a hash of the record field names in the > compiled go files. On runtime this has is recalcuated and checked against= the > stored hash to verify that no abi mismatch occured. As described in [1] t= his > hash differs if the corresponding record was compiled in a cross-compiled > context. Guile uses internally an `unsigned long` to store the hash, which > results in hashes of different sizes depending on the platform the guile > compiler is executed on. Guix already tries to work around this problem by > limiting the size of the hash in a cross-compile context to the most posi= tive > fixnum size of the target, but this is insufficient, because, as one can = look > up in the guile source code, the size is limited by an modulo operation a= fter > the hash was already calculated for an 8byte unsigned long. Therefore the > resulting hashes during compilation and execution are different and an abi > mismatch error is erroneously reported during runtime. > > An easy workaround is documented in the guile src namely in an comment of= the > `JENKINS_LOOKUP3_HASHWORD2`, which is used to calculate the hash: > >> Scheme can access symbol-hash, which exposes this value. For >>cross-compilation reasons, we ensure that the high 32 bits of the hash on= a >>64-bit system are equal to the hash on a 32-bit system. The low 32 bits = just >>add more entropy. > > This suggest the following workaround. Always limit the hash size to 32bit > even if executed on a 64bit platform (or to be more specific a platform w= here > ulong is 8bytes big). Do this by right shift the hash value 32bits and do= n't > rely on the size parameter of the `string-hash` function. This is what th= is > patch tries to accomplish. Woow, thanks for the investigation & explanation! (I would say that the =E2=80=98scm_ihash=E2=80=99 implementation as a mere = modulo is dubious, but that=E2=80=99s hard to change anyway.) > Imho this approach has two drawbacks. Lost entropy on 64 bit machines and= the > abi break because on new compilation the hash values on 64bit platforms w= ill > change. The lost entropy is irrelevant because the hash is not used in an > cryptophically relevant context. For the abi break i am not sure how seve= re > this change is. Capping at 32-bits means that potentially some ABI changes could go unnoticed, but that=E2=80=99s extremely unlikely if the hash function is go= od enough. I believe the ABI break is fine too: developers will have to =E2=80=9Cmake clean-go && make=E2=80=9D, but that=E2=80=99s okay. Thoughts? Opinions? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 13 09:05:31 2024 Received: (at 74296) by debbugs.gnu.org; 13 Nov 2024 14:05:31 +0000 Received: from localhost ([127.0.0.1]:41332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBDzu-0000Qn-MR for submit@debbugs.gnu.org; Wed, 13 Nov 2024 09:05:31 -0500 Received: from mail-108-mta89.mxroute.com ([136.175.108.89]:40393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBCks-0005Kd-3o for 74296@debbugs.gnu.org; Wed, 13 Nov 2024 07:45:55 -0500 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta89.mxroute.com (ZoneMTA) with ESMTPSA id 193258f0f1d0003e01.002 for <74296@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 13 Nov 2024 12:45:52 +0000 X-Zone-Loop: 3bc9404af47eeddd16970d975918603efad8bf4bd76a X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=icepic.de; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gVuRl196pMeZkoxDZv6eZgH1/RYu+4tJ7tKr/RS4yps=; b=Y9qqN1/1APgL7dT6bObqJe33qd qVR2XwCmlZN38vURJj2hHpK52d4Y+9Txbl8Z8+bVEfX2REHVPQpaOT/foaY+b4n38BEDdATASpZSF HzkqvHS+6LZXCdi7TePpgmF5iNGC5ZyidobsLDVVu7C4DFHmeZJTrpOjgQS6vObtc78aFZFHTZr48 qKH+gJwVo0Pcl+Xy8Yy1UnSd86TkT8HaBVRsRRk1L0NXqZAdxqPm/ItBPI1pGtnTCWo3eaF93O3Vm pkcBZ/FynZJcQHYp/QORrq6k1IdlMrGeH7mZm4jZIjLdCSKTAditMLTj/KW97r6bWTbO79/eAYCqF UqgNzBPQ==; From: Christoph Buck To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#74296] [PATCH 0/1] Fix abi mismatch error on boot for cross-compiled images In-Reply-To: <87o72krs8n.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Tue, 12 Nov 2024 23:40:08 +0100") References: <87o72krs8n.fsf@gnu.org> Date: Wed, 13 Nov 2024 13:45:49 +0100 Message-ID: <87iksrpaiq.fsf@icepic.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Authenticated-Id: dev@icepic.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74296 X-Mailman-Approved-At: Wed, 13 Nov 2024 09:05:26 -0500 Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 74296@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Court=C3=A8s writes: > Woow, thanks for the investigation & explanation! Your are welcome :) I usually keep notes during investigation of bugs and append them to my patches. This keeps my train of thought transparent and makes it easier for others to follow along or spot obvious errors on my side. However, it can get a little bit noisy. So let met now if i should "keep it done" more. > Capping at 32-bits means that potentially some ABI changes could go > unnoticed, but that=E2=80=99s extremely unlikely if the hash function is = good > enough. Yes, but this problem exits for 32bit builds in general. > I believe the ABI break is fine too: developers will have to > =E2=80=9Cmake clean-go && make=E2=80=9D, but that=E2=80=99s okay. Good to know. --=20 Best regards Christoph From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 16 05:58:42 2024 Received: (at 74296) by debbugs.gnu.org; 16 Nov 2024 10:58:42 +0000 Received: from localhost ([127.0.0.1]:52225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCGVl-0004H0-V8 for submit@debbugs.gnu.org; Sat, 16 Nov 2024 05:58:42 -0500 Received: from mail-pf1-f174.google.com ([209.85.210.174]:48152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCGVk-0004Gn-A0 for 74296@debbugs.gnu.org; Sat, 16 Nov 2024 05:58:41 -0500 Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7245a9d0e92so1548736b3a.0 for <74296@debbugs.gnu.org>; Sat, 16 Nov 2024 02:58:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731754654; x=1732359454; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=b8mBnbXOKtqr/USbxDfXJsRVZeHSrHNOwDsX/RYbHWM=; b=SbZ5sNXLpr/f4p3MtSkIPoAwoD85RWMQlN2PI/2ySvl4LN9MqRIbYf51jcAcUVSkZp EHSshvp5xB0OjaHUSiP/JYM0eNq7nzfw9iAQ6Zk73ERg9Zu4w/EW5JMS3gevU8z6gLEq 9OuV7VucWeGHut3YvEB3C+b2JXM2E5FZ45oYUExoLQxyYgQmekrfOz4mtzrYAUt9MB3x E0c9MwDcRFL8a26Gix0dEAxE1BUf6kU05UbFSESpVU2khAyeJwfSEViNbOkWsWp12ElD OFB51xKIWSGmrsrltBi3DIcmZvkPbR/PDFw06UhoUn79Igycc4IhGgnwKXB/bRWPneAd N0eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731754654; x=1732359454; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b8mBnbXOKtqr/USbxDfXJsRVZeHSrHNOwDsX/RYbHWM=; b=Q3+O2cmWSRqvA26v5mE9CXJUOCYcp8dLhHk2OX7S0WLy93pZ/4c4YKXHOjDaVdINLq xLHWv88ASxWugW4dV7W94Ub3y1VhvoBRyVPyw8FDHhJQGf76rTJqLrsJRpUMgDYoE/I8 bDCcPvfc1PKBGipOnT+Qr9jJ+DIm9AnoKFVmQFEWfT9IwgIvWqUav/ep5zyRhhAEDaws Vs5QKQSVzyOEY5oHp9u2D2BXzcyRuPFBvIgwQd4WnSltAaPHldaa7s3+o/4VIf8ajunT GyBSMTzNOB041hiKgq2ajYB3zXQS2Jo7QmlSR+efzn2EjMoD3J1VXswCWht3S6EZnz1G qw4Q== X-Forwarded-Encrypted: i=1; AJvYcCV3WfNPaVKRDlqVgwNGgomYGUAEbd8P9ZDA0ZRhrCYGZ6jU2Wkur3qxdFiT9FAs9P9cTsZDog==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxMUyYF7WeomjEoFachrWCE3GcxXw1WTTO3CvOE7UbLBHykGDa5 O+mR243bLrafVoZMlWyGTfYK0eOykko653DLgNxrpU5mlX1qSSz/ X-Google-Smtp-Source: AGHT+IFVV5isg7qBMNCyv/J71fpyMIVkviF0weX7+UyP7fVHdYRHf0VtMTfBtqOx+xZKGbVdDmznFQ== X-Received: by 2002:a17:90b:3910:b0:2e2:eacc:3227 with SMTP id 98e67ed59e1d1-2ea155875dcmr6430947a91.23.1731754654323; Sat, 16 Nov 2024 02:57:34 -0800 (PST) Received: from lili ([147.127.248.1]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ea4a6bc0a0sm45532a91.18.2024.11.16.02.57.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Nov 2024 02:57:33 -0800 (PST) From: Simon Tournier To: Christoph Buck , Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#74296] [PATCH 0/1] Fix abi mismatch error on boot for cross-compiled images In-Reply-To: <87iksrpaiq.fsf@icepic.de> References: <87o72krs8n.fsf@gnu.org> <87iksrpaiq.fsf@icepic.de> Date: Sat, 16 Nov 2024 08:05:07 +0100 Message-ID: <87serrbqvw.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Christoph, On Wed, 13 Nov 2024 at 13:45, Christoph Buck wrote: >> Woow, thanks for the investigation & explanation! > > Your are welcome :) I usually keep notes during investigation of bugs > and append them to my patches. This keeps my train of thought > transpa [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (zimon.toutoune[at]gmail.com) 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.210.174 listed in bl.score.senderscore.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 1.1 DATE_IN_PAST_03_06 Date: is 3 to 6 hours before Received: date 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.210.174 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.210.174 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.210.174 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 74296 Cc: Christopher Baines , Mathieu Othacehe , Josselin Poiret , Tobias Geerinckx-Rice , 74296@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Hi Christoph, On Wed, 13 Nov 2024 at 13:45, Christoph Buck wrote: >> Woow, thanks for the investigation & explanation! > > Your are welcome :) I usually keep notes during investigation of bugs > and append them to my patches. This keeps my train of thought > transparent and makes it easier for others to follow along or spot > obvious errors on my side. However, it can get a little bit noisy. So > let met now if i should "keep it done" more. I like this sentence attributed to Leslie Lamport: =C2=AB If you're thinking without writing, you only think you=E2=80=99re thinking. =C2=BB. For what = my opinion is worth, your explanations appears to me the good ratio between the =E2=80=9Ctoo much details=E2=80=9D and the =E2=80=9Chelp outsider to follow= =E2=80=9D. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 18 05:07:40 2024 Received: (at 74296-done) by debbugs.gnu.org; 18 Nov 2024 10:07:40 +0000 Received: from localhost ([127.0.0.1]:60054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCyfU-00014u-7R for submit@debbugs.gnu.org; Mon, 18 Nov 2024 05:07:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCyfR-00014g-QQ for 74296-done@debbugs.gnu.org; Mon, 18 Nov 2024 05:07:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tCyfK-0007cF-6k; Mon, 18 Nov 2024 05:07:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=AgvJilmsyZLn1EqH6HOQSi0Ma6jdGtVDLkSWPWo6+5M=; b=mOo/eOpb9WDrFrhIUNoa Iq7YRMcI3mK5R21vLqO8tNRnrkk+CV8ZUCQL2mBMdJHlhzJAy9jm/SVpR4UozeGFU9LZUWsGpwklh 7LdMSyDAavWJSWkoYhl+D6wMLpKxfbH+AugzCxxyHWvkaMOWnkDLKW6eL7OIfP6Y7bj+AyGmtQQSo bAyzsOmu6CnKfhNXCrN8VZthD2CpV+K1EPyH3cLlxyfaL9Xm0sQdkRe8l5xxqhRYIokGtPbUO2abL vxFOpfEfY8Rcrnbv87CdY1PBFDxe2PHQDt3SojlLI5+u/9nARddA8taaIhxILnPzLmWJISaP8ly1u M183OJQ9MXzAzg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Christoph Buck Subject: Re: [bug#74296] [PATCH 0/1] Fix abi mismatch error on boot for cross-compiled images In-Reply-To: <87iksrpaiq.fsf@icepic.de> (Christoph Buck's message of "Wed, 13 Nov 2024 13:45:49 +0100") References: <87o72krs8n.fsf@gnu.org> <87iksrpaiq.fsf@icepic.de> Date: Mon, 18 Nov 2024 11:07:24 +0100 Message-ID: <87cyisg8ir.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74296-done Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 74296-done@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Christoph Buck skribis: > Ludovic Court=C3=A8s writes: [...] >> I believe the ABI break is fine too: developers will have to >> =E2=80=9Cmake clean-go && make=E2=80=9D, but that=E2=80=99s okay. > > Good to know. I added a summary of your explanation as a comment in the code, so our future selves get an idea of why things are done this way, and pushed as 23cbbe6860782c5d4a0ba599ea1cda0642e91661. Time for =E2=80=9Cmake clean-go && make=E2=80=9D! Thanks, Ludo=E2=80=99. From unknown Fri Aug 15 16:17:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 16 Dec 2024 12:24:16 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator