From unknown Tue Jun 24 17:29:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74289: 30.0.92; `require-with-check' fails on non-existing files Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Nov 2024 08:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74289 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 74289@debbugs.gnu.org Cc: Stefan Monnier X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Stefan Monnier Received: via spool by submit@debbugs.gnu.org id=B.173122823821746 (code B ref -1); Sun, 10 Nov 2024 08:44:01 +0000 Received: (at submit) by debbugs.gnu.org; 10 Nov 2024 08:43:58 +0000 Received: from localhost ([127.0.0.1]:55507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tA3Y5-0005eg-Jh for submit@debbugs.gnu.org; Sun, 10 Nov 2024 03:43:57 -0500 Received: from lists.gnu.org ([209.51.188.17]:44596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tA3Y3-0005eV-BW for submit@debbugs.gnu.org; Sun, 10 Nov 2024 03:43:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tA3Y1-00044N-BM for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2024 03:43:54 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tA3Xy-0005yv-TN for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2024 03:43:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=x75Rrg3pauMK93bN6KVUOECAR9hlWyMJL2GiD67xrnU=; b=l3cng8dNk2Bjv34+s3sO31jer2 nTcKPLjve6D0JBB3bBdcB1giqnL0Bcu8HqcyJvoXJL7+8zz8+ssr3A54+7w4ZHD8NEhcoaigpqfKF CHjqtGexPjGWsiZE3eqr4aUXRJdtdFjMssIijswiOHcn/1Gv2C+U2hetg8HMSlxgpMDc=; From: Daniel Mendler Date: Sun, 10 Nov 2024 09:43:29 +0100 Message-ID: <87ldxrbhse.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a01:4f8:c012:9177::1; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) `require-with-check' fails since 0aae02a3741c397d6952e3128d434827aca0f912 on non-existing files. See the CI run of the Compat test suite: https://github.com/emacs-compat/compat/actions/runs/11763132765/job/32766767667 This call fails: (require-with-check 'compat-does-not-exist nil 'noerror) Backtrace: Test compat-require-with-check backtrace: string-match("\\(?:\\.\\(?:el\\(?:\\.gz\\|c\\(?:\\.gz\\)?\\)?\\|so\\ require-with-check(compat-does-not-exist nil noerror) apply(require-with-check (compat-does-not-exist nil noerror)) (setq value-7960 (apply fn-7958 args-7959)) (unwind-protect (setq value-7960 (apply fn-7958 args-7959)) (setq fo (not (unwind-protect (setq value-7960 (apply fn-7958 args-7959)) (se (if (not (unwind-protect (setq value-7960 (apply fn-7958 args-7959)) (let (form-description-7962) (if (not (unwind-protect (setq value-79 (let ((value-7960 'ert-form-evaluation-aborted-7961)) (let (form-des (let* ((fn-7958 #'require-with-check) (args-7959 (condition-case err (progn (let ((tail (list dir1 dir2))) (while tail (let ((dir (car ta (unwind-protect (progn (let ((tail (list dir1 dir2))) (while tail (l (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct (progn (let* ((coding-system-for-write nil) (temp-file (file-name-as (unwind-protect (progn (let* ((coding-system-for-write nil) (temp-fi (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct #f(lambda () [compat-tests--unexist compat-tests--local compat-tests #f(compiled-function () #)() handler-bind-1(#f(compiled-function () # Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Nov 2024 17:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74289 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Daniel Mendler Cc: 74289@debbugs.gnu.org Received: via spool by 74289-submit@debbugs.gnu.org id=B74289.173126034218057 (code B ref 74289); Sun, 10 Nov 2024 17:40:02 +0000 Received: (at 74289) by debbugs.gnu.org; 10 Nov 2024 17:39:02 +0000 Received: from localhost ([127.0.0.1]:56479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tABtt-0004gz-OD for submit@debbugs.gnu.org; Sun, 10 Nov 2024 12:39:02 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tABtr-0004gg-K2 for 74289@debbugs.gnu.org; Sun, 10 Nov 2024 12:39:00 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 25FEC8099D; Sun, 10 Nov 2024 12:38:54 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1731260333; bh=9Ez7VWh+OjpXKQk7gzFbi6xgFNrIv7B7iECjAariea4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=b34Lu/232iWMZcBWyYh2DGwp37Ovy2mf2LxXQqZj0nkXR0KsGDeZtkBE1T0Bvu8fj HLZavDWvev7PoRg8nNaJiP/WHJ4GRCms7ylgIHh/+iyRmOP8hHPol+PWJgjXtNFPgz /nYkyTjjnuuVinf5xWaNsHMatnX9TM+7XlsjATjD0kk9H4KCuMwUDDTO+25LV6Q72c +pBEIOC+DP4R7QwxoKQfKeXJeMMNXwzmFCuey/xBm4I3hLpHMAtWVoQp3w+RZ27As1 mIvy/Q049OxNDgjHOYBIXXrFz4FXqXvOObqh+PVruQJ8aVQDwXGnkxx38TJaYiuUso vbclgp4fl5tvg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4831380964; Sun, 10 Nov 2024 12:38:53 -0500 (EST) Received: from pastel (104-195-225-43.cpe.teksavvy.com [104.195.225.43]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1BAEB12020C; Sun, 10 Nov 2024 12:38:53 -0500 (EST) From: Stefan Monnier In-Reply-To: <87ldxrbhse.fsf@daniel-mendler.de> (Daniel Mendler's message of "Sun, 10 Nov 2024 09:43:29 +0100") Message-ID: References: <87ldxrbhse.fsf@daniel-mendler.de> Date: Sun, 10 Nov 2024 12:38:51 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.039 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > `require-with-check' fails since > 0aae02a3741c397d6952e3128d434827aca0f912 on non-existing files. > > See the CI run of the Compat test suite: > > https://github.com/emacs-compat/compat/actions/runs/11763132765/job/32766767667 > > This call fails: > > (require-with-check 'compat-does-not-exist nil 'noerror) Oops, can you confirm that the patch below works for you? Stefan diff --git a/lisp/files.el b/lisp/files.el index c3fce9f15f9..0d998e6e18e 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -1288,10 +1306,11 @@ require-with-check ;; we did load "it". (bug#74040) ;; So use a "permissive" search which doesn't pay attention to ;; differences between file extensions. - (prefix (if (string-match - (concat (regexp-opt (get-load-suffixes)) "\\'") fn) - (concat (substring fn 0 (match-beginning 0)) ".") - fn)) + (prefix (when fn + (if (string-match + (concat (regexp-opt (get-load-suffixes)) "\\'") fn) + (concat (substring fn 0 (match-beginning 0)) ".") + fn))) (lh load-history)) (while (and lh (let ((file (car-safe (car lh)))) (not (and file (string-prefix-p prefix file))))) From unknown Tue Jun 24 17:29:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74289: 30.0.92; `require-with-check' fails on non-existing files Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Nov 2024 17:49:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74289 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 74289@debbugs.gnu.org Received: via spool by 74289-submit@debbugs.gnu.org id=B74289.173126092619831 (code B ref 74289); Sun, 10 Nov 2024 17:49:03 +0000 Received: (at 74289) by debbugs.gnu.org; 10 Nov 2024 17:48:46 +0000 Received: from localhost ([127.0.0.1]:56516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAC3K-00059n-8a for submit@debbugs.gnu.org; Sun, 10 Nov 2024 12:48:46 -0500 Received: from server.qxqx.de ([49.12.34.165]:50439 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAC3H-00059U-QM for 74289@debbugs.gnu.org; Sun, 10 Nov 2024 12:48:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=08qUNynVDR1/BLfad9HLDbqRluWkuGROV7q/7mBWJ4E=; b=FD0jhzl0RFsjCZaFrpN8ab2dpZ Q/Ba4iX7khNBN7j2Zr1u945S9fozkBQhOu16+BZau8k+D+FC2za7WcQqfJoJoU1cVTgmIe9z06Xcj sWLqkjvpOeEql+w/Kr/+M5VUZdvr8zy3AG8f8DdDw6WKKsjNxO1AxmzLJvHykop5iCYY=; From: Daniel Mendler In-Reply-To: (Stefan Monnier's message of "Sun, 10 Nov 2024 12:38:51 -0500") References: <87ldxrbhse.fsf@daniel-mendler.de> Date: Sun, 10 Nov 2024 18:46:25 +0100 Message-ID: <87iksvasni.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: >> `require-with-check' fails since >> 0aae02a3741c397d6952e3128d434827aca0f912 on non-existing files. >> >> See the CI run of the Compat test suite: >> >> https://github.com/emacs-compat/compat/actions/runs/11763132765/job/32766767667 >> >> This call fails: >> >> (require-with-check 'compat-does-not-exist nil 'noerror) > > Oops, can you confirm that the patch below works for you? It does look correct :) Thanks. Daniel From unknown Tue Jun 24 17:29:33 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Daniel Mendler Subject: bug#74289: closed (Re: bug#74289: 30.0.92; `require-with-check' fails on non-existing files) Message-ID: References: <87ldxrbhse.fsf@daniel-mendler.de> X-Gnu-PR-Message: they-closed 74289 X-Gnu-PR-Package: emacs Reply-To: 74289@debbugs.gnu.org Date: Sun, 10 Nov 2024 21:52:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1731275522-30118-1" This is a multi-part message in MIME format... ------------=_1731275522-30118-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #74289: 30.0.92; `require-with-check' fails on non-existing files which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 74289@debbugs.gnu.org. --=20 74289: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74289 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1731275522-30118-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 74289-done) by debbugs.gnu.org; 10 Nov 2024 21:51:26 +0000 Received: from localhost ([127.0.0.1]:56909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAFqA-0007oo-7h for submit@debbugs.gnu.org; Sun, 10 Nov 2024 16:51:26 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:8289) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAFq7-0007oa-D6 for 74289-done@debbugs.gnu.org; Sun, 10 Nov 2024 16:51:24 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6EA8C442AFD; Sun, 10 Nov 2024 16:51:17 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1731275475; bh=GCzC4nlEDudqqlSLcuVpwwuQElJED13r+1YGCsK70o8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Zqhzag3zkUIow7lNvIxyMrcJ85rWax2JG5dT0q+as9NClvSIQy6b35Hpn/8lcA5cm fmyJU0KwpFevX75xRqWE4R1yXnFH7PH3/6lmB6RPfpkw6uBWuK95UhrzJwKmkNwrYg Kf/IHeVxC9D52Z9p3Mt50CL2Bzt9IBM1I/dtTqyCJDPqIdQhF9ZkNrcgbJz36Zgjnz 3dX1fbu2G4nrmxD53WAcbJPzzmytp8A7GWgPU9Ig5PLhHcrlrcHK/+mLDtgoFnxEWq rUj6VM+Q1UHyndDPgWWQh/a15oFKZjf7nZEngFetMmvoAEVqwCQNe1zve2ACLaFTdt 2M3yVKpy4rxng== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id ABE07442AEF; Sun, 10 Nov 2024 16:51:15 -0500 (EST) Received: from pastel (104-195-225-43.cpe.teksavvy.com [104.195.225.43]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 836BC120304; Sun, 10 Nov 2024 16:51:15 -0500 (EST) From: Stefan Monnier To: Daniel Mendler Subject: Re: bug#74289: 30.0.92; `require-with-check' fails on non-existing files In-Reply-To: <87iksvasni.fsf@daniel-mendler.de> (Daniel Mendler's message of "Sun, 10 Nov 2024 18:46:25 +0100") Message-ID: References: <87ldxrbhse.fsf@daniel-mendler.de> <87iksvasni.fsf@daniel-mendler.de> Date: Sun, 10 Nov 2024 16:51:14 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.040 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74289-done Cc: 74289-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>> `require-with-check' fails since >>> 0aae02a3741c397d6952e3128d434827aca0f912 on non-existing files. >>> >>> See the CI run of the Compat test suite: >>> >>> https://github.com/emacs-compat/compat/actions/runs/11763132765/job/32766767667 >>> >>> This call fails: >>> >>> (require-with-check 'compat-does-not-exist nil 'noerror) >> >> Oops, can you confirm that the patch below works for you? > > It does look correct :) Thanks. Than you, Daniel, pushed to `emacs-30`. Closing, Stefan ------------=_1731275522-30118-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 10 Nov 2024 08:43:58 +0000 Received: from localhost ([127.0.0.1]:55507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tA3Y5-0005eg-Jh for submit@debbugs.gnu.org; Sun, 10 Nov 2024 03:43:57 -0500 Received: from lists.gnu.org ([209.51.188.17]:44596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tA3Y3-0005eV-BW for submit@debbugs.gnu.org; Sun, 10 Nov 2024 03:43:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tA3Y1-00044N-BM for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2024 03:43:54 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tA3Xy-0005yv-TN for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2024 03:43:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=x75Rrg3pauMK93bN6KVUOECAR9hlWyMJL2GiD67xrnU=; b=l3cng8dNk2Bjv34+s3sO31jer2 nTcKPLjve6D0JBB3bBdcB1giqnL0Bcu8HqcyJvoXJL7+8zz8+ssr3A54+7w4ZHD8NEhcoaigpqfKF CHjqtGexPjGWsiZE3eqr4aUXRJdtdFjMssIijswiOHcn/1Gv2C+U2hetg8HMSlxgpMDc=; From: Daniel Mendler To: bug-gnu-emacs@gnu.org Subject: 30.0.92; `require-with-check' fails on non-existing files X-Debbugs-Cc: Stefan Monnier Date: Sun, 10 Nov 2024 09:43:29 +0100 Message-ID: <87ldxrbhse.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a01:4f8:c012:9177::1; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) `require-with-check' fails since 0aae02a3741c397d6952e3128d434827aca0f912 on non-existing files. See the CI run of the Compat test suite: https://github.com/emacs-compat/compat/actions/runs/11763132765/job/32766767667 This call fails: (require-with-check 'compat-does-not-exist nil 'noerror) Backtrace: Test compat-require-with-check backtrace: string-match("\\(?:\\.\\(?:el\\(?:\\.gz\\|c\\(?:\\.gz\\)?\\)?\\|so\\ require-with-check(compat-does-not-exist nil noerror) apply(require-with-check (compat-does-not-exist nil noerror)) (setq value-7960 (apply fn-7958 args-7959)) (unwind-protect (setq value-7960 (apply fn-7958 args-7959)) (setq fo (not (unwind-protect (setq value-7960 (apply fn-7958 args-7959)) (se (if (not (unwind-protect (setq value-7960 (apply fn-7958 args-7959)) (let (form-description-7962) (if (not (unwind-protect (setq value-79 (let ((value-7960 'ert-form-evaluation-aborted-7961)) (let (form-des (let* ((fn-7958 #'require-with-check) (args-7959 (condition-case err (progn (let ((tail (list dir1 dir2))) (while tail (let ((dir (car ta (unwind-protect (progn (let ((tail (list dir1 dir2))) (while tail (l (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct (progn (let* ((coding-system-for-write nil) (temp-file (file-name-as (unwind-protect (progn (let* ((coding-system-for-write nil) (temp-fi (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct #f(lambda () [compat-tests--unexist compat-tests--local compat-tests #f(compiled-function () #)() handler-bind-1(#f(compiled-function () # Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Nov 2024 04:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74289 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 74289-done@debbugs.gnu.org Received: via spool by 74289-done@debbugs.gnu.org id=D74289.17313008784748 (code D ref 74289); Mon, 11 Nov 2024 04:55:02 +0000 Received: (at 74289-done) by debbugs.gnu.org; 11 Nov 2024 04:54:38 +0000 Received: from localhost ([127.0.0.1]:57433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAMRi-0001EW-0h for submit@debbugs.gnu.org; Sun, 10 Nov 2024 23:54:38 -0500 Received: from server.qxqx.de ([49.12.34.165]:37191 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAMRf-0001EG-TJ for 74289-done@debbugs.gnu.org; Sun, 10 Nov 2024 23:54:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ExmHsfRhBLHy2P/vyZfDfH9Wq21g0FicGvpbY3neg+Q=; b=f9jQ0N+P16H6B/OOGZ9YgGu6zr V9xCzssHFXl1aE0htH+U2aoJ+I/h5OwU64IyDPclhiA9TPkoBzKd9oRZepQuL5bR37tAuKq+1E3vP ILQsvCjUsa1G78oLLji7BpCT0oXgN/SrKv+ZYap/0LeIQL6iQezlvZac8JVsjdkqtuvA=; From: Daniel Mendler In-Reply-To: (Stefan Monnier's message of "Sun, 10 Nov 2024 16:51:14 -0500") References: <87ldxrbhse.fsf@daniel-mendler.de> <87iksvasni.fsf@daniel-mendler.de> Date: Mon, 11 Nov 2024 05:52:16 +0100 Message-ID: <87r07icqyn.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: >>>> `require-with-check' fails since >>>> 0aae02a3741c397d6952e3128d434827aca0f912 on non-existing files. >>>> >>>> See the CI run of the Compat test suite: >>>> >>>> https://github.com/emacs-compat/compat/actions/runs/11763132765/job/32766767667 >>>> >>>> This call fails: >>>> >>>> (require-with-check 'compat-does-not-exist nil 'noerror) >>> >>> Oops, can you confirm that the patch below works for you? >> >> It does look correct :) Thanks. > > Than you, Daniel, pushed to `emacs-30`. > Closing, Hi Stefan, I think there is one more bug a little bit later. prefix can be nil here: (while (and lh (let ((file (car-safe (car lh)))) (not (and file (string-prefix-p prefix file))))) ...) In order to check, simply eval this code: (require-with-check 'compat-does-not-exist nil 'noerror) Daniel From unknown Tue Jun 24 17:29:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74289: 30.0.92; `require-with-check' fails on non-existing files Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Nov 2024 08:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74289 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 74289-done@debbugs.gnu.org Received: via spool by 74289-done@debbugs.gnu.org id=D74289.173148810913013 (code D ref 74289); Wed, 13 Nov 2024 08:56:02 +0000 Received: (at 74289-done) by debbugs.gnu.org; 13 Nov 2024 08:55:09 +0000 Received: from localhost ([127.0.0.1]:40691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tB99Z-0003Ng-0N for submit@debbugs.gnu.org; Wed, 13 Nov 2024 03:55:09 -0500 Received: from server.qxqx.de ([49.12.34.165]:51965 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tB99W-0003JY-4g for 74289-done@debbugs.gnu.org; Wed, 13 Nov 2024 03:55:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=WjS6VumtwMqCY0zGmRn7r0vZJC8V72PD3UrE46BJQHM=; b=T5Qx+H/z1SI3aqBbetJWKRYr2B hhBRjdGGtrWPxQM2F3q5JcVO5KK1vGDakTbMIUl5E3TV6PBtXwODpAru4+kQhQSlATlp5jhz4gl42 3E4Q4XWig8ELfRdub2mKdmFFjRQmdaZUBYWxCcfZnfDO/5dlkOw7UZ9uzbEh3+QiVevQ=; From: Daniel Mendler In-Reply-To: <87r07icqyn.fsf@daniel-mendler.de> (Daniel Mendler's message of "Mon, 11 Nov 2024 05:52:16 +0100") References: <87ldxrbhse.fsf@daniel-mendler.de> <87iksvasni.fsf@daniel-mendler.de> <87r07icqyn.fsf@daniel-mendler.de> Date: Wed, 13 Nov 2024 09:52:48 +0100 Message-ID: <87a5e3ldlr.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Btw, 3496234c8ed10a14f740199722ec727bd43c82d3 mentioned an unrelated wrong bug number, not bug#74289. From unknown Tue Jun 24 17:29:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74289: 30.0.92; `require-with-check' fails on non-existing files Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Nov 2024 16:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74289 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Daniel Mendler Cc: 74289-done@debbugs.gnu.org Received: via spool by 74289-done@debbugs.gnu.org id=D74289.173151605030841 (code D ref 74289); Wed, 13 Nov 2024 16:41:02 +0000 Received: (at 74289-done) by debbugs.gnu.org; 13 Nov 2024 16:40:50 +0000 Received: from localhost ([127.0.0.1]:43303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBGQE-00081N-6Q for submit@debbugs.gnu.org; Wed, 13 Nov 2024 11:40:50 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBGQB-000819-VJ for 74289-done@debbugs.gnu.org; Wed, 13 Nov 2024 11:40:48 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B70CF80294; Wed, 13 Nov 2024 11:40:36 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1731516035; bh=3q8iWOdaUWKI0kJ2a6+TRr8iS6Q31+UrBGq6ykKma3g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=jI9mX7dHpI0mPY6DUYkO1ep8MJ40dr85/RekCjOb9RfxICGSNvm2rdN5nbiume0t/ Q03HW45i1gQ12+2H9mlpNec9PVpa1IQQGHgTve7yBXbaSiALFwPWp8rmvnKIUETWtc txoe71EBuU/r2V8PbzSf37yLL8xU6rqqbp7DNn5BJBQnU2VoWGDJzIGcO8Y007HQ2H Sn5YjiTSQOoe8vBjm48Xfkz2pJKBTBPI+bcRDzC6tnGaQAh3+mdKPeLD3HA7LimsoV Le5WxOwymORfess4Qs1IYtlUK62CJHeOzovXF4yrou65CWMFchH5AgfaC++uU7NL6Y 1Ual4nekjjDRQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1C28080030; Wed, 13 Nov 2024 11:40:35 -0500 (EST) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0AD79120312; Wed, 13 Nov 2024 11:40:35 -0500 (EST) From: Stefan Monnier In-Reply-To: <87r07icqyn.fsf@daniel-mendler.de> (Daniel Mendler's message of "Mon, 11 Nov 2024 05:52:16 +0100") Message-ID: References: <87ldxrbhse.fsf@daniel-mendler.de> <87iksvasni.fsf@daniel-mendler.de> <87r07icqyn.fsf@daniel-mendler.de> Date: Wed, 13 Nov 2024 11:40:34 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.172 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I think there is one more bug a little bit later. My belief that it is fixed is a bit stronger now. Can you confirm on your side? Stefan From unknown Tue Jun 24 17:29:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74289: 30.0.92; `require-with-check' fails on non-existing files Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Nov 2024 16:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74289 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 74289-done@debbugs.gnu.org Received: via spool by 74289-done@debbugs.gnu.org id=D74289.1731516935922 (code D ref 74289); Wed, 13 Nov 2024 16:56:01 +0000 Received: (at 74289-done) by debbugs.gnu.org; 13 Nov 2024 16:55:35 +0000 Received: from localhost ([127.0.0.1]:43346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBGeU-0000En-R3 for submit@debbugs.gnu.org; Wed, 13 Nov 2024 11:55:35 -0500 Received: from server.qxqx.de ([49.12.34.165]:53579 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBGeR-0000EU-Oi for 74289-done@debbugs.gnu.org; Wed, 13 Nov 2024 11:55:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9TbmPafEGyYg09sWGZdkDAt86xJwrQdYs9a4P9ZVTgg=; b=QDo/J25o8kzWiUljG3/SQfabcs I9C5OTXLvRolONZ3Y4HnR+ePQz4/zI22jSHF2NcJtTGZjrx4aYFn4kvvzNZGREfVAFvGkDYW+XvX2 zEHKkEL2niMxRzZAcDP0K+F8HgXwTm/lL/vTRybRsbNhnlerXbCXU3J10zxJksaOso8E=; From: Daniel Mendler In-Reply-To: (Stefan Monnier's message of "Wed, 13 Nov 2024 11:40:34 -0500") References: <87ldxrbhse.fsf@daniel-mendler.de> <87iksvasni.fsf@daniel-mendler.de> <87r07icqyn.fsf@daniel-mendler.de> Date: Wed, 13 Nov 2024 17:53:13 +0100 Message-ID: <87jzd73wjq.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: >> I think there is one more bug a little bit later. > > My belief that it is fixed is a bit stronger now. > Can you confirm on your side? Thanks. It works. I've evaluated the function in my Emacs and executed the test. Daniel