GNU bug report logs - #74287
[PATCH] Rework history Isearch for Eshell

Previous Next

Full log

View this message in rfc822 format

From: Jim Porter <jporterbugs <at> gmail.com>
To: James Thomas <jimjoe <at> gmx.net>
Cc: 74287 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>, Pengji Zhang <me <at> pengjiz.com>, Juri Linkov <juri <at> linkov.net>
Subject: bug#74287: [PATCH] Rework history Isearch for Eshell
Date: Tue, 26 Nov 2024 09:00:13 -0800

On 11/26/2024 1:41 AM, James Thomas via Bug reports for GNU Emacs, the 
Swiss army knife of text editors wrote:
> My 2c: I now think it's better to hold out for something with way less
> code, using capf.

Like mentioned in the emacs-devel list, that's probably how *I'd* want a 
command history search implementation to use, but I also think that an 
Isearch interface makes a lot of sense as an option, depending on user 
preferences. As far as I can tell, we'd have to write different code for 
each of these styles (i.e. you can't just make Isearch use capf). Though 
as mentioned I'm not very familiar with Isearch's internals.

So long as this doesn't prevent a capf-based implementation (and I'm 
guessing it wouldn't, since that would just be a new option), I think we 
could merge this patch. I also prefer to have Shell and Eshell work the 
same way unless there's some compelling reason why they should be different.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.