GNU bug report logs - #74287
[PATCH] Rework history Isearch for Eshell

Previous Next

Full log

Message #14 received at 74287 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Pengji Zhang <me <at> pengjiz.com>, 74287 <at> debbugs.gnu.org
Cc: Juri Linkov <juri <at> linkov.net>, James Thomas <jimjoe <at> gmx.net>,
 Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#74287: [PATCH] Rework history Isearch for Eshell
Date: Mon, 25 Nov 2024 22:53:36 -0800

On 11/9/2024 5:22 PM, Pengji Zhang wrote:
> Hello,
> 
> This patch brings a comint-like interface for history Isearch to Eshell.
> To try it, type 'M-r' in Eshell, and search through the input history
> ring incrementally.

From inspection, this code all looks good to me. At least, it matches 
what Comint does; I don't know much about Isearch's implementation, so 
I'm just trusting that Comint is right here. Since this is a 
somewhat-large patch, I'm going to try and find some time this week to 
test it out so that I understand how it all works, and assuming I don't 
find any major problems, I'll merge it shortly after that.

Thanks for your contribution to Eshell (and Emacs as a whole)!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.