From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 09 03:21:24 2024 Received: (at submit) by debbugs.gnu.org; 9 Nov 2024 08:21:24 +0000 Received: from localhost ([127.0.0.1]:53283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9gif-0007Wl-Ie for submit@debbugs.gnu.org; Sat, 09 Nov 2024 03:21:24 -0500 Received: from lists.gnu.org ([209.51.188.17]:59486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9VWg-0000f7-Th for submit@debbugs.gnu.org; Fri, 08 Nov 2024 15:24:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9VWf-0001WX-Ua for bug-gnu-emacs@gnu.org; Fri, 08 Nov 2024 15:24:14 -0500 Received: from tilde.club ([142.44.150.184]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9VWc-0001so-Eh for bug-gnu-emacs@gnu.org; Fri, 08 Nov 2024 15:24:12 -0500 Received: from webmail.tilde.club (tilde.club [IPv6:2607:5300:203:b92b::115]) by tilde.club (Postfix) with ESMTPSA id A917E2209E0D7 for ; Fri, 8 Nov 2024 20:24:07 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 tilde.club A917E2209E0D7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.club; s=mail; t=1731097447; bh=mPYVfTtQc+D+Kfc6aFnoNeLJYwJ2SV6dV4JjqzExMII=; h=Date:From:Subject:To:From; b=ERYVrZjLqzFoik2ANdr/X3UY1cePZhNFZ3t+5L+5tVIZyAFAL5cDV3TOK2sQnJ5kV MFGyrOwHjmOGoZ0W4jdrsAqN4vLG8PYRIf5rD9gO5MbxcP41+3rZCDraGS8F30Xzua 5pr/LUUvBmvZFqfGXCxUzg6PhM3lTK4PejaKNS0k= MIME-Version: 1.0 Date: Fri, 08 Nov 2024 20:24:07 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: acidbong@tilde.club Message-ID: TLS-Required: No Subject: 29.4; rust-ts-mode doesn't highlight some function calls To: bug-gnu-emacs@gnu.org Received-SPF: pass client-ip=142.44.150.184; envelope-from=acidbong@tilde.club; helo=tilde.club X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 09 Nov 2024 03:21:20 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) rust-ts-mode highlights function calls when they're used in an assignment or as statements, but not in string formatting: ``` println!("Some line and {}", some_function(a, b)) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 # ^^^^^^^^^^^^^ this is not getting highlighted ``` This is how it looks in Emacs (treesit-level is 4 btw): https://matrix.envs.net/_matrix/media/r0/download/envs.net/66652827fc7545= e57d2eef263ee28ef6bc2ef1c01854976160883015680 This is how it looks in Neovim (with treesitter highlighting on): https://matrix.envs.net/_matrix/media/r0/download/envs.net/382a104ee3e6e4= dacabebfa7f84f4b9b7231b1171854976151936565248 ----------------------------------- In GNU Emacs 29.4 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.18.2, Xaw3d scroll bars) Windowing system distributor 'The X.Org Foundation', version 11.0.1210101= 3 System Description: NixOS 24.11 (Vicuna) Configured using: 'configure --prefix=3D/nix/store/fsglyaxfhlavaskr159b4yyjlajy4qq5-emacs-29.4 --disable-build-details --with-modules --with-x-toolkit=3Dlucid --with-cairo --with-xft --with-compress-install --with-toolkit-scroll-bars --with-native-compilation --without-imagemagick --with-mailutils --without-small-ja-dic --with-tree-sitter --with-xinput2 --without-xwidgets --with-dbus --with-selinux' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: =C2=A0 value of $EMACSLOADPATH:=C2=A0 =C2=A0 value of $EMACSNATIVELOADPATH:=C2=A0 =C2=A0 value of $LANG: ru_RU.UTF-8 =C2=A0 locale-coding-system: utf-8-unix Major mode: Rust Minor modes in effect: =C2=A0 consult-eglot-embark-mode: t =C2=A0 eglot-inlay-hints-mode: t =C2=A0 eglot--managed-mode: t =C2=A0 flymake-mode: t =C2=A0 server-mode: t =C2=A0 display-line-numbers-mode: t =C2=A0 rainbow-mode: t =C2=A0 corfu-popupinfo-mode: t =C2=A0 corfu-history-mode: t =C2=A0 corfu-mode: t =C2=A0 doom-modeline-mode: t =C2=A0 nerd-icons-completion-mode: t =C2=A0 marginalia-mode: t =C2=A0 vertico-mode: t =C2=A0 global-treesit-auto-mode: t =C2=A0 diff-hl-flydiff-mode: t =C2=A0 global-diff-hl-mode: t =C2=A0 diff-hl-mode: t =C2=A0 ws-butler-global-mode: t =C2=A0 ws-butler-mode: t =C2=A0 direnv-mode: t =C2=A0 global-ligature-mode: t =C2=A0 ligature-mode: t =C2=A0 which-key-mode: t =C2=A0 meow-global-mode: t =C2=A0 meow-mode: t =C2=A0 meow-normal-mode: t =C2=A0 meow-esc-mode: t =C2=A0 override-global-mode: t =C2=A0 delete-selection-mode: t =C2=A0 global-auto-revert-mode: t =C2=A0 recentf-mode: t =C2=A0 save-place-mode: t =C2=A0 savehist-mode: t =C2=A0 global-hl-line-mode: t =C2=A0 electric-pair-mode: t =C2=A0 global-eldoc-mode: t =C2=A0 eldoc-mode: t =C2=A0 show-paren-mode: t =C2=A0 electric-indent-mode: t =C2=A0 mouse-wheel-mode: t =C2=A0 file-name-shadow-mode: t =C2=A0 global-font-lock-mode: t =C2=A0 font-lock-mode: t =C2=A0 blink-cursor-mode: t =C2=A0 size-indication-mode: t =C2=A0 column-number-mode: t =C2=A0 line-number-mode: t =C2=A0 global-visual-line-mode: t =C2=A0 visual-line-mode: t =C2=A0 transient-mark-mode: t =C2=A0 auto-composition-mode: t =C2=A0 auto-encryption-mode: t =C2=A0 auto-compression-mode: t Load-path shadows: /nix/store/qm7zdj12cb53nm3lvyh7pmf9kzfbz613-emacs-packages-deps/share/ema= cs/site-lisp/site-start hides /nix/store/fsglyaxfhlavaskr159b4yyjlajy4qq5= -emacs-29.4/share/emacs/site-lisp/site-start /nix/store/qm7zdj12cb53nm3lvyh7pmf9kzfbz613-emacs-packages-deps/share/ema= cs/site-lisp/elpa/transient-20241104.2211/transient hides /nix/store/fsgl= yaxfhlavaskr159b4yyjlajy4qq5-emacs-29.4/share/emacs/29.4/lisp/transient /nix/store/qm7zdj12cb53nm3lvyh7pmf9kzfbz613-emacs-packages-deps/share/ema= cs/site-lisp/elpa/seq-2.24/seq hides /nix/store/fsglyaxfhlavaskr159b4yyjl= ajy4qq5-emacs-29.4/share/emacs/29.4/lisp/emacs-lisp/seq Features: (edmacro shadow sort mail-extr emacsbug consult-eglot-embark consult-eglot consult-eglot-embark-autoloads consult-eglot-autoloads loaddefs-gen lisp-mnt radix-tree tar-mode arc-mode archive-mode mm-archive message sendmail yank-media rfc822 mml mml-sec epa derived epg rfc6068 gnus-util mailabbrev gmm-utils mailheader mm-decode mm-bodies mm-encode epg-config mail-utils gnutls network-stream url-cache url-http url-auth mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm puny cus-edit cus-start cus-load descr-text embark-consult consult bookmark eglot external-completion jsonrpc ert debug backtrace xref flymake-proc flymake imenu vc-git rust-ts-mode c-ts-common misearch multi-isearch dabbrev cape-char pp mule-util face-remap embark-org org-element org-persist xdg org-id org-refile avl-tree generator embark ffap thingatpt project pulse server display-line-numbers rainbow-mode corfu-popupinfo corfu-history nerd-icons-corfu corfu doom-modeline doom-modeline-segments doom-modeline-env doom-modeline-core shrink-path f s org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete pcomplete org-list org-footnote org-faces org-entities time-date noutline outline ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs find-func cal-menu calendar cal-loaddefs org-version org-compat org-macs format-spec cape nerd-icons-completion marginalia vertico orderless compat compat-30 treesit-auto treesit meson-mode smie compile text-property-search comint ansi-osc ansi-color ring diff-hl-dired dired dired-loaddefs diff-hl-flydiff diff diff-hl log-view pcvs-util vc-dir ewoc vc vc-dispatcher ws-butler direnv diff-mode dash ligature nerd-icons nerd-icons-faces nerd-icons-data nerd-icons-data-mdicon nerd-icons-data-flicon nerd-icons-data-codicon nerd-icons-data-devicon nerd-icons-data-sucicon nerd-icons-data-wicon nerd-icons-data-faicon nerd-icons-data-powerline nerd-icons-data-octicon nerd-icons-data-pomicon nerd-icons-data-ipsicon doom-themes-ext-org doom-gruvbox-theme doom-themes doom-themes-base which-key meow meow-tutor meow-cheatsheet meow-cheatsheet-layout meow-core meow-shims meow-esc meow-command array meow-beacon kmacro meow-thing meow-visual meow-keypad meow-helpers meow-util color meow-keymap meow-face meow-var bind-key easy-mmode comp comp-cstr warnings icons cl-extra help-mode delsel autorevert filenotify recentf tree-widget wid-edit saveplace savehist hl-line elec-pair use-package-ensure use-package-core finder-inf consult-project-extra-autoloads cue-sheet-mode-autoloads rx inputrc-mode-autoloads ws-butler-autoloads cape-autoloads corfu-autoloads diff-hl-autoloads direnv-autoloads doom-modeline-autoloads doom-themes-autoloads embark-consult-autoloads consult-autoloads embark-autoloads ligature-autoloads magit-autoloads pcase magit-section-autoloads marginalia-autoloads meow-autoloads meson-mode-autoloads nerd-icons-completion-autoloads nerd-icons-corfu-autoloads nerd-icons-dired-autoloads nerd-icons-autoloads nix-ts-mode-autoloads orderless-autoloads rainbow-mode-autoloads shrink-path-autoloads f-autoloads dash-autoloads s-autoloads transient-autoloads treesit-auto-autoloads vertico-autoloads which-key-autoloads with-editor-autoloads info compat-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib cyril-util rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 638926 185590) (symbols 48 47388 5) (strings 32 264344 60226) (string-bytes 1 7396023) (vectors 16 62210) (vector-slots 8 1620783 87746) (floats 8 820 424) (intervals 56 1600 2497) (buffers 984 28)) From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 09 03:52:27 2024 Received: (at 74277) by debbugs.gnu.org; 9 Nov 2024 08:52:27 +0000 Received: from localhost ([127.0.0.1]:53337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9hCk-0000Qc-Gr for submit@debbugs.gnu.org; Sat, 09 Nov 2024 03:52:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9hCi-0000QI-2g for 74277@debbugs.gnu.org; Sat, 09 Nov 2024 03:52:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9hCc-000747-G0; Sat, 09 Nov 2024 03:52:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=LfgGX1M9O3IBzkm0/AEDKbnFFFcpHAf8lJOmcKh4lmU=; b=sITIvbsVEiiBOq5PvhOE EP2VxhC3E7KHNu8XhmGTUdZVLHn/pkiEHvm3km/ixh88I73mTcd0p/lwkDsQQqjvpubkxfWTN4gCv x0tuV0rkskU33WNmtUobrXhb75/xAw+YuS04YT6hhVlyciKSOkVI9dqMQKlE8BhGQaxAXLNWBE2yF HAyMO4K0fkoIhbIznxFJuaYjfJlTNHZYEUZnmOjH1NeGQpNlUXEf/aGI15gewFbQ9CD1Ago3+42tz kj3ITHlspvcJ2RbMmZ4Uu6+avWNGqPduPruHdQYWUfnRpUI8A0HVRYloErcFhqCHOIooVUg3O+Xfl 5K0dHwEE2jRyZw==; Date: Sat, 09 Nov 2024 10:52:14 +0200 Message-Id: <86bjyookld.fsf@gnu.org> From: Eli Zaretskii To: acidbong@tilde.club, Randy Taylor , Yuan Fu In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#74277: 29.4; rust-ts-mode doesn't highlight some function calls References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74277 Cc: 74277@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 08 Nov 2024 20:24:07 +0000 > From: acidbong--- via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > rust-ts-mode highlights function calls when they're used in an > assignment or as statements, but not in string formatting: > > > ``` > println!("Some line and {}", some_function(a, b)) >                            # ^^^^^^^^^^^^^ this is not getting highlighted > ``` > > This is how it looks in Emacs (treesit-level is 4 btw): > https://matrix.envs.net/_matrix/media/r0/download/envs.net/66652827fc7545e57d2eef263ee28ef6bc2ef1c01854976160883015680 > > This is how it looks in Neovim (with treesitter highlighting on): > https://matrix.envs.net/_matrix/media/r0/download/envs.net/382a104ee3e6e4dacabebfa7f84f4b9b7231b1171854976151936565248 > > ----------------------------------- Thanks. Randy/Yuan, any suggestions or fixes? From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 10 16:10:51 2024 Received: (at 74277) by debbugs.gnu.org; 10 Nov 2024 21:10:51 +0000 Received: from localhost ([127.0.0.1]:56866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAFCt-00062t-36 for submit@debbugs.gnu.org; Sun, 10 Nov 2024 16:10:51 -0500 Received: from mail-4018.proton.ch ([185.70.40.18]:29187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAFCo-00062Z-UO for 74277@debbugs.gnu.org; Sun, 10 Nov 2024 16:10:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1731273040; x=1731532240; bh=pPw4rpa2FS3aEFCl++oaFcqTeuWXGVEv7lBLsa0mFtw=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=SI0r2GJqHRTgDp2jGxCw8NIhT3T0jjbnzZnDQtBNmKM1ZqAKegomiwx+22aCv4+cu GAlPAM4dNzpprYfhTju+NY3zpeJKpfoUSKyB3szunnhLupyNb3Slu2/6JW50R2Y9ve 4ysek6Iz8jhPHKLJG5nG78lBzaNeOTcsQjp+86ZKadZe1ygrp6/2/Dx2fo17KaQuHP gVEz1AP1ST+GFA9gvGz6Am+9v0np06tLiPCe4ABggaKXAUOfbWcwG2AuMI1ORhWNd7 VcJmebPL+DM6G/ihsu9Nk37fMnNL0m1SVXFIItFmD/r+l94hwGiXkxhZ6zGBpZrM+V j8E+6b0/VHWRA== Date: Sun, 10 Nov 2024 21:10:35 +0000 To: Eli Zaretskii From: Randy Taylor Subject: Re: bug#74277: 29.4; rust-ts-mode doesn't highlight some function calls Message-ID: In-Reply-To: <86bjyookld.fsf@gnu.org> References: <86bjyookld.fsf@gnu.org> Feedback-ID: 44397038:user:proton X-Pm-Message-ID: 91f7767ddf5ce42310ccf57422c6937bfbfd67be MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74277 Cc: acidbong@tilde.club, 74277@debbugs.gnu.org, Yuan Fu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Saturday, November 9th, 2024 at 03:52, Eli Zaretskii wrot= e: >=20 >=20 > > Date: Fri, 08 Nov 2024 20:24:07 +0000 >=20 > > From: acidbong--- via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" bug-gnu-emacs@gnu.org > >=20 > > rust-ts-mode highlights function calls when they're used in an > > assignment or as statements, but not in string formatting: > >=20 > > `println!("Some line and {}", some_function(a, b)) # ^^^^^^^^^^^^^ this= is not getting highlighted` > >=20 > > This is how it looks in Emacs (treesit-level is 4 btw): > > https://matrix.envs.net/_matrix/media/r0/download/envs.net/66652827fc75= 45e57d2eef263ee28ef6bc2ef1c01854976160883015680 > >=20 > > This is how it looks in Neovim (with treesitter highlighting on): > > https://matrix.envs.net/_matrix/media/r0/download/envs.net/382a104ee3e6= e4dacabebfa7f84f4b9b7231b1171854976151936565248 > >=20 > > ----------------------------------- >=20 >=20 > Thanks. >=20 > Randy/Yuan, any suggestions or fixes? This was discussed briefly awhile back, but it's basically going to require special handling because macro invocations don't give us the usual dead simple way of doing it. Maybe it's easy enough to see if the identifier has parentheses immediately following it... I probably won't have a chance to take a crack at it anytime soon, so if anyone wants to beat me to it, feel free. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 15:49:36 2024 Received: (at 74277) by debbugs.gnu.org; 19 Nov 2024 20:49:36 +0000 Received: from localhost ([127.0.0.1]:44212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDVAF-0000vv-Vp for submit@debbugs.gnu.org; Tue, 19 Nov 2024 15:49:36 -0500 Received: from mail-lf1-f54.google.com ([209.85.167.54]:48428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDVAE-0000ve-7S for 74277@debbugs.gnu.org; Tue, 19 Nov 2024 15:49:34 -0500 Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-539f76a6f0dso4660961e87.1 for <74277@debbugs.gnu.org>; Tue, 19 Nov 2024 12:49:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732049308; x=1732654108; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=GL++9O724ohRFlTk6w9Az+yyYtmFKswMBhfuKBeTZUI=; b=nMmVYZIH8Tm20PoGpZEgVcMj5D3Ke+tfbI5T2e+v++O7F0C3zxs+luR8yXQOy23ab9 W6ldOgjONPotE4DI7w3U5bSYNIOFApADAMHgGFbO2MBXldm2B/NNyN6CghYcPL4snNyF qumaYLWPRuFmpqLt+TcsF+F/Pq6M+1T+r2mQkNLv0Fptl4LSYZJ0W8INWgRVH2a9Y3uA zJHDGSaxCfzwxX1m/kWz1l/fcrHOPpphc4vXa5Hic8F//EJq5fSOOzuqg/pXnqVo4LaB ieDgU+nT+pYcYDa0OTJGVa2T5Yy+crCXQS1CMQLZ7vMvQTlJMx6ojLJ73LFZ4k4vNgqp z4lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732049308; x=1732654108; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GL++9O724ohRFlTk6w9Az+yyYtmFKswMBhfuKBeTZUI=; b=BiBUEz0N7+VQF/GUpP3VZDHSz61m3v6KDPNBUv0QnrEDh+S1MoaeICjAjVL4AKXJ/v fZ3EHhAICkBhIRH0muntMbV8jwD3D4HUTBlFeGbwjGSBKPBdEbarZFkpGgyYHSBDyxNn XTag0TGxBK5DFoglnzlflIP+mpsxPasyrtub3NUR1kn84ZEBdhG3aS/8mzUxJOWmGDY7 UETexKF+ivyTanndOnCGvvkyhR+4ULoHVrQulvJv4N+eQG6L4oF9ks+txG1FEO/5+oDX rqO6j+NRr7KtwL5Bx7FWvlNBUhUvEbk+75M5aP/HSBqiYr0e6WfS7YOt8X1DDvjof+X0 N7YQ== X-Forwarded-Encrypted: i=1; AJvYcCU1DwLC/wZ8KCqjvS0u++d6/o3lgwY74PXSG8V3o55ooVmr/ZPMAiIlWD0BcdAtBIlGGSnJFg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyZtb9vqlIMXPZ9DBEj42p1VtmSsG4k58/rSPqM0heijVD59J3i o1EOKNCpkdpTxLU48qDUQs+fss+2GT+a3tj4tXHXCjur1GCW9Yci X-Google-Smtp-Source: AGHT+IFxwR5h2RIldWNR0wEKTiki6qKjiZeInI4HPD5YZW304V6NySWW+Mh/qtj7+5+rNsgZs738MQ== X-Received: by 2002:a05:6512:23aa:b0:53a:40e:d54f with SMTP id 2adb3069b0e04-53dc1323560mr37471e87.8.1732049307713; Tue, 19 Nov 2024 12:48:27 -0800 (PST) Received: from localhost (109-252-36-249.nat.spd-mgts.ru. [109.252.36.249]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53dbd46729esm402117e87.151.2024.11.19.12.48.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2024 12:48:26 -0800 (PST) From: Trevor Arjeski To: Randy Taylor Subject: Re: bug#74277: 29.4; rust-ts-mode doesn't highlight some function calls In-Reply-To: (Randy Taylor's message of "Sun, 10 Nov 2024 21:10:35 +0000") References: <86bjyookld.fsf@gnu.org> Date: Tue, 19 Nov 2024 23:48:24 +0300 Message-ID: <87r077kl0n.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74277 Cc: Yuan Fu , Eli Zaretskii , 74277@debbugs.gnu.org, acidbong@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Randy Taylor writes: Hi all, randomly started looking into this... > This was discussed briefly awhile back, but it's basically going to > require special handling because macro invocations don't give us the > usual dead simple way of doing it. Is this due to lack of support for injections.scm in Emacs' treesitter implementation? http://tree-sitter.github.io/tree-sitter/syntax-highlighting#language-injection Can't seem to find any traces of that in the current source. >From inspecting this line of code in Neovim, it appears that the injection on macro_invocation is what forces parsing the macro params as another source_file. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 07:35:22 2024 Received: (at 74277) by debbugs.gnu.org; 20 Nov 2024 12:35:22 +0000 Received: from localhost ([127.0.0.1]:45730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDjvW-0001vk-GY for submit@debbugs.gnu.org; Wed, 20 Nov 2024 07:35:22 -0500 Received: from tilde.club ([142.44.150.184]:54348 ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDjvU-0001vb-FH for 74277@debbugs.gnu.org; Wed, 20 Nov 2024 07:35:21 -0500 Received: from [IPv6:::1] (unknown [IPv6:2a03:f680:fe00:97d:2904:12d9:1941:dc79]) by tilde.club (Postfix) with ESMTPSA id E12D52204D82B; Wed, 20 Nov 2024 12:34:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 tilde.club E12D52204D82B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.club; s=mail; t=1732106089; bh=1uVnk6hgrEwJOx8HU36zwf4gWBL8VqyV+9VD1O26cXA=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=cq7d35SxG0iL55W6mKpZTSGhGeJ1eckJLbrwn5vjw3vJMYwVQscVM+uUQeEanN5Yf uVCCQDAKlFhSEdFOD8PkN64IEsaB9FY7pZn5R2/wSyou9apOQD7KP5VJlbaMAJHiID Qx7E8kw5sBRwKEpDJWW1EdJwcJ6EupmtwqJ+B1WM= Date: Wed, 20 Nov 2024 14:34:43 +0200 From: Acid Bong To: Trevor Arjeski , Randy Taylor Subject: =?US-ASCII?Q?Re=3A_bug=2374277=3A_29=2E4=3B_rust-ts-mode_d?= =?US-ASCII?Q?oesn=27t_highlight_some_function_calls?= In-Reply-To: <87r077kl0n.fsf@gmail.com> References: <86bjyookld.fsf@gnu.org> <87r077kl0n.fsf@gmail.com> Message-ID: <8639616A-771B-42B8-A111-60B7832657DF@tilde.club> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74277 Cc: Eli Zaretskii , 74277@debbugs.gnu.org, Yuan Fu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >Is this due to lack of support for injections=2Escm in Emacs' treesitter >implementation? This starts making sense for me: I guess that's why nix-ts-mode can't proc= ess its Bash injections=2E Looks like not using injections is the real issue here=2E From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 13:23:40 2024 Received: (at 74277) by debbugs.gnu.org; 20 Nov 2024 18:23:40 +0000 Received: from localhost ([127.0.0.1]:47701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDpMZ-0001Hz-TZ for submit@debbugs.gnu.org; Wed, 20 Nov 2024 13:23:40 -0500 Received: from mail-lf1-f48.google.com ([209.85.167.48]:50547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDpMY-0001Hn-6H for 74277@debbugs.gnu.org; Wed, 20 Nov 2024 13:23:38 -0500 Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-53a097aa3daso21235e87.1 for <74277@debbugs.gnu.org>; Wed, 20 Nov 2024 10:23:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732126952; x=1732731752; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=lKOpJ5lSPulzkV/76StYdK362wu5/dtmT5i3UUzFdHU=; b=OYEJqXUuUcM83++gcoXTAG5/5JMh9QeDQ+StkwgXQi4DpgK7JnEZRYs98I4B/H3HgJ lD6FQreA10WWZIA6uqn+5cnIWQQtGtUpJuMPR9G7zxIJFqt4k/eC52tUZuqDdsec3Wpt 4tGDz/RP0xiWzyBnt2uyfUp4sVeTJ38FTgur/jbVhUFG7NKPtE9nGy59ghKNENQ2c3QC le+5bRsaihadn8PbUcYgoazoxy9sYz2CXv+HZrtAWwvEP66reJFszn/iq+IsXerhbWsc m1hJjku8PZeGkyhRr4tjCchlmMIHc4mKuyIOmAQ6+fZVmAZB7u6oHMJ0U25yLBu4WP46 dJXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732126952; x=1732731752; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lKOpJ5lSPulzkV/76StYdK362wu5/dtmT5i3UUzFdHU=; b=W2S7YQlOYg+DS41CJCNESJMpcxbFgsH1MyShuMxYHvc/m3UTVhV51xJRZmCokOa3my T2uskWLPE+l6dy86CCMUBZOs7ExDFiXsUJEn183hI6FsJX3UQtD19Y3p5j0Y8RRVy1uB vu36jXNRYkPqNVZ879Qb44li2A8PCNRMjBxEtECpMJPsaHK1xZNLQltW9TTGTcts83eI t486dbnczZye3ca2qBJTpVFYXH9JpGKN50si6rWQjyHyBKYu3CZEJNhxoCViUTos0/N0 Cnafi9zQZj0VV+bzpgEJNuVTfdJyOKlllXWLz2PBixC/MwT+LNrSXI/0YwzE/tJ95uQ0 4/Ug== X-Forwarded-Encrypted: i=1; AJvYcCVEyPVIgAxkloFdS29is9yUCv/rwDvF4GGrOgDaaJmAsKtfKnP53HNj4qxYGtxOQ99j6I2Uqg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzAbPzM0ZnoFPdda+DkFEkdI2aBwWpNJDaWP77BZfksxyf4Zoku Vd5O2kNkEX5+4fSHfn6IDiCzyJf5jFY6pZdecOKVlgfM22xP5RBO X-Google-Smtp-Source: AGHT+IHpUFNovHiFFJKsuPl8ssHvcsUeNej8WD4gcLOJk37DVO5xfkk4hBAVJE1htdR2yeKjBGHPUg== X-Received: by 2002:ac2:4e07:0:b0:53b:2105:1919 with SMTP id 2adb3069b0e04-53dc13338fcmr2194107e87.14.1732126951420; Wed, 20 Nov 2024 10:22:31 -0800 (PST) Received: from trevarch (109-252-36-249.nat.spd-mgts.ru. [109.252.36.249]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53dbd47817dsm716889e87.229.2024.11.20.10.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Nov 2024 10:22:30 -0800 (PST) From: Trevor Arjeski To: Randy Taylor Subject: Re: bug#74277: 29.4; rust-ts-mode doesn't highlight some function calls In-Reply-To: <87r077kl0n.fsf@gmail.com> (Trevor Arjeski's message of "Tue, 19 Nov 2024 23:48:24 +0300") References: <86bjyookld.fsf@gnu.org> <87r077kl0n.fsf@gmail.com> Date: Wed, 20 Nov 2024 21:22:28 +0300 Message-ID: <87ed3522aj.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74277 Cc: Yuan Fu , Eli Zaretskii , 74277@debbugs.gnu.org, acidbong@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Trevor Arjeski writes: I decided to hack around with this a little bit and found that adding the following lines partially works: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=rust-ts-mode-macro-highlight.patch Content-Description: rudamentary fix diff --git a/lisp/progmodes/rust-ts-mode.el b/lisp/progmodes/rust-ts-mode.el index e52ea3b125a..508a53d9e32 100644 --- a/lisp/progmodes/rust-ts-mode.el +++ b/lisp/progmodes/rust-ts-mode.el @@ -517,6 +517,19 @@ rust-ts-mode (setq-local syntax-propertize-function #'rust-ts-mode--syntax-propertize) + ;; Injected languages + ;; TODO: add json? + (setq-local treesit-range-settings + (treesit-range-rules + :embed 'rust + :host 'rust + :local t + '((macro_invocation + (token_tree) @capture)))) + + ;; TODO: set this to a useful function + (setq-local treesit-language-at-point-function (lambda (_pos) 'rust)) + ;; Comments. (c-ts-common-comment-setup) --=-=-= Content-Type: text/plain I'm sure there is an issue with solving it this way, I just need someone else more experienced to confirm. It is finicky where it turns the highlighting on and off when you make some code changes, for example adding and removing the semi-colon after the macro invocation. Here is some example code to test it against: fn foo() -> i32 { 4 } fn main() { println!("{:?}", foo()); } Thanks --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 22:30:18 2024 Received: (at 74277) by debbugs.gnu.org; 22 Nov 2024 03:30:18 +0000 Received: from localhost ([127.0.0.1]:52513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEKN7-00088p-Q2 for submit@debbugs.gnu.org; Thu, 21 Nov 2024 22:30:18 -0500 Received: from mail-4018.proton.ch ([185.70.40.18]:22627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEKN5-000877-ET for 74277@debbugs.gnu.org; Thu, 21 Nov 2024 22:30:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1732246209; x=1732505409; bh=YaIhUq40vJD35TUtDyuEtqm+z01+FnA9yFs7kTZ//Nk=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=iU9bA8i6FsvPLuFYqKbBdPwzpl1Z7DvKWolLL+AQSMON9mdkdI923AGr+ZnsW3G8O lzLAlMGnMA6bGYvqWlpuGqlpCKLQ9b7MixfEbY56vD0NAfF9zTKKTllwqpDQgk0YvB gh7yC2lwlCz4HiGO7DV0v+f4jWwYK1VvYsor6xb7KUh4ZjvqXBysjabZSaQj+1splh de+Njzdd6g0RXf7AngFFtt1cNNk/nQiRmr/563aDUGIKr/JFTWS4PWWpTyriJ/y4OS DT/ON6onEM+uM0g5gpJGu5kLnRujF9YgKap6yuiQtXcCkJ/Qp6OAhqhHarirDTHKaG ZuTJ/wQCvaIqw== Date: Fri, 22 Nov 2024 03:30:05 +0000 To: Trevor Arjeski From: Randy Taylor Subject: Re: bug#74277: 29.4; rust-ts-mode doesn't highlight some function calls Message-ID: In-Reply-To: <87ed3522aj.fsf@gmail.com> References: <86bjyookld.fsf@gnu.org> <87r077kl0n.fsf@gmail.com> <87ed3522aj.fsf@gmail.com> Feedback-ID: 44397038:user:proton X-Pm-Message-ID: 50f1ad47c8e19f0bea1de9446a92842dcbae7d4b MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74277 Cc: Yuan Fu , Eli Zaretskii , 74277@debbugs.gnu.org, acidbong@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wednesday, November 20th, 2024 at 13:22, Trevor Arjeski wrote: >=20 > Trevor Arjeski tmarjeski@gmail.com writes: >=20 >=20 > I decided to hack around with this a little bit and found that adding > the following lines partially works: >=20 >=20 > I'm sure there is an issue with solving it this way, I just need someone > else more experienced to confirm. It is finicky where it turns the > highlighting on and off when you make some code changes, for example > adding and removing the semi-colon after the macro invocation. Yuan would be the best to answer that. Personally, I envisioned a custom highlight helper function like rust-ts-mode--fontify-pattern or rust-ts-mode--fontify-scope which seems like the simplest solution that should cover this use case, but I'm not actually aware of all the sorts of craziness one could get up to in a macro invocation so that might not be enough and maybe injections are the way to go. >=20 > Here is some example code to test it against: >=20 > fn foo() -> i32 { >=20 > 4 > } >=20 > fn main() { > println!("{:?}", foo()); > } >=20 >=20 > Thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 24 00:20:14 2024 Received: (at 74277) by debbugs.gnu.org; 24 Nov 2024 05:20:14 +0000 Received: from localhost ([127.0.0.1]:60338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tF52b-0004y8-QF for submit@debbugs.gnu.org; Sun, 24 Nov 2024 00:20:14 -0500 Received: from mail-pl1-f170.google.com ([209.85.214.170]:43045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tF52Z-0004xv-KL for 74277@debbugs.gnu.org; Sun, 24 Nov 2024 00:20:12 -0500 Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-21260209c68so33269995ad.0 for <74277@debbugs.gnu.org>; Sat, 23 Nov 2024 21:20:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732425550; x=1733030350; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=edu6LV6Y5NsfPfH6reGGyvQtLmmUyLhqOAw+kdbMtCY=; b=cPR8b4STacT2K3lGDROYm+zQ1RESLUeSVLYx1xToeZ8pW8wXwXcClRtUpi4bdufIWI dcwjYTscPcpN4lZV2JP95m/mhLPKuJE+2Hvhet4TVftwmyajvLNek7doRxAswVbpiIhM EpxM8V2dFL8UV1JnFK8P3NfpprEM3QL64fd43QkXGp6Vfd8LCiVoRXnwyo0WSSjkirmI kaxN5VPuvTyyjdHycBHTQguHaxGYSi+kxpvuJ7dtueNiHJlkk3WtLYHfYpAISZE9L4o4 JRlVFtcRQqinIBp98k5AzdiDfWzpNOVkGIG9FEbh9uFJGCAFa2htkjOh+m54ZzUchid5 EAYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732425550; x=1733030350; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=edu6LV6Y5NsfPfH6reGGyvQtLmmUyLhqOAw+kdbMtCY=; b=JzBe8sh6SFdJbaEZqt4vpAeg2v6N7O2+wXqr4RNChZNLrSEYL9pJ75JNjanJUcZysj 9FQsqFehqw0+wYoojuAGBulQrqTFVkJ1xQdrDIS45cgeLXEqT5nhhdCH+XycxoYNdKwm bwmzfKPVxD3c9XdZA9OUbYVrEExd2TmRridc1ywgezi0hU9xG/hTw/lCvdxXmgCUBpp2 jjf/3cyik9r8iW5DadZ5h8tzXoEm+GtPtlLxBrHa9DE2QQNDkW0H2rmuFNmFhb1k21yY 70yeL7BC3NpI2LabC3JX152F/fPOgRhrt7e8qrlxS2B2z2Qsp1mMGQiVLHH8tWqCOXxo gYMQ== X-Forwarded-Encrypted: i=1; AJvYcCW9irRU4drc/avZwnmy8ODgh/KKtCv0ywRQEuHWrT2GzIN+NE7qxgEgeCf50KhFO97XRiOKoA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyosGm3Tw9733ujtmd5vQ8R4qidQiY7eb5l/hxROZW56/sY8EbM 7PmfQ+x8KnCbhQM8xOwoTVXEEgKDGhDuuT8mnoLYHFzPZJRF7w3H X-Gm-Gg: ASbGncv8ZnQRgGm4udpLlIqrQ5ApGqUbmw7+0IKxa9zGMHgnv5rL6LxZqlS09HJREFJ Ly1K7vHnYqtvjtiGQEGNWEuTudFEsyWkhkeeveCvc2vU7STIUXpORPpUjrTm6myac7csjvGfgOJ s8Fou5e3PYCPeeDPL9N9tVYHXl56/xmZfuRjX2kdtbMN/8Ei4j6H3LSAbS++Lgahq2/9Zaq3Qz8 zE+Y12HRqQyTllT/vNduujS8xs2RwddWUe1LWwgLDBfJ3wEhH+xneirKBYKa25+fJeXiq2D2g== X-Google-Smtp-Source: AGHT+IHCCpVo2JWXWVcSw7oDZe958JFsyUXMWHDEW2xrLkdiox0i5Qhqor1/y7DGOLfhhOeeKHMoFA== X-Received: by 2002:a17:902:e849:b0:20b:a9b2:b558 with SMTP id d9443c01a7336-21283d20371mr189644585ad.28.1732425550414; Sat, 23 Nov 2024 21:19:10 -0800 (PST) Received: from smtpclient.apple ([2601:646:8f81:6120:9db4:d34c:247c:f36b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2129dbff380sm40998755ad.114.2024.11.23.21.19.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Nov 2024 21:19:09 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: bug#74277: 29.4; rust-ts-mode doesn't highlight some function calls From: Yuan Fu In-Reply-To: Date: Sat, 23 Nov 2024 21:18:58 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <86bjyookld.fsf@gnu.org> <87r077kl0n.fsf@gmail.com> <87ed3522aj.fsf@gmail.com> To: Randy Taylor X-Mailer: Apple Mail (2.3776.700.51) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74277 Cc: acidbong@tilde.club, Trevor Arjeski , 74277@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Nov 21, 2024, at 7:30=E2=80=AFPM, Randy Taylor wrote: >=20 > On Wednesday, November 20th, 2024 at 13:22, Trevor Arjeski = wrote: >>=20 >> Trevor Arjeski tmarjeski@gmail.com writes: >>=20 >>=20 >> I decided to hack around with this a little bit and found that adding >> the following lines partially works: >>=20 >>=20 >> I'm sure there is an issue with solving it this way, I just need = someone >> else more experienced to confirm. It is finicky where it turns the >> highlighting on and off when you make some code changes, for example >> adding and removing the semi-colon after the macro invocation. >=20 > Yuan would be the best to answer that. Using injection (what Emacs calls local parser, same thing) here is = fine, I think. As Randy said, tree-sitter doesn=E2=80=99t have a good = answer for macros. If nvim uses this workaround (create an injection for = the macro and parses it like normal rust code), then it should be fine = for us to follow suit. >=20 > Personally, I envisioned a custom highlight helper function like > rust-ts-mode--fontify-pattern or rust-ts-mode--fontify-scope which > seems like the simplest solution that should cover this use case, but > I'm not actually aware of all the sorts of craziness one could get up > to in a macro invocation so that might not be enough and maybe = injections > are the way to go. Rust macros are not as crazy as C/C++, but definitely goes beyond normal = rust code, for example, the select! macro: #[tokio::main] async fn main() { tokio::select! { _ =3D do_stuff_async() =3D> { println!("do_stuff_async() completed first") } _ =3D more_async_work() =3D> { println!("more_async_work() completed first") } }; } Does what you envisioned work for something like this? To be fair, I = don=E2=80=99t think the injection solution works well for this either. Yuan From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 24 02:18:46 2024 Received: (at 74277) by debbugs.gnu.org; 24 Nov 2024 07:18:46 +0000 Received: from localhost ([127.0.0.1]:60520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tF6tK-0002ds-Hx for submit@debbugs.gnu.org; Sun, 24 Nov 2024 02:18:46 -0500 Received: from mail-lf1-f53.google.com ([209.85.167.53]:50641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tF6tJ-0002dk-By for 74277@debbugs.gnu.org; Sun, 24 Nov 2024 02:18:45 -0500 Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-53dd9e853ccso1471214e87.1 for <74277@debbugs.gnu.org>; Sat, 23 Nov 2024 23:18:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732432664; x=1733037464; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fUB1Oc7/LrxiDAsjw14WNyZ2CPssmg1NsRuS3ikIkSU=; b=LWO/yuV17JWrcVDv2xrPeHBEUchO2QxKaf1OHFCCu02PWdhyy7xrHU7SF9IRPPEX7E wF0oTtB8vb0OycE5k07/AFy8hk1BfBcYPAQYJH2QgyYqS3cKOck8ObzzGq9HY533rJcC 3yu71sL1187axN6IuG2WTHjstwEHfp4dunkjTyHHG27e6bqPGw0k9M666OtDs8u/IpOC SJrk7DTcW9FaEM0Kb943mfd78AMKEM+uTfLfyBUV1NaWhJcaylO9ks3/TaQOP16HgStG /bfNdu6U2CGAmejQUerLSQRA1gXo3Dhp3j9y+el3zLKPC3ufcxHenywUVtyIH6CXoAgU psRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732432664; x=1733037464; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fUB1Oc7/LrxiDAsjw14WNyZ2CPssmg1NsRuS3ikIkSU=; b=xJmw3SEWs43+KWa3Pj+BGmUy9TLegp6Da1xEmHL8KRVZKeQ5L9fJt2NcV0D67dY8Ia edClnDUAtky69HWVH3syuujNLvJGSnPGwYcckkHxD8YEm6jBIvyNUSQiSup04nJ+StgI S3NCy047Res8I9gKBrqJepY9ZrV+oYG+Z/4SM7dMH8Lj/fwdQxIUs1Id5NQN9rf2NVFA nKnfiHJ/+VoOolxzLqLRNp6udQ4iGlT/W1yDkRGfTbOurCPnSxun2dfScDHlLNqCflbI Y+X9iXbo79m4BqCCubTqj/kC/Rg6M4O0p1BGoYOPXr1blzXF3v3BY68C5mUVET8s0u1f JmXQ== X-Forwarded-Encrypted: i=1; AJvYcCUGTWeJ4FMnKLWchK3bJTumwFXoPRBghugXr76b4464nFaGHYZD7AjnPpOJaRSLZYuOwljAzA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwHdAhJlliaZKP9L5s6A2RXHUhrPPxF6UvEjKN6g6+bKpQmFf3c 4cMUlSOLJ6ecCTx56bI0r5aPOwcgCCffUeAvOTF+zm/aUEWqIRUK7EGPBTKH X-Gm-Gg: ASbGncvwh6NAaPWXNy2EkSyV3GILn0l79jUT9fqRNNiA7GXhFXywU3pXXu3qoal037a JI8RTHuUCsmF3xbG/VnUz1YhpizNZ0cXC5zhxzKAnpnTwrKC9L2ZgAaA34QZPP25DXuBW93U+J4 EEbgqb0Qqm/3b2PQPkv7NZFnogUPQ2T96UAT/1099hMTq0bs2/pkkvttwccRQebmRIQZFrsaB/Y 3v8SoQdSxcqEr5TX8f4Glk0ZZ4MYX0P2P4GjM73FF98tgWEnr0MVPVd1xVsKM0EQL8M1gc/YuRi 3g== X-Google-Smtp-Source: AGHT+IH3n/oS2ZwAsp2AIwG4hD/wbZJCbQ3lrXdWfI5/1KFRboUG9D9fXeWpZWbVwLwyRmNZLKtM1w== X-Received: by 2002:a05:6512:282b:b0:53d:a23d:37e6 with SMTP id 2adb3069b0e04-53dd3aadfecmr4227271e87.57.1732432663665; Sat, 23 Nov 2024 23:17:43 -0800 (PST) Received: from trevarch (109-252-36-249.nat.spd-mgts.ru. [109.252.36.249]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53dd2497f04sm1205001e87.254.2024.11.23.23.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Nov 2024 23:17:42 -0800 (PST) From: Trevor Arjeski To: Yuan Fu Subject: Re: bug#74277: 29.4; rust-ts-mode doesn't highlight some function calls In-Reply-To: (Yuan Fu's message of "Sat, 23 Nov 2024 21:18:58 -0800") References: <86bjyookld.fsf@gnu.org> <87r077kl0n.fsf@gmail.com> <87ed3522aj.fsf@gmail.com> Date: Sun, 24 Nov 2024 10:17:40 +0300 Message-ID: <87bjy5yuaz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74277 Cc: Randy Taylor , Eli Zaretskii , 74277@debbugs.gnu.org, acidbong@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Yuan Fu writes: >> On Nov 21, 2024, at 7:30=E2=80=AFPM, Randy Taylor wrote: >>=20 >> On Wednesday, November 20th, 2024 at 13:22, Trevor Arjeski wrote: >>>=20 >>> Trevor Arjeski tmarjeski@gmail.com writes: >>>=20 >>>=20 >>> I decided to hack around with this a little bit and found that adding >>> the following lines partially works: >>>=20 >>>=20 >>> I'm sure there is an issue with solving it this way, I just need someone >>> else more experienced to confirm. It is finicky where it turns the >>> highlighting on and off when you make some code changes, for example >>> adding and removing the semi-colon after the macro invocation. >>=20 >> Yuan would be the best to answer that. > > Using injection (what Emacs calls local parser, same thing) here is fine,= I > think. As Randy said, tree-sitter doesn=E2=80=99t have a good answer for = macros. If nvim > uses this workaround (create an injection for the macro and parses it like > normal rust code), then it should be fine for us to follow suit. > Any ideas why my crude implementation of the injection "flickers" on and off after certain changes? Thanks, Trevor From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 25 02:35:29 2024 Received: (at 74277) by debbugs.gnu.org; 25 Nov 2024 07:35:29 +0000 Received: from localhost ([127.0.0.1]:37684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFTd3-0008WQ-9F for submit@debbugs.gnu.org; Mon, 25 Nov 2024 02:35:29 -0500 Received: from mail-pf1-f180.google.com ([209.85.210.180]:50227) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFTd1-0008WG-7a for 74277@debbugs.gnu.org; Mon, 25 Nov 2024 02:35:28 -0500 Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-724d8422dbaso3016506b3a.0 for <74277@debbugs.gnu.org>; Sun, 24 Nov 2024 23:35:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732520066; x=1733124866; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lhHYU+OOUtVuHW20Qc+5odGDe/Dm+nNI1P2WeFc6+hI=; b=kFZFAWyOjg3r52Ouf6hCo3JbJXrdWd9+FVhIC6/wNepL85Q1BUadkfgV9VPh/JKdBe XCJsE2sC6NNbbvrLpJq0mzSw7Zxg++Q10E0J/PFeNdVZSHpD0TzmMTbryISM73Nmd5LQ m9eOZVV/Vfrna1ar6LXI5Q+mKEp4CZaZs+OamcEvacU/8OM+upNhnCOhhf15yinKl9lt cUcorM3rpuQImoOiyA39aqyMjfXKnLVofyaqCq/wpfMBHHMpt0roWGL35HT7pstfTxdy A8S6bgT5250HX70Pyt26TYTmIC4nd0xR8FfO+TjRM5ZdBnvkz6MFfPBtzzfwVE5EXYfU D8iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732520066; x=1733124866; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lhHYU+OOUtVuHW20Qc+5odGDe/Dm+nNI1P2WeFc6+hI=; b=s2XHo9fxkyizeLi5RZNegqqWSC9V9fGraGi8Xc0BXcpBK9IvtrZCpbX5ScI5kagLz2 lIJixBkNUuIJx+Njcz+hj2U5nh0vP0YFCTxPD7ikJRJrVsILNqyPsMdrYN3br880wYob 13/mMEzqXtbS9M3dS0XY5FL9wRRqgP3/D7yYGvQ5pPVk8Im4Mgqd13cs3QnEXTMbTmtC Y03gcl0MRscAQFjhYIu/s42+/En7/7Boiszwj/rPEYengoIjtqPa35pc3+F927HCmhIq N6+tUwl3deYNQB6ZexgJGhAXcZRbC9B3If8Vdyg4rtFLMIMUPn3EGYLgF9qvNBPLn63q cLKQ== X-Forwarded-Encrypted: i=1; AJvYcCWYxW0Z8i6sxYqyv5DvR4wexHUH19sTcgKBxvIg5eWMwrpSSL3B4xla3oL+Mrzn/dtk9iYUWw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxyrUgNQre9aI4kRyaIpQHfSGSR8l1Km+fPVyjcpUF4ZUXmXg4z H7hasdc+AO4rCxozX051+Xdw6gO2S0inf8nUbdKSr5QdDa5fCyl1 X-Gm-Gg: ASbGncvijyh0ojlq+lBx+mOs3HTP2j1yIOkyqu4gQrDF1j6UxSLaDBDCbzpkJRoGhbx rW0MY/hzeHQOLMcs18Dhncf2vwriqdsgNVVe5QpIpkDfNfeqIpsy8zM+B7QmkntO1NZUW8sa9Xt C87EAGJduzgWFcgRPcyouix2O1iEu+A38RN/C9eERoSjQcETl4m0fpx/k7nXYL/eSaC1ai9Akxf tV0nl5gZA7lXlvs0+Swh8Hj+3i8jedi8J0jCGm7UFVDuMtX12SjmL63bA5Xgz0z58+dNx563w== X-Google-Smtp-Source: AGHT+IE+yjWEngMXoj8dN/fzjdIOkERwi2xO5skPAP2RLbqYvR9jEu4IyJ2wuhOejqlMWy3rHRKG6g== X-Received: by 2002:a05:6a20:4320:b0:1db:e0e5:9109 with SMTP id adf61e73a8af0-1e09e3ba352mr18021938637.4.1732520066126; Sun, 24 Nov 2024 23:34:26 -0800 (PST) Received: from smtpclient.apple ([2601:646:8f81:6120:9db4:d34c:247c:f36b]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2eb0d06299dsm6036420a91.53.2024.11.24.23.34.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Nov 2024 23:34:25 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: bug#74277: 29.4; rust-ts-mode doesn't highlight some function calls From: Yuan Fu In-Reply-To: <87bjy5yuaz.fsf@gmail.com> Date: Sun, 24 Nov 2024 23:34:14 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <89EB0889-DD32-40C2-92E3-8A89ABB6EE37@gmail.com> References: <86bjyookld.fsf@gnu.org> <87r077kl0n.fsf@gmail.com> <87ed3522aj.fsf@gmail.com> <87bjy5yuaz.fsf@gmail.com> To: Trevor Arjeski X-Mailer: Apple Mail (2.3776.700.51) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74277 Cc: Randy Taylor , Eli Zaretskii , 74277@debbugs.gnu.org, acidbong@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Nov 23, 2024, at 11:17=E2=80=AFPM, Trevor Arjeski = wrote: >=20 > Yuan Fu writes: >=20 >>> On Nov 21, 2024, at 7:30=E2=80=AFPM, Randy Taylor = wrote: >>>=20 >>> On Wednesday, November 20th, 2024 at 13:22, Trevor Arjeski = wrote: >>>>=20 >>>> Trevor Arjeski tmarjeski@gmail.com writes: >>>>=20 >>>>=20 >>>> I decided to hack around with this a little bit and found that = adding >>>> the following lines partially works: >>>>=20 >>>>=20 >>>> I'm sure there is an issue with solving it this way, I just need = someone >>>> else more experienced to confirm. It is finicky where it turns the >>>> highlighting on and off when you make some code changes, for = example >>>> adding and removing the semi-colon after the macro invocation. >>>=20 >>> Yuan would be the best to answer that. >>=20 >> Using injection (what Emacs calls local parser, same thing) here is = fine, I >> think. As Randy said, tree-sitter doesn=E2=80=99t have a good answer = for macros. If nvim >> uses this workaround (create an injection for the macro and parses it = like >> normal rust code), then it should be fine for us to follow suit. >>=20 >=20 > Any ideas why my crude implementation of the injection "flickers" on = and > off after certain changes? >=20 > Thanks, > Trevor So, after spending a night on this, it appears to be a tree-sitter bug = :( I created an issue here: = https://github.com/tree-sitter/tree-sitter/issues/3962 Yuan From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 14 14:25:30 2024 Received: (at 74277) by debbugs.gnu.org; 14 Dec 2024 19:25:30 +0000 Received: from localhost ([127.0.0.1]:48408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMXla-0002j3-4g for submit@debbugs.gnu.org; Sat, 14 Dec 2024 14:25:30 -0500 Received: from mail-10626.protonmail.ch ([79.135.106.26]:55573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMXlW-0002ij-5y for 74277@debbugs.gnu.org; Sat, 14 Dec 2024 14:25:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1734204319; x=1734463519; bh=J5hqRnioIdnGCZ+GPPxCoKOdxj35+hoVkfdF/7Hfcsw=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=GYmOGs18HRZDg8Xta1t1X97FDrAKG7Oyqv9rxxKJun8M7XcUE4Sx5rgndZxvdSP9y KbYq9r1clStiiKyeE8FdK1wVQ1CduZZjrBKV8sirZWWI8Qx9Yj5Zvw4HQ1t1GBWN+m RYGNiswbFaqYBPOnuIpO+NR1usiUDotmzW5BeVLVI3ONXYnts7wKaS/A41tydo0Sc0 TXvnb6PLRXEhwjOWRkYDIIw7u0z6AsSSAXo3Ye0nsJrpJTJOViomHUdu74yJeAf5fi 5I0N+Y7ePo3iqvZuHQnkLUSO7SDCOsWq48AIgh2OWNx7suW/wY1swAJmU2+grKfmim 0/92wKnEW2nZg== Date: Sat, 14 Dec 2024 19:25:13 +0000 To: Yuan Fu From: Randy Taylor Subject: Re: bug#74277: 29.4; rust-ts-mode doesn't highlight some function calls Message-ID: In-Reply-To: References: <86bjyookld.fsf@gnu.org> <87r077kl0n.fsf@gmail.com> <87ed3522aj.fsf@gmail.com> Feedback-ID: 44397038:user:proton X-Pm-Message-ID: ebcd15a6beb10c6c22040d03d7824f79b6f95678 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74277 Cc: acidbong@tilde.club, Trevor Arjeski , 74277@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sunday, November 24th, 2024 at 00:18, Yuan Fu wrote: >=20 >=20 > > On Nov 21, 2024, at 7:30=E2=80=AFPM, Randy Taylor dev@rjt.dev wrote: > >=20 > > On Wednesday, November 20th, 2024 at 13:22, Trevor Arjeski tmarjeski@gm= ail.com wrote: > >=20 > > > Trevor Arjeski tmarjeski@gmail.com writes: > > >=20 > > > I decided to hack around with this a little bit and found that adding > > > the following lines partially works: > > >=20 > > > I'm sure there is an issue with solving it this way, I just need some= one > > > else more experienced to confirm. It is finicky where it turns the > > > highlighting on and off when you make some code changes, for example > > > adding and removing the semi-colon after the macro invocation. > >=20 > > Yuan would be the best to answer that. >=20 >=20 > Using injection (what Emacs calls local parser, same thing) here is fine,= I think. As Randy said, tree-sitter doesn=E2=80=99t have a good answer for= macros. If nvim uses this workaround (create an injection for the macro an= d parses it like normal rust code), then it should be fine for us to follow= suit. >=20 > > Personally, I envisioned a custom highlight helper function like > > rust-ts-mode--fontify-pattern or rust-ts-mode--fontify-scope which > > seems like the simplest solution that should cover this use case, but > > I'm not actually aware of all the sorts of craziness one could get up > > to in a macro invocation so that might not be enough and maybe injectio= ns > > are the way to go. >=20 >=20 > Rust macros are not as crazy as C/C++, but definitely goes beyond normal = rust code, for example, the select! macro: >=20 > #[tokio::main] > async fn main() { > tokio::select! { > _ =3D do_stuff_async() =3D> { >=20 > println!("do_stuff_async() completed first") > } > _ =3D more_async_work() =3D> { >=20 > println!("more_async_work() completed first") > } > }; > } >=20 > Does what you envisioned work for something like this? To be fair, I don= =E2=80=99t think the injection solution works well for this either. >=20 > Yuan Sorry for the super late reply! The custom highlighter function(s) would definitely not be the best way for= macros like that. Back when this was discussed ages ago, I remember that i= njection had some problems or questions surrounding it (don't remember the = details), so depending on whether those can be ironed out (whatever those i= ssues were if they even still apply), we may only be able to tackle simpler= highlights with those custom highlighter functions until injection becomes= more feasible. But injection seems to be the way to go to cover all types of macros approp= riately. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 22:17:40 2025 Received: (at 74277) by debbugs.gnu.org; 2 Jan 2025 03:17:40 +0000 Received: from localhost ([127.0.0.1]:41645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTBiN-00064J-AA for submit@debbugs.gnu.org; Wed, 01 Jan 2025 22:17:39 -0500 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:56564) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tTBiJ-000649-Cr for 74277@debbugs.gnu.org; Wed, 01 Jan 2025 22:17:36 -0500 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-2163b0c09afso145255015ad.0 for <74277@debbugs.gnu.org>; Wed, 01 Jan 2025 19:17:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735787854; x=1736392654; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LHRTQXghrhv48rapjABL/2+zNcHopiSVE74O2pnO7W8=; b=P2huWyERGbpNK1Btl1vuGh+tbFopYNC1SJUmOC5SbQVgGErrphNnj6G/eZy4ch8+I6 B4QqJz1nOG02qQljAu/UA/q1w519mjiKOv4fb8JEiMmZYSbuybZDPkLPNqbOxx8UbuNS SQtboxhsKpmUHOEMaPX4F9k6RJX4/m2pbuXLyjy21xOWsAC4HSYw29rIThp9B21r7Fjc WJ9ujPCWRUvDwd050+g3ceaHufpc8fWq3XPjrKboyhG8f6GfGWrepaTcDaqEbiNOzzK2 CHRuxkBN2tpGC0D/xPyiOx790nsob7XKs2lJpU/7qod+2TvP4KWmJKyzKcxuSMLP02aH JZZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735787854; x=1736392654; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LHRTQXghrhv48rapjABL/2+zNcHopiSVE74O2pnO7W8=; b=XPuctVn1g61DF621mVW0Mk6DtLkgE4HNqtd9yA1IJDaJIaq4Y4jKK9xjJkhp7r1Ybb ZxmKtTTbjnkg4wsP9auENGjbUv4OCSN4FjxuvP2FMq2zrGTgJS8ddI4UHNXjtogLmrhc E8muFRIxCfxKMaBYLOT6e4BNT7tkWpG/F82GRhhfhxxHEK2G+m8vSA7ytUWxqv6drTa2 R9Nt8VZQWPWL7Z5ZLEv0vuogVEchtTycK0ComnndrcDTwWhPII8QNUl6OVeUBPuMGcHM X/oXMjrstyW2Ak7zsYTbJ3XUFerQTHwWYiIJLZ1Wg8UZ9WV87neAdPCRmsV4a2oPdNp2 +zPQ== X-Forwarded-Encrypted: i=1; AJvYcCVMCqJhAtOEmS9xaM2YzhFXEdsqxkf32E906Xtci7j56cE3F2U7cxzk9tYKX/BlmI1/Lfzk4g==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwsoaZofcW8nwr5O9YxrRtHWkuJubn+tq5szyL8bM6n8jwaLGx1 xfvLTXKN1GqkXctm6htskp76MfoYSiY6O3os2MD9sV62gtxoxIh0 X-Gm-Gg: ASbGncu/y9dNyvL+hIzFHtntt4AAD6xm48NjX2P3125xWM79REo4yrwmJ4kpD4jnh4h jwsZ42S80ua/3hshBER3+1Q+/vql3HsjxLnoJkGF8aKAXprK1JgKSFV9yvvfuYP7H3zu816DYkU N1NYan2ZWIZejqGuWE+eIKZRNjold0wlUZqXBBQaVI1djE4nM3H0k1PVFWEqTvnRG/csKwVhGQd ozI9PKPajvDJDIfcIr26IQW0roruRbCI3CHjHX17Hx+ljvRNDXJ3KfuVEkUVkCUVt9AW1eLM+BY Gwzf X-Google-Smtp-Source: AGHT+IGPFnUYWnLvVKSCdb/YQLR/I4kZxdsVfABIIewYZLNJsAcmA399kbjfx9u6zb3WudVgUQq3nw== X-Received: by 2002:a05:6a20:e68b:b0:1e1:72ce:fefc with SMTP id adf61e73a8af0-1e5e05a9edemr79269168637.22.1735787854074; Wed, 01 Jan 2025 19:17:34 -0800 (PST) Received: from smtpclient.apple ([2601:646:8f81:6120:85eb:71bd:58ac:56a8]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8157d7sm23979942b3a.21.2025.01.01.19.17.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Jan 2025 19:17:33 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: bug#74277: 29.4; rust-ts-mode doesn't highlight some function calls From: Yuan Fu In-Reply-To: <89EB0889-DD32-40C2-92E3-8A89ABB6EE37@gmail.com> Date: Wed, 1 Jan 2025 19:17:22 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <86bjyookld.fsf@gnu.org> <87r077kl0n.fsf@gmail.com> <87ed3522aj.fsf@gmail.com> <87bjy5yuaz.fsf@gmail.com> <89EB0889-DD32-40C2-92E3-8A89ABB6EE37@gmail.com> To: Trevor Arjeski X-Mailer: Apple Mail (2.3776.700.51) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74277 Cc: Randy Taylor , Eli Zaretskii , 74277@debbugs.gnu.org, acidbong@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Nov 24, 2024, at 11:34=E2=80=AFPM, Yuan Fu = wrote: >=20 >=20 >=20 >> On Nov 23, 2024, at 11:17=E2=80=AFPM, Trevor Arjeski = wrote: >>=20 >> Yuan Fu writes: >>=20 >>>> On Nov 21, 2024, at 7:30=E2=80=AFPM, Randy Taylor = wrote: >>>>=20 >>>> On Wednesday, November 20th, 2024 at 13:22, Trevor Arjeski = wrote: >>>>>=20 >>>>> Trevor Arjeski tmarjeski@gmail.com writes: >>>>>=20 >>>>>=20 >>>>> I decided to hack around with this a little bit and found that = adding >>>>> the following lines partially works: >>>>>=20 >>>>>=20 >>>>> I'm sure there is an issue with solving it this way, I just need = someone >>>>> else more experienced to confirm. It is finicky where it turns the >>>>> highlighting on and off when you make some code changes, for = example >>>>> adding and removing the semi-colon after the macro invocation. >>>>=20 >>>> Yuan would be the best to answer that. >>>=20 >>> Using injection (what Emacs calls local parser, same thing) here is = fine, I >>> think. As Randy said, tree-sitter doesn=E2=80=99t have a good answer = for macros. If nvim >>> uses this workaround (create an injection for the macro and parses = it like >>> normal rust code), then it should be fine for us to follow suit. >>>=20 >>=20 >> Any ideas why my crude implementation of the injection "flickers" on = and >> off after certain changes? >>=20 >> Thanks, >> Trevor >=20 > So, after spending a night on this, it appears to be a tree-sitter bug = :( I created an issue here: = https://github.com/tree-sitter/tree-sitter/issues/3962 According to tree-sitter devs, the tree-sitter bug should be fixed now. Yuan= From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 02 01:12:10 2025 Received: (at 74277) by debbugs.gnu.org; 2 Jan 2025 06:12:11 +0000 Received: from localhost ([127.0.0.1]:42400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTERD-0006D0-K7 for submit@debbugs.gnu.org; Thu, 02 Jan 2025 01:12:10 -0500 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:51635) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tTERA-0006CS-R0 for 74277@debbugs.gnu.org; Thu, 02 Jan 2025 01:12:06 -0500 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5d84179ef26so15877166a12.3 for <74277@debbugs.gnu.org>; Wed, 01 Jan 2025 22:12:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735798318; x=1736403118; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=zEp0czTcftv9WyKeNHfDsOBw8i6430UuVHQZ4kOI8YQ=; b=kb8PflEIrkoTz3mZEZRmNhe8d411DKFPE1c0dYPkIX5gUHTst6LzozcD3rEjvkmDY7 SFvyhTau/DLNP/sA4TGv3Yj5h9spinZVeCQILOIZQ5jYtwTIoXT1QCmru0t5dy9N8Tsf T/F3t6YaT9OAuIPlT2UsMDYh0wV+fZaBXlTNTB4SR6caJqU/890euh/+Wt72jVl2r8XF TztosnTYTY1glkUav00WCVDdvIBpQYOFm8TvPFoeuzUtyBe8+exVxaSlhmwy1Q1HZ0V+ PeHU2KQof4FcS9SjQpEyZyzIHZoBlPw0CMABxM2/Zxd0rqJVdgx4jz+SVyK4Mbiq60Gh 7ZpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735798318; x=1736403118; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zEp0czTcftv9WyKeNHfDsOBw8i6430UuVHQZ4kOI8YQ=; b=s4kTzboz6l63CAMIVYcaiemk0rsZNcpZEJ6k1feS3VIoRLWz0LYLhcvltrgqRUw7s9 kKxzfJ+eU7riENouNkeVRetvf8ZMjoCSLf3lIsPJH8m1/Mq8ykJNiWJcL2lvMyQnmjwg 8TfWp1fG+ZXO0W39QFa6QvD7UUpoVTtE/FsugttYyrYVan0msiFXYmQZtWxHylkOzPDZ PDVNBscjevI+i9Adv8fgiudXRiJdbsLWvEJUVpbT//PtvGVijvrgPiEZXdiYLCoKsh3U yF5wRBdv51E02ce+mvYS837n3BCmiPcmzjK39gEZ7y7XmjEdSsqtM719cBLbP1BPWeSN EcGw== X-Forwarded-Encrypted: i=1; AJvYcCX/bMKtWP1Gdzos0n+5elFd8cgzQK3DcYOWCJcCyd5LTxOAjmQ3XZzheBlii2VH3PvhYTQL0Q==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyxkOCb/v1xdPzKrAx2FOemMJ4SfnZ3knlng+3R5k6JuWBYKv1G dyu2HttfiBzWRoF5dBYNex26wsJLvWzVHRQma8STAEdsU5QnkEhhiJ734nfinEP4xWJIHkjUP1l M0YkNlJ8pGx0cuACoF6OUr+1kW/A= X-Gm-Gg: ASbGncvJFuzAYQK6hB1mz6IUzUYHSQhNpiG2hGOQsy1X/dJwueD4x1IKnDRMNVPgtb5 fBwENGIa9mX+IENaMAKCRDsgofvDDUQN4bG+yF84i X-Google-Smtp-Source: AGHT+IFE89Wfe2DztjRgYsqO36BAAClSWEPPs7Ab4ORL6tDVfriJxkvBwF3+tManmQsorkkGOs2dlmvEBaWqHu+HAGk= X-Received: by 2002:a05:6402:1e8e:b0:5d0:8359:7a49 with SMTP id 4fb4d7f45d1cf-5d81dc74098mr35393004a12.0.1735798318293; Wed, 01 Jan 2025 22:11:58 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 2 Jan 2025 00:11:58 -0600 From: Stefan Kangas In-Reply-To: References: <86bjyookld.fsf@gnu.org> <87r077kl0n.fsf@gmail.com> <87ed3522aj.fsf@gmail.com> <87bjy5yuaz.fsf@gmail.com> <89EB0889-DD32-40C2-92E3-8A89ABB6EE37@gmail.com> MIME-Version: 1.0 Date: Thu, 2 Jan 2025 00:11:58 -0600 Message-ID: Subject: Re: bug#74277: 29.4; rust-ts-mode doesn't highlight some function calls To: Yuan Fu , Trevor Arjeski Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74277 Cc: Randy Taylor , Eli Zaretskii , 74277@debbugs.gnu.org, acidbong@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Yuan Fu writes: > According to tree-sitter devs, the tree-sitter bug should be fixed now. Thanks. Maybe we should verify the fix on our end? Meanwhile, should we tag this as "notabug" (since it's not a bug in Emacs)? From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 03 01:05:10 2025 Received: (at 74277) by debbugs.gnu.org; 3 Jan 2025 06:05:11 +0000 Received: from localhost ([127.0.0.1]:49209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTao2-0002J7-B8 for submit@debbugs.gnu.org; Fri, 03 Jan 2025 01:05:10 -0500 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:58444) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tTao0-0002DR-Ky for 74277@debbugs.gnu.org; Fri, 03 Jan 2025 01:05:09 -0500 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-218c8aca5f1so207452455ad.0 for <74277@debbugs.gnu.org>; Thu, 02 Jan 2025 22:05:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735884303; x=1736489103; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=W5iAKUm2LxJhxVy83IOvbc7XuEcWD7SoF+7LhEyYmDM=; b=N99WHeTUK67V8M8i74DhXCMJsx1NaPgDXT0nSZmNTVF2d2CzF8yFY0i3nGm8Vl+WQd Vw5OD8OihtGLSI5Jlo+KcwOfrwAyC5Zt6NeFgIZuzPcYUwAms6oQC37B7B5QFZ2TyRyF 01HbWSyCRYnBxIZZiNVEZJ4TPIpkLkEo6tyMlidsyDu9Gb9Kj9xPMWd0WXo1y/Y1Xmvf fhYfQ+OMVnUszB+eCQdrRG+32dn6PFluezYOQ6K4BHnVAZVAgCuXUfKpIxpQ3XfkzQe8 N+MBxMdJ9bdlIs9AQo73OApP/d4AFaALkD67iC4FTGsjULVg8kLAMy+WtHtGBB2mDir+ fq4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735884303; x=1736489103; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W5iAKUm2LxJhxVy83IOvbc7XuEcWD7SoF+7LhEyYmDM=; b=MmTAC5CMFn0SfXYwvDbxZsLFS0jsY7XyF45dM3vDuAykkgFnaKvn5lo269pgbHA8Ds JEtXoyxjhDYkEqM6b8S45C3X/dejOwmhsyjwmkcAxD2e5bNybKyULYXXUYxdwVMgjFWq N2LbhtS+wQTF6EdsMfX/6wHAu2035u09Sm2fla3SOIuqfWS8e5jAj44TA19G78z+S6Z0 2q/zMzrAdD+SQEhKeB8gaxx3LyE2vyZdJ2gFqKxYwiAa1ENUkQrHYLIFWxirauKAJxO2 CQmRRZ1iIZ3gRVZHW0EloZAvndqQlSXWId4juz8ALO2vKQ7U363D1FGS5eAX23F2Qa6l d24w== X-Forwarded-Encrypted: i=1; AJvYcCXEL7FFp5NclE8ep/5k4uZYekzzCm0av9vfFqyHlkt90tZvmWdUli3UYOZKbayZcHr0+bqPsQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy1OGGCE4nMJZY98vnrDkN4EeQ4Z/zhw72vLJgjovD0rGuZpaxN U++d1R7jOrKwU4s+7/pLnghtPVVxCx/J1/UXJE2AS2zA4ubvm6lN X-Gm-Gg: ASbGncsRC+k8i+Z3L4bes7Fr2ZTRA/LIoeod0hbY2RSmAgf+BASd6+Yehi+JIgKvbq4 T0PQ22rdPcJAfr/c3RLzCY7BgTAdBtrB4QkbQeZFfiuMkISIyttK82Q6LpZOZt1iSMft/MEjF+T G+XR3jOB0yfzWSvP7edib184xLIGazNVvKGl6uHaQdJ6sXavgwys+u58WwNJTyz1herNv2Zin7A CZSnWLLOA/tp42/ujI/JiEcdQKlzQQloBoWNySCMiJ565DlYHZLxM7jTc2WfoNFsh+Jwqvmdjd+ W2oN X-Google-Smtp-Source: AGHT+IEHypQ4IKdZO459G9fgwgfL09weOuUHqZ++q0NGN/wlJs99jqgPG2A7zhKibHlk54rN2KA1Bw== X-Received: by 2002:a17:902:f68d:b0:215:e98c:c5bc with SMTP id d9443c01a7336-219e6f28423mr693303925ad.48.1735884302630; Thu, 02 Jan 2025 22:05:02 -0800 (PST) Received: from smtpclient.apple ([2601:646:8f81:6120:85eb:71bd:58ac:56a8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc962bfasm237945065ad.2.2025.01.02.22.05.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Jan 2025 22:05:01 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: bug#74277: 29.4; rust-ts-mode doesn't highlight some function calls From: Yuan Fu In-Reply-To: Date: Thu, 2 Jan 2025 22:04:50 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <446F967C-BBF6-4ED7-980A-ABDB82DB9275@gmail.com> References: <86bjyookld.fsf@gnu.org> <87r077kl0n.fsf@gmail.com> <87ed3522aj.fsf@gmail.com> <87bjy5yuaz.fsf@gmail.com> <89EB0889-DD32-40C2-92E3-8A89ABB6EE37@gmail.com> To: Stefan Kangas X-Mailer: Apple Mail (2.3776.700.51) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74277 Cc: Randy Taylor , Trevor Arjeski , acidbong@tilde.club, 74277@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Jan 1, 2025, at 10:11=E2=80=AFPM, Stefan Kangas = wrote: >=20 > Yuan Fu writes: >=20 >> According to tree-sitter devs, the tree-sitter bug should be fixed = now. >=20 > Thanks. Maybe we should verify the fix on our end? I just ran the Elisp reproduce recipe and it=E2=80=99s fixed. > Meanwhile, should we tag this as "notabug" (since it's not a bug in > Emacs)? Yeah, we can tag it as =E2=80=9Cnotabug=E2=80=9D, it=E2=80=99s more of a = feature request (fontifying Rust macros). Yuan= From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 04 08:20:47 2025 Received: (at 74277) by debbugs.gnu.org; 4 Jan 2025 13:20:47 +0000 Received: from localhost ([127.0.0.1]:53894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU458-0007o1-JW for submit@debbugs.gnu.org; Sat, 04 Jan 2025 08:20:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60222) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU456-0007nk-VX; Sat, 04 Jan 2025 08:20:45 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU451-0005UP-0j; Sat, 04 Jan 2025 08:20:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=MBAmrswPO6AsbyCBnxF3dt11His2u7YIS6a/2GbxB1Q=; b=BRDH6yLl6SPqljiF/3eC jwjFav3DtoKBQmvu8ZV3/ZN/+67eFuGr0ztRheYj5mIm9b6E9Ix/8rN6wltpIw6EtNdYwzRpPoeiX v+v7ZqXM+7fNfvunK1JVyIhKqjahEWiD/rqKrKUpl5bl1oL1CzDsBEr3wTMpaGmDN7IZhQVeAesIz 8WAug9GFsFkenn7TYhWynmWMS8tqqL89X9brV4iyN5rXcMvzTpRj2CLpnBeTaMs9oiJqhpxURgr+6 o9Dl+z0o9MIzrUlYoNm9OT4qgUXLCma7x9VKLXXNaLTSjw/ztwlmGsFIFZpoZKKOpM+QaRU6w7lq1 4p8ab3Q0cGUKJA==; Date: Sat, 04 Jan 2025 15:20:35 +0200 Message-Id: <86pll2d8bg.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: <446F967C-BBF6-4ED7-980A-ABDB82DB9275@gmail.com> (message from Yuan Fu on Thu, 2 Jan 2025 22:04:50 -0800) Subject: Re: bug#74277: 29.4; rust-ts-mode doesn't highlight some function calls References: <86bjyookld.fsf@gnu.org> <87r077kl0n.fsf@gmail.com> <87ed3522aj.fsf@gmail.com> <87bjy5yuaz.fsf@gmail.com> <89EB0889-DD32-40C2-92E3-8A89ABB6EE37@gmail.com> <446F967C-BBF6-4ED7-980A-ABDB82DB9275@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74277 Cc: dev@rjt.dev, tmarjeski@gmail.com, acidbong@tilde.club, 74277@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 74277 notabug close 74277 thanks > From: Yuan Fu > Date: Thu, 2 Jan 2025 22:04:50 -0800 > Cc: Trevor Arjeski , > Randy Taylor , > Eli Zaretskii , > 74277@debbugs.gnu.org, > acidbong@tilde.club > > > > > On Jan 1, 2025, at 10:11 PM, Stefan Kangas wrote: > > > > Yuan Fu writes: > > > >> According to tree-sitter devs, the tree-sitter bug should be fixed now. > > > > Thanks. Maybe we should verify the fix on our end? > > I just ran the Elisp reproduce recipe and it’s fixed. > > > Meanwhile, should we tag this as "notabug" (since it's not a bug in > > Emacs)? > > Yeah, we can tag it as “notabug”, it’s more of a feature request (fontifying Rust macros). Done. From unknown Tue Jun 17 01:50:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 02 Feb 2025 12:24:18 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator