GNU bug report logs - #74265
[PATCH] guix: packages: Fix building development profiles.

Previous Next

To reply to this bug, email your comments to 74265 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: pjals <at> privacyrequired.com
To: guix-patches <at> gnu.org
Cc: "Daniel \[REDACTED\]" <pjals <at> privacyrequired.com>
Subject: [PATCH] guix: packages: Fix building development profiles.
Date: Fri,  8 Nov 2024 16:44:46 +0200

From: "Daniel [REDACTED]" <pjals <at> privacyrequired.com>

* guix/packages.scm (bag-transitive-inputs): Set %current-target-system while
finding bag transitive inputs.

Change-Id: If33a0fc2bf038e09819c87f535c27dfe5e873973
---
 guix/packages.scm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/guix/packages.scm b/guix/packages.scm
index f373136d22..40d5e7b1d5 100644
--- a/guix/packages.scm
+++ b/guix/packages.scm
@@ -1443,12 +1443,6 @@ (define (bag-direct-inputs bag)
           (bag-host-inputs bag)
           (bag-target-inputs bag)))
 
-(define (bag-transitive-inputs bag)
-  "Same as 'package-transitive-inputs', but applied to a bag."
-  (parameterize ((%current-target-system #f)
-                 (%current-system (bag-system bag)))
-    (transitive-inputs (bag-direct-inputs bag))))
-
 (define (bag-transitive-build-inputs bag)
   "Same as 'package-transitive-native-inputs', but applied to a bag."
   (parameterize ((%current-target-system #f)
@@ -1467,6 +1461,12 @@ (define (bag-transitive-target-inputs bag)
                  (%current-system (bag-system bag)))
     (transitive-inputs (bag-target-inputs bag))))
 
+(define (bag-transitive-inputs bag)
+  "Same as 'package-transitive-inputs', but applied to a bag."
+  (append (bag-transitive-build-inputs bag)
+          (bag-transitive-host-inputs bag)
+          (bag-transitive-target-inputs bag)))
+
 (define* (package-development-inputs package
                                      #:optional (system (%current-system))
                                      #:key target)

base-commit: 2a6d96425eea57dc6dd48a2bec16743046e32e06
-- 
2.46.0

Message #8 received at 74265 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: pjals <at> privacyrequired.com
Cc: 74265 <at> debbugs.gnu.org
Subject: Re: [bug#74265] [PATCH] guix: packages: Fix building development
 profiles.
Date: Tue, 12 Nov 2024 23:44:48 +0100

Hi,

pjals <at> privacyrequired.com skribis:

> From: "Daniel [REDACTED]" <pjals <at> privacyrequired.com>
>
> * guix/packages.scm (bag-transitive-inputs): Set %current-target-system while
> finding bag transitive inputs.
>
> Change-Id: If33a0fc2bf038e09819c87f535c27dfe5e873973

Could you add a test that illustrates what this change fixes?

From a cursory look, it’s not clear to me what the motivation is.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.