GNU bug report logs - #74258
[PATCH 0/3] Fix uninstall script

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74258: closed ([PATCH 0/3] Fix uninstall script)
Date: Thu, 14 Nov 2024 14:43:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 14 Nov 2024 15:41:56 +0100
with message-id <87v7wpop1n.fsf <at> gnu.org>
and subject line Re: [bug#74258] [PATCH 0/3] Fix uninstall script
has caused the debbugs.gnu.org bug report #74258,
regarding [PATCH 0/3] Fix uninstall script
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74258: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74258
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: David Boilleau <david_boilleau <at> gmx.fr>
To: guix-patches <at> gnu.org
Cc: David Boilleau <david_boilleau <at> gmx.fr>
Subject: [PATCH 0/3] Fix uninstall script
Date: Fri,  8 Nov 2024 14:41:12 +0100

I installed Guix on Ubuntu 24.04 with the script guix-install.sh, then I
tried to uninstall it by running `guix-install.sh --uninstall`. The
uninstall failed three times:
1. The unit gnu-store.mount was not suppressed, because the prior test
on the gnu-store.mount file failed.
2. The variable ROOT_HOME did not exist, so /root/.guix-profile,
/root/.config/guix and /root/.cache/guix were not suppressed.
3. The "guixbuilder" users were already removed due to the previous
attempts, so the script failed to remove them and exited here. Same when
it tried to remove the service guix-daemon.service.

Here are propositions to fix all of this.

David Boilleau (3):
  guix-install.sh: Test if gnu-store.mount exists before removing the
    unit
  guix-install.sh: Replace `ROOT_HOME` with `~root`
  guix-install.sh: Run the uninstall even if already partially done

 etc/guix-install.sh | 36 +++++++++++++++++++++---------------
 1 file changed, 21 insertions(+), 15 deletions(-)


base-commit: 673b924ac1e30a5d498e28859af365cf2bb4a508
--
2.43.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: David Boilleau <david_boilleau <at> gmx.fr>
Cc: 74258-done <at> debbugs.gnu.org
Subject: Re: [bug#74258] [PATCH 0/3] Fix uninstall script
Date: Thu, 14 Nov 2024 15:41:56 +0100

Hi David,

David Boilleau <david_boilleau <at> gmx.fr> skribis:

> I installed Guix on Ubuntu 24.04 with the script guix-install.sh, then I
> tried to uninstall it by running `guix-install.sh --uninstall`. The
> uninstall failed three times:
> 1. The unit gnu-store.mount was not suppressed, because the prior test
> on the gnu-store.mount file failed.
> 2. The variable ROOT_HOME did not exist, so /root/.guix-profile,
> /root/.config/guix and /root/.cache/guix were not suppressed.
> 3. The "guixbuilder" users were already removed due to the previous
> attempts, so the script failed to remove them and exited here. Same when
> it tried to remove the service guix-daemon.service.
>
> Here are propositions to fix all of this.
>
> David Boilleau (3):
>   guix-install.sh: Test if gnu-store.mount exists before removing the
>     unit
>   guix-install.sh: Replace `ROOT_HOME` with `~root`
>   guix-install.sh: Run the uninstall even if already partially done

This looks good to me.

Applied, thank you for spotting the problems and for fixing them!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.