From unknown Mon Aug 18 17:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#74258] [PATCH 0/3] Fix uninstall script Resent-From: David Boilleau Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 08 Nov 2024 13:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74258 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74258@debbugs.gnu.org Cc: David Boilleau X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173107414830522 (code B ref -1); Fri, 08 Nov 2024 13:56:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Nov 2024 13:55:48 +0000 Received: from localhost ([127.0.0.1]:51583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9PSj-0007w6-3R for submit@debbugs.gnu.org; Fri, 08 Nov 2024 08:55:47 -0500 Received: from lists.gnu.org ([209.51.188.17]:52584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9PFB-0007JO-PJ for submit@debbugs.gnu.org; Fri, 08 Nov 2024 08:41:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9PFB-0002PT-Jq for guix-patches@gnu.org; Fri, 08 Nov 2024 08:41:45 -0500 Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9PFA-0003mL-1I for guix-patches@gnu.org; Fri, 08 Nov 2024 08:41:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.fr; s=s31663417; t=1731073300; x=1731678100; i=david_boilleau@gmx.fr; bh=vONnq7BoImFu3XVKLk2TO/hGi4o3jTrome4XxDEQhbQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID: MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=h1S36nnijJ44y/18hk8BdOAhanJC5wab6BgMO3AO3COmE9xBr0kTaLrmaVMa4v96 6VjTSF5Z3+iRwCLGVp5gV/qL8pX2ROOIqrIMFCxEFnV1FlLIXE6YKv3+68H4UQbBa tMSj8kS/w3nNcQ8m1xswp3MUf5T4RVWNPuOK3qH2HfzvoQ0K9Bd1du1WLsTYKj0nh slgQP+A7ggNyFzPtvCerc8geCuMlxjOHGU8o8S9aCZ97c7kbZ+DSfQPLpXwLhdNf0 vkfB+cDQPAmwezv60VG2lrulhuHaa/kgCVY+e+eAUShO+lQ8sR/3pVLKtYPi0JYg6 sZqyLA33vbIjl6OsMw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from pms ([88.126.7.20]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mqb1c-1teMLc27RQ-00ZiTv; Fri, 08 Nov 2024 14:41:40 +0100 From: David Boilleau Date: Fri, 8 Nov 2024 14:41:12 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:3EHlImKF8o7gKEbNgi+JOeI7X6Sr6HzaWG2gppNIhjabDRwEM66 9jzY2+Sfm/w0fTOvWyKpFpqCnhtvSW78x8sKvAJc/7UQvUTcOF7K9TBR52WPNFB+/ejG7c2 OZLDvxUgMoNvF9Bqc5YllTzKUOz9yAdsGIkdEreBn0XsOhOx3b5LNakGh90C2x0aEfdnySQ F7KbXPglPQ0OL5AjCUnMA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:+I39tI84IV4=;n2dFpReOrZJDh1ItT4VeCCHwuuS dhfYCpWplQ6/1IGfCK7UiTcNi3LiG8p9Xe4/AHvggt2lqAgQdX/aAY5f7n7WFhMWIdpon7hz1 DmokYcnglHEzv/+awRG7S/djF8ykrNl1UyNLqOj44DuDP5fAImM7eafpTfPLS9xJdOaPXiPcF d2iU1mTR1eTQ9fnGAzMUNMBWbDc7BNjDxEtDICeKV+ZjGEEMGnY5D5b5gQjWUlXoE5OQfBiyx TbeNioPXN3kLcixfHlQyejbuILUslmPVT0ePyj6oYSO3bmwVdAAa7SI9/5m6T+cWWdicLSv4h 6fKTKoNQL5HtkNA5htLryVhGaK+W7yQcFnkQHl1HrN1Ev5SwQTlGN+lfs+Z7OUYL63mEmYi78 42KehNdnuTbAgQR5SSOToAR8nDvT5iBe7mcyaTxzxssVEdJYvr6p+/sa4r3kKn+Xf2ked5Jws tG7JU0xVMz1hrsC9ewMmV/gtieurXjSp4sjBX3XxIGtqRJv4HZ5ZzcrKLGf2SuNHuYrG5t25j hpEDuMcpdbcQz39m+NpLntevs/HlNDBu0U2+q6BE05No4sDpKzNzaE7pRsPx73pQA4hK6r6rw dTofF7vp96Y0lBnjFfBhq0F5ZM9bh/w6TxXb1lKBPd60hK+w+7BLRAQJihcC8d3vC81dLMhB/ UTuSnp2+Hk4XoHgeUHW3+emHgTU3svMmGmJRNaBlnfap5Ow02JX1+6YdeJSus87AeXj9W/UrM 9Xeq13hnW1u7E4P8zt9pGM4FeCmkh05V+MDeRo9nbiuBDetv8LiCDePFmSLBmnZqusnmMD8He Y+1uzGl3aY0xn0YojLX+B98g== Received-SPF: pass client-ip=212.227.17.21; envelope-from=david_boilleau@gmx.fr; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Mailman-Approved-At: Fri, 08 Nov 2024 08:55:40 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) I installed Guix on Ubuntu 24.04 with the script guix-install.sh, then I tried to uninstall it by running `guix-install.sh --uninstall`. The uninstall failed three times: 1. The unit gnu-store.mount was not suppressed, because the prior test on the gnu-store.mount file failed. 2. The variable ROOT_HOME did not exist, so /root/.guix-profile, /root/.config/guix and /root/.cache/guix were not suppressed. 3. The "guixbuilder" users were already removed due to the previous attempts, so the script failed to remove them and exited here. Same when it tried to remove the service guix-daemon.service. Here are propositions to fix all of this. David Boilleau (3): guix-install.sh: Test if gnu-store.mount exists before removing the unit guix-install.sh: Replace `ROOT_HOME` with `~root` guix-install.sh: Run the uninstall even if already partially done etc/guix-install.sh | 36 +++++++++++++++++++++--------------- 1 file changed, 21 insertions(+), 15 deletions(-) base-commit: 673b924ac1e30a5d498e28859af365cf2bb4a508 =2D- 2.43.0 From unknown Mon Aug 18 17:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#74258] [PATCH 1/3] guix-install.sh: Test if gnu-store.mount exists before removing the unit Resent-From: David Boilleau Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 08 Nov 2024 18:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74258 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74258@debbugs.gnu.org Cc: David Boilleau Received: via spool by 74258-submit@debbugs.gnu.org id=B74258.173109150216910 (code B ref 74258); Fri, 08 Nov 2024 18:46:02 +0000 Received: (at 74258) by debbugs.gnu.org; 8 Nov 2024 18:45:02 +0000 Received: from localhost ([127.0.0.1]:52129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9Tyc-0004OD-FA for submit@debbugs.gnu.org; Fri, 08 Nov 2024 13:45:01 -0500 Received: from mout.gmx.net ([212.227.17.22]:43721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9PhO-0000AG-7y for 74258@debbugs.gnu.org; Fri, 08 Nov 2024 09:10:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.fr; s=s31663417; t=1731075048; x=1731679848; i=david_boilleau@gmx.fr; bh=862NZUM707SZJFoROMhU5edXDBjNqbImESMZv4G0jhM=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=VMJEW99viHFKnNtHE9ByWRHq4bAl0nyc1gn7cVYFfV8JDv7RvmMz2CJVXt2shqeD TMQ1wx1vCfdeQ9h3AlY7ndtF8hPmbOlfcizWOxnwaOWB4HccEmgAEkn6hwxh9TzCw WeBAd4Va8NHQuc2fpJvtlUPvCUtX09fX7trWtnqCA5CGWDD7mvXT1pb/rm5rYSrBP skN0kVB0ReFy9h+HxjwUi7lwYJB6ubzFep2Mujz6OdP8Qmx3oTCNWA6xobvMGvGCK S0dP4C95Pn1QySGHYoiuM4I0Flz1z0nMOiLyRWgwLnqUbP6/7DkduiGeSxebcVCG8 QsMsjNPt3sZupVShCQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from pms ([88.126.7.20]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MmULx-1taFzK0grZ-00kNfe; Fri, 08 Nov 2024 15:10:48 +0100 From: David Boilleau Date: Fri, 8 Nov 2024 15:10:22 +0100 Message-ID: <2a447bdebd8520746ff31f34b87801938e8af17c.1731055803.git.david_boilleau@gmx.fr> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:UFD05tR8ih4acR8lv36Nqoy4xboRQjM4gzFFPyv1YX+Fg52je93 /aBWDwx+ntfByUM9v/AK1Fk+udAmlt2vJVzC+yNatJotJPxYKxF/zsPJYmztt0wdWdygzXR lMRT/GxYXllBRDZJMrvrf0Mt1yoP98uhXhd6j/PgN9grBkjeWpfRPoejYkX3dADS2bI6kvb r5nbj0yb3jyH5qrCgp2tQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:7TRMrGxa+wo=;Dber80ml1mqfilmHIZ5GWqHO8VI xougggTTUthofTj7204gUfpRZ0PZenXF+l186hHANmmrehbLVFu8bf0MyuPpWi13C5UApHhm+ wZb7O9PvmzhtnHKYSx9IJEf7Apml6halQXgZMWRnqpg6yBPFAljS52G/OWeufQfmjsw7FaVJe AjTRtbDyo//qkMpjLyRqeSTrjLLFUfKdymrg8k3h4wpLjYuYoebKtYQCtfmQ+/BKD6uuD2TUf jHqsmI/zKFLHRsixLSc9crAzny2l0ZTO10YnnQU3nLJwpN+v9YRvndS2nlN8rKfk3lWzxNsWO Vd7ehV61R7F6GbigEJysWOQeU/7Zbh9u7Ih3oXl2fG9AeQRAIdhdqFcApOOQJ9mR43YrYp+NL DNuIQn1mCzWEPf6NNC8xrz9+tzxnuog+zZkIaFpEt452L+aJcTrNc8VcGDBmSrg4YMxlyJe9R f/7GFeLTyO0lIl3xIkvZn/matJFyYmbQgIQA0T19FU4/5CPk7QzcVzlPgkkFk363dfpqEwaHX LZL/+7RxlnRlYEWMnI3cIiErHSue9J/HZurZ9ByWd0vezH8za4QF0R3l0I2kPuJ4xbga/E+s2 8ph4/K6/uRF+T8zEJ0Ui1OYnFj/u29bYexi2Y/dLvGke26pZ4PrjiQaQu7vyTrczulRjnW0nL 739wW8HEuxH+nJBkXzsN7Tx9ubn5zDTDfgKcV8b7Cnzz9EPwVKNxr2N15loB3SYG/eYskwg4N zAhPGPZe63RQBQOBt0EFL6aj+9autpk4R0X6LK7L0LLxhSpGgxslna50gwhGlrewIiwvE2DKd imCoPvRPeXjtMYKtdCoDcOVor5VQqQVoVp4N3AIW5rf/ZrIB3VebIStC/57XLb4Ywii/UqcG5 8sAdZiVWrWzzNmOvmyTgUXuVyubtabKn28tJz7rMk8Xc+pPBHuQpgKPG0 X-Spam-Score: -0.7 (/) X-Mailman-Approved-At: Fri, 08 Nov 2024 13:44:56 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) The file /etc/systemd/system/gnu-store.mount has permissions 664, since th= e `install_unit()` function installed it so. So the test prior to removing t= he matching Systemd unit should not be wether this file is executable, otherw= ise it will always fail. The relevant test is on the file existence. * etc/guix-install.sh (sys_delete_guix_daemon): Test if gnu-store.mount fi= le exists rather than if it is executable. Change-Id: Ic7cc186618b0b92fccf49a3b27805756a9126b89 =2D-- etc/guix-install.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index 9d9c294d75..e97190d964 100755 =2D-- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -576,7 +576,7 @@ sys_delete_guix_daemon() _msg "${INF}removing guix-daemon" rm -f /etc/systemd/system/guix-daemon.service - if [ -x /etc/systemd/system/gnu-store.mount ]; then + if [ -f /etc/systemd/system/gnu-store.mount ]; then _msg "${INF}disabling gnu-store.mount" systemctl disable gnu-store.mount _msg "${INF}stopping gnu-store.mount" =2D- 2.43.0 From unknown Mon Aug 18 17:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#74258] [PATCH 2/3] guix-install.sh: Replace `ROOT_HOME` with `~root` Resent-From: David Boilleau Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 08 Nov 2024 18:46:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74258 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74258@debbugs.gnu.org Cc: David Boilleau Received: via spool by 74258-submit@debbugs.gnu.org id=B74258.173109150216933 (code B ref 74258); Fri, 08 Nov 2024 18:46:03 +0000 Received: (at 74258) by debbugs.gnu.org; 8 Nov 2024 18:45:02 +0000 Received: from localhost ([127.0.0.1]:52131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9Tyf-0004Oh-Um for submit@debbugs.gnu.org; Fri, 08 Nov 2024 13:45:02 -0500 Received: from mout.gmx.net ([212.227.17.21]:36255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9PhS-0000AL-HD for 74258@debbugs.gnu.org; Fri, 08 Nov 2024 09:10:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.fr; s=s31663417; t=1731075052; x=1731679852; i=david_boilleau@gmx.fr; bh=h3ZyX81ZgsMMHdfeZgBLEau2mmLqN0sTzAhLPqmu/9w=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=uBtyvAj7pHZ1LZjQEZ/z8rvxXzB26v944uSPWZuEmuLk2cRQ6eJ39jGgvy1WuVOQ FH7thHHi12q4XQBtnUA3kh3EHChOHQ1yKwuJDD/AjkSHOqjbze224k7pAziMu7B4A s47YyjTiYVy4wASlirF+MYNZYHOxvLdjlEj8aEOjMEJjb4HAiEkVF41qsNwA5NyF7 VHEeubFfEVhzCMX0YaWliOyQFxLqE2eYuSYM+cDvk6byrS7t5KYgb5Lwv5Xn9RYAv vutV4GHyI7fsqwXrhBgQOUqN/n2NBg8yvIe1+W6AVx9sPf1CWqe9lpv2marIkmd/n PLcJlMMcyjWjnZmjqA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from pms ([88.126.7.20]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MTzb8-1tHlOr0ZaU-00TXft; Fri, 08 Nov 2024 15:10:52 +0100 From: David Boilleau Date: Fri, 8 Nov 2024 15:10:23 +0100 Message-ID: <1a9aa88fcacc1c9b2f173a0aa8a6aa7327a3a2b7.1731055803.git.david_boilleau@gmx.fr> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:gckVTgaalK6xsLZRIEQBuvEohOvs22nlKg3n27GD8BTgX0lzTxY 5RKRWKWpF8amkTixBt4m3sX7J8a+GB/gWDmOKV7Fq7ZRdB7dCFCIyn1lH41I2KgOM4fquVn XNtmo6XV+G0KKBH1+A470xlFeTs3forQSx85IzyPolsdl6z8Hb/cQ7X+IIBdLeRJ0NBJQZ8 r5hz/+AJ6fPtzONz0U/EA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:/D2Slg94AQk=;jvwIS2aP4FYr5LKEsnUmu0O8i3y a9gH1OFngcSZBqIwBCqvRsJPVkINNq/NSCvf9jISxVviG/0JbBlcZIqhwJgHtKFo9zP26cyeV 4P3UMWfLXmgWVQ4GqksXCso/At7qbFmCihJiP2rsBs6CKSBndRmOINX2FxecTFzEbnTGl1Ouz RGftMDjr0wJ7aRmVbI3wZ8MOMVNCSg5AQ30x4tlZ8pcMwTsunQs01G8eiF8WMlDtEf3vdO+Ax NKa9yO63YxyUQh6WqfyUJIRvA0EK50kY5KzwskhhoBDSbunV+HtkJafkcFsNnTLqIoktgW+IV qGu7n/jpCcygEJNSc3qx23C3N83cb4+Pd7Ecb9TAuCaGqgm7I1NUTIBUmGF0noVID8/tqSl+P PBPDh2Nqyhl7WrVZuJsys73TL+n5B6vWYHdsun5MeM4a3b7tCuKfLdNuospEVyop3VCMZmsOu jMtJsmra7WajdVXsfeODCtZuVeVkR3Lhc4cfrgNMLSNmgnETZ8ZcYazLsRTe+zt5bKFXeRpK7 ydrVwfMZuftekXbc6xT97iDSFEgYb7Gn3o8CUpDUNFURC6NCK0JDNI3GuatI29N7Ss6BZoRE3 Iuy2yccm0g8FcLvbf742FMMbUEMfUh8YtWPzJzweXBFBsl6j/E/gUQuMRakibKNeOK8iq+Uov YFpRYES2zvZdAlT0H6OAph7r7PVSBhtW34fgTjoyRc9KP7k7kobaiBxH02zRsXZT95Xrkk0Bo OBV46wLFJYVfTM9vkG9lpPFkoLsPtXPIxvIIUdFXNwkqd4TtUIWqFSILzwp45TQY5DFLR1eM6 1tmOxOkIwHmVh5KtMtmFax69cF+JpLpW4XiPpJxYg03C3vQVVJ03fOmPHl1VKpBB1plGoZPrZ BFieeT7t0EGELn38ofaONNDHp7UBUSLKsN44yB+FWiai0bbB8FmE/Vug2 X-Spam-Score: -0.7 (/) X-Mailman-Approved-At: Fri, 08 Nov 2024 13:44:56 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) The `ROOT_HOME` variable is natively absent from some systems, however the= form `~root`, which is used by the install functions in this same file, works. * etc/guix-install.sh (sys_delete_store, sys_delete_guix_daemon) (sys_delete_user_profiles): Replace `ROOT_HOME` with `~root`. Change-Id: Ia867e271ac4c5557d9708235fee028bccce68342 =2D-- etc/guix-install.sh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index e97190d964..7fb5ac63c5 100755 =2D-- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -410,8 +410,8 @@ sys_delete_store() _msg "${INF}removing /gnu" rm -rf /gnu - _msg "${INF}removing ${ROOT_HOME}/.config/guix" - rm -rf ${ROOT_HOME}/.config/guix + _msg "${INF}removing ~root/.config/guix" + rm -rf ~root/.config/guix } sys_create_build_user() @@ -594,7 +594,7 @@ sys_delete_guix_daemon() ;; NA|*) _msg "${ERR}unsupported init system; disable, stop and remove= the daemon manually:" - echo " ${ROOT_HOME}/.config/guix/current/bin/guix-daemon --b= uild-users-group=3Dguixbuild" + echo " ~root/.config/guix/current/bin/guix-daemon --build-us= ers-group=3Dguixbuild" ;; esac @@ -743,9 +743,9 @@ sys_delete_init_profile() sys_delete_user_profiles() { - _msg "${INF}removing ${ROOT_HOME}/.guix-profile" - rm -f ${ROOT_HOME}/.guix-profile - rm -rf ${ROOT_HOME}/.cache/guix + _msg "${INF}removing ~root/.guix-profile" + rm -f ~root/.guix-profile + rm -rf ~root/.cache/guix _msg "${INF}removing .guix-profile, .cache/guix and .config/guix of a= ll /home users" for user in `ls -1 /home`; do =2D- 2.43.0 From unknown Mon Aug 18 17:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#74258] [PATCH 3/3] guix-install.sh: Run the uninstall even if already partially done Resent-From: David Boilleau Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 08 Nov 2024 18:46:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74258 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74258@debbugs.gnu.org Cc: David Boilleau Received: via spool by 74258-submit@debbugs.gnu.org id=B74258.173109150316941 (code B ref 74258); Fri, 08 Nov 2024 18:46:03 +0000 Received: (at 74258) by debbugs.gnu.org; 8 Nov 2024 18:45:03 +0000 Received: from localhost ([127.0.0.1]:52134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9Tyg-0004P4-Lp for submit@debbugs.gnu.org; Fri, 08 Nov 2024 13:45:03 -0500 Received: from mout.gmx.net ([212.227.17.22]:42481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9PhW-0000AQ-PQ for 74258@debbugs.gnu.org; Fri, 08 Nov 2024 09:11:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.fr; s=s31663417; t=1731075057; x=1731679857; i=david_boilleau@gmx.fr; bh=j+A13LMfNHbGxe6k1Y7NzSGS5JkWgpCCO5WYKdTIV5U=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=j8y+tBkbdeujwfXK1vgPDo3KMxkJIKllaUp7bDXr/fh39TRHFlzIfTGxydENm3Mt HWjQAXyqEEY7YhhEDNWW/1d/UwN9E3DNKB1nIdztgGDumQNZo8k/z9+lRQjqMACpz wb1IqkTursdab3z+nt4UmZ1v9AtwK6THhNcpx5ljkK6WClvxVT9YeDVYx2DPOt65Y lG/+b27GghJzB4toAXni/ZCb4NAa+dVcLcFXekEv4yFGpPhJXgmeK5I0zpggK752X 1MDywVJ6UcPybKcHxM2AvhcqpPzVMPDeM14AFcXP1wAzSDUmWR/dF2+KBWBqx5g62 sFvrPKTpraxBKGAuQg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from pms ([88.126.7.20]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MwfWU-1u22O20sX4-00wFfV; Fri, 08 Nov 2024 15:10:57 +0100 From: David Boilleau Date: Fri, 8 Nov 2024 15:10:24 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Fi6eoLr3KYlCWL9kqTDgXUIEcYNuwkNnAIpD8eSf603si6EluWw GGO6Dcz8Azc18Dfckzf+49w27mScdVvFG8h2aUlnfhTfJAY22CwnJyFf160Hcm7eUqC8ydl TpWwmTpkohpr9DX6/3siGdOGlafF53e8dXdO+HP8CHgbUJ/JM5X67eFv1EVYJtObO0NWFLD LxiCETRcTKbuBFpt215qA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:kNLQovMOj5I=;46tqSNY/azgDTB+JdU61mD5olWj 3jr6oUkdL077KinSkZ1HV9yMlolQTwynI1YcUikXZEUzlqg/4j5dqr1sX1WVJtvc+QnHNfWid bk/rp6/mVx3OvIJREO+Ynq1yQ4Goe1UPYI09LgWmIPlmS+oUZBdr2QTjNN6v94VaqD2JEc7cL X8QP3/2nVgY8X+xQ9ejm6HBABNuOldkkInL1aYJcW/o+UWApVPUQaah3XZ2HA8dQsMh1cqaFV 0OIyr3pH9XEEyvT77HvTnfoMdXGl26PlOJ1YqCHkIUU9noYrugM7yBUdwf55glDKqmUw2YwQ/ PWRD5HfP0rXGMPPUuO6F0h9pUkUUBvdxXph8/IzFuqodtWWP1rcrNrXTPM8LOChhYS906QT/n ntDf4KRLtf72Y2Avi/ovAkZgWajXBBE9yq7Vr1mJXAhcDorg0XEf43EB04EuaSwUKCYDbz+bp eIWF4HzGaOAbRzykH1CicSm4aX3J21/ulQmGteV58OgLGNqvC1yKqb25kLcjWOKjVC9GjnCCw oxOQX5SyVqcJ8++ywyYuWXo02EgEazJ/4jk1SPNM8zKCbDYap3W8Xd+4nrvYoqVj67PNvsc4r oP0MjcCpX24MUN3IqdddxjPfLnJZXniNQviF+0+/th+cKjQNFD31IiIEPffw2NxWwtq7DQnQh 7ye93OHCtLTcO+b/Y0R8P8vr3hKj6LnKV7GgdlQ7951VvdGH9wu6lw8iuFoo/70ZjPLIm84Wy F3k6EYsHdQnJPNpPAMzbl/4lorhw/gCEmDGDyOucpgvtYwT/QZc3ziMqLrWQYgQ5mCQmcscgS xG8OX67iEZF8hLK7Z2kA0aqdHa6zaiqh4kvcodDSmnxLDsNEwinYsMY+a9h2gGjMnOiAikpZW iNhkgv31bJK1uoQqdm0jzv/d0O++URa39Z0slxqMMRe1jjM1dYIb+mYx3 X-Spam-Score: -0.7 (/) X-Mailman-Approved-At: Fri, 08 Nov 2024 13:44:56 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Removing users, groups or Systemd units fails if they are already absent, causing the uninstall script to exit. The goal here is to make the uninsta= ll always run entirely, whatever parts are already done. * etc/guix-install.sh (sys_delete_build_user): Test if users and groups ex= ist before deleting them. (sys_delete_guix_daemon): Test if /etc/systemd/system/guix-daemon.service = file exists before removing the matching Systemd unit. Change-Id: Ibffb1f1b39de675542fb8057af21ecaea1b53d4c =2D-- etc/guix-install.sh | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index 7fb5ac63c5..f07b2741bb 100755 =2D-- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -451,11 +451,15 @@ sys_create_build_user() sys_delete_build_user() { for i in $(seq -w 1 10); do - userdel -f guixbuilder${i} + if id -u "guixbuilder${i}" &>/dev/null; then + userdel -f guixbuilder${i} + fi done _msg "${INF}delete group guixbuild" - groupdel -f guixbuild + if getent group guixbuild &>/dev/null; then + groupdel -f guixbuild + fi } sys_enable_guix_daemon() @@ -569,12 +573,14 @@ sys_delete_guix_daemon() ;; systemd) - _msg "${INF}disabling guix-daemon" - systemctl disable guix-daemon - _msg "${INF}stopping guix-daemon" - systemctl stop guix-daemon - _msg "${INF}removing guix-daemon" - rm -f /etc/systemd/system/guix-daemon.service + if [ -f /etc/systemd/system/guix-daemon.service ]; then + _msg "${INF}disabling guix-daemon" + systemctl disable guix-daemon + _msg "${INF}stopping guix-daemon" + systemctl stop guix-daemon + _msg "${INF}removing guix-daemon" + rm -f /etc/systemd/system/guix-daemon.service + fi if [ -f /etc/systemd/system/gnu-store.mount ]; then _msg "${INF}disabling gnu-store.mount" =2D- 2.43.0 From unknown Mon Aug 18 17:55:28 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: David Boilleau Subject: bug#74258: closed (Re: [bug#74258] [PATCH 0/3] Fix uninstall script) Message-ID: References: <87v7wpop1n.fsf@gnu.org> X-Gnu-PR-Message: they-closed 74258 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 74258@debbugs.gnu.org Date: Thu, 14 Nov 2024 14:43:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1731595382-7722-1" This is a multi-part message in MIME format... ------------=_1731595382-7722-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #74258: [PATCH 0/3] Fix uninstall script which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 74258@debbugs.gnu.org. --=20 74258: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74258 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1731595382-7722-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 74258-done) by debbugs.gnu.org; 14 Nov 2024 14:42:10 +0000 Received: from localhost ([127.0.0.1]:45663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBb2w-0001z9-Cj for submit@debbugs.gnu.org; Thu, 14 Nov 2024 09:42:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBb2t-0001yw-5W for 74258-done@debbugs.gnu.org; Thu, 14 Nov 2024 09:42:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBb2n-0006TM-9P; Thu, 14 Nov 2024 09:42:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=1WeqHLDK9GCl0oZDuXjcJ+lc269FUIIjijpXLkMNtmU=; b=sJme/6pRhWprCy+TIHUf mwt1Sv+xWbj/Zz/CfVz8/HbMqcNGUzSrj1XF2Aj5OB0aFqcEwTc49y4w/2Q/iwE2kvULuTwxSHN1n TbUb3/Aj/dNtJMK+qL8C2zZ6pjQLE6YPXOdBT7Hfyf2lDZPDrFLLITprr+bvA0NxPMupSLGNpSToe pMmu8SNkr8XG12dnQisQc7b+eEYhxBo2LqaA3XOFXOfKWIbyhBGIzw4LzQnXD2ElVVwLSy44bV9gI 8wJJqmVYnHPKjYISXgnXuejb44lIYNSsM0uJFh0GHsFUAFSIb2vjNuKa2gYyvpAa96LHUT8p8Ra4a ElNjGE2h8yEf2w==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: David Boilleau Subject: Re: [bug#74258] [PATCH 0/3] Fix uninstall script In-Reply-To: (David Boilleau's message of "Fri, 8 Nov 2024 14:41:12 +0100") References: Date: Thu, 14 Nov 2024 15:41:56 +0100 Message-ID: <87v7wpop1n.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74258-done Cc: 74258-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi David, David Boilleau skribis: > I installed Guix on Ubuntu 24.04 with the script guix-install.sh, then I > tried to uninstall it by running `guix-install.sh --uninstall`. The > uninstall failed three times: > 1. The unit gnu-store.mount was not suppressed, because the prior test > on the gnu-store.mount file failed. > 2. The variable ROOT_HOME did not exist, so /root/.guix-profile, > /root/.config/guix and /root/.cache/guix were not suppressed. > 3. The "guixbuilder" users were already removed due to the previous > attempts, so the script failed to remove them and exited here. Same when > it tried to remove the service guix-daemon.service. > > Here are propositions to fix all of this. > > David Boilleau (3): > guix-install.sh: Test if gnu-store.mount exists before removing the > unit > guix-install.sh: Replace `ROOT_HOME` with `~root` > guix-install.sh: Run the uninstall even if already partially done This looks good to me. Applied, thank you for spotting the problems and for fixing them! Ludo=E2=80=99. ------------=_1731595382-7722-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 8 Nov 2024 13:55:48 +0000 Received: from localhost ([127.0.0.1]:51583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9PSj-0007w6-3R for submit@debbugs.gnu.org; Fri, 08 Nov 2024 08:55:47 -0500 Received: from lists.gnu.org ([209.51.188.17]:52584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9PFB-0007JO-PJ for submit@debbugs.gnu.org; Fri, 08 Nov 2024 08:41:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9PFB-0002PT-Jq for guix-patches@gnu.org; Fri, 08 Nov 2024 08:41:45 -0500 Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9PFA-0003mL-1I for guix-patches@gnu.org; Fri, 08 Nov 2024 08:41:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.fr; s=s31663417; t=1731073300; x=1731678100; i=david_boilleau@gmx.fr; bh=vONnq7BoImFu3XVKLk2TO/hGi4o3jTrome4XxDEQhbQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID: MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=h1S36nnijJ44y/18hk8BdOAhanJC5wab6BgMO3AO3COmE9xBr0kTaLrmaVMa4v96 6VjTSF5Z3+iRwCLGVp5gV/qL8pX2ROOIqrIMFCxEFnV1FlLIXE6YKv3+68H4UQbBa tMSj8kS/w3nNcQ8m1xswp3MUf5T4RVWNPuOK3qH2HfzvoQ0K9Bd1du1WLsTYKj0nh slgQP+A7ggNyFzPtvCerc8geCuMlxjOHGU8o8S9aCZ97c7kbZ+DSfQPLpXwLhdNf0 vkfB+cDQPAmwezv60VG2lrulhuHaa/kgCVY+e+eAUShO+lQ8sR/3pVLKtYPi0JYg6 sZqyLA33vbIjl6OsMw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from pms ([88.126.7.20]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mqb1c-1teMLc27RQ-00ZiTv; Fri, 08 Nov 2024 14:41:40 +0100 From: David Boilleau To: guix-patches@gnu.org Subject: [PATCH 0/3] Fix uninstall script Date: Fri, 8 Nov 2024 14:41:12 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:3EHlImKF8o7gKEbNgi+JOeI7X6Sr6HzaWG2gppNIhjabDRwEM66 9jzY2+Sfm/w0fTOvWyKpFpqCnhtvSW78x8sKvAJc/7UQvUTcOF7K9TBR52WPNFB+/ejG7c2 OZLDvxUgMoNvF9Bqc5YllTzKUOz9yAdsGIkdEreBn0XsOhOx3b5LNakGh90C2x0aEfdnySQ F7KbXPglPQ0OL5AjCUnMA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:+I39tI84IV4=;n2dFpReOrZJDh1ItT4VeCCHwuuS dhfYCpWplQ6/1IGfCK7UiTcNi3LiG8p9Xe4/AHvggt2lqAgQdX/aAY5f7n7WFhMWIdpon7hz1 DmokYcnglHEzv/+awRG7S/djF8ykrNl1UyNLqOj44DuDP5fAImM7eafpTfPLS9xJdOaPXiPcF d2iU1mTR1eTQ9fnGAzMUNMBWbDc7BNjDxEtDICeKV+ZjGEEMGnY5D5b5gQjWUlXoE5OQfBiyx TbeNioPXN3kLcixfHlQyejbuILUslmPVT0ePyj6oYSO3bmwVdAAa7SI9/5m6T+cWWdicLSv4h 6fKTKoNQL5HtkNA5htLryVhGaK+W7yQcFnkQHl1HrN1Ev5SwQTlGN+lfs+Z7OUYL63mEmYi78 42KehNdnuTbAgQR5SSOToAR8nDvT5iBe7mcyaTxzxssVEdJYvr6p+/sa4r3kKn+Xf2ked5Jws tG7JU0xVMz1hrsC9ewMmV/gtieurXjSp4sjBX3XxIGtqRJv4HZ5ZzcrKLGf2SuNHuYrG5t25j hpEDuMcpdbcQz39m+NpLntevs/HlNDBu0U2+q6BE05No4sDpKzNzaE7pRsPx73pQA4hK6r6rw dTofF7vp96Y0lBnjFfBhq0F5ZM9bh/w6TxXb1lKBPd60hK+w+7BLRAQJihcC8d3vC81dLMhB/ UTuSnp2+Hk4XoHgeUHW3+emHgTU3svMmGmJRNaBlnfap5Ow02JX1+6YdeJSus87AeXj9W/UrM 9Xeq13hnW1u7E4P8zt9pGM4FeCmkh05V+MDeRo9nbiuBDetv8LiCDePFmSLBmnZqusnmMD8He Y+1uzGl3aY0xn0YojLX+B98g== Received-SPF: pass client-ip=212.227.17.21; envelope-from=david_boilleau@gmx.fr; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 08 Nov 2024 08:55:40 -0500 Cc: David Boilleau X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) I installed Guix on Ubuntu 24.04 with the script guix-install.sh, then I tried to uninstall it by running `guix-install.sh --uninstall`. The uninstall failed three times: 1. The unit gnu-store.mount was not suppressed, because the prior test on the gnu-store.mount file failed. 2. The variable ROOT_HOME did not exist, so /root/.guix-profile, /root/.config/guix and /root/.cache/guix were not suppressed. 3. The "guixbuilder" users were already removed due to the previous attempts, so the script failed to remove them and exited here. Same when it tried to remove the service guix-daemon.service. Here are propositions to fix all of this. David Boilleau (3): guix-install.sh: Test if gnu-store.mount exists before removing the unit guix-install.sh: Replace `ROOT_HOME` with `~root` guix-install.sh: Run the uninstall even if already partially done etc/guix-install.sh | 36 +++++++++++++++++++++--------------- 1 file changed, 21 insertions(+), 15 deletions(-) base-commit: 673b924ac1e30a5d498e28859af365cf2bb4a508 =2D- 2.43.0 ------------=_1731595382-7722-1--