GNU bug report logs - #74251
[PATCH] Adding jack-mixer audio package

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74251 in the body.
You can then email your comments to 74251 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Divya Ranjan <divya <at> subvertising.org>
To: guix-patches <at> gnu.org
Cc: Divya Ranjan <divya <at> subvertising.org>
Subject: [PATCH] Adding jack-mixer audio package
Date: Fri,  8 Nov 2024 00:01:01 +0000

---
 gnu/packages/audio.scm | 68 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 68 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 467dc4a74f..70477d1071 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -79,6 +79,7 @@ (define-module (gnu packages audio)
   #:use-module (gnu packages check)
   #:use-module (gnu packages cdrom)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages commencement)
   #:use-module (gnu packages cpp)
   #:use-module (gnu packages curl)
   #:use-module (gnu packages dbm)
@@ -160,6 +161,7 @@ (define-module (gnu packages audio)
   #:use-module (guix build-system python)
   #:use-module (guix build-system trivial)
   #:use-module (guix build-system waf)
+  #:use-module (guix build utils)
   #:use-module (guix download)
   #:use-module (guix gexp)
   #:use-module (guix git-download)
@@ -2772,6 +2774,72 @@ (define-public jacktrip
 audio signal streaming.")
     (license (list license:gpl3+ license:lgpl3 license:expat))))
 
+(define-public jack-mixer
+  (package
+    (name "jack-mixer")
+    (version "19")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/jack-mixer/jack_mixer")
+             (commit (string-append "release-" version))))
+       (sha256
+        (base32 "18m6a9asbwaslw418i2w04kgc6jgdpw01i3kawdqy903kw66hnhj"))))
+    (build-system meson-build-system)
+    (arguments
+     (list
+      #:build-type "release"
+      #:phases #~(modify-phases %standard-phases
+                   ;; Replaces hardcoded path with /gnu/store
+                   (add-after 'unpack 'path-patch
+                     (lambda _
+                       (substitute* '("meson.build")
+                         (("'/', 'etc', 'xdg'")
+                          (string-append "'"
+                                         #$output "'")))))
+
+                   ;; To wrap the paths for python and GTK
+                   (add-after 'install 'wrap-path
+                     (lambda* (#:key outputs #:allow-other-keys)
+                       (let* ((out (assoc-ref outputs "out"))
+                              (bin (string-append out "/bin/"))
+			      (gi-typelib-path (getenv "GI_TYPELIB_PATH"))
+                              (version #$(version-major+minor (package-version
+                                                               (this-package-input
+                                                                "python"))))
+                              (lib (string-append out "/lib/python" version
+                                                  "/site-packages")))
+                         (wrap-program (string-append bin "jack_mixer")
+                           `("GUIX_PYTHONPATH" ":" prefix
+                             (,(getenv "GUIX_PYTHONPATH") ,lib))
+			   `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))))))
+    (native-inputs
+     (list gcc-toolchain
+           pkg-config
+           python-cython
+           python-docutils
+           gnu-gettext
+           glib))
+    (propagated-inputs
+     (list gtk+
+	   `(,gtk+ "bin") ;; Required during runtime.
+	   python
+	   bash-minimal
+	   python-wrapper
+	   python-pygobject
+	   python-pycairo
+	   python-platformdirs ;; Required to save sessions.
+	   jack-2))
+    (synopsis
+     "JACK Mixer: A multi-channel audio mixer for the JACK Audio Connection Kit")
+    (description
+     "The jack_mixer is a GTK+ JACK audio mixer app with a look & handling
+similar to hardware mixing desks.  It has lot of useful features, apart
+from being able to mix multiple JACK audio streams.")
+    (home-page "https://rdio.space/jackmixer/")
+    (license license:gpl2+)))
+
 (define-public jalv
   (package
     (name "jalv")
-- 
2.46.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Divya Ranjan <divya <at> subvertising.org>
To: guix-patches <at> gnu.org
Cc: divya <at> subvertising.org
Subject: Re: [PATCH] Adding jack-mixer audio package
Date: Fri, 08 Nov 2024 00:08:33 +0000

[Message part 1 (text/plain, inline)]

Hello Guix devs,

Apologies, I forgot to `--annotate` the git send-email, the following patch adds the jack-mixer application to the `(gnu packages audio)`. It's a python package built with meson, I've tested it with my system and it is deterministic.

Let me know if any changes need to be done.

P.S: CC me, since I'm not subscribed to the mailing list.

Regards,


On 8 November 2024 00:01:01 GMT, Divya Ranjan <divya <at> subvertising.org> wrote:
>---
> gnu/packages/audio.scm | 68 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 68 insertions(+)
>
>diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
>index 467dc4a74f..70477d1071 100644
>--- a/gnu/packages/audio.scm
>+++ b/gnu/packages/audio.scm
>@@ -79,6 +79,7 @@ (define-module (gnu packages audio)
>   #:use-module (gnu packages check)
>   #:use-module (gnu packages cdrom)
>   #:use-module (gnu packages compression)
>+  #:use-module (gnu packages commencement)
>   #:use-module (gnu packages cpp)
>   #:use-module (gnu packages curl)
>   #:use-module (gnu packages dbm)
>@@ -160,6 +161,7 @@ (define-module (gnu packages audio)
>   #:use-module (guix build-system python)
>   #:use-module (guix build-system trivial)
>   #:use-module (guix build-system waf)
>+  #:use-module (guix build utils)
>   #:use-module (guix download)
>   #:use-module (guix gexp)
>   #:use-module (guix git-download)
>@@ -2772,6 +2774,72 @@ (define-public jacktrip
> audio signal streaming.")
>     (license (list license:gpl3+ license:lgpl3 license:expat))))
> 
>+(define-public jack-mixer
>+  (package
>+    (name "jack-mixer")
>+    (version "19")
>+    (source
>+     (origin
>+       (method git-fetch)
>+       (uri (git-reference
>+             (url "https://github.com/jack-mixer/jack_mixer")
>+             (commit (string-append "release-" version))))
>+       (sha256
>+        (base32 "18m6a9asbwaslw418i2w04kgc6jgdpw01i3kawdqy903kw66hnhj"))))
>+    (build-system meson-build-system)
>+    (arguments
>+     (list
>+      #:build-type "release"
>+      #:phases #~(modify-phases %standard-phases
>+                   ;; Replaces hardcoded path with /gnu/store
>+                   (add-after 'unpack 'path-patch
>+                     (lambda _
>+                       (substitute* '("meson.build")
>+                         (("'/', 'etc', 'xdg'")
>+                          (string-append "'"
>+                                         #$output "'")))))
>+
>+                   ;; To wrap the paths for python and GTK
>+                   (add-after 'install 'wrap-path
>+                     (lambda* (#:key outputs #:allow-other-keys)
>+                       (let* ((out (assoc-ref outputs "out"))
>+                              (bin (string-append out "/bin/"))
>+			      (gi-typelib-path (getenv "GI_TYPELIB_PATH"))
>+                              (version #$(version-major+minor (package-version
>+                                                               (this-package-input
>+                                                                "python"))))
>+                              (lib (string-append out "/lib/python" version
>+                                                  "/site-packages")))
>+                         (wrap-program (string-append bin "jack_mixer")
>+                           `("GUIX_PYTHONPATH" ":" prefix
>+                             (,(getenv "GUIX_PYTHONPATH") ,lib))
>+			   `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))))))
>+    (native-inputs
>+     (list gcc-toolchain
>+           pkg-config
>+           python-cython
>+           python-docutils
>+           gnu-gettext
>+           glib))
>+    (propagated-inputs
>+     (list gtk+
>+	   `(,gtk+ "bin") ;; Required during runtime.
>+	   python
>+	   bash-minimal
>+	   python-wrapper
>+	   python-pygobject
>+	   python-pycairo
>+	   python-platformdirs ;; Required to save sessions.
>+	   jack-2))
>+    (synopsis
>+     "JACK Mixer: A multi-channel audio mixer for the JACK Audio Connection Kit")
>+    (description
>+     "The jack_mixer is a GTK+ JACK audio mixer app with a look & handling
>+similar to hardware mixing desks.  It has lot of useful features, apart
>+from being able to mix multiple JACK audio streams.")
>+    (home-page "https://rdio.space/jackmixer/")
>+    (license license:gpl2+)))
>+
> (define-public jalv
>   (package
>     (name "jalv")
>-- 
>2.46.0
>

Divya Ranjan, Mathematics, Philosophy and Libre Software

[Message part 2 (text/html, inline)]

Message #11 received at 74251 <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: 74251 <at> debbugs.gnu.org
Cc: Divya Ranjan <divya <at> subvertising.org>
Subject: Re: [PATCH] Adding jack-mixer audio package
Date: Sat, 9 Nov 2024 19:20:42 +0100

Hi,

The commit message should follow the Changelog format as described the 
Submitting-Patches section of the manual.

That said:

> Hello Guix devs,
> 
> Apologies, I forgot to `--annotate` the git send-email, the following patch adds the jack-mixer application to the `(gnu packages audio)`. It's a python package built with meson, I've tested it with my system and it is deterministic.
> 
> Let me know if any changes need to be done.
> 
> P.S: CC me, since I'm not subscribed to the mailing list.
> 
> Regards,
> 
> 
> On 8 November 2024 00:01:01 GMT, Divya Ranjan <divya <at> subvertising.org> wrote:
> >---
> > gnu/packages/audio.scm | 68 ++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 68 insertions(+)
> >
> >diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> >index 467dc4a74f..70477d1071 100644
> >--- a/gnu/packages/audio.scm
> >+++ b/gnu/packages/audio.scm
> >@@ -79,6 +79,7 @@ (define-module (gnu packages audio)
> >   #:use-module (gnu packages check)
> >   #:use-module (gnu packages cdrom)
> >   #:use-module (gnu packages compression)
> >+  #:use-module (gnu packages commencement)

This is already included in the `build-system` so you don't need to add 
it. In fact, it breaks Guix when you do :)

> >   #:use-module (gnu packages cpp)
> >   #:use-module (gnu packages curl)
> >   #:use-module (gnu packages dbm)
> >@@ -160,6 +161,7 @@ (define-module (gnu packages audio)
> >   #:use-module (guix build-system python)
> >   #:use-module (guix build-system trivial)
> >   #:use-module (guix build-system waf)
> >+  #:use-module (guix build utils)
> >   #:use-module (guix download)
> >   #:use-module (guix gexp)
> >   #:use-module (guix git-download)
> >@@ -2772,6 +2774,72 @@ (define-public jacktrip
> > audio signal streaming.")
> >     (license (list license:gpl3+ license:lgpl3 license:expat))))
> > 
> >+(define-public jack-mixer
> >+  (package
> >+    (name "jack-mixer")
> >+    (version "19")
> >+    (source
> >+     (origin
> >+       (method git-fetch)
> >+       (uri (git-reference
> >+             (url "https://github.com/jack-mixer/jack_mixer")
> >+             (commit (string-append "release-" version))))
> >+       (sha256
> >+        (base32 "18m6a9asbwaslw418i2w04kgc6jgdpw01i3kawdqy903kw66hnhj"))))
> >+    (build-system meson-build-system)
> >+    (arguments
> >+     (list
> >+      #:build-type "release"
> >+      #:phases #~(modify-phases %standard-phases
> >+                   ;; Replaces hardcoded path with /gnu/store
> >+                   (add-after 'unpack 'path-patch
> >+                     (lambda _
> >+                       (substitute* '("meson.build")
> >+                         (("'/', 'etc', 'xdg'")
> >+                          (string-append "'"
> >+                                         #$output "'")))))
> >+
> >+                   ;; To wrap the paths for python and GTK
> >+                   (add-after 'install 'wrap-path
> >+                     (lambda* (#:key outputs #:allow-other-keys)
> >+                       (let* ((out (assoc-ref outputs "out"))
> >+                              (bin (string-append out "/bin/"))
> >+			      (gi-typelib-path (getenv "GI_TYPELIB_PATH"))
> >+                              (version #$(version-major+minor (package-version
> >+                                                               (this-package-input
> >+                                                                "python"))))
> >+                              (lib (string-append out "/lib/python" version
> >+                                                  "/site-packages")))
> >+                         (wrap-program (string-append bin "jack_mixer")
> >+                           `("GUIX_PYTHONPATH" ":" prefix
> >+                             (,(getenv "GUIX_PYTHONPATH") ,lib))
> >+			   `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))))))
> >+    (native-inputs
> >+     (list gcc-toolchain

As said, remove gcc-toolchain

> >+           pkg-config
> >+           python-cython
> >+           python-docutils
> >+           gnu-gettext
> >+           glib))
> >+    (propagated-inputs
> >+     (list gtk+
> >+	   `(,gtk+ "bin") ;; Required during runtime.
> >+	   python
> >+	   bash-minimal
> >+	   python-wrapper
> >+	   python-pygobject
> >+	   python-pycairo
> >+	   python-platformdirs ;; Required to save sessions.
> >+	   jack-2))
> >+    (synopsis
> >+     "JACK Mixer: A multi-channel audio mixer for the JACK Audio Connection Kit")
> >+    (description
> >+     "The jack_mixer is a GTK+ JACK audio mixer app with a look & handling
> >+similar to hardware mixing desks.  It has lot of useful features, apart
> >+from being able to mix multiple JACK audio streams.")
> >+    (home-page "https://rdio.space/jackmixer/")
> >+    (license license:gpl2+)))
> >+
> > (define-public jalv
> >   (package
> >     (name "jalv")
> >-- 
> >2.46.0

Also when running `./pre-inst-env guix lint jack-mixer` there are 
several problems with the package.

Some you can fix with `./pre-inst-env style jack-mixer` but some others 
you have to fix by hand:

	guix/gnu/packages/audio.scm:2777:2: jack-mixer <at> 19: 'gettext' should 
probably switched for its minimal variant
	gnu/packages/audio.scm:2777:2: jack-mixer <at> 19: "bash-minimal" should be 
in 'inputs' when 'wrap-program' is used
	...

Please, run the linter and fix the problems.

Thanks for the patch!

Message #14 received at 74251 <at> debbugs.gnu.org (full text, mbox):

From: Divya Ranjan <divya <at> subvertising.org>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: 74251 <at> debbugs.gnu.org
Subject: Re: [PATCH] Adding jack-mixer audio package
Date: Mon, 11 Nov 2024 01:17:07 +0000

[Message part 1 (text/plain, inline)]

Ekaitz Zarraga <ekaitz <at> elenq.tech> writes:

> Hi,
>
> The commit message should follow the Changelog format as described the
> Submitting-Patches section of the manual.
>
> That said:
>
>> Hello Guix devs,
>> Apologies, I forgot to `--annotate` the git send-email, the
>> following patch adds the jack-mixer application to the `(gnu
>> packages audio)`. It's a python package built with meson, I've
>> tested it with my system and it is deterministic.
>> Let me know if any changes need to be done.
>> P.S: CC me, since I'm not subscribed to the mailing list.
>> Regards,
>> On 8 November 2024 00:01:01 GMT, Divya Ranjan
>> <divya <at> subvertising.org> wrote:
>> >---
>> > gnu/packages/audio.scm | 68 ++++++++++++++++++++++++++++++++++++++++++
>> > 1 file changed, 68 insertions(+)
>> >
>> >diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
>> >index 467dc4a74f..70477d1071 100644
>> >--- a/gnu/packages/audio.scm
>> >+++ b/gnu/packages/audio.scm
>> >@@ -79,6 +79,7 @@ (define-module (gnu packages audio)
>> >   #:use-module (gnu packages check)
>> >   #:use-module (gnu packages cdrom)
>> >   #:use-module (gnu packages compression)
>> >+  #:use-module (gnu packages commencement)
>
> This is already included in the `build-system` so you don't need to
> add it. In fact, it breaks Guix when you do :)
>
>> >   #:use-module (gnu packages cpp)
>> >   #:use-module (gnu packages curl)
>> >   #:use-module (gnu packages dbm)
>> >@@ -160,6 +161,7 @@ (define-module (gnu packages audio)
>> >   #:use-module (guix build-system python)
>> >   #:use-module (guix build-system trivial)
>> >   #:use-module (guix build-system waf)
>> >+  #:use-module (guix build utils)
>> >   #:use-module (guix download)
>> >   #:use-module (guix gexp)
>> >   #:use-module (guix git-download)
>> >@@ -2772,6 +2774,72 @@ (define-public jacktrip
>> > audio signal streaming.")
>> >     (license (list license:gpl3+ license:lgpl3 license:expat))))
>> >  >+(define-public jack-mixer
>> >+  (package
>> >+    (name "jack-mixer")
>> >+    (version "19")
>> >+    (source
>> >+     (origin
>> >+       (method git-fetch)
>> >+       (uri (git-reference
>> >+             (url "https://github.com/jack-mixer/jack_mixer")
>> >+             (commit (string-append "release-" version))))
>> >+       (sha256
>> >+        (base32 "18m6a9asbwaslw418i2w04kgc6jgdpw01i3kawdqy903kw66hnhj"))))
>> >+    (build-system meson-build-system)
>> >+    (arguments
>> >+     (list
>> >+      #:build-type "release"
>> >+      #:phases #~(modify-phases %standard-phases
>> >+                   ;; Replaces hardcoded path with /gnu/store
>> >+                   (add-after 'unpack 'path-patch
>> >+                     (lambda _
>> >+                       (substitute* '("meson.build")
>> >+                         (("'/', 'etc', 'xdg'")
>> >+                          (string-append "'"
>> >+                                         #$output "'")))))
>> >+
>> >+                   ;; To wrap the paths for python and GTK
>> >+                   (add-after 'install 'wrap-path
>> >+                     (lambda* (#:key outputs #:allow-other-keys)
>> >+                       (let* ((out (assoc-ref outputs "out"))
>> >+                              (bin (string-append out "/bin/"))
>> >+			      (gi-typelib-path (getenv "GI_TYPELIB_PATH"))
>> >+                              (version #$(version-major+minor (package-version
>> >+                                                               (this-package-input
>> >+                                                                "python"))))
>> >+                              (lib (string-append out "/lib/python" version
>> >+                                                  "/site-packages")))
>> >+                         (wrap-program (string-append bin "jack_mixer")
>> >+                           `("GUIX_PYTHONPATH" ":" prefix
>> >+                             (,(getenv "GUIX_PYTHONPATH") ,lib))
>> >+			   `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))))))
>> >+    (native-inputs
>> >+     (list gcc-toolchain
>
> As said, remove gcc-toolchain
>
>> >+           pkg-config
>> >+           python-cython
>> >+           python-docutils
>> >+           gnu-gettext
>> >+           glib))
>> >+    (propagated-inputs
>> >+     (list gtk+
>> >+	   `(,gtk+ "bin") ;; Required during runtime.
>> >+	   python
>> >+	   bash-minimal
>> >+	   python-wrapper
>> >+	   python-pygobject
>> >+	   python-pycairo
>> >+	   python-platformdirs ;; Required to save sessions.
>> >+	   jack-2))
>> >+    (synopsis
>> >+     "JACK Mixer: A multi-channel audio mixer for the JACK Audio Connection Kit")
>> >+    (description
>> >+     "The jack_mixer is a GTK+ JACK audio mixer app with a look & handling
>> >+similar to hardware mixing desks.  It has lot of useful features, apart
>> >+from being able to mix multiple JACK audio streams.")
>> >+    (home-page "https://rdio.space/jackmixer/")
>> >+    (license license:gpl2+)))
>> >+
>> > (define-public jalv
>> >   (package
>> >     (name "jalv")
>> >--  >2.46.0
>
> Also when running `./pre-inst-env guix lint jack-mixer` there are
> several problems with the package.
>
> Some you can fix with `./pre-inst-env style jack-mixer` but some
> others you have to fix by hand:
>
> 	guix/gnu/packages/audio.scm:2777:2: jack-mixer <at> 19: 'gettext'
> 	should probably switched for its minimal variant
> 	gnu/packages/audio.scm:2777:2: jack-mixer <at> 19: "bash-minimal"
> 	should be in 'inputs' when 'wrap-program' is used
> 	...
>
> Please, run the linter and fix the problems.
>
> Thanks for the patch!
>

Thank you for reminding me about the linter issues and the fact that gcc stuff doesn’t need to be added, I’ve made the changes in the attached patch. Also, let me know if the commit message is okay.

Regards,

[0001-gnu-audio-Add-jack-mixer.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Divya Ranjan,
Philosophy, Mathematics, Libre Software.

Message #17 received at 74251 <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: Divya Ranjan <divya <at> subvertising.org>
Cc: 74251 <at> debbugs.gnu.org
Subject: Re: [PATCH] Adding jack-mixer audio package
Date: Mon, 11 Nov 2024 17:01:41 +0100

Hi,

> 
> Thank you for reminding me about the linter issues and the fact that gcc stuff doesn’t need to be added, I’ve made the changes in the attached patch. Also, let me know if the commit message is okay.
> 
> Regards,

The commit message is missing the body.
It should have something like:

* gnu/packages/audio.scm (jack-mixer): New variable.

Please add that and I'll do a further review.

Cheers,
Ekaitz

Message #20 received at 74251 <at> debbugs.gnu.org (full text, mbox):

From: Divya Ranjan <divya <at> subvertising.org>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: 74251 <at> debbugs.gnu.org
Subject: Re: [PATCH] Adding jack-mixer audio package
Date: Mon, 11 Nov 2024 16:18:06 +0000

[Message part 1 (text/plain, inline)]

Ekaitz Zarraga <ekaitz <at> elenq.tech> writes:

> Hi,
>
>> Thank you for reminding me about the linter issues and the fact that
>> gcc stuff doesn’t need to be added, I’ve made the changes in the
>> attached patch. Also, let me know if the commit message is okay.
>> Regards,
>
> The commit message is missing the body.
> It should have something like:
>
> * gnu/packages/audio.scm (jack-mixer): New variable.
>
> Please add that and I'll do a further review.
>
> Cheers,
> Ekaitz
>

Does this look good?

[0001-gnu-packages-audio.scm-jack-mixer-New-variable.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

Regards,
-- 
Divya Ranjan,
Philosophy, Mathematics, Libre Software.

Message #23 received at 74251 <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: Divya Ranjan <divya <at> subvertising.org>
Cc: 74251 <at> debbugs.gnu.org
Subject: Re: [PATCH] Adding jack-mixer audio package
Date: Mon, 11 Nov 2024 17:23:16 +0100

Sorry mate I didn't explain it properly.

The commit message has two parts: a title and a body.

The title you used before was correct, you were only missing the body. 
This is how the whole commit message should look like:

gnu: audio: Add jack-mixer

* gnu/packages/audio.scm (jack-mixer): New variable.

Message #26 received at 74251 <at> debbugs.gnu.org (full text, mbox):

From: Divya Ranjan <divya <at> subvertising.org>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: 74251 <at> debbugs.gnu.org
Subject: Re: [PATCH] Adding jack-mixer audio package
Date: Mon, 11 Nov 2024 16:32:40 +0000

[Message part 1 (text/plain, inline)]

Ekaitz Zarraga <ekaitz <at> elenq.tech> writes:

> Sorry mate I didn't explain it properly.
>
> The commit message has two parts: a title and a body.
>
> The title you used before was correct, you were only missing the
> body. This is how the whole commit message should look like:
>
> gnu: audio: Add jack-mixer
>
> * gnu/packages/audio.scm (jack-mixer): New variable.
>

Apologies I was confused with the title and the body, I usually only have titles in commit messages. Confirm if this one is appropriate.

[0001-gnu-audio-Add-jack-mixer.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

Regards,
-- 
Divya Ranjan,
Philosophy, Mathematics, Libre Software.

Message #29 received at 74251 <at> debbugs.gnu.org (full text, mbox):

From: Divya Ranjan <divya <at> subvertising.org>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: 74251 <at> debbugs.gnu.org
Subject: Re: [PATCH] Adding jack-mixer audio package
Date: Mon, 11 Nov 2024 19:42:24 +0000

[Message part 1 (text/plain, inline)]

Ekaitz Zarraga <ekaitz <at> elenq.tech> writes:

> Sorry mate I didn't explain it properly.
>
> The commit message has two parts: a title and a body.
>
> The title you used before was correct, you were only missing the
> body. This is how the whole commit message should look like:
>
> gnu: audio: Add jack-mixer
>
> * gnu/packages/audio.scm (jack-mixer): New variable.
>

Okay, I think this is the final patch.


Regards,

[0001-gnu-audio-Add-jack-mixer.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Divya Ranjan,
Philosophy, Mathematics, Libre Software.

Message #32 received at 74251 <at> debbugs.gnu.org (full text, mbox):

From: Divya Ranjan <divya <at> subvertising.org>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: 74251 <at> debbugs.gnu.org
Subject: Re: [PATCH] Adding jack-mixer audio package
Date: Mon, 11 Nov 2024 19:42:50 +0000

[Message part 1 (text/plain, inline)]

Ekaitz Zarraga <ekaitz <at> elenq.tech> writes:

> Sorry mate I didn't explain it properly.
>
> The commit message has two parts: a title and a body.
>
> The title you used before was correct, you were only missing the
> body. This is how the whole commit message should look like:
>
> gnu: audio: Add jack-mixer
>
> * gnu/packages/audio.scm (jack-mixer): New variable.
>

Okay, I think this is the final patch.


Regards,

[0001-gnu-audio-Add-jack-mixer.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Divya Ranjan,
Philosophy, Mathematics, Libre Software.

Message #35 received at 74251 <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: Divya Ranjan <divya <at> subvertising.org>
Cc: 74251 <at> debbugs.gnu.org
Subject: Re: [PATCH] Adding jack-mixer audio package
Date: Mon, 11 Nov 2024 22:19:06 +0100

On 2024-11-11 20:42, Divya Ranjan wrote:
> Ekaitz Zarraga <ekaitz <at> elenq.tech> writes:
> 
>> Sorry mate I didn't explain it properly.
>>
>> The commit message has two parts: a title and a body.
>>
>> The title you used before was correct, you were only missing the
>> body. This is how the whole commit message should look like:
>>
>> gnu: audio: Add jack-mixer
>>
>> * gnu/packages/audio.scm (jack-mixer): New variable.
>>
> 
> Okay, I think this is the final patch.
> 
> 
> Regards,

Yes, this is almost there but there are still a couple of warnings by 
`guix lint`:

	jack-mixer <at> 19: the source file name should contain the package name

This is complaining because when it clones the source code it is called 
"jack_mixer" but your package is called "jack-mixer" instead. You could 
fix it using something like this in the `origin`:

	(file-name (git-file-name name version))

If you add that and fix the indentation (you can use `guix style` for 
that), I think this is ready to go.

You are almost there!

PS: The other warning I think we can ignore for the moment. We have some 
other packages with the same warning I think it's because of the 
expansion of the `(,gtk+ "bin")

Message #38 received at 74251 <at> debbugs.gnu.org (full text, mbox):

From: Divya Ranjan <divya <at> subvertising.org>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: 74251 <at> debbugs.gnu.org
Subject: Re: [PATCH] Adding jack-mixer audio package
Date: Tue, 12 Nov 2024 01:21:57 +0000

[Message part 1 (text/plain, inline)]

Ekaitz Zarraga <ekaitz <at> elenq.tech> writes:

> On 2024-11-11 20:42, Divya Ranjan wrote:
>> Ekaitz Zarraga <ekaitz <at> elenq.tech> writes:
>> 
>>> Sorry mate I didn't explain it properly.
>>>
>>> The commit message has two parts: a title and a body.
>>>
>>> The title you used before was correct, you were only missing the
>>> body. This is how the whole commit message should look like:
>>>
>>> gnu: audio: Add jack-mixer
>>>
>>> * gnu/packages/audio.scm (jack-mixer): New variable.
>>>
>> Okay, I think this is the final patch.
>> Regards,
>
> Yes, this is almost there but there are still a couple of warnings by
> `guix lint`:
>
> 	jack-mixer <at> 19: the source file name should contain the package name
>
> This is complaining because when it clones the source code it is
> called "jack_mixer" but your package is called "jack-mixer"
> instead. You could fix it using something like this in the `origin`:
>
> 	(file-name (git-file-name name version))
>
> If you add that and fix the indentation (you can use `guix style` for
> that), I think this is ready to go.
>
> You are almost there!
>
> PS: The other warning I think we can ignore for the moment. We have
> some other packages with the same warning I think it's because of the
> expansion of the `(,gtk+ "bin")
>

Added the necessary changes.

Regards,

[0001-gnu-audio-Add-jack-mixer.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Divya Ranjan,
Philosophy, Mathematics, Libre Software.

Message #41 received at 74251 <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: control <at> debbugs.gnu.org, 74251 <at> debbugs.gnu.org
Subject: QA review for 74251
Date: Tue, 12 Nov 2024 11:42:44 +0100

user guix
usertag 74251 + reviewed-looks-good
thanks

Guix QA review form submission:


Items marked as checked: Lint warnings, Package builds, Commit messages, 
New package licenses, New package tests, New package synopsis and 
descriptions
-- 
ElenQ Technology

Message #44 received at 74251 <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: control <at> debbugs.gnu.org, 74251 <at> debbugs.gnu.org
Subject: QA review for 74251
Date: Tue, 12 Nov 2024 11:42:50 +0100

user guix
usertag 74251 + reviewed-looks-good
thanks

Guix QA review form submission:


Items marked as checked: Lint warnings, Package builds, Commit messages, 
New package licenses, New package tests, New package synopsis and 
descriptions
-- 
ElenQ Technology

Message #49 received at 74251-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 74251-done <at> debbugs.gnu.org
Subject: Close
Date: Wed, 13 Nov 2024 14:02:48 +0100

Pushed, thanks for the patch and the reviewing work!

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.