From unknown Sun Jun 15 01:08:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74236: emacs-guix: guix-command-popup not displaying argument improvers Resent-From: Christopher Howard Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 06 Nov 2024 23:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74236 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 74236@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173093713223113 (code B ref -1); Wed, 06 Nov 2024 23:53:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Nov 2024 23:52:12 +0000 Received: from localhost ([127.0.0.1]:46454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8pop-00060i-TZ for submit@debbugs.gnu.org; Wed, 06 Nov 2024 18:52:12 -0500 Received: from lists.gnu.org ([209.51.188.17]:36966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8pon-00060b-Pk for submit@debbugs.gnu.org; Wed, 06 Nov 2024 18:52:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8pon-0006kB-J2 for bug-guix@gnu.org; Wed, 06 Nov 2024 18:52:09 -0500 Received: from mx.kolabnow.com ([212.103.80.155]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8pok-0006XY-Ao for bug-guix@gnu.org; Wed, 06 Nov 2024 18:52:08 -0500 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id 8067E3007679 for ; Thu, 7 Nov 2024 00:51:56 +0100 (CET) Authentication-Results: ext-mx-out013.mykolab.com (amavis); dkim=pass (2048-bit key) reason="pass (just generated, assumed good)" header.d=kolabnow.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:date:date:subject:subject:from:from:received :received:received; s=dkim20240523; t=1730937113; x=1732751514; bh=U76aVP1ES0EO63scbbBVhf3RJ83fxjuhdWCj2slU038=; b=YnhZLBf3yrXG 0QVqUJYrP347/SqxFAavBVN7JIEXZVM3snp3iIc58sxZp7CS5pJr50uQygts7mk+ Uy+QsSR2JXhZjnmUSFmdff1aBsSnLzG79UBOomhT67KtxoWuq0HWfg9mLYyEytGV AWKll3lL7h6mxAdihNQ6TowGmUowh3e91AFGgOM3YVzTfAhgcdR7vQqAeMwPq48f h3CcQqg2Q4E4VTL7jJ9OecZGIPG8mHh/RUAKcyJ9thzAwoguVBpj9errHqk0o6Uk 3hl+YcjsPZVlD8DwOTZPEiI9AZiYmfILjiyPScgsBgSuc1r1vD9c2wGvVRoVLt1B omR2gS2KRg== X-Virus-Scanned: amavis at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-10 required=5 tests=[ALL_TRUSTED=-1] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out013.mykolab.com [127.0.0.1]) (amavis, port 10024) with ESMTP id 9LYNgoJ4k7GV for ; Thu, 7 Nov 2024 00:51:53 +0100 (CET) Received: from int-mx011.mykolab.com (unknown [10.9.13.11]) by mx.kolabnow.com (Postfix) with ESMTPS id 711A73007678 for ; Thu, 7 Nov 2024 00:51:52 +0100 (CET) Received: from ext-subm010.mykolab.com (unknown [10.9.6.10]) by int-mx011.mykolab.com (Postfix) with ESMTPS id 1D34B30C50E3 for ; Thu, 7 Nov 2024 00:51:52 +0100 (CET) From: Christopher Howard Date: Wed, 06 Nov 2024 14:51:49 -0900 Message-ID: <87pln7ncoa.fsf@librehacker.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: none client-ip=212.103.80.155; envelope-from=christopher@librehacker.com; helo=mx.kolabnow.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Note that to even display the guix-command-popup, you have to either set gu= ix-repl-use-server to nil, or apply the patch from bug#73462. The magit popup code for the guix-command-popup (M-x guix c) appears to be = broken so that it skips the popup menu where you would construct your comma= nd line argument. Instead, it assumes an empty argument, and jumps to the p= opup where you select whether you want to run the command in the REPL or fr= om a shell. This code is in guix-command.el, and uses the old magit-popup interface (no= w superceded by transient). Presumably either something has changed in magi= t-popup since the code was written (2015-2020) or some Emacs change has bro= ken guix-command.el. I hope to investigate this further. My hope is that so= me minor fix can be made to guix-command.el rather than having to rewrite e= verything for transient. One part I am fuzzy on is how to debug it as it is apparently not possible = to run edebug-instrument-function on guix-command-popup, as guix-command-po= pup is a function generated by other code. If anybody has any advice concer= ning this, that would be helpful. Testing this on GNU Emacs 30.0.92 (build 2, x86_64-pc-linux-gnu, GTK+ Versi= on 3.24.41, cairo version 1.18.0) of 2024-10-29. --=20 =F0=9F=93=9B Christopher Howard =F0=9F=9A=80 gemini://gem.librehacker.com =F0=9F=8C=90 http://gem.librehacker.com =D7=91=D7=A8=D7=90=D7=A9=D7=99=D7=AA =D7=91=D7=A8=D7=90 =D7=90=D7=9C=D7=94= =D7=99=D7=9D =D7=90=D7=AA =D7=94=D7=A9=D7=9E=D7=99=D7=9D =D7=95=D7=90=D7=AA= =D7=94=D7=90=D7=A8=D7=A5 From unknown Sun Jun 15 01:08:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74236: [PATCH] Tweaks command parsing regex to address debbugs bug#74236 References: <87pln7ncoa.fsf@librehacker.com> Resent-From: Christopher Howard Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 07 Nov 2024 21:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74236 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 74236@debbugs.gnu.org Cc: Katherine Cox-Buday , Liliana Marie Prikler , guix-patches@gnu.org, Andrew Tropin Received: via spool by submit@debbugs.gnu.org id=B.173101473819367 (code B ref -1); Thu, 07 Nov 2024 21:26:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Nov 2024 21:25:38 +0000 Received: from localhost ([127.0.0.1]:49806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9A0Y-00052J-5q for submit@debbugs.gnu.org; Thu, 07 Nov 2024 16:25:38 -0500 Received: from lists.gnu.org ([209.51.188.17]:57908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9A0V-000525-O4 for submit@debbugs.gnu.org; Thu, 07 Nov 2024 16:25:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9A0Q-0004ak-BS for guix-patches@gnu.org; Thu, 07 Nov 2024 16:25:30 -0500 Received: from mx.kolabnow.com ([212.103.80.155]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9A0O-0007hI-2c for guix-patches@gnu.org; Thu, 07 Nov 2024 16:25:30 -0500 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id 0F0C530E4C26; Thu, 7 Nov 2024 22:25:26 +0100 (CET) Authentication-Results: ext-mx-out013.mykolab.com (amavis); dkim=pass (2048-bit key) reason="pass (just generated, assumed good)" header.d=kolabnow.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-type:content-type:mime-version:message-id:date:date :in-reply-to:subject:subject:from:from:received:received :received; s=dkim20240523; t=1731014724; x=1732829125; bh=t1coI5 X8lVxmK5+QH+GD1H/sh5mL+iTZ39f895pM6Tk=; b=nxmfbd7gR+SVFVjBk1bmiV +MXffmrCuApe2t9osEtD20RhfuHCp7gsdu9Uv6jZASKPOp5c+jzp/xBVf8D+VvWn oipxIecQ5bJU6Y9Jky8F/dUufcsPAMaT2Mod0UAbOTKApbesjttBHWanU/3SWvnX 6gLb3N/Rbxa4Oi9g1TAJnZcHNaLp9901L9pU/lu7gHV6VepBb8CjaIzllMp+qviF qkIkYtJpYakAmZ0yFUkTbyF1f8OARYNuiK164S5X27wIYtvU9+dKFbXdObuPEN1j z7n6K/xAR8dDQ5xSLdI3w0zmI4MgnQc7c5m64ylYEi5kTStPjIQtWX4vCvPkzv9w == X-Virus-Scanned: amavis at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-10 required=5 tests=[ALL_TRUSTED=-1] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out013.mykolab.com [127.0.0.1]) (amavis, port 10024) with ESMTP id ZPMvlySqzCxA; Thu, 7 Nov 2024 22:25:24 +0100 (CET) Received: from int-mx011.mykolab.com (unknown [10.9.13.11]) by mx.kolabnow.com (Postfix) with ESMTPS id 92BE730E4C25; Thu, 7 Nov 2024 22:25:22 +0100 (CET) Received: from ext-subm010.mykolab.com (unknown [10.9.6.10]) by int-mx011.mykolab.com (Postfix) with ESMTPS id 070AF30CC0D6; Thu, 7 Nov 2024 22:25:22 +0100 (CET) From: Christopher Howard In-Reply-To: Christopher Howard's message of "Wed, 06 Nov 2024 14:51:49 -0900 (21 hours, 27 minutes, 34 seconds ago)" Date: Thu, 07 Nov 2024 12:25:18 -0900 Message-ID: <87o72q7n41.fsf@librehacker.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: none client-ip=212.103.80.155; envelope-from=christopher@librehacker.com; helo=mx.kolabnow.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-Tweaks-command-parsing-regex-to-address-debbugs-bug-.patch Content-Transfer-Encoding: quoted-printable Content-Description: 0001-Tweaks-command-parsing-regex-to-address-debbugs-bug-.patch >From faa152608c418086af8e79d4bb578de4243d8fd2 Mon Sep 17 00:00:00 2001 From: Christopher Howard Date: Thu, 7 Nov 2024 12:14:43 -0900 Subject: [PATCH] Tweaks command parsing regex to address debbugs bug#74236 --- elisp/guix-help-vars.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/elisp/guix-help-vars.el b/elisp/guix-help-vars.el index 0dc0bc6..b30938a 100644 --- a/elisp/guix-help-vars.el +++ b/elisp/guix-help-vars.el @@ -1,6 +1,7 @@ ;;; guix-help-vars.el --- Variables related to Guix --help output =20 ;; Copyright =C2=A9 2015, 2017, 2018 Alex Kost +;; Copyright =C2=A9 2024 Christopher Howard =20 ;; This file is part of Emacs-Guix. =20 @@ -42,7 +43,7 @@ "Common regexp used to find command options.") =20 (defvar guix-help-parse-command-regexp - (rx bol " " + (rx bol " " (group wordchar (one-or-more (or wordchar "-")))) "Regexp used to find guix commands. 'Command' means any option not prefixed with '-'. For example, --=20 2.46.0 --=-=-= Content-Type: text/plain See also bug#73462 for a patch which ideally would be applied first, but is not strictly speaking a prerequisite. -- Christopher Howard --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 10 11:51:01 2024 Received: (at control) by debbugs.gnu.org; 10 Dec 2024 16:51:02 +0000 Received: from localhost ([127.0.0.1]:59352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tL3Rt-0005u7-Ae for submit@debbugs.gnu.org; Tue, 10 Dec 2024 11:51:01 -0500 Received: from mail-wr1-f53.google.com ([209.85.221.53]:50297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tL3Rp-0005tE-Cz for control@debbugs.gnu.org; Tue, 10 Dec 2024 11:50:57 -0500 Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-382610c7116so3012845f8f.0 for ; Tue, 10 Dec 2024 08:50:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733849392; x=1734454192; darn=debbugs.gnu.org; h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=ZySUOS4fUxXqxZDo9BZwhSmklwSmXLIC5vJrmCYWyBs=; b=FAPiY+jIutHs75OJM9xMVlKdL9mF1OY5rC54QHUkhVnJ80gbgis8ybsXk9M7isJZSh DEtvbzZqMWpRFQI6HjJd/Mo7XyJYyzUxvMUTw2wCgIBrnH7t32pXzBiMG53JRfHnw2/y zlcr6yqnEh9pewnyBZ4Hk6vi69omvPJf6Y4OtqfFOoB5Dvx25B3BNElI8h9nOc7f2Ln2 zy8FyVning97jpd00FAEiO7ikRzD4aleLOJ186C8zeVsxa8IS1bUzeBqd4S8fn8q0PDq UYneZeL1s8b1mxQLmn6eaWqMKHmuyBoMAFa0sMaZ7zzTjAdHEoK+B7t3ZqVNpljcJXYI 9mEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733849392; x=1734454192; h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZySUOS4fUxXqxZDo9BZwhSmklwSmXLIC5vJrmCYWyBs=; b=em+JbDV0j3kuni9KVjClbyT4OCtxtJ1hFi1di5Or/g/qfY6SLIOMMxpjAFjpgCYy5z JUoIyK6PLed7Ec3/z8AoK3dqFS8o75Fpbg5/rKwi1EleIXb6uzo9d9OobEJqB0zc1FAf fhxoLTk2//uUmyXiy1+yqwLjtbpWtCD3UtqqVf3nqen8EoXRRMTtQ5m5F59HYu0pSf/2 KlG6t4RopOtsLdAXEQ9yDJtXhdUE9yjwKIwu4vIIselSLjwHebcbit/WoUppy5sHLgKO 4yhLGDVHZSg5M+TKNw0A+lCgGZsP5LEzlL1WU0VU6qFssHWXgOJHN4xLWsWhVzNTefIi Sqkg== X-Gm-Message-State: AOJu0YzluQjcqF8KUfDGQh+cQatdqXUm10oR5UtjbXdCGUcjSi3mw7ta OFYl7R2RyI1dAk8y/XoqTFDf3r5IT34oEPHA5nS29avYRPC+ffh3lvN2vA== X-Gm-Gg: ASbGncvl3KAWN22ITAVr+mRW1q1xFUl8gftNQS/CHAB87Lm42MSGrE9xMFOo8C3C7q6 DmifvpY8z66KcqNuDb842z5upXRVm7zspVCj5ZIFQAkmtc18wD7tFz0QTmR0t11+uKsTBUvtvUK X7RlcnyXExO28eGfDUZ1IBchS1mulxIWkKnoyWPHSv7jyNVJgNQLCGHwySAyWwu0282IC2atQyL S+5okwICIHnKyKFBOxpFXiYPgZETLmyfUQZ9A4tl75JY6Xqlw== X-Google-Smtp-Source: AGHT+IHHHJE610wGsni9OGlVdNKBTjGnSmubLBb5TW4KAKz96BvYhXEjHY4bfGyqHYxTIqG4pX63/A== X-Received: by 2002:a5d:6daa:0:b0:385:fac7:89ba with SMTP id ffacd0b85a97d-386453f9d59mr4342164f8f.47.1733849391725; Tue, 10 Dec 2024 08:49:51 -0800 (PST) Received: from lili ([148.60.59.223]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38621fbbc08sm16555888f8f.86.2024.12.10.08.49.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 08:49:51 -0800 (PST) Date: Tue, 10 Dec 2024 17:33:26 +0100 Message-Id: <87h67bxzu1.fsf@gmail.com> To: control@debbugs.gnu.org From: Simon Tournier Subject: control message for bug #74236 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 74236 + patch quit