From unknown Sat Aug 16 21:23:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options Resent-From: john muhl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Nov 2024 21:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 74235@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173092800921118 (code B ref -1); Wed, 06 Nov 2024 21:21:01 +0000 Received: (at submit) by debbugs.gnu.org; 6 Nov 2024 21:20:09 +0000 Received: from localhost ([127.0.0.1]:46243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8nRg-0005TW-Qz for submit@debbugs.gnu.org; Wed, 06 Nov 2024 16:20:09 -0500 Received: from lists.gnu.org ([209.51.188.17]:40624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8nRe-0005SM-AD for submit@debbugs.gnu.org; Wed, 06 Nov 2024 16:20:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8nRd-00082w-L8 for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2024 16:20:05 -0500 Received: from fhigh-b4-smtp.messagingengine.com ([202.12.124.155]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8nRb-0001YP-J1 for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2024 16:20:05 -0500 Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfhigh.stl.internal (Postfix) with ESMTP id 942AA254010F for ; Wed, 6 Nov 2024 16:19:59 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Wed, 06 Nov 2024 16:19:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to; s=fm3; t=1730927999; x=1731014399; bh=3Emet/PTuH gkO7U1k8acsweDxLPAlSlyGA4nRHWB/J8=; b=XHV2pjXom6adcda6Wui2VbcKAk ChAiBKsWkp9rmGyQEqj5Atys7fkc3V2luc+qdzPoVjceVNTE928IoLKO6sdaq1xt SlmjF6p3ltCIsmCXocbrhmTO8a+lP/4Nk6197QyT+J8DcHnY8hT5JU04lu7xD/WM iO/CKmzx8pYRHlat/6QrBwgZZmtCUaj4job/SbfRUTepM2JBZh5A1uPKhswuRR6c W4sm7xEi3Ma63G7erVWrkj3GzxX1FtDLzxL1cpv07xBzUcPlFvpZVtITzokGFo3v v7zLAZxxT+SE0Fn0jt8dSdPJ4glDsunDaW7M7y3mbt+8Fe/La48sFB8t4KPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1730927999; x=1731014399; bh=3Emet/PTuHgkO7U1k8acsweDxLPAlSlyGA4 nRHWB/J8=; b=hLtn6pMocWoL2bihhzGcknX830tE1YpF59V6MGYXDqellPMTsRm KdTKXX1bnx0mJWsWlINU+17i45Ii819I+WITBGkKOGBPMUhPCHSp5Cx/TKUmy9w/ COAL1qfecgpMglumP6nGi5cG3SPEvlZ5VrxVwQeCpz4wJ2IQQA9ea9eQmPlhEEQn JNqtG3VQi+zrLAj1EVtDugMfbM2JW955HtjeVkVdCO5KshTQZme89A7lR61VbYu4 83eyN8R6PxJneVAxxIp2xvKSo1e8OaqyeV33LmDW1pC5sDd0GFN8z+9GtdJ0mbJP oyfT7eDw3/qJSZKeeNOekdyenHVlAfDY3tw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrtddvgddugeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuff fkgggtgfesthhqredttddtjeenucfhrhhomhepjhhohhhnuchmuhhhlhcuoehjmhesphhu sgdrphhinhhkqeenucggtffrrghtthgvrhhnpeetuefhgfeuieejteekffejudettdeuue ekueffkeeileekueegleefkefhgefhueenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehjmhesphhusgdrphhinhhkpdhnsggprhgtphhtthhope dupdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghs sehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 6 Nov 2024 16:19:58 -0500 (EST) From: john muhl Date: Wed, 06 Nov 2024 15:19:52 -0600 Message-ID: <8734k4xdon.fsf@pub.pink> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=202.12.124.155; envelope-from=jm@pub.pink; helo=fhigh-b4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Tags: patch For some silly reason the lua-ts-{inferior,luacheck}-program options ended up with an option for =E2=80=9CNone=E2=80=9D. Obviously setti= ng your Lua interpreter or linter program to nil is not going to work. Any chance it could make it into emacs-30? Thanks. From unknown Sat Aug 16 21:23:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options Resent-From: john muhl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Nov 2024 21:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 74235@debbugs.gnu.org Received: via spool by 74235-submit@debbugs.gnu.org id=B74235.173092816321539 (code B ref 74235); Wed, 06 Nov 2024 21:23:01 +0000 Received: (at 74235) by debbugs.gnu.org; 6 Nov 2024 21:22:43 +0000 Received: from localhost ([127.0.0.1]:46250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8nUB-0005bK-CL for submit@debbugs.gnu.org; Wed, 06 Nov 2024 16:22:43 -0500 Received: from fout-b1-smtp.messagingengine.com ([202.12.124.144]:52939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8nU8-0005b7-I2 for 74235@debbugs.gnu.org; Wed, 06 Nov 2024 16:22:41 -0500 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfout.stl.internal (Postfix) with ESMTP id 26E361140196 for <74235@debbugs.gnu.org>; Wed, 6 Nov 2024 16:22:35 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Wed, 06 Nov 2024 16:22:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1730928155; x=1731014555; bh=b6mYgyqSO2 iLEbmedjP77WJOYZSjdzt+u2/IvkgVzBo=; b=dtuv6TcmvuBZuS7tTWKULXh7wL IrRMVlf61BE+eVnzGHK+EfdX8Y9SHNY47/q6Etw2U8MURfs2H85P06snjz3Q4Cnb OE9EDyyj0uquxCS/KttIOnPD4jK+OJ532q9YTJYIFqHznrPXgejpSA9FSDK57Jcu kEkGHL8+o/e4qRM7KZ2UYL38UxBEnJDTuULoJjGG9Z/BsuWSQuhWTRotRDt0zGjq zmDGMmjlATufZz3dRmQ6hWNeW0KAxW870A2MSW7rzdpG0kB2sPpkfNh+JfNHPuOS QWCKI/d0Zvx1KiWAi958FLK/FaMY+hNsixurkgrR0pB7j1NbQkTtxU3LPU+Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1730928155; x=1731014555; bh=b6mYgyqSO2iLEbmedjP77WJOYZSjdzt+u2/ IvkgVzBo=; b=SkSTh7fciZqGnd0PWWX7mWcvXE3MO0WJ7jA5j3WnhaTTN9kVj/+ G2QTP/kF9rLm7WcNRqS0eRlIS2PDFr6pbbuyMafYpHzKS/3JK8Uf7xeB1SQ1IYnS HinN7Dg5k3RcP+HGeYWMKFLVjW0TNPkygOoPAso1Fx+MU4N/Enoy6/vyOyozfgpV evCK9brrT+YzF5vxQ0144bi6VN5R3HmxTwnDzDCWmXHPTT39AB0Rd3ERoa4ITFSS kLf8z2DawpPtqW+tJCuLChpp854UR/A1hb4+EwixoziLryfs41Zk8eUA/zKvj/O9 hYqIEo3Ke+E7z5L/pH8A0YwNF2eIS+XCz6A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrtddvgddugeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffujg hffgffkfggtgesmhdtreertderjeenucfhrhhomhepjhhohhhnuchmuhhhlhcuoehjmhes phhusgdrphhinhhkqeenucggtffrrghtthgvrhhnpeettdejhefgveefuefhleffvdehud fhhfefgffgudevteevudffgefgtdegkeffkeenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehjmhesphhusgdrphhinhhkpdhnsggprhgtphhtth hopedupdhmohguvgepshhmthhpohhuthdprhgtphhtthhopeejgedvfeehseguvggssghu ghhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <74235@debbugs.gnu.org>; Wed, 6 Nov 2024 16:22:34 -0500 (EST) From: john muhl In-Reply-To: <8734k4xdon.fsf@pub.pink> (john muhl's message of "Wed, 06 Nov 2024 15:19:52 -0600") References: <8734k4xdon.fsf@pub.pink> User-Agent: mu4e 1.12.1; emacs 31.0.50 Date: Wed, 06 Nov 2024 15:22:34 -0600 Message-ID: <87ses4vyzp.fsf@pub.pink> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Remove-nil-from-some-lua-ts-mode-options.patch >From 9875334458c9b6820eeb1f5762c994e52cc9cdba Mon Sep 17 00:00:00 2001 From: john muhl Date: Wed, 6 Nov 2024 14:56:24 -0600 Subject: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options * lisp/progmodes/lua-ts-mode.el (lua-ts-luacheck-program): (lua-ts-inferior-program): Remove 'nil' as it is never a valid choice. (Bug#74235) --- lisp/progmodes/lua-ts-mode.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el index 20bc1f3e158..1ab0b29608f 100644 --- a/lisp/progmodes/lua-ts-mode.el +++ b/lisp/progmodes/lua-ts-mode.el @@ -72,7 +72,7 @@ lua-ts-indent-offset (defcustom lua-ts-luacheck-program "luacheck" "Location of the Luacheck program." - :type '(choice (const :tag "None" nil) string) + :type 'string :version "30.1") (defcustom lua-ts-inferior-buffer "*Lua*" @@ -83,7 +83,7 @@ lua-ts-inferior-buffer (defcustom lua-ts-inferior-program "lua" "Program to run in the inferior Lua process." - :type '(choice (const :tag "None" nil) string) + :type 'string :version "30.1") (defcustom lua-ts-inferior-options '("-i") -- 2.47.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable john muhl writes: > Tags: patch > > For some silly reason the lua-ts-{inferior,luacheck}-program > options ended up with an option for =E2=80=9CNone=E2=80=9D. Obviously set= ting your > Lua interpreter or linter program to nil is not going to work. > > Any chance it could make it into emacs-30? > > Thanks. --=-=-=-- From unknown Sat Aug 16 21:23:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Nov 2024 06:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: john muhl Cc: 74235@debbugs.gnu.org Received: via spool by 74235-submit@debbugs.gnu.org id=B74235.173095926918708 (code B ref 74235); Thu, 07 Nov 2024 06:02:01 +0000 Received: (at 74235) by debbugs.gnu.org; 7 Nov 2024 06:01:09 +0000 Received: from localhost ([127.0.0.1]:46903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8vZq-0004rd-30 for submit@debbugs.gnu.org; Thu, 07 Nov 2024 01:01:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8vZk-0004qz-Q8 for 74235@debbugs.gnu.org; Thu, 07 Nov 2024 01:01:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8vXZ-0002Ax-D2; Thu, 07 Nov 2024 00:58:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=bnr1QcvbA1q61YkUn36B6c0AgEZYZlqlahFSQdzSs10=; b=JaZyZ35oJkT16XTYuUKK 4068TipfIq4fN9tKGdvzL24+76mSg+ZdLH5MuS+W/ci2cuz+SycK9jjpgV1sluvdKUFeuVHEoGCgV qSPFjYpcMF8BeaiAySpVchIf1wGITa78RHf+j49O2Rhtm8BVjQZ3JHSWf5FZ7n4brmlJ4eKMjAkzS wzBUapg8563/bUZ8z44dKqgmRFtBIyDjvWWyeVV0OuU+jLDs1009+/iF491wDVma1ZoRJGm49XQcP QwiF5R5EchzohVm0djEu/OGmhmxlGjQrCj+zd9UX7+RA8nRlKrN555TacQlhjP/YSqY5Z/sFO2gDC BMEkPql4KC1j2Q==; Date: Thu, 07 Nov 2024 07:58:42 +0200 Message-Id: <86y11vr3e5.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87ses4vyzp.fsf@pub.pink> (message from john muhl on Wed, 06 Nov 2024 15:22:34 -0600) References: <8734k4xdon.fsf@pub.pink> <87ses4vyzp.fsf@pub.pink> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: john muhl > Date: Wed, 06 Nov 2024 15:22:34 -0600 > > * lisp/progmodes/lua-ts-mode.el (lua-ts-luacheck-program): > (lua-ts-inferior-program): Remove 'nil' as it is never a valid > choice. (Bug#74235) IMO, the use of these options in the code is not clean: if these programs are not installed, the commands which reference these options will signal errors whose diagnostic might not clearly indicate the root cause. I would like to see a cleaner handling of such contingencies by this mode. Does this make sense, and if so, would you like to suggest changes to that effect? > (defcustom lua-ts-luacheck-program "luacheck" > "Location of the Luacheck program." > - :type '(choice (const :tag "None" nil) string) > + :type 'string > :version "30.1") I think if we require this to be the name of a program, 'file' is a better value for :type, because it allows completion if the user types an absolute file name. > (defcustom lua-ts-inferior-buffer "*Lua*" > @@ -83,7 +83,7 @@ lua-ts-inferior-buffer > > (defcustom lua-ts-inferior-program "lua" > "Program to run in the inferior Lua process." > - :type '(choice (const :tag "None" nil) string) > + :type 'string > :version "30.1") > > (defcustom lua-ts-inferior-options '("-i") > -- > 2.47.0 > > john muhl writes: > > > Tags: patch > > > > For some silly reason the lua-ts-{inferior,luacheck}-program > > options ended up with an option for “None”. Obviously setting your > > Lua interpreter or linter program to nil is not going to work. > > > > Any chance it could make it into emacs-30? lua-ts-mode is new in Emacs 30, so we can install these changes on the release branch, as a stopgap. But I'd like to see a cleaner solution installed later, even if we decide to install that on master due to its complexity. Thanks. From unknown Sat Aug 16 21:23:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options Resent-From: john muhl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Nov 2024 15:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 74235@debbugs.gnu.org Received: via spool by 74235-submit@debbugs.gnu.org id=B74235.173099189214963 (code B ref 74235); Thu, 07 Nov 2024 15:05:02 +0000 Received: (at 74235) by debbugs.gnu.org; 7 Nov 2024 15:04:52 +0000 Received: from localhost ([127.0.0.1]:49227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9443-0003tG-OK for submit@debbugs.gnu.org; Thu, 07 Nov 2024 10:04:52 -0500 Received: from fhigh-b7-smtp.messagingengine.com ([202.12.124.158]:48501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9441-0003sx-V2 for 74235@debbugs.gnu.org; Thu, 07 Nov 2024 10:04:50 -0500 Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailfhigh.stl.internal (Postfix) with ESMTP id 6BC0F254009B; Thu, 7 Nov 2024 10:04:44 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-08.internal (MEProxy); Thu, 07 Nov 2024 10:04:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1730991884; x=1731078284; bh=9hR++o5VjIOiYawdbMpnvpDL33hRvkroHXBPsRtn2gg=; b= YKgeZRwEXwEVjW5Sy6VZwaxJGqNNv2NkvisEpzcIzD3k+REqy9uCZzmTcUr4ujmG VKleQ8XpMZy9bLdCi0ZcdJV7LfK35fzXYORusgzRi6SseGgF5P+mzKBqxQkkGeDj uJheXoTlukj1uqlFothvMiZPo5RLaBbNrj3/WY1vbHQgW/skPzPvB62NNpSwhjRO VZhMlfTcbmtDrHnfXo/rE/flzyoCc7kGguS3yrd/bTki5+23uMuj5IDw5pSL2Kfc 8ZM+PEvXazB6OjztLzusAlBSQdeeLPpYNIker327WJOmfvKTPNE1mIkuRJ+t73V3 p1vHs/vEJ1gF4PLgQLGxrg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1730991884; x= 1731078284; bh=9hR++o5VjIOiYawdbMpnvpDL33hRvkroHXBPsRtn2gg=; b=U A6sucENPZJzkucBQ8q2vi3S9QOSHlbzKpI/6om10C2WW3ZtNqPQB7+dMp94fFU8J MphFVZ6IqFd/SC8ACCsyT6f3vngJZQZGLV8iGcqwL7WECbO0HSvJrAle6lNdbTN/ brkfdZkLYWCeTbd9IsbuZeNaQEQmQ2lbtjnWn8okF8uFM4du9+nLE5S0Kz3h+hhk IlV4wjiSbe3dMzF1gzV5gaFiqTow0GPLLtYrbgl8L7+n5nUkHm2RQEscYBYLKaiR 3Gfb8uUbp9UIBTLYiYjN6uF/USX3jW7B10QKpib9ykENe0jPwprtsywZyDdua0t/ o7f/TO8w7sJuXHcVXJn5A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrtdeggdejudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtgfesthhqredttderjeen ucfhrhhomhepjhhohhhnuchmuhhhlhcuoehjmhesphhusgdrphhinhhkqeenucggtffrrg htthgvrhhnpeegveehvddttedvkeduvddttdehhfdvgffgvdfgiedtjeduhefhffejtddv veevkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hjmhesphhusgdrphhinhhkpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhu thdprhgtphhtthhopeejgedvfeehseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpth htohepvghlihiisehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Nov 2024 10:04:43 -0500 (EST) From: john muhl In-Reply-To: <86y11vr3e5.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Nov 2024 07:58:42 +0200") References: <8734k4xdon.fsf@pub.pink> <87ses4vyzp.fsf@pub.pink> <86y11vr3e5.fsf@gnu.org> User-Agent: mu4e 1.12.1; emacs 31.0.50 Date: Thu, 07 Nov 2024 09:04:42 -0600 Message-ID: <87zfmbozjp.fsf@pub.pink> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: john muhl >> Date: Wed, 06 Nov 2024 15:22:34 -0600 >>=20 >> * lisp/progmodes/lua-ts-mode.el (lua-ts-luacheck-program): >> (lua-ts-inferior-program): Remove 'nil' as it is never a valid >> choice. (Bug#74235) > > IMO, the use of these options in the code is not clean: if these > programs are not installed, the commands which reference these options > will signal errors whose diagnostic might not clearly indicate the > root cause. I would like to see a cleaner handling of such > contingencies by this mode. Does this make sense, and if so, would > you like to suggest changes to that effect? Good point. I=E2=80=99ll work on that very soon. >> (defcustom lua-ts-luacheck-program "luacheck" >> "Location of the Luacheck program." >> - :type '(choice (const :tag "None" nil) string) >> + :type 'string >> :version "30.1") > > I think if we require this to be the name of a program, 'file' is a > better value for :type, because it allows completion if the user types > an absolute file name. Makes sense. >> (defcustom lua-ts-inferior-buffer "*Lua*" >> @@ -83,7 +83,7 @@ lua-ts-inferior-buffer >>=20=20 >> (defcustom lua-ts-inferior-program "lua" >> "Program to run in the inferior Lua process." >> - :type '(choice (const :tag "None" nil) string) >> + :type 'string >> :version "30.1") >>=20=20 >> (defcustom lua-ts-inferior-options '("-i") >> --=20 >> 2.47.0 >>=20 >> john muhl writes: >>=20 >> > Tags: patch >> > >> > For some silly reason the lua-ts-{inferior,luacheck}-program >> > options ended up with an option for =E2=80=9CNone=E2=80=9D. Obviously = setting your >> > Lua interpreter or linter program to nil is not going to work. >> > >> > Any chance it could make it into emacs-30? > > lua-ts-mode is new in Emacs 30, so we can install these changes on the > release branch, as a stopgap. But I'd like to see a cleaner solution > installed later, even if we decide to install that on master due to > its complexity. > > Thanks. Then let=E2=80=99s put this one on hold and I=E2=80=99ll work on the improv= ements you suggest. Hopefully it doesn=E2=80=99t require significant changes and we can skip the stopgap and get it all into 30. Thanks for the help. From unknown Sat Aug 16 21:23:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options Resent-From: john muhl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Nov 2024 14:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 74235@debbugs.gnu.org Received: via spool by 74235-submit@debbugs.gnu.org id=B74235.17310778669241 (code B ref 74235); Fri, 08 Nov 2024 14:58:02 +0000 Received: (at 74235) by debbugs.gnu.org; 8 Nov 2024 14:57:46 +0000 Received: from localhost ([127.0.0.1]:51689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9QQj-0002Oz-UE for submit@debbugs.gnu.org; Fri, 08 Nov 2024 09:57:46 -0500 Received: from fout-a6-smtp.messagingengine.com ([103.168.172.149]:55109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9QQi-0002Og-1G for 74235@debbugs.gnu.org; Fri, 08 Nov 2024 09:57:45 -0500 Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfout.phl.internal (Postfix) with ESMTP id F335013800F4; Fri, 8 Nov 2024 09:57:38 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Fri, 08 Nov 2024 09:57:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1731077858; x=1731164258; bh=2DCwPgqv7qyRAMC6PPd3/mu6L5dXx1NiOXrPxIV7UW8=; b= C58G1X5ZLIPHFa0/eBGb8FGLtpVM4rfitSe13c8n8+V2ODZjg25J3hETbzDaGmtn PpA7QX8KPJ+eTtZiq+b79KYuH0o+igrayEkE2NmENUMA2vaEKS5TVGoaBRseizvI y7RKXbuD+niF6WC8tpIo2/AqKieavd4+NLafcg+HpVH8Qp0JIEplScd7mECqOqT3 nDUQTndky9d2tht4zzd0xKiPrlJbcAK037PLhRRgfEcmBZTVm8ZapsF6YkesPm+b BjV/rAeU+pYgIABMT8O92qsOuheDMMQR6v5M1lxdHwRaZ2fIQijQshUC+TJ2qghe A7MXKyUkX/uHBcJbMSBPTA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731077858; x= 1731164258; bh=2DCwPgqv7qyRAMC6PPd3/mu6L5dXx1NiOXrPxIV7UW8=; b=Q o7RA5Mh/je/LSp/2vR/hbnp5SroxZbVhgfdiKADTit/7UqJ9hwnWmb9x8un73mmZ BB8z2At+hZ2KIzAMg8dKBhQy3e06LujLe+dWVFaC6mqSEqf9CQzcXK5XMZh+hW7G SpNb0YqtduVhAhOd8yojrkDc4N3A6bK7j4wY7jwWayFCEnjQYSEXgwkM7jgcuXr9 WsQ9htDKJRs+qAEFbCBad1yoMrJgMkzm2AlRcs8bmnSKSVhbKtauqgUJUTNV+MB/ kokhQlQaBCMBYL5gmB0274wQt2S6l3hS0u14etBBPUmhVZmIj0iWn5Sv3PsSxjsn wpTnDBleRjjcxzryyWT5Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrtdeigdeijecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtgfesthhqredttderjeen ucfhrhhomhepjhhohhhnuchmuhhhlhcuoehjmhesphhusgdrphhinhhkqeenucggtffrrg htthgvrhhnpeegveehvddttedvkeduvddttdehhfdvgffgvdfgiedtjeduhefhffejtddv veevkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hjmhesphhusgdrphhinhhkpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhu thdprhgtphhtthhopeejgedvfeehseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpth htohepvghlihiisehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Nov 2024 09:57:38 -0500 (EST) From: john muhl In-Reply-To: <86y11vr3e5.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Nov 2024 07:58:42 +0200") References: <8734k4xdon.fsf@pub.pink> <87ses4vyzp.fsf@pub.pink> <86y11vr3e5.fsf@gnu.org> User-Agent: mu4e 1.12.1; emacs 31.0.50 Date: Fri, 08 Nov 2024 08:57:37 -0600 Message-ID: <87ldxtn57i.fsf@pub.pink> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: john muhl >> Date: Wed, 06 Nov 2024 15:22:34 -0600 >>=20 >> * lisp/progmodes/lua-ts-mode.el (lua-ts-luacheck-program): >> (lua-ts-inferior-program): Remove 'nil' as it is never a valid >> choice. (Bug#74235) > > IMO, the use of these options in the code is not clean: if these > programs are not installed, the commands which reference these options > will signal errors whose diagnostic might not clearly indicate the > root cause. I would like to see a cleaner handling of such > contingencies by this mode. Does this make sense, and if so, would > you like to suggest changes to that effect? The only idea I=E2=80=99ve come up with so far is showing a warning that mentions the incorrectly set option. Does that sound like what you have in mind? If not I=E2=80=99d appreciate some more explicit guidance. Thanks. From unknown Sat Aug 16 21:23:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Nov 2024 15:27:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: john muhl Cc: 74235@debbugs.gnu.org Received: via spool by 74235-submit@debbugs.gnu.org id=B74235.173107960514642 (code B ref 74235); Fri, 08 Nov 2024 15:27:03 +0000 Received: (at 74235) by debbugs.gnu.org; 8 Nov 2024 15:26:45 +0000 Received: from localhost ([127.0.0.1]:51732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9Qsn-0003o6-AA for submit@debbugs.gnu.org; Fri, 08 Nov 2024 10:26:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9Qsl-0003ns-Aj for 74235@debbugs.gnu.org; Fri, 08 Nov 2024 10:26:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9QqY-0002Zp-Vp; Fri, 08 Nov 2024 10:24:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=bBbdNjGOskS5lZJ6WweDbWqicaDo2iZ98E/3JpJzZ0s=; b=fDW2G01I0jYh6WNfpPPq 2xQNmYxXjvxjPg+T/eyjNPMu4t1saH5kLKIRdwEkhgqr8ELysWoLNro20+GgkElji1tjXZ2JE30p8 nIGTm9ZGkcE3kJqemGAT8Ph73VsUC241qEz8IJ1suUXWI5nQER+CjUpnGK4ded9nD39c6SN1RqY33 G4A5zEDqMtHMmbn8QwyzzIjgCR/AwTdhXmBJzb2bdkfQDrJtedwMVacofVgaTgfGo1sinKXWL+xu2 Zey4EL0B2B8CGJm91gPZu2E9mXrhewBbJJH9Ozs3pr4z+3K1rL0lTNZEE71QezJ/0CGL1hTys6ATl EGIgE3M6ibG4IQ==; Date: Fri, 08 Nov 2024 17:24:04 +0200 Message-Id: <86ses1oijv.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87ldxtn57i.fsf@pub.pink> (message from john muhl on Fri, 08 Nov 2024 08:57:37 -0600) References: <8734k4xdon.fsf@pub.pink> <87ses4vyzp.fsf@pub.pink> <86y11vr3e5.fsf@gnu.org> <87ldxtn57i.fsf@pub.pink> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: john muhl > Cc: 74235@debbugs.gnu.org > Date: Fri, 08 Nov 2024 08:57:37 -0600 > > Eli Zaretskii writes: > > >> From: john muhl > >> Date: Wed, 06 Nov 2024 15:22:34 -0600 > >> > >> * lisp/progmodes/lua-ts-mode.el (lua-ts-luacheck-program): > >> (lua-ts-inferior-program): Remove 'nil' as it is never a valid > >> choice. (Bug#74235) > > > > IMO, the use of these options in the code is not clean: if these > > programs are not installed, the commands which reference these options > > will signal errors whose diagnostic might not clearly indicate the > > root cause. I would like to see a cleaner handling of such > > contingencies by this mode. Does this make sense, and if so, would > > you like to suggest changes to that effect? > > The only idea I’ve come up with so far is showing a warning that > mentions the incorrectly set option. Does that sound like what you > have in mind? If not I’d appreciate some more explicit guidance. How about signaling user-error from the commands that invoke those programs, when they are missing? From unknown Sat Aug 16 21:23:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options Resent-From: john muhl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Nov 2024 20:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 74235@debbugs.gnu.org Received: via spool by 74235-submit@debbugs.gnu.org id=B74235.173118569827800 (code B ref 74235); Sat, 09 Nov 2024 20:55:02 +0000 Received: (at 74235) by debbugs.gnu.org; 9 Nov 2024 20:54:58 +0000 Received: from localhost ([127.0.0.1]:54620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9sTx-0007EK-VR for submit@debbugs.gnu.org; Sat, 09 Nov 2024 15:54:58 -0500 Received: from fhigh-b8-smtp.messagingengine.com ([202.12.124.159]:51807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9sTu-0007Dz-Lk for 74235@debbugs.gnu.org; Sat, 09 Nov 2024 15:54:56 -0500 Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfhigh.stl.internal (Postfix) with ESMTP id DBC1C254014E; Sat, 9 Nov 2024 15:54:48 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Sat, 09 Nov 2024 15:54:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1731185688; x=1731272088; bh=T0HZjnT+R3 rAoLIlW6WU2igFuZHYksVYBmEciFK2PyY=; b=FN570z/jPOO1rVoZdTgCg/R91A J69E+3+2IFxsg7S20jlJfDu17w6KekICghyv/TLIwSlbe5Dq0+Y1mvqRqE6R1Fkt HkcZbKnxxaTnlzkk+LV/JmUQQexo0QVkCmgXl1oAcISJol7Z8r6CQz1fqXtR6Vvh lFxowyNsPW8m29VfgzEcU7slWhZxFK0OlOeW612iZnwAypj/tCUHpNPsbAkiv2aG 99Y4qtlyJ74YOvSLVAQzjDBVrlllMBC+H23LNuC7/vHGrJExhk+n3tRQ1I17Le2G DpNmNi9aOtFJCDliAzFSfXX9QjW7uzyao2VbPJi8ib8zvZGJ5ah3Q8KtcP4Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1731185688; x=1731272088; bh=T0HZjnT+R3rAoLIlW6WU2igFuZHYksVYBmE ciFK2PyY=; b=f5AgAQJinZyuocpvRuwU2KLKQDS4G+/mIq45l4Ahy5DHmieTBLe txMYfsxaThQCsT+e5kMxYZCBo0edlEyMrWWjkRWBAhp22xrRQPy35J1nMm2iznme gXnjySZoBDC9GrzNP8yMDstQWwv1JkvX8+ENwFMNHuOGe7373tIfV1GorawAHsI7 uqpBXUtPOpbfNzv3VFLRiXRlm/f+R5iG0ioJderZjByrPJkh4F8a95l9zJiAMMvg 90yotPbjRrUABbG3fpTsA0PExGlvl2835MaIQXwzLyiD59Fqi32+ENZLItqvmnGp 5tZiR3LQlV4lsD0XDs4pclPcOcOUJ+QpBCg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrtdekgddugedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffgffkfggtgesmhdtreertderjeen ucfhrhhomhepjhhohhhnuchmuhhhlhcuoehjmhesphhusgdrphhinhhkqeenucggtffrrg htthgvrhhnpeehkeeiudffvefhieelueduleelvddtjeevtdetgefgieelhfehieekleef ffffteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hjmhesphhusgdrphhinhhkpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhu thdprhgtphhtthhopeejgedvfeehseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpth htohepvghlihiisehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 9 Nov 2024 15:54:48 -0500 (EST) From: john muhl In-Reply-To: <86ses1oijv.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 08 Nov 2024 17:24:04 +0200") References: <8734k4xdon.fsf@pub.pink> <87ses4vyzp.fsf@pub.pink> <86y11vr3e5.fsf@gnu.org> <87ldxtn57i.fsf@pub.pink> <86ses1oijv.fsf@gnu.org> User-Agent: mu4e 1.12.1; emacs 31.0.50 Date: Sat, 09 Nov 2024 14:54:47 -0600 Message-ID: <87ikswi0vc.fsf@pub.pink> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> From: john muhl >> Cc: 74235@debbugs.gnu.org >> Date: Fri, 08 Nov 2024 08:57:37 -0600 >>=20 >> Eli Zaretskii writes: >>=20 >> >> From: john muhl >> >> Date: Wed, 06 Nov 2024 15:22:34 -0600 >> >>=20 >> >> * lisp/progmodes/lua-ts-mode.el (lua-ts-luacheck-program): >> >> (lua-ts-inferior-program): Remove 'nil' as it is never a valid >> >> choice. (Bug#74235) >> > >> > IMO, the use of these options in the code is not clean: if these >> > programs are not installed, the commands which reference these options >> > will signal errors whose diagnostic might not clearly indicate the >> > root cause. I would like to see a cleaner handling of such >> > contingencies by this mode. Does this make sense, and if so, would >> > you like to suggest changes to that effect? >>=20 >> The only idea I=E2=80=99ve come up with so far is showing a warning that >> mentions the incorrectly set option. Does that sound like what you >> have in mind? If not I=E2=80=99d appreciate some more explicit guidance. > > How about signaling user-error from the commands that invoke those > programs, when they are missing? Agree that=E2=80=99s better than a warning. It seems flymake already handles the case where it can=E2=80=99t find the requested program so I left that part as is. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-some-lua-ts-mode-options-Bug-74235.patch >From 3e49aa1086f2498ccbad396cf8c799c57919847e Mon Sep 17 00:00:00 2001 From: john muhl Date: Sat, 9 Nov 2024 11:01:45 -0600 Subject: [PATCH] ; Fix some 'lua-ts-mode' options (Bug#74235) * lisp/progmodes/lua-ts-mode.el (lua-ts-luacheck-program): (lua-ts-inferior-program): Switch to 'file' type and remove 'nil' as a choice. (lua-ts-inferior-lua): Ensure 'lua-ts-inferior-program' is a valid executable. --- lisp/progmodes/lua-ts-mode.el | 85 ++++++++++++++++++----------------- 1 file changed, 44 insertions(+), 41 deletions(-) diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el index 4ea453c9b65..2323461ed4c 100644 --- a/lisp/progmodes/lua-ts-mode.el +++ b/lisp/progmodes/lua-ts-mode.el @@ -72,7 +72,7 @@ lua-ts-indent-offset (defcustom lua-ts-luacheck-program "luacheck" "Location of the Luacheck program." - :type '(choice (const :tag "None" nil) string) + :type 'file :version "30.1") (defcustom lua-ts-inferior-buffer "*Lua*" @@ -83,7 +83,7 @@ lua-ts-inferior-buffer (defcustom lua-ts-inferior-program "lua" "Program to run in the inferior Lua process." - :type '(choice (const :tag "None" nil) string) + :type 'file :version "30.1") (defcustom lua-ts-inferior-options '("-i") @@ -632,47 +632,50 @@ lua-ts-flymake-luacheck (defun lua-ts-inferior-lua () "Run a Lua interpreter in an inferior process." (interactive) - (unless (comint-check-proc lua-ts-inferior-buffer) - (apply #'make-comint-in-buffer - (string-replace "*" "" lua-ts-inferior-buffer) - lua-ts-inferior-buffer - lua-ts-inferior-program - lua-ts-inferior-startfile - lua-ts-inferior-options) - (when lua-ts-inferior-history + (if (or (not lua-ts-inferior-program) + (not (executable-find lua-ts-inferior-program))) + (user-error "You must set `lua-ts-inferior-program' to use this command") + (unless (comint-check-proc lua-ts-inferior-buffer) + (apply #'make-comint-in-buffer + (string-replace "*" "" lua-ts-inferior-buffer) + lua-ts-inferior-buffer + lua-ts-inferior-program + lua-ts-inferior-startfile + lua-ts-inferior-options) + (when lua-ts-inferior-history (set-process-sentinel (get-buffer-process lua-ts-inferior-buffer) 'lua-ts-inferior--write-history)) - (with-current-buffer lua-ts-inferior-buffer - (setq-local comint-input-ignoredups t - comint-input-ring-file-name lua-ts-inferior-history - comint-prompt-read-only t - comint-prompt-regexp (rx-to-string `(: bol - ,lua-ts-inferior-prompt - (1+ space)))) - (comint-read-input-ring t) - (add-hook 'comint-preoutput-filter-functions - (lambda (string) - (if (equal string (concat lua-ts-inferior-prompt-continue " ")) - string - (concat - ;; Filter out the extra prompt characters that - ;; accumulate in the output when sending regions - ;; to the inferior process. - (replace-regexp-in-string (rx-to-string - `(: bol - (* ,lua-ts-inferior-prompt - (? ,lua-ts-inferior-prompt) - (1+ space)) - (group (* nonl)))) - "\\1" string) - ;; Re-add the prompt for the next line. - lua-ts-inferior-prompt " "))) - nil t))) - (select-window (display-buffer lua-ts-inferior-buffer - '((display-buffer-reuse-window - display-buffer-pop-up-window) - (reusable-frames . t)))) - (get-buffer-process (current-buffer))) + (with-current-buffer lua-ts-inferior-buffer + (setq-local comint-input-ignoredups t + comint-input-ring-file-name lua-ts-inferior-history + comint-prompt-read-only t + comint-prompt-regexp (rx-to-string `(: bol + ,lua-ts-inferior-prompt + (1+ space)))) + (comint-read-input-ring t) + (add-hook 'comint-preoutput-filter-functions + (lambda (string) + (if (equal string (concat lua-ts-inferior-prompt-continue " ")) + string + (concat + ;; Filter out the extra prompt characters that + ;; accumulate in the output when sending regions + ;; to the inferior process. + (replace-regexp-in-string + (rx-to-string `(: bol + (* ,lua-ts-inferior-prompt + (? ,lua-ts-inferior-prompt) + (1+ space)) + (group (* nonl)))) + "\\1" string) + ;; Re-add the prompt for the next line. + lua-ts-inferior-prompt " "))) + nil t))) + (select-window (display-buffer lua-ts-inferior-buffer + '((display-buffer-reuse-window + display-buffer-pop-up-window) + (reusable-frames . t)))) + (get-buffer-process (current-buffer)))) (defun lua-ts-send-buffer () "Send current buffer to the inferior Lua process." -- 2.47.0 --=-=-=-- From unknown Sat Aug 16 21:23:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Nov 2024 05:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: john muhl Cc: 74235@debbugs.gnu.org Received: via spool by 74235-submit@debbugs.gnu.org id=B74235.173121742121892 (code B ref 74235); Sun, 10 Nov 2024 05:44:02 +0000 Received: (at 74235) by debbugs.gnu.org; 10 Nov 2024 05:43:41 +0000 Received: from localhost ([127.0.0.1]:55254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tA0jc-0005h2-VY for submit@debbugs.gnu.org; Sun, 10 Nov 2024 00:43:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tA0ja-0005gm-9g for 74235@debbugs.gnu.org; Sun, 10 Nov 2024 00:43:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tA0jU-0004cB-Jh; Sun, 10 Nov 2024 00:43:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ryM6SHSeKyYJjyVMAS4rZR3vtWclRiSs9v0sl6h7KBA=; b=IrggwKqV29Ax IouzEx29ktnheZ9Lx8fg/axBzww8wmY3uusT6dUfO4MjGBKz9rN33FF5dtLewCCcnLL64pZ1zOUfi WvxlZpKJGJqXiV6RgIsMIef5VE5l3+NjswJlmLfUDoi9JU+WDu8WhWdjXHIbnBrgqIJRzsWAfI9k9 jQjHYVgpctO8f4actOiTwYfcWEyoMrCY8OK/wbki2wuBf6moT/BF07t3kyV1YdH8hn5tHogY1q7R/ YZ7QZxJxUTAg5CzewXpNsWrUdqv2QgMgjMEhsFSmjY6hEhCGkrnLRJg0Z6u4U2ASxDU32GSaksy6G LdF4X4BIWw2bns4uZr+oIw==; Date: Sun, 10 Nov 2024 07:43:28 +0200 Message-Id: <86r07jlk3j.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87ikswi0vc.fsf@pub.pink> (message from john muhl on Sat, 09 Nov 2024 14:54:47 -0600) References: <8734k4xdon.fsf@pub.pink> <87ses4vyzp.fsf@pub.pink> <86y11vr3e5.fsf@gnu.org> <87ldxtn57i.fsf@pub.pink> <86ses1oijv.fsf@gnu.org> <87ikswi0vc.fsf@pub.pink> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: john muhl > Cc: 74235@debbugs.gnu.org > Date: Sat, 09 Nov 2024 14:54:47 -0600 > > + (if (or (not lua-ts-inferior-program) > + (not (executable-find lua-ts-inferior-program))) > + (user-error "You must set `lua-ts-inferior-program' to use this command") The text of user-error should say something about being unable to find the program, not just about the variable being nil, since you use executable-find. Otherwise, LGTM, thanks. From unknown Sat Aug 16 21:23:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Nov 2024 05:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: john muhl Cc: Eli Zaretskii , 74235@debbugs.gnu.org Received: via spool by 74235-submit@debbugs.gnu.org id=B74235.173121753122442 (code B ref 74235); Sun, 10 Nov 2024 05:46:02 +0000 Received: (at 74235) by debbugs.gnu.org; 10 Nov 2024 05:45:31 +0000 Received: from localhost ([127.0.0.1]:55263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tA0lO-0005pt-DF for submit@debbugs.gnu.org; Sun, 10 Nov 2024 00:45:30 -0500 Received: from mout01.posteo.de ([185.67.36.65]:53121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tA0lL-0005pe-An for 74235@debbugs.gnu.org; Sun, 10 Nov 2024 00:45:28 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 71393240027 for <74235@debbugs.gnu.org>; Sun, 10 Nov 2024 06:45:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1731217521; bh=zRbLR1lFFu3Br8Xspl0yfRc5/tY+STXsDGM04UQOXiQ=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=c0DjqwWXxZFNiHzUo4qbiabITHHgjzxrjn8leCbPxlin4TIrVfTMSN3HUTnfMXsUe 81brtvCjcsfCmAhrIybhziXkrglC4zczEihIezf2N3q95hggmT51FU1YpClIBxKEei W6/A5R4WlxOURXCUEvIn8OT3NftKesXF+K3JuXI52CJWm+FI2xZ2qVz+iili2Gc5p7 UGyipZDd9m0vOvYQCKkph7sK9LLbTiBHT/WkBaB2haybm6sTAyradeBlfgm/XqYm6D Ukx2MIWgzah1IENR0dkq4BZqGph0R4dgTpMhD/A9xSA5NjUZPhR5hILEb69Ounr1Ig fRK3nmL+Ngirw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XmM8b1Zt4z9rxD; Sun, 10 Nov 2024 06:45:18 +0100 (CET) From: Philip Kaludercic In-Reply-To: <87ikswi0vc.fsf@pub.pink> (john muhl's message of "Sat, 09 Nov 2024 14:54:47 -0600") References: <8734k4xdon.fsf@pub.pink> <87ses4vyzp.fsf@pub.pink> <86y11vr3e5.fsf@gnu.org> <87ldxtn57i.fsf@pub.pink> <86ses1oijv.fsf@gnu.org> <87ikswi0vc.fsf@pub.pink> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Date: Sun, 10 Nov 2024 05:45:14 +0000 Message-ID: <87y11r3amt.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) john muhl writes: > Eli Zaretskii writes: > >>> From: john muhl >>> Cc: 74235@debbugs.gnu.org >>> Date: Fri, 08 Nov 2024 08:57:37 -0600 >>>=20 >>> Eli Zaretskii writes: >>>=20 >>> >> From: john muhl >>> >> Date: Wed, 06 Nov 2024 15:22:34 -0600 >>> >>=20 >>> >> * lisp/progmodes/lua-ts-mode.el (lua-ts-luacheck-program): >>> >> (lua-ts-inferior-program): Remove 'nil' as it is never a valid >>> >> choice. (Bug#74235) >>> > >>> > IMO, the use of these options in the code is not clean: if these >>> > programs are not installed, the commands which reference these options >>> > will signal errors whose diagnostic might not clearly indicate the >>> > root cause. I would like to see a cleaner handling of such >>> > contingencies by this mode. Does this make sense, and if so, would >>> > you like to suggest changes to that effect? >>>=20 >>> The only idea I=E2=80=99ve come up with so far is showing a warning that >>> mentions the incorrectly set option. Does that sound like what you >>> have in mind? If not I=E2=80=99d appreciate some more explicit guidance. >> >> How about signaling user-error from the commands that invoke those >> programs, when they are missing? > > Agree that=E2=80=99s better than a warning. It seems flymake already > handles the case where it can=E2=80=99t find the requested program so I > left that part as is. > > From 3e49aa1086f2498ccbad396cf8c799c57919847e Mon Sep 17 00:00:00 2001 > From: john muhl > Date: Sat, 9 Nov 2024 11:01:45 -0600 > Subject: [PATCH] ; Fix some 'lua-ts-mode' options (Bug#74235) > > * lisp/progmodes/lua-ts-mode.el (lua-ts-luacheck-program): > (lua-ts-inferior-program): Switch to 'file' type and remove 'nil' > as a choice. > (lua-ts-inferior-lua): Ensure 'lua-ts-inferior-program' is a > valid executable. > --- > lisp/progmodes/lua-ts-mode.el | 85 ++++++++++++++++++----------------- > 1 file changed, 44 insertions(+), 41 deletions(-) > > diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el > index 4ea453c9b65..2323461ed4c 100644 > --- a/lisp/progmodes/lua-ts-mode.el > +++ b/lisp/progmodes/lua-ts-mode.el > @@ -72,7 +72,7 @@ lua-ts-indent-offset >=20=20 > (defcustom lua-ts-luacheck-program "luacheck" > "Location of the Luacheck program." > - :type '(choice (const :tag "None" nil) string) > + :type 'file > :version "30.1") >=20=20 > (defcustom lua-ts-inferior-buffer "*Lua*" > @@ -83,7 +83,7 @@ lua-ts-inferior-buffer >=20=20 > (defcustom lua-ts-inferior-program "lua" > "Program to run in the inferior Lua process." > - :type '(choice (const :tag "None" nil) string) > + :type 'file > :version "30.1") >=20=20 > (defcustom lua-ts-inferior-options '("-i") > @@ -632,47 +632,50 @@ lua-ts-flymake-luacheck > (defun lua-ts-inferior-lua () > "Run a Lua interpreter in an inferior process." > (interactive) > - (unless (comint-check-proc lua-ts-inferior-buffer) > - (apply #'make-comint-in-buffer > - (string-replace "*" "" lua-ts-inferior-buffer) > - lua-ts-inferior-buffer > - lua-ts-inferior-program > - lua-ts-inferior-startfile > - lua-ts-inferior-options) > - (when lua-ts-inferior-history > + (if (or (not lua-ts-inferior-program) > + (not (executable-find lua-ts-inferior-program))) > + (user-error "You must set `lua-ts-inferior-program' to use this co= mmand") Isn't this error message misleading as `lua-ts-inferior-program' can be set (as it is by default), but the executable couldn't be located (which isn't a mistake by the user, but just due to Lua not being installed)? > + (unless (comint-check-proc lua-ts-inferior-buffer) > + (apply #'make-comint-in-buffer > + (string-replace "*" "" lua-ts-inferior-buffer) > + lua-ts-inferior-buffer > + lua-ts-inferior-program > + lua-ts-inferior-startfile > + lua-ts-inferior-options) > + (when lua-ts-inferior-history > (set-process-sentinel (get-buffer-process lua-ts-inferior-buffer) > 'lua-ts-inferior--write-history)) > - (with-current-buffer lua-ts-inferior-buffer > - (setq-local comint-input-ignoredups t > - comint-input-ring-file-name lua-ts-inferior-history > - comint-prompt-read-only t > - comint-prompt-regexp (rx-to-string `(: bol > - ,lua-ts-inferio= r-prompt > - (1+ space)))) > - (comint-read-input-ring t) > - (add-hook 'comint-preoutput-filter-functions > - (lambda (string) > - (if (equal string (concat lua-ts-inferior-prompt-conti= nue " ")) > - string > - (concat > - ;; Filter out the extra prompt characters that > - ;; accumulate in the output when sending regions > - ;; to the inferior process. > - (replace-regexp-in-string (rx-to-string > - `(: bol > - (* ,lua-ts-inferior-= prompt > - (? ,lua-ts-inferi= or-prompt) > - (1+ space)) > - (group (* nonl)))) > - "\\1" string) > - ;; Re-add the prompt for the next line. > - lua-ts-inferior-prompt " "))) > - nil t))) > - (select-window (display-buffer lua-ts-inferior-buffer > - '((display-buffer-reuse-window > - display-buffer-pop-up-window) > - (reusable-frames . t)))) > - (get-buffer-process (current-buffer))) > + (with-current-buffer lua-ts-inferior-buffer > + (setq-local comint-input-ignoredups t > + comint-input-ring-file-name lua-ts-inferior-history > + comint-prompt-read-only t > + comint-prompt-regexp (rx-to-string `(: bol > + ,lua-ts-infer= ior-prompt > + (1+ space)))) This should be equivalent to (rx bol (literal lua-ts-inferior-prompt) (1+ space)) that macroexpands to (concat "^" (regexp-quote inferior-lisp-program) "[[:space:]]+") without the need to load rx at run-time. > + (comint-read-input-ring t) > + (add-hook 'comint-preoutput-filter-functions > + (lambda (string) > + (if (equal string (concat lua-ts-inferior-prompt-con= tinue " ")) > + string > + (concat > + ;; Filter out the extra prompt characters that > + ;; accumulate in the output when sending regions > + ;; to the inferior process. > + (replace-regexp-in-string > + (rx-to-string `(: bol > + (* ,lua-ts-inferior-prompt > + (? ,lua-ts-inferior-prompt) > + (1+ space)) > + (group (* nonl)))) > + "\\1" string) > + ;; Re-add the prompt for the next line. > + lua-ts-inferior-prompt " "))) > + nil t))) > + (select-window (display-buffer lua-ts-inferior-buffer > + '((display-buffer-reuse-window > + display-buffer-pop-up-window) > + (reusable-frames . t)))) > + (get-buffer-process (current-buffer)))) >=20=20 > (defun lua-ts-send-buffer () > "Send current buffer to the inferior Lua process." --=20 Philip Kaludercic on siskin From unknown Sat Aug 16 21:23:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options Resent-From: john muhl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Nov 2024 14:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 74235@debbugs.gnu.org Received: via spool by 74235-submit@debbugs.gnu.org id=B74235.173125013021241 (code B ref 74235); Sun, 10 Nov 2024 14:49:02 +0000 Received: (at 74235) by debbugs.gnu.org; 10 Nov 2024 14:48:50 +0000 Received: from localhost ([127.0.0.1]:56277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tA9FB-0005WW-VJ for submit@debbugs.gnu.org; Sun, 10 Nov 2024 09:48:50 -0500 Received: from fhigh-b3-smtp.messagingengine.com ([202.12.124.154]:58443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tA9F9-0005WF-6S for 74235@debbugs.gnu.org; Sun, 10 Nov 2024 09:48:48 -0500 Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfhigh.stl.internal (Postfix) with ESMTP id 67C8525400F2; Sun, 10 Nov 2024 09:48:41 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Sun, 10 Nov 2024 09:48:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1731250121; x=1731336521; bh=NH9FK9nw2e 7x7LQ/EEWxjg93zPlxd0sGNZZAh2fWy4w=; b=cSM85UjpqVzeaUVtRetNiXGJvR 9eH0jT7wHSPNPWhcNqJlF1W2TuRoCMvoFgcmtZ7Ms2uqbkxLiQ2EN/ypaBXgIenz SNUBhA5GP7j3r2pWHMgLTAmliuFHOyppxZQdrpOU2smjzK3eUpW1vRZiyWhPMSDh aiTw5CbG0jcRO9VzSh3vfINm0KZ3jnEOGtySY/VguCUmkk5u94H6oJsM48V6Sxo+ H9d6tf4S/V5vgS2bnjc11kSDuMMtnThT//1Ky9Ac2ofHYaySa5ypULUHdc9mFQOB OUWLWEktBlV7KPW1TsnzLwheI+Lq/QSZBKmn3Zi2eIYIoGFYfA/jB0gRJWSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1731250121; x=1731336521; bh=NH9FK9nw2e7x7LQ/EEWxjg93zPlxd0sGNZZ Ah2fWy4w=; b=IFutub1iSdU5n26RZ+42Y41y9BOQJftle5o/FbAfleGGGbqzcUZ cmfbFLtPe5Lu9zqlNRlLajzEaOkwOabEKBT9W7Vuwuj13i8XmWyyxJRUyUarlUmB h1oxlkVm3wHnAwCQ/fCWBOxH7cJ3fPgaI4i3lDTr2PmkF+Ll/qcDe8AL8FRU+t8E qRw5e0tLYyH5jex9YTilDlIzzYOYmkSn0hrDO4Q76vtCrAQHIVtFCRihHQWd1P3e pKi7anIJxh9gUJuTxZoBFsa2VdNt+vUsRWdQ14nDJD0idqaZbHNKQYklDVXrUvK6 Z4vIzC9V0aQHr/2BsjUnRjrkamjREL/yH2w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddtgdeijecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtsehmtderredtreejnecu hfhrohhmpehjohhhnhcumhhuhhhluceojhhmsehpuhgsrdhpihhnkheqnecuggftrfgrth htvghrnhepheekieduffevhfeileeuudelledvtdejvedtteeggfeilefhheeikeelfeff ffetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjh hmsehpuhgsrdhpihhnkhdpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhht pdhrtghpthhtohepjeegvdefheesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtth hopegvlhhiiiesghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 10 Nov 2024 09:48:40 -0500 (EST) From: john muhl In-Reply-To: <86r07jlk3j.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 10 Nov 2024 07:43:28 +0200") References: <8734k4xdon.fsf@pub.pink> <87ses4vyzp.fsf@pub.pink> <86y11vr3e5.fsf@gnu.org> <87ldxtn57i.fsf@pub.pink> <86ses1oijv.fsf@gnu.org> <87ikswi0vc.fsf@pub.pink> <86r07jlk3j.fsf@gnu.org> User-Agent: mu4e 1.12.1; emacs 31.0.50 Date: Sun, 10 Nov 2024 08:48:39 -0600 Message-ID: <87y11r87qw.fsf@pub.pink> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> From: john muhl >> Cc: 74235@debbugs.gnu.org >> Date: Sat, 09 Nov 2024 14:54:47 -0600 >>=20 >> + (if (or (not lua-ts-inferior-program) >> + (not (executable-find lua-ts-inferior-program))) >> + (user-error "You must set `lua-ts-inferior-program' to use this c= ommand") > > The text of user-error should say something about being unable to find > the program, not just about the variable being nil, since you use > executable-find. > > Otherwise, LGTM, thanks. I guess the executable-find check is redundant anyway since comint/process will tell you =E2=80=9CSearching for program: No such file or directory, luaz=E2=80=9D if you get it wrong. Thanks again. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-some-lua-ts-mode-options-Bug-74235.patch >From b170e406f834806842761726de47ca3afeb05cfe Mon Sep 17 00:00:00 2001 From: john muhl Date: Sat, 9 Nov 2024 11:01:45 -0600 Subject: [PATCH] ; Fix some 'lua-ts-mode' options (Bug#74235) * lisp/progmodes/lua-ts-mode.el (lua-ts-luacheck-program): (lua-ts-inferior-program): Switch to 'file' type and remove 'nil' as a choice. (lua-ts-inferior-lua): Ensure 'lua-ts-inferior-program' is set. --- lisp/progmodes/lua-ts-mode.el | 84 ++++++++++++++++++----------------- 1 file changed, 43 insertions(+), 41 deletions(-) diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el index 4ea453c9b65..a7763377177 100644 --- a/lisp/progmodes/lua-ts-mode.el +++ b/lisp/progmodes/lua-ts-mode.el @@ -72,7 +72,7 @@ lua-ts-indent-offset (defcustom lua-ts-luacheck-program "luacheck" "Location of the Luacheck program." - :type '(choice (const :tag "None" nil) string) + :type 'file :version "30.1") (defcustom lua-ts-inferior-buffer "*Lua*" @@ -83,7 +83,7 @@ lua-ts-inferior-buffer (defcustom lua-ts-inferior-program "lua" "Program to run in the inferior Lua process." - :type '(choice (const :tag "None" nil) string) + :type 'file :version "30.1") (defcustom lua-ts-inferior-options '("-i") @@ -632,47 +632,49 @@ lua-ts-flymake-luacheck (defun lua-ts-inferior-lua () "Run a Lua interpreter in an inferior process." (interactive) - (unless (comint-check-proc lua-ts-inferior-buffer) - (apply #'make-comint-in-buffer - (string-replace "*" "" lua-ts-inferior-buffer) - lua-ts-inferior-buffer - lua-ts-inferior-program - lua-ts-inferior-startfile - lua-ts-inferior-options) - (when lua-ts-inferior-history + (if (not lua-ts-inferior-program) + (user-error "You must set `lua-ts-inferior-program' to use this command") + (unless (comint-check-proc lua-ts-inferior-buffer) + (apply #'make-comint-in-buffer + (string-replace "*" "" lua-ts-inferior-buffer) + lua-ts-inferior-buffer + lua-ts-inferior-program + lua-ts-inferior-startfile + lua-ts-inferior-options) + (when lua-ts-inferior-history (set-process-sentinel (get-buffer-process lua-ts-inferior-buffer) 'lua-ts-inferior--write-history)) - (with-current-buffer lua-ts-inferior-buffer - (setq-local comint-input-ignoredups t - comint-input-ring-file-name lua-ts-inferior-history - comint-prompt-read-only t - comint-prompt-regexp (rx-to-string `(: bol - ,lua-ts-inferior-prompt - (1+ space)))) - (comint-read-input-ring t) - (add-hook 'comint-preoutput-filter-functions - (lambda (string) - (if (equal string (concat lua-ts-inferior-prompt-continue " ")) - string - (concat - ;; Filter out the extra prompt characters that - ;; accumulate in the output when sending regions - ;; to the inferior process. - (replace-regexp-in-string (rx-to-string - `(: bol - (* ,lua-ts-inferior-prompt - (? ,lua-ts-inferior-prompt) - (1+ space)) - (group (* nonl)))) - "\\1" string) - ;; Re-add the prompt for the next line. - lua-ts-inferior-prompt " "))) - nil t))) - (select-window (display-buffer lua-ts-inferior-buffer - '((display-buffer-reuse-window - display-buffer-pop-up-window) - (reusable-frames . t)))) - (get-buffer-process (current-buffer))) + (with-current-buffer lua-ts-inferior-buffer + (setq-local comint-input-ignoredups t + comint-input-ring-file-name lua-ts-inferior-history + comint-prompt-read-only t + comint-prompt-regexp (rx-to-string `(: bol + ,lua-ts-inferior-prompt + (1+ space)))) + (comint-read-input-ring t) + (add-hook 'comint-preoutput-filter-functions + (lambda (string) + (if (equal string (concat lua-ts-inferior-prompt-continue " ")) + string + (concat + ;; Filter out the extra prompt characters that + ;; accumulate in the output when sending regions + ;; to the inferior process. + (replace-regexp-in-string + (rx-to-string `(: bol + (* ,lua-ts-inferior-prompt + (? ,lua-ts-inferior-prompt) + (1+ space)) + (group (* nonl)))) + "\\1" string) + ;; Re-add the prompt for the next line. + lua-ts-inferior-prompt " "))) + nil t))) + (select-window (display-buffer lua-ts-inferior-buffer + '((display-buffer-reuse-window + display-buffer-pop-up-window) + (reusable-frames . t)))) + (get-buffer-process (current-buffer)))) (defun lua-ts-send-buffer () "Send current buffer to the inferior Lua process." -- 2.47.0 --=-=-=-- From unknown Sat Aug 16 21:23:54 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: john muhl Subject: bug#74235: closed (Re: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options) Message-ID: References: <8634jukyqt.fsf@gnu.org> <8734k4xdon.fsf@pub.pink> X-Gnu-PR-Message: they-closed 74235 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 74235@debbugs.gnu.org Date: Thu, 14 Nov 2024 08:27:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1731572822-3430-1" This is a multi-part message in MIME format... ------------=_1731572822-3430-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 74235@debbugs.gnu.org. --=20 74235: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74235 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1731572822-3430-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 74235-done) by debbugs.gnu.org; 14 Nov 2024 08:26:39 +0000 Received: from localhost ([127.0.0.1]:44917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBVBW-0000sV-Rc for submit@debbugs.gnu.org; Thu, 14 Nov 2024 03:26:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBVBV-0000sH-4p for 74235-done@debbugs.gnu.org; Thu, 14 Nov 2024 03:26:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBVBO-0001GQ-1G; Thu, 14 Nov 2024 03:26:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=B6oMtMImB7D9wHQeCk/yP9A3+WcKz/XVe8Y6TdCm318=; b=HScOfbVXI8mLCVZkK6U0 6xGaF3M/lVr0UFM372LGwmkYc3+VT0s7gs6Iz5NkJl96s4FWKVMrakiYNCtN5sH1b7ULNm83j75XJ Ftuk0Rib4u3PFRs5aH1eNp185Pt4SIb90vQvsRSqSu0IJ65ZBS4EkMSOgxV1JjsIFrwlykoAJclWM keQc4dqXVSMp3vcc90NvLgsV2zxLF1POvI/vgN8Ye38FK2d5k9KfUVFkkZ7COnf0Be7JuDCbMsGpt Pc3lpr2DenJBGuOqvxmDwbTMHggI3fObDciJOud6YO1rBnoudfj+OrPFnRFNxHNYhbXpPpHBGf9OQ FxF0GYVNr85S0g==; Date: Thu, 14 Nov 2024 10:26:02 +0200 Message-Id: <8634jukyqt.fsf@gnu.org> From: Eli Zaretskii To: john muhl In-Reply-To: <87y11r87qw.fsf@pub.pink> (message from john muhl on Sun, 10 Nov 2024 08:48:39 -0600) Subject: Re: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options References: <8734k4xdon.fsf@pub.pink> <87ses4vyzp.fsf@pub.pink> <86y11vr3e5.fsf@gnu.org> <87ldxtn57i.fsf@pub.pink> <86ses1oijv.fsf@gnu.org> <87ikswi0vc.fsf@pub.pink> <86r07jlk3j.fsf@gnu.org> <87y11r87qw.fsf@pub.pink> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74235-done Cc: 74235-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: john muhl > Cc: 74235@debbugs.gnu.org > Date: Sun, 10 Nov 2024 08:48:39 -0600 > > Eli Zaretskii writes: > > >> From: john muhl > >> Cc: 74235@debbugs.gnu.org > >> Date: Sat, 09 Nov 2024 14:54:47 -0600 > >> > >> + (if (or (not lua-ts-inferior-program) > >> + (not (executable-find lua-ts-inferior-program))) > >> + (user-error "You must set `lua-ts-inferior-program' to use this command") > > > > The text of user-error should say something about being unable to find > > the program, not just about the variable being nil, since you use > > executable-find. > > > > Otherwise, LGTM, thanks. > > I guess the executable-find check is redundant anyway since > comint/process will tell you “Searching for program: No such file > or directory, luaz” if you get it wrong. Thanks, installed on the emacs-30 branch, and closing the bug. Btw, I noticed that you are marking with ";" the log entries of changes which should definitely appear in the produced ChangeLog. Is this on purpose, or did you misunderstand the meaning of the semi-colon in the first line of the commit log messages? ------------=_1731572822-3430-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Nov 2024 21:20:09 +0000 Received: from localhost ([127.0.0.1]:46243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8nRg-0005TW-Qz for submit@debbugs.gnu.org; Wed, 06 Nov 2024 16:20:09 -0500 Received: from lists.gnu.org ([209.51.188.17]:40624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8nRe-0005SM-AD for submit@debbugs.gnu.org; Wed, 06 Nov 2024 16:20:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8nRd-00082w-L8 for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2024 16:20:05 -0500 Received: from fhigh-b4-smtp.messagingengine.com ([202.12.124.155]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8nRb-0001YP-J1 for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2024 16:20:05 -0500 Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfhigh.stl.internal (Postfix) with ESMTP id 942AA254010F for ; Wed, 6 Nov 2024 16:19:59 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Wed, 06 Nov 2024 16:19:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to; s=fm3; t=1730927999; x=1731014399; bh=3Emet/PTuH gkO7U1k8acsweDxLPAlSlyGA4nRHWB/J8=; b=XHV2pjXom6adcda6Wui2VbcKAk ChAiBKsWkp9rmGyQEqj5Atys7fkc3V2luc+qdzPoVjceVNTE928IoLKO6sdaq1xt SlmjF6p3ltCIsmCXocbrhmTO8a+lP/4Nk6197QyT+J8DcHnY8hT5JU04lu7xD/WM iO/CKmzx8pYRHlat/6QrBwgZZmtCUaj4job/SbfRUTepM2JBZh5A1uPKhswuRR6c W4sm7xEi3Ma63G7erVWrkj3GzxX1FtDLzxL1cpv07xBzUcPlFvpZVtITzokGFo3v v7zLAZxxT+SE0Fn0jt8dSdPJ4glDsunDaW7M7y3mbt+8Fe/La48sFB8t4KPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1730927999; x=1731014399; bh=3Emet/PTuHgkO7U1k8acsweDxLPAlSlyGA4 nRHWB/J8=; b=hLtn6pMocWoL2bihhzGcknX830tE1YpF59V6MGYXDqellPMTsRm KdTKXX1bnx0mJWsWlINU+17i45Ii819I+WITBGkKOGBPMUhPCHSp5Cx/TKUmy9w/ COAL1qfecgpMglumP6nGi5cG3SPEvlZ5VrxVwQeCpz4wJ2IQQA9ea9eQmPlhEEQn JNqtG3VQi+zrLAj1EVtDugMfbM2JW955HtjeVkVdCO5KshTQZme89A7lR61VbYu4 83eyN8R6PxJneVAxxIp2xvKSo1e8OaqyeV33LmDW1pC5sDd0GFN8z+9GtdJ0mbJP oyfT7eDw3/qJSZKeeNOekdyenHVlAfDY3tw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrtddvgddugeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuff fkgggtgfesthhqredttddtjeenucfhrhhomhepjhhohhhnuchmuhhhlhcuoehjmhesphhu sgdrphhinhhkqeenucggtffrrghtthgvrhhnpeetuefhgfeuieejteekffejudettdeuue ekueffkeeileekueegleefkefhgefhueenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehjmhesphhusgdrphhinhhkpdhnsggprhgtphhtthhope dupdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghs sehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 6 Nov 2024 16:19:58 -0500 (EST) From: john muhl To: bug-gnu-emacs@gnu.org Subject: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options X-Debbugs-Cc: Date: Wed, 06 Nov 2024 15:19:52 -0600 Message-ID: <8734k4xdon.fsf@pub.pink> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=202.12.124.155; envelope-from=jm@pub.pink; helo=fhigh-b4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Tags: patch For some silly reason the lua-ts-{inferior,luacheck}-program options ended up with an option for =E2=80=9CNone=E2=80=9D. Obviously setti= ng your Lua interpreter or linter program to nil is not going to work. Any chance it could make it into emacs-30? Thanks. ------------=_1731572822-3430-1-- From unknown Sat Aug 16 21:23:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options Resent-From: john muhl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Nov 2024 03:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 74235-done@debbugs.gnu.org Received: via spool by 74235-done@debbugs.gnu.org id=D74235.173164287618299 (code D ref 74235); Fri, 15 Nov 2024 03:55:01 +0000 Received: (at 74235-done) by debbugs.gnu.org; 15 Nov 2024 03:54:36 +0000 Received: from localhost ([127.0.0.1]:48032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBnPo-0004l4-Bc for submit@debbugs.gnu.org; Thu, 14 Nov 2024 22:54:36 -0500 Received: from fhigh-a2-smtp.messagingengine.com ([103.168.172.153]:55709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBnPm-0004kr-Cj for 74235-done@debbugs.gnu.org; Thu, 14 Nov 2024 22:54:35 -0500 Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailfhigh.phl.internal (Postfix) with ESMTP id 8A78A1140132; Thu, 14 Nov 2024 22:54:28 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Thu, 14 Nov 2024 22:54:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1731642868; x=1731729268; bh=V45WbuzJ4ARYqyEYYsMqzA/8l7t4Ik0odDOd3Z7SjLA=; b= aW0p6J0b7weS2FSKau6voB03CbNQk8Vj1eNs3zXmsDUxL1+SKkRkwxbdZSCZDJtf X7ONuSYI5d4bLglsbzPijLJLruZZYCI4BJBYjq95/GC6akwyaiWYLHBMSdu64rrz LsJhmtpoVD9tbpYcJlZ/Rsi0qMUL1iK7werjtePS1wC0bMvIQWaA4wgCb+/6HIwt x49VPRRENVyLDq1bjx+V/vYxd5MH4LML+gBwn+tTrPOOJDjzw18uMIo1Eedu/4vP IU6cOxumckx39jMKpz3YqYM3eEqTmraLubWsspNoTvQJa5VouKrw5BwsvwrC2OHq AyuKb4iPs5trg6YxP64MgQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731642868; x= 1731729268; bh=V45WbuzJ4ARYqyEYYsMqzA/8l7t4Ik0odDOd3Z7SjLA=; b=f nlN3f3/tVA5w95DJlZxPj72k8nM20BlYZhsTtpPrM/92tvd5KNRPsxsl21lWEplN gZp1+q3sToTwKPMjDh40dRWGIOgb08p7D5mUC7wDDGXvsPD2LnkXbszlXwdboYrR pE1EFVn0ZtdpBOLQTqYvbBLwV3wg32NOvF4E2LQOc+g/7HiVUKBAqe9f2/42i/Hx tTZ8vlgWOpj/sX+/u2m47NBWb7wl14IP7Gh0+Nlq+TrRogFXESHcUX4GRvGaq9pZ 3+OKI0J82ZwoajK0TmX+U8co4h55NVOiWrIatMWcTY7OoOG1atAiHEgC63gYWK4y rhkT0z/3lJEQKvMTB1xzA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrvdefgdeivdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtgfesthhqredttderjeen ucfhrhhomhepjhhohhhnuchmuhhhlhcuoehjmhesphhusgdrphhinhhkqeenucggtffrrg htthgvrhhnpeegveehvddttedvkeduvddttdehhfdvgffgvdfgiedtjeduhefhffejtddv veevkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hjmhesphhusgdrphhinhhkpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhu thdprhgtphhtthhopeejgedvfeehqdguohhnvgesuggvsggsuhhgshdrghhnuhdrohhrgh dprhgtphhtthhopegvlhhiiiesghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 Nov 2024 22:54:27 -0500 (EST) From: john muhl In-Reply-To: <8634jukyqt.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 14 Nov 2024 10:26:02 +0200") References: <8734k4xdon.fsf@pub.pink> <87ses4vyzp.fsf@pub.pink> <86y11vr3e5.fsf@gnu.org> <87ldxtn57i.fsf@pub.pink> <86ses1oijv.fsf@gnu.org> <87ikswi0vc.fsf@pub.pink> <86r07jlk3j.fsf@gnu.org> <87y11r87qw.fsf@pub.pink> <8634jukyqt.fsf@gnu.org> User-Agent: mu4e 1.12.1; emacs 31.0.50 Date: Thu, 14 Nov 2024 21:54:26 -0600 Message-ID: <87ldxl2lu5.fsf@pub.pink> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: john muhl >> Cc: 74235@debbugs.gnu.org >> Date: Sun, 10 Nov 2024 08:48:39 -0600 >>=20 >> Eli Zaretskii writes: >>=20 >> >> From: john muhl >> >> Cc: 74235@debbugs.gnu.org >> >> Date: Sat, 09 Nov 2024 14:54:47 -0600 >> >>=20 >> >> + (if (or (not lua-ts-inferior-program) >> >> + (not (executable-find lua-ts-inferior-program))) >> >> + (user-error "You must set `lua-ts-inferior-program' to use this >> >> command") >> > >> > The text of user-error should say something about being unable to find >> > the program, not just about the variable being nil, since you use >> > executable-find. >> > >> > Otherwise, LGTM, thanks. >>=20 >> I guess the executable-find check is redundant anyway since >> comint/process will tell you =E2=80=9CSearching for program: No such file >> or directory, luaz=E2=80=9D if you get it wrong. > > Thanks, installed on the emacs-30 branch, and closing the bug. > > Btw, I noticed that you are marking with ";" the log entries of > changes which should definitely appear in the produced ChangeLog. Is > this on purpose, or did you misunderstand the meaning of the > semi-colon in the first line of the commit log messages? Temporary (hopefully) confusion. I think I had NEWS entries on my mind and conflated the the semicolon with not needing an entry there. I should probably re-read CONTRIBUTING since it=E2=80=99s been awhile and I don=E2=80=99t contribute often enough to have it all ingrained yet. Thanks for your patience.