From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 13:48:12 2024 Received: (at submit) by debbugs.gnu.org; 6 Nov 2024 18:48:12 +0000 Received: from localhost ([127.0.0.1]:45420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8l4d-0006WZ-PX for submit@debbugs.gnu.org; Wed, 06 Nov 2024 13:48:12 -0500 Received: from lists.gnu.org ([209.51.188.17]:41520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8l4a-0006WO-8h for submit@debbugs.gnu.org; Wed, 06 Nov 2024 13:48:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8l4Y-00031I-HP for guix-patches@gnu.org; Wed, 06 Nov 2024 13:48:07 -0500 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t8l4V-00015R-IE for guix-patches@gnu.org; Wed, 06 Nov 2024 13:48:05 -0500 Received: by mail-qk1-x744.google.com with SMTP id af79cd13be357-7b1488fde46so6674785a.2 for ; Wed, 06 Nov 2024 10:48:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730918881; x=1731523681; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=EzyT64VJNtSMOwYggBilcDS1vyNbdVW1R29vBjSx4nw=; b=g4+WsDJcKjmSJtldePYNlgXF6wKch4oO1KOX0gnuCdEtZURSQGOX4/iy/Q9k3EPyTn vfQJ0U+RBNbpN3OFa71QlmHGa8wbCq6UeR66pskIyZIrvOuGwvKARahktyl/eumI3q3m TUzMLYlZjHQSvz5e6Xv4mJCwkPJZEjwA3CzDPNIyIsvZ7kwyDj1RVf9SRulv6uq4dQSX 5pZcPhy6z2Op9tYcdOcmVirh/cyO/rjnFcwUrBhY4Op0Up1E8Hj0tyU5lQl73Qrd0m/h 8Pn9Za8H8FRGAa8KnwIDf41ZXbaLsY2yhemKYqO2rLkg8OnksT4GcAOS+Ua242IMvddU P5ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730918881; x=1731523681; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EzyT64VJNtSMOwYggBilcDS1vyNbdVW1R29vBjSx4nw=; b=GSmaFZksCgRyuHS460oIE6rVya+9CEoQRSEZRpEDFbQuXeq2fOXIaDW218EWyzCrcQ /wiIARWrmkR5qjXbL+FRzpmgi9BtMWh2dW2Xd+jfYkM2RYdXb4uMK0yQhYkQOGHS0MhQ hb5wbs9wu25939S85gqwd6tTuw0t+/je56E3U4fu1Q4X7ANRTJHXkGiLKpogV25T0v7U 4KBGHgJVhIiePO9vrdVaILNtWbRx0raZHJXZ7ZLF5FYNaw1XiVI0UwPKPY//PUYpJVHI v7vIgX1wszYL7BBfHl7MW6iOM6Ihlk6FTtsC7Z313pTwyCZLnRFVrvmUGUv/BR1BiS3p OO8Q== X-Gm-Message-State: AOJu0Yzl6tNzJqi52uGxoRw9MZ/RBNze7wYluOkcrADiB4hz4uiZoOYj phzgvdYjQ5TVs0QCoUHGa/YNieirgc4sFJuPJKKssk8q9weXfsjlAyL9rzfY X-Google-Smtp-Source: AGHT+IFvUanfTZ4BnG6lfOBLtp2oRwYHOv/pu3fHeBGbplRoPs6GJ0AyS+XF4v9txHQ1/MC8j1neSg== X-Received: by 2002:a05:620a:409:b0:7b1:e77b:26cc with SMTP id af79cd13be357-7b1e77b27e1mr3129682085a.9.1730918881120; Wed, 06 Nov 2024 10:48:01 -0800 (PST) Received: from gnus ([174.92.178.190]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b2f39f900asm658707585a.40.2024.11.06.10.48.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2024 10:48:00 -0800 (PST) From: "Suhail Singh" To: guix-patches@gnu.org Subject: [PATCH] gnu: emacs-git-email: Update to 0.5.0. Date: Wed, 6 Nov 2024 13:37:51 -0500 X-Debbugs-Cc: Andrew Tropin , Katherine Cox-Buday , Liliana Marie Prikler Message-Id: <578f2ae3ba7cc4838ffdbc0929e6d3a5c8a6a9cc.1730918803.git.suhail@bayesians.ca> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::744; envelope-from=suhailsingh247@gmail.com; helo=mail-qk1-x744.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/emacs-xyz.scm (emacs-git-email): Update to 0.5.0 on actively maintained fork. Update homepage. Add emacs-piem as a build-time dependency. Don't propagate mu, emacs-magit, and emacs-notm [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (suhailsingh247[at]gmail.com) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (suhailsingh247[at]gmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.51.188.17 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.51.188.17 listed in bl.score.senderscore.com] 1.7 URIBL_BLACK Contains an URL listed in the URIBL blacklist [URIs: codeberg.org] X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) * gnu/packages/emacs-xyz.scm (emacs-git-email): Update to 0.5.0 on actively maintained fork. Update homepage. Add emacs-piem as a build-time dependency. Don't propagate mu, emacs-magit, and emacs-notmuch since they are optional. * gnu/local.mk (dist_patch_DATA): Delete emacs-git-email-missing-parens.patch, since it's no longer needed. * gnu/packages/patches/emacs-git-email-missing-parens.patch: Delete unnecessary patch. Change-Id: I47f5aa12cfa676772e281a45cdc9ec3bb3eae544 --- gnu/local.mk | 1 - gnu/packages/emacs-xyz.scm | 63 ++++++++----------- .../emacs-git-email-missing-parens.patch | 27 -------- 3 files changed, 25 insertions(+), 66 deletions(-) delete mode 100644 gnu/packages/patches/emacs-git-email-missing-parens.patch diff --git a/gnu/local.mk b/gnu/local.mk index 945d89d550..90ef82204d 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1186,7 +1186,6 @@ dist_patch_DATA = \ %D%/packages/patches/emacs-disable-jit-compilation.patch \ %D%/packages/patches/emacs-exec-path.patch \ %D%/packages/patches/emacs-fix-scheme-indent-function.patch \ - %D%/packages/patches/emacs-git-email-missing-parens.patch \ %D%/packages/patches/emacs-helpful-fix-tests.patch \ %D%/packages/patches/emacs-highlight-stages-add-gexp.patch \ %D%/packages/patches/emacs-json-reformat-fix-tests.patch \ diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 59c804066a..57ae548a3b 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -22159,44 +22159,31 @@ (define-public emacs-gitpatch (license license:gpl3+))) (define-public emacs-git-email - ;; Use latest commit since latest tagged release is missing important - ;; changes. - (let ((commit "b5ebade3a48dc0ce0c85699f25800808233c73be") - (revision "0")) - (package - (name "emacs-git-email") - (version (git-version "0.2.0" revision commit)) - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://git.sr.ht/~yoctocell/git-email") - (commit commit))) - (patches - (search-patches "emacs-git-email-missing-parens.patch")) - (file-name (git-file-name name version)) - (sha256 - (base32 "1lk1yds7idgawnair8l3s72rgjmh80qmy4kl5wrnqvpmjrmdgvnx")))) - (build-system emacs-build-system) - (arguments - `(#:phases - (modify-phases %standard-phases - ;; piem is not yet packaged in Guix. - (add-after 'unpack 'remove-piem - (lambda _ - (delete-file "git-email-piem.el"))) - (add-before 'install 'makeinfo - (lambda _ - (invoke "makeinfo" "doc/git-email.texi")))))) - (native-inputs - (list texinfo)) - (propagated-inputs - (list mu emacs-magit emacs-notmuch)) - (license license:gpl3+) - (home-page "https://sr.ht/~yoctocell/git-email") - (synopsis "Format and send Git patches in Emacs") - (description "This package provides utilities for formatting and -sending Git patches via Email, without leaving Emacs.")))) + (package + (name "emacs-git-email") + (version "0.5.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://codeberg.org/suhail/git-email") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0q70k0pn0dkbrcsah0hcwxa2c3f8aw89bbds5k2dslacn93ghws7")))) + (build-system emacs-build-system) + (arguments + `(#:phases (modify-phases %standard-phases + (add-before 'install 'makeinfo + (lambda _ + (invoke "makeinfo" "doc/git-email.texi")))))) + (inputs (list mu emacs-magit emacs-notmuch emacs-piem)) + (native-inputs (list texinfo)) + (license license:gpl3+) + (home-page "https://suhail.codeberg.page/git-email") + (synopsis "Format and send Git patches in Emacs") + (description "This package provides utilities for formatting and +sending Git patches via Email, without leaving Emacs."))) (define-public emacs-erc-hl-nicks (package diff --git a/gnu/packages/patches/emacs-git-email-missing-parens.patch b/gnu/packages/patches/emacs-git-email-missing-parens.patch deleted file mode 100644 index 051e2bf1eb..0000000000 --- a/gnu/packages/patches/emacs-git-email-missing-parens.patch +++ /dev/null @@ -1,27 +0,0 @@ -From 820ad7eb2e919e3f880bec22bd4f737fa55c4d22 Mon Sep 17 00:00:00 2001 -From: Niklas Eklund -Date: Thu, 5 May 2022 12:43:49 +0200 -Subject: [PATCH] Fix missing parens in git-email-mu4e.el - -The incorrect number of parens in this file lead to Emacs failing to -parse the file. ---- - git-email-mu4e.el | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/git-email-mu4e.el b/git-email-mu4e.el -index d5b8770..9220bf9 100644 ---- a/git-email-mu4e.el -+++ b/git-email-mu4e.el -@@ -51,7 +51,7 @@ from Lisp, enable the mode if ARG is omitted or nil." - ;; built in context feature. - (seq-filter (lambda (header) - (not (eq (car header) 'from))) -- headers) -+ headers)))) - (setq git-email-compose-email-function 'message-mail))) - - (provide 'git-email-mu4e) --- -2.34.0 - base-commit: ba9466481d10992d35f09d010166d616fdb6a637 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 06:40:55 2024 Received: (at 74231) by debbugs.gnu.org; 7 Nov 2024 11:40:56 +0000 Received: from localhost ([127.0.0.1]:47410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t90sh-00031W-GD for submit@debbugs.gnu.org; Thu, 07 Nov 2024 06:40:55 -0500 Received: from devianza.investici.org ([198.167.222.108]:46157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t90se-00031K-BY; Thu, 07 Nov 2024 06:40:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1730979650; bh=f+oi4Xs+ea3NkPj1pfFelAfkrlSQcNkwf6txBOBTOR4=; h=From:To:Subject:Date:From; b=N1BphzFNiOSIyWlR7Kep8N/aQYfuR108LbIUE0MF4M3fMkzwGfaenzgyiBjo6JBCl 74DrOWqyxnOi1YiyyaEkGIA/pW0vrFVJZ7c1ltEzM6Ch2wjvGo9DqYgqWP+xB0rdJS v1trwJmsre2q1fTA761+7bcksq3M2i4ROC2/rT1Q= Received: from mx2.investici.org (unknown [127.0.0.1]) by devianza.investici.org (Postfix) with ESMTP id 4XkgBB3Nq9z6vJR; Thu, 7 Nov 2024 11:40:50 +0000 (UTC) Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108]) (Authenticated sender: cayetano.santos@inventati.org) by localhost (Postfix) with ESMTPSA id 4XkgBB1yR6z6vCc; Thu, 7 Nov 2024 11:40:50 +0000 (UTC) From: Cayetano Santos To: control@debbugs.gnu.org,74231@debbugs.gnu.org Subject: QA review for 74231 Date: Thu, 07 Nov 2024 12:40:49 +0100 Message-ID: <87ed3n1dby.fsf@inventati.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74231 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) user guix usertag 74231 + waiting-on-contributor thanks Guix QA review form submission: "The Elisp dependencies of Emacs packages are typically provided as propagated-inputs when required at run time." See: https://guix.gnu.org/manual/en/html_node/Emacs-Packages.html. To note that this is a completely different beast compared to previous package (repo, version and mantainer). Items marked as checked: - Commit messages - Package builds - Lint warnings - Package style - Dependent packages build From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 08:34:15 2024 Received: (at 74231) by debbugs.gnu.org; 7 Nov 2024 13:34:15 +0000 Received: from localhost ([127.0.0.1]:47566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t92eN-0007oG-01 for submit@debbugs.gnu.org; Thu, 07 Nov 2024 08:34:15 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:57521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t92eH-0007nt-DM for 74231@debbugs.gnu.org; Thu, 07 Nov 2024 08:34:12 -0500 Received: by mail-qk1-f195.google.com with SMTP id af79cd13be357-7b1511697a5so55204785a.2 for <74231@debbugs.gnu.org>; Thu, 07 Nov 2024 05:34:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730986381; x=1731591181; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=qvfqzXNmM6TN1lZZXtv3JEddvRW1A6sv4NcogAW0dRY=; b=WV1Gsdfb6fb/uJs9AFaVphEj3rZ3OiNb22ctD8HEILkWNzey621rskSf1V76sfSlxv 3AxvRUV63ZCmcJM3AeWyVVPzlMaJVOaQNVwIg2NbhmXO/15NxpZ6Dvh2OxNNuLZ0DZ1I fSra/hwpOOl6upT1sUGUC7KpKv2r0e2XSwHqMa2xGkeRQnhuRWqwO5flehaFzGeQak1p E+HESxH3WfLIo3ooABiMudOxtXgZc4hZ4EpGK9wB4YgHHDi8BrvyPiyo7DNAiXFlqZRq BdTXF0dCg7gpMAZzSfub4j20UcLs0GUvp0FSfH9GajFCSTB22mnEjuzsH6ermDr9YOPw O4Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730986381; x=1731591181; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qvfqzXNmM6TN1lZZXtv3JEddvRW1A6sv4NcogAW0dRY=; b=RsX47psRjveymYLMlINfxL167r1o8aYNT+qWooMyVbK+fNzCYKkIpb7bM1WckXyuxN CV2JgbnAoWSsfL9A8ngIhbPB1Eqy44EebrPYwz0fF2UpUHUrxZIgsa0I3SDKqe2SI5li 7H1sjkVMVbaBKeUxhSOMWlKp08sj/SJ35Yseokf3Kn+dUPGQsJ86X8xU0Q+GsCG78I7L pVbXgFFugHqUhQZouXamh/9qxIrZ+0FSltJhbjlFRauH/Or2mvT6rvttuIWql+rXovcb QpV3qaUvFoIp6s9qKc1Yj7sjAkfIo2T9WM8MdTT3fG+2nJq5rjzf6RUfTk6e3E50DzZT 97Cg== X-Gm-Message-State: AOJu0YyCcv+ovEVRA4kPXqRncAdRhnPhGK5MGQnyef4DpCFVjXSBH+Dd LAe+quUZ74YI6m4gyfvpbrRiHFDY1AiAgNVY/P+fbsmY6jrHn7xQF4BUC2B+ X-Google-Smtp-Source: AGHT+IFuYWLuzQWDZwpfaV2d6sVmMcykIq6SHiVb1sxpO4RXQvgqZqyRZuy9XviZxhNQvFKiA1iW9Q== X-Received: by 2002:a05:620a:44d5:b0:7a9:ab71:f820 with SMTP id af79cd13be357-7b193ed5c29mr6077441485a.4.1730986381611; Thu, 07 Nov 2024 05:33:01 -0800 (PST) Received: from gnus (bras-base-mtrlpq0776w-grc-36-174-92-178-190.dsl.bell.ca. [174.92.178.190]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b32ac2ea60sm62014285a.17.2024.11.07.05.33.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2024 05:33:01 -0800 (PST) From: Suhail Singh To: Cayetano Santos Subject: Re: [bug#74231] QA review for 74231 In-Reply-To: <87ed3n1dby.fsf@inventati.org> (Cayetano Santos via Guix-patches via's message of "Thu, 07 Nov 2024 12:40:49 +0100") References: <578f2ae3ba7cc4838ffdbc0929e6d3a5c8a6a9cc.1730918803.git.suhail@bayesians.ca> <87ed3n1dby.fsf@inventati.org> Date: Thu, 07 Nov 2024 08:32:59 -0500 Message-ID: <87ed3nyxro.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 74231 Cc: 74231@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Cayetano Santos via Guix-patches via writes: > "The Elisp dependencies of Emacs packages are typically provided as > propagated-inputs when required at run time." > > See: https://guix.gnu.org/manual/en/html_node/Emacs-Packages.html. Yes, please note however, that the dependencies in question were entirely optional. The package doesn't have any "required" Elisp dependencies with the version of Emacs packaged in Guix. More importantly, for some of these optional dependencies a user would only ever want to use one of them at a time (since it's intimately tied to their personal workflow and MUA etc.). > To note that this is a completely different beast compared to previous > package (repo, version and mantainer). Yes. Please let me know in case the commit message needs to be revised (it already does note that we are changing the referenced fork). The previous fork hasn't been updated in a couple of years and had a number of bugs that have since been resolved in the updated fork. Regards, -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 10:13:51 2024 Received: (at 74231) by debbugs.gnu.org; 7 Nov 2024 15:13:51 +0000 Received: from localhost ([127.0.0.1]:49241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t94Cl-0004Hn-05 for submit@debbugs.gnu.org; Thu, 07 Nov 2024 10:13:51 -0500 Received: from devianza.investici.org ([198.167.222.108]:26041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t94Ch-0004He-JY for 74231@debbugs.gnu.org; Thu, 07 Nov 2024 10:13:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1730992419; bh=YZ6nApnfRtlqTVijw9wvqfjyoLR0zys9QG+eedP+sEI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=XcjuczhwzinDgHQitYjpxVRnUvPeW4moZ7oeni4oZ8QhtbJC3vp1vjMjtT7vZ/VWE NqRsP+pPCL6fRMFpIKBokAvAR8rOkRPq0YD+ifPTfsB3XIpcM2sxq8s7FsHsmY9k9S 3JajDRsMjZ4N5hJE0r+FEZsOViEqPkAhT+N0KVxc= Received: from mx2.investici.org (unknown [127.0.0.1]) by devianza.investici.org (Postfix) with ESMTP id 4Xklvl1Wcwz6vJH; Thu, 7 Nov 2024 15:13:39 +0000 (UTC) Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108]) (Authenticated sender: cayetano.santos@inventati.org) by localhost (Postfix) with ESMTPSA id 4Xklvl06SZz6vJG; Thu, 7 Nov 2024 15:13:38 +0000 (UTC) From: Cayetano Santos To: Suhail Singh Subject: Re: [bug#74231] QA review for 74231 In-Reply-To: <87ed3nyxro.fsf@gmail.com> (Suhail Singh's message of "Thu, 07 Nov 2024 08:32:59 -0500") References: <578f2ae3ba7cc4838ffdbc0929e6d3a5c8a6a9cc.1730918803.git.suhail@bayesians.ca> <87ed3n1dby.fsf@inventati.org> <87ed3nyxro.fsf@gmail.com> Date: Thu, 07 Nov 2024 16:13:37 +0100 Message-ID: <87ed3n3wm6.fsf@inventati.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74231 Cc: 74231@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >jeu. 07 nov. 2024 at 08:32, Suhail Singh wrote: > Cayetano Santos via Guix-patches via writes: > >> "The Elisp dependencies of Emacs packages are typically provided as >> propagated-inputs when required at run time." >> >> See: https://guix.gnu.org/manual/en/html_node/Emacs-Packages.html. > > Yes, please note however, that the dependencies in question were > entirely optional. The package doesn't have any "required" Elisp > dependencies with the version of Emacs packaged in Guix. More > importantly, for some of these optional dependencies a user would only > ever want to use one of them at a time (since it's intimately tied to > their personal workflow and MUA etc.). Fine with me, then. >> To note that this is a completely different beast compared to previous >> package (repo, version and mantainer). > > Yes. Please let me know in case the commit message needs to be revised > (it already does note that we are changing the referenced fork). The > previous fork hasn't been updated in a couple of years and had a number > of bugs that have since been resolved in the updated fork. To me, the open question goes well beyond this package. Does guix package forks of code from a couple of years ago, without an explicit acknowledgement between maintainers ? Additionally, this is a second generation fork ... I=E2=80=99d say, better bring the question to guix-devel, as this has large implications. There must be a policy already around this point. C. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 10:49:36 2024 Received: (at 74231) by debbugs.gnu.org; 7 Nov 2024 15:49:36 +0000 Received: from localhost ([127.0.0.1]:49285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t94lL-0005qv-Tv for submit@debbugs.gnu.org; Thu, 07 Nov 2024 10:49:36 -0500 Received: from mail-qv1-f65.google.com ([209.85.219.65]:45467) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t94lJ-0005ql-BV for 74231@debbugs.gnu.org; Thu, 07 Nov 2024 10:49:34 -0500 Received: by mail-qv1-f65.google.com with SMTP id 6a1803df08f44-6cbd00dd21cso6873546d6.3 for <74231@debbugs.gnu.org>; Thu, 07 Nov 2024 07:49:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730994513; x=1731599313; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6SuSgJL5S//qlap+2XYX6yzK9YXgX612Sy56d6cKFtI=; b=TNjcdvQluuaDBQ/5cDx3mPpcOc3manmJ0xO3pALoSbGaT52/Ous3e2WgnyXL4vKqtT ihSSSMNJ4uD89BVIqUBs5JGgu/B02lokOHkjRLOE23vixsLB3IuO5IAr2Ws9ZcYzIoy2 U2m2lBFdr1/MNeBQaA1IHDBc+p7mqevWUqWHuIBwnvvxWd5kHWU+1dOPYKBS1v01fQO2 Di8wPboV9XvkzADrTIM9LeuUGT8bBN0zJuKANan32nClVevzwHMvEN9iVEJV0kpg1V8G nqIjo1FEAgvo1YTlH9SswDK+Gg4LW4ngO5C4VPOodQVSF1+N25FNEw7JS5085zlOH22i aiZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730994513; x=1731599313; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6SuSgJL5S//qlap+2XYX6yzK9YXgX612Sy56d6cKFtI=; b=uAiB4quY+yUTyf8X1Hkxtue5hiPpPKHz/7jsPgZMprtgTV6ipxlScAiu1kY33PMwAX J6t5vUGPi4Fxr3mz3DuY1N7C3J1siRp1dZqNhXFVeQt1zfdhyFV5VVbA+IszOs07hG3U KkFEZb0QT5BK4bh/0yfo0JYcYZK1/oDPW9kki5gVbV1GknKsRTZlDuBGUp6VoC5mZt2Y oPftFW+NCrHZ3v4p7uMldk5cHxNXnBTlyoN4gs0pzJ9JeX15UtZqs3qso8q5q1eEB+Ky +Fv4b1lLsgAUaez2LZNK1DqXIcegkfSxiZmZEspgTHNj0iqyh2C2sbB033NQr4ohn0h5 sFzg== X-Forwarded-Encrypted: i=1; AJvYcCUQM/vYIci7L89EgRsO9s96jKlbQdt9LFjpffeWSMnL7oY6h6EmUUGcCacBy+I1oMkUpkAGIQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwusOzO6s985HoVA+zViJxBHKGhGhjwrRjAXt9gZlp0RooHnMtD msi1GAKYqBippm0Wp5ttfN6DzQCEpOKPZlsuTo+wpt3FJuxKE0zu X-Google-Smtp-Source: AGHT+IGJpLmYnzozuFeumYSdhxctWmE9M5dyntVrSETZfwuI+3+hKNQzaPphwsIdRKfEMxNGMtlQ5Q== X-Received: by 2002:a05:6214:5b08:b0:6ce:2822:7a9b with SMTP id 6a1803df08f44-6d39d0283b6mr4722036d6.37.1730994512743; Thu, 07 Nov 2024 07:48:32 -0800 (PST) Received: from gnus ([174.92.178.190]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d3961dfa0csm8860506d6.14.2024.11.07.07.48.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2024 07:48:32 -0800 (PST) From: Suhail Singh To: Cayetano Santos Subject: emacs-git-email: Guix policy for dealing with abandoned packages with active forks (was: [bug#74231] QA review for 74231) In-Reply-To: <87ed3n3wm6.fsf@inventati.org> (Cayetano Santos's message of "Thu, 07 Nov 2024 16:13:37 +0100") References: <578f2ae3ba7cc4838ffdbc0929e6d3a5c8a6a9cc.1730918803.git.suhail@bayesians.ca> <87ed3n1dby.fsf@inventati.org> <87ed3nyxro.fsf@gmail.com> <87ed3n3wm6.fsf@inventati.org> Date: Thu, 07 Nov 2024 10:48:21 -0500 Message-ID: <87y11vf3ju.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 74231 Cc: Guix-devel mailing list , Mekeor Melire , Xinglu Chen , Suhail Singh , 74231@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Cayetano Santos writes: >>> To note that this is a completely different beast compared to previous >>> package (repo, version and mantainer). >> >> Yes. Please let me know in case the commit message needs to be revised >> (it already does note that we are changing the referenced fork). The >> previous fork hasn't been updated in a couple of years and had a number >> of bugs that have since been resolved in the updated fork. > > To me, the open question goes well beyond this package. > > Does guix package forks of code from a couple of years ago, without an > explicit acknowledgement between maintainers ? The maintainer has not been active on their own mailing list () for a while despite repeated discussions about outstanding issues ([1], [2]). I believe it would be fair to characterize the original package as having been abandoned. I'm CC-ing Xinglu Chen (the original author) to this email for transparency. > Additionally, this is a second generation fork ... I am not sure I understand what you mean by "second generation" in this regard. Could you please elaborate? If you're referring to the fact that it used another contributor's (Mekeor) fork as a starting point, then for context please note that the decision to treat my fork as "upstream" was in discussion with them (since Mekeor's no longer actively using the package). I'm CC-ing Mekeor to this message for transparency. > I=E2=80=99d say, better bring the question to guix-devel, as this has lar= ge > implications. There must be a policy already around this point. I'm CC-ing guix-devel. [1]: [2]: --=20 Suhail From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 11:10:01 2024 Received: (at 74231) by debbugs.gnu.org; 7 Nov 2024 16:10:01 +0000 Received: from localhost ([127.0.0.1]:49321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9557-0006ot-8W for submit@debbugs.gnu.org; Thu, 07 Nov 2024 11:10:01 -0500 Received: from mail-qv1-f67.google.com ([209.85.219.67]:59394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9555-0006og-5D for 74231@debbugs.gnu.org; Thu, 07 Nov 2024 11:10:00 -0500 Received: by mail-qv1-f67.google.com with SMTP id 6a1803df08f44-6cbce16d151so6947746d6.2 for <74231@debbugs.gnu.org>; Thu, 07 Nov 2024 08:09:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730995733; x=1731600533; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n5ZI/YXRZ1I+ki++DR3s5tFJXnw1IUS/U+gb2WNwFQM=; b=gC/4jyg4fp7XoXVm8xYKDWmUhTzlBFsvYbhPRQA72dzXcyCt/BPTmu4RisjlPgfFwN QXscaBJ6nMXZ3YXhbTCGhJOHwGSeH7GM5fpWYWvc0JcSPAPeyza4dUSrmnLwoa1F+pVT /djUCzesTp86lSBcSuFJWy80Gi1ur8l8XEL4L7Ycth8kt/JirNgVCFKTpy4n/7Up0jzT IQ5pNOtoSZpxZwdDBSQZtQ9J3/fuB9GZb45163DPDe/A1gXEKpTiG+l13sq3YLIg3SSo lCiU3h3amksLY2ljFsFbGyJb563Y67Sv3xguN8NjqzPSwEbCO2+P285Q3LDmcoVE9kD+ MrdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730995733; x=1731600533; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=n5ZI/YXRZ1I+ki++DR3s5tFJXnw1IUS/U+gb2WNwFQM=; b=WxmlQ6VAW45N9gMPLwimcngVjIDY94E3S9wVRwXONuGhRM/cTFctmUtktmu4X7yUrl gaWu9uLIS0LOmKZpvzv8rPAeBpI3+QihjpLkk+OdG6WWQ1qXJzPC8Eholx9W9Ut4PSxy j5Qs+HKVS+1JJi86HEXwAndj0tR6K5ENtCnwjzIToTf3yXpIdJxihYEkS4HzcjJpplzF COlGPzntDZMum9fORHivHHfaURdhdG/q+Y4uyhy32vl50vgQ2KdB7R1OCWlYD5Q2FcvY Qq3YLtaxaloOGAUH/CloeFilZrmCnQXdx9V57SJWPeqQVBqIQW3WP1tknzmD+N6q3EEl Uy/A== X-Forwarded-Encrypted: i=1; AJvYcCVErIwABYPrRxH4bguEFYsAAUrw3FWqkurFveD8o7MRff1tvwCHUt06yV0n/YzfPvCqHyhMNQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yzphe0QImozyPCy2PyniNDqT6WrU6j1dJplhTBhwhTrXVe7S9MI f/g+HngB8xxpsKp0escKNWSzeIbaQqeN0yl8G8IentVYBRtUR7h1 X-Google-Smtp-Source: AGHT+IFme3T883Xm88ID2H4kt0eaigxJALRuXfSsBZhuKgYnEsMzrZnhZonJFKfamb/vo3oyAsNbFg== X-Received: by 2002:a05:6214:4a89:b0:6d3:71ab:adbb with SMTP id 6a1803df08f44-6d371abc4admr216615166d6.13.1730995733290; Thu, 07 Nov 2024 08:08:53 -0800 (PST) Received: from gnus ([174.92.178.190]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d39643c6a3sm8918256d6.81.2024.11.07.08.08.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2024 08:08:52 -0800 (PST) From: Suhail Singh To: Guix-devel mailing list Subject: Re: emacs-git-email: Guix policy for dealing with abandoned packages with active forks In-Reply-To: <87y11vf3ju.fsf_-_@gmail.com> (Suhail Singh's message of "Thu, 07 Nov 2024 10:48:21 -0500") References: <578f2ae3ba7cc4838ffdbc0929e6d3a5c8a6a9cc.1730918803.git.suhail@bayesians.ca> <87ed3n1dby.fsf@inventati.org> <87ed3nyxro.fsf@gmail.com> <87ed3n3wm6.fsf@inventati.org> <87y11vf3ju.fsf_-_@gmail.com> Date: Thu, 07 Nov 2024 11:08:41 -0500 Message-ID: <87ttcjf2ly.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 74231 Cc: Mekeor Melire , Xinglu Chen , Cayetano Santos , 74231@debbugs.gnu.org, Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hello Guix, Below is a summary of the situation that we're seeking guidance on. Please ignore this message, if already aware of context. Suhail Singh writes: >> I=E2=80=99d say, better bring the question to guix-devel, as this has la= rge >> implications. There must be a policy already around this point. > > I'm CC-ing guix-devel. > > [1]: > > [2]: In issue #74231 I submitted a patch to update emacs-git-email. The patch changes the notion of "upstream" for the emacs-git-email package. The current package definition in Guix points to the original implementation. However, for the last couple of years that project has received no updates. Importantly, there has been no response from the original author regarding offers to take over or help with maintainership during the same period (see [1] and [2] above). All this while the original package had some critical bugs (including, but not limited to, missing parentheses). I have, since recently, started actively using (and developing) the package and incorporated all existing patches as well as added some additional functionality. In situations such as these: 1. Is it okay to update the package to point to an actively maintained fork? 2. Are there some necessary pre-requisites that have to be fulfilled before 1 can be done? If so, have they been fulfilled? If not, could the outstanding items be noted? Regards, --=20 Suhail From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 11:20:13 2024 Received: (at 74231) by debbugs.gnu.org; 7 Nov 2024 16:20:13 +0000 Received: from localhost ([127.0.0.1]:49337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t95Ez-0007OM-En for submit@debbugs.gnu.org; Thu, 07 Nov 2024 11:20:13 -0500 Received: from confino.investici.org ([93.190.126.19]:46027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t95Ex-0007NP-3s for 74231@debbugs.gnu.org; Thu, 07 Nov 2024 11:20:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1730996402; bh=CluKmMt3YaMo9yhgZnUxfM2M8Bpg+pp6C85UV6xeNrw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Gd4AcSQeoc1b4JhzVnnL0wB+XWckRhjAfnRtJuYXPulYMLGjg4cS7uYATsWzwQc0W OEjYVjJ/hDKgj10bvBOpwvAD20GkUTiTLZD0k26DPZBuk4vO9GzB5M2oaVu1SoBc+D vDb39518YIeONLE0oDZSwoL/qhyzPomyNmBcoemg= Received: from mx1.investici.org (unknown [127.0.0.1]) by confino.investici.org (Postfix) with ESMTP id 4XknNL6LZtz111j; Thu, 7 Nov 2024 16:20:02 +0000 (UTC) Received: from [93.190.126.19] (mx1.investici.org [93.190.126.19]) (Authenticated sender: cayetano.santos@inventati.org) by localhost (Postfix) with ESMTPSA id 4XknNL4F6vz111Z; Thu, 7 Nov 2024 16:20:02 +0000 (UTC) From: Cayetano Santos To: Suhail Singh Subject: Re: emacs-git-email: Guix policy for dealing with abandoned packages with active forks In-Reply-To: <87y11vf3ju.fsf_-_@gmail.com> (Suhail Singh's message of "Thu, 07 Nov 2024 10:48:21 -0500") References: <578f2ae3ba7cc4838ffdbc0929e6d3a5c8a6a9cc.1730918803.git.suhail@bayesians.ca> <87ed3n1dby.fsf@inventati.org> <87ed3nyxro.fsf@gmail.com> <87ed3n3wm6.fsf@inventati.org> <87y11vf3ju.fsf_-_@gmail.com> Date: Thu, 07 Nov 2024 17:20:01 +0100 Message-ID: <87wmhfyq1a.fsf@inventati.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74231 Cc: Guix-devel mailing list , Mekeor Melire , Xinglu Chen , 74231@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >jeu. 07 nov. 2024 at 10:48, Suhail Singh wrote: > Cayetano Santos writes: > >>>> To note that this is a completely different beast compared to previous >>>> package (repo, version and mantainer). >>> >>> Yes. Please let me know in case the commit message needs to be revised >>> (it already does note that we are changing the referenced fork). The >>> previous fork hasn't been updated in a couple of years and had a number >>> of bugs that have since been resolved in the updated fork. >> >> To me, the open question goes well beyond this package. >> >> Does guix package forks of code from a couple of years ago, without an >> explicit acknowledgement between maintainers ? > > The maintainer has not been active on their own mailing list > () for a while despite > repeated discussions about outstanding issues ([1], [2]). I believe it > would be fair to characterize the original package as having been > abandoned. > > I'm CC-ing Xinglu Chen (the original author) to this email for > transparency. > >> Additionally, this is a second generation fork ... > > I am not sure I understand what you mean by "second generation" in this > regard. Could you please elaborate? > > If you're referring to the fact that it used another contributor's > (Mekeor) fork as a starting point, then for context please note that the > decision to treat my fork as "upstream" was in discussion with them > (since Mekeor's no longer actively using the package). > > I'm CC-ing Mekeor to this message for transparency. Yes, this is what I refer to. >> I=E2=80=99d say, better bring the question to guix-devel, as this has la= rge >> implications. There must be a policy already around this point. > > I'm CC-ing guix-devel. Thanks ! I=E2=80=99m just curious about whether guix has a policy concerning this ki= nd of situation, before reviewing your patch (#74231), as there might have consequences in the most general case. Namely, it is the case of patching a package definition, redirecting its source url to a fork by the patch=E2=80=99s author. Is that acceptable or a risk ? Is it up to the committer to evaluate, once being warned ? Something more explicit ? C. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 10 21:45:28 2024 Received: (at 74231) by debbugs.gnu.org; 11 Nov 2024 02:45:28 +0000 Received: from localhost ([127.0.0.1]:57290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAKQi-0003zL-6T for submit@debbugs.gnu.org; Sun, 10 Nov 2024 21:45:28 -0500 Received: from out-185.mta1.migadu.com ([95.215.58.185]:23833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAKQf-0003z6-De for 74231@debbugs.gnu.org; Sun, 10 Nov 2024 21:45:27 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpfr.net; s=key1; t=1731293119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dE0iAzqz2fTZMEU/bHjYjsvqNy7DXjfLJy+9G5pfpfI=; b=DEtEsFrU52TX8IEwI503pmku2OQk2G8cJtopoXFZhBY7evZ/Y1WoefLqB81mEZuk+rN1Oa K7s5SkZAwQFTrMFdDApzvHKsd+nruJXtjIMs8W0KmL7FKIQ0TxE7fwsTchqBSW64rX1/qX /vk/phx9muYi/MrKDZOke4RZJulpLzTML6QmthfWqIwdOPhFMZGjiV2LY9PeL13WiOXjGF HF664jAxB94zn2VGwp7KFyol0aB5FKLZVi8kpsflkedUTEWUk9oJuCfTubwC8UrXt7J2Nh DOEnyktdWpFnG8Y8i6vkmJaicZTXsjL0I3AdrX7zZI4ceLaZRpx+DzSETd7bSQ== From: Liam Hupfer To: Cayetano Santos , Suhail Singh Subject: Re: [bug#74231] emacs-git-email: Guix policy for dealing with abandoned packages with active forks In-Reply-To: <87wmhfyq1a.fsf@inventati.org> References: <578f2ae3ba7cc4838ffdbc0929e6d3a5c8a6a9cc.1730918803.git.suhail@bayesians.ca> <87ed3n1dby.fsf@inventati.org> <87ed3nyxro.fsf@gmail.com> <87ed3n3wm6.fsf@inventati.org> <87y11vf3ju.fsf_-_@gmail.com> <87wmhfyq1a.fsf@inventati.org> Date: Sun, 10 Nov 2024 20:45:13 -0600 Message-ID: <87ttce7akm.fsf@hpfr.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74231 Cc: Guix-devel mailing list , Mekeor Melire , Xinglu Chen , 74231@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Cayetano Santos via Guix-patches via writes: > I=E2=80=99m just curious about whether guix has a policy concerning this = kind of > situation, before reviewing your patch (#74231), as there might have > consequences in the most general case. Namely, it is the case of > patching a package definition, redirecting its source url to a fork by > the patch=E2=80=99s author. > > Is that acceptable or a risk ? Is it up to the committer to evaluate, > once being warned ? Something more explicit ? Changing origins is inevitable sometimes. I don=E2=80=99t think there=E2=80= =99s a formal process; it=E2=80=99s more of a matter of judgment on a case-by-case basis.= The [general guidelines on consensus-based decision making] certainly apply. In this case, it seems the original maintainer has been absent for several years, there are active requests for a fork (see [any takers for a fork? =E2=80=94 sourcehut lists]), and Suhail has made [substantial tidyi= ng] over several weeks. Given these circumstances, and Suhail=E2=80=99s [established presence] as a contributor, the fact that he is both the author of the patch and the fork is not concerning to me. So +1 from me (as a user of the Guix package) for what it=E2=80=99s worth. =E2=80=94Liam [general guidelines on consensus-based decision making] [any takers for a fork? =E2=80=94 sourcehut lists] [substantial tidying] [established presence] --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 13 13:13:06 2024 Received: (at 74231) by debbugs.gnu.org; 13 Nov 2024 18:13:06 +0000 Received: from localhost ([127.0.0.1]:43548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBHrW-0003hO-1s for submit@debbugs.gnu.org; Wed, 13 Nov 2024 13:13:06 -0500 Received: from mail-qv1-f65.google.com ([209.85.219.65]:59731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBHrT-0003hG-SJ for 74231@debbugs.gnu.org; Wed, 13 Nov 2024 13:13:04 -0500 Received: by mail-qv1-f65.google.com with SMTP id 6a1803df08f44-6cbe3e99680so38252506d6.3 for <74231@debbugs.gnu.org>; Wed, 13 Nov 2024 10:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731521523; x=1732126323; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Fg0EcqOu85lU1gOFLkgl62eXzXHj3F1mV3hjvjU+ZA4=; b=GIeBnY+OpJNd8axjC55/pwBz+zohe0caLhVagexhGs8HKX1cZMi4dSexfhRnyj6Vi0 n21eNWgLXCDVY7GRI6ycD4yXwW+qg5FaqGGd7/IM0bwiE9CEHkjWx6BLWea4uBlBop52 IOEFHKwHxjnYow5NSwLLKViUk+Xh+a8YLIMfjmUdeKay/wylzUDKeuw64Jr/r9GMnOIX 7+sqen5C2ZpVysNZ+MHVBZwp4um4QRxNaeRSR2OPidaHQot0YmnD4HsW45zzkVP6nJ+8 isM0tuhuyu1mvsQrb02vFWnG91JlaPbUtqGhoCaecyI3WmPLb5EQK/lBDaH2hyshoFDk ywww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731521523; x=1732126323; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Fg0EcqOu85lU1gOFLkgl62eXzXHj3F1mV3hjvjU+ZA4=; b=CVzK/MBN5Zac4tpbmW8pR12ZPHXBbe7XmbkeMiE1Poej6d8ndQhCzP+AXGARaCW+JH SFbZ/hn76zFVJh0o4dFIkH2pr6SZn8FSEOyg7jWXV6IYXJP+jLQlLoITIwY/SlNS5k3M TipNVfUh6BULm+54dbHsOwnI3RoEldjSSlCk8sUjH8LXF1O6RQritTcwGh5TncxWHaXG W3fPC+L6MfLgUiHyOSH8AIghcmgv45dejeRxTLtU1hFVfypHPYKMzy/uhlR9VMPxIcUF ubs0osC8C/TtSAlrt3lXZeCLkF3nWnoOc6ItOCf00f+L4aiVyxzOeXxaxj1iDOLgZlHF zsXg== X-Gm-Message-State: AOJu0YzIrNfips+Lt6tV3sjIokskM/5mD6rB1nCVC88AC/AJBa649huB Lp2hAF9MSRL/W7jQTLN83BcIEg5eu6iDxWFTBL3gj97qIZGEitlF9yCuk91t X-Google-Smtp-Source: AGHT+IGQilAATeGIcneVl6jrzpU99PIl7dHEbY2Ig1CQOOq28MjYy/LXSZtFANxGVxLWgb4JyZ74Zg== X-Received: by 2002:a0c:f410:0:b0:6cd:feec:32eb with SMTP id 6a1803df08f44-6d39e197c53mr289849686d6.22.1731521523010; Wed, 13 Nov 2024 10:12:03 -0800 (PST) Received: from gnus ([70.26.179.129]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d3961def9asm87479756d6.20.2024.11.13.10.12.02 for <74231@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2024 10:12:02 -0800 (PST) From: "Suhail Singh" To: 74231@debbugs.gnu.org Subject: [PATCH v2] gnu: emacs-git-email: Update to 0.6.0. Date: Wed, 6 Nov 2024 13:37:51 -0500 X-Debbugs-Cc: Andrew Tropin , Katherine Cox-Buday , Liliana Marie Prikler Message-Id: <4dda52df4c7e1da9c03cdf6d97c224b777c8fa59.1731521500.git.suhail@bayesians.ca> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/emacs-xyz.scm (emacs-git-email): Update to 0.6.0 on actively maintained fork. Update homepage. Add emacs-piem as a build-time dependency. Don't propagate mu, emacs-magit, and emacs-notm [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (suhailsingh247[at]gmail.com) 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.219.65 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.219.65 listed in bl.score.senderscore.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 2.1 DATE_IN_PAST_96_XX Date: is 96 hours or more before Received: date 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (suhailsingh247[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.65 listed in list.dnswl.org] -0.7 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.65 listed in wl.mailspike.net] X-Debbugs-Envelope-To: 74231 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) * gnu/packages/emacs-xyz.scm (emacs-git-email): Update to 0.6.0 on actively maintained fork. Update homepage. Add emacs-piem as a build-time dependency. Don't propagate mu, emacs-magit, and emacs-notmuch since they are optional. * gnu/local.mk (dist_patch_DATA): Delete emacs-git-email-missing-parens.patch, since it's no longer needed. * gnu/packages/patches/emacs-git-email-missing-parens.patch: Delete unnecessary patch. Change-Id: I47f5aa12cfa676772e281a45cdc9ec3bb3eae544 --- gnu/local.mk | 1 - gnu/packages/emacs-xyz.scm | 63 ++++++++----------- .../emacs-git-email-missing-parens.patch | 27 -------- 3 files changed, 25 insertions(+), 66 deletions(-) delete mode 100644 gnu/packages/patches/emacs-git-email-missing-parens.patch diff --git a/gnu/local.mk b/gnu/local.mk index 1f48fddc9e..88b3bc8ffb 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1188,7 +1188,6 @@ dist_patch_DATA = \ %D%/packages/patches/emacs-disable-jit-compilation.patch \ %D%/packages/patches/emacs-exec-path.patch \ %D%/packages/patches/emacs-fix-scheme-indent-function.patch \ - %D%/packages/patches/emacs-git-email-missing-parens.patch \ %D%/packages/patches/emacs-helpful-fix-tests.patch \ %D%/packages/patches/emacs-highlight-stages-add-gexp.patch \ %D%/packages/patches/emacs-json-reformat-fix-tests.patch \ diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index b3517b7bd9..b8eb4b6b1a 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -22186,44 +22186,31 @@ (define-public emacs-gitpatch (license license:gpl3+))) (define-public emacs-git-email - ;; Use latest commit since latest tagged release is missing important - ;; changes. - (let ((commit "b5ebade3a48dc0ce0c85699f25800808233c73be") - (revision "0")) - (package - (name "emacs-git-email") - (version (git-version "0.2.0" revision commit)) - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://git.sr.ht/~yoctocell/git-email") - (commit commit))) - (patches - (search-patches "emacs-git-email-missing-parens.patch")) - (file-name (git-file-name name version)) - (sha256 - (base32 "1lk1yds7idgawnair8l3s72rgjmh80qmy4kl5wrnqvpmjrmdgvnx")))) - (build-system emacs-build-system) - (arguments - `(#:phases - (modify-phases %standard-phases - ;; piem is not yet packaged in Guix. - (add-after 'unpack 'remove-piem - (lambda _ - (delete-file "git-email-piem.el"))) - (add-before 'install 'makeinfo - (lambda _ - (invoke "makeinfo" "doc/git-email.texi")))))) - (native-inputs - (list texinfo)) - (propagated-inputs - (list mu emacs-magit emacs-notmuch)) - (license license:gpl3+) - (home-page "https://sr.ht/~yoctocell/git-email") - (synopsis "Format and send Git patches in Emacs") - (description "This package provides utilities for formatting and -sending Git patches via Email, without leaving Emacs.")))) + (package + (name "emacs-git-email") + (version "0.6.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://codeberg.org/suhail/git-email") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 "1cx6a4dxvdggnjn95a9fhcidd1140srpzw9lx9hi65kancnyjsci")))) + (build-system emacs-build-system) + (arguments + `(#:phases (modify-phases %standard-phases + (add-before 'install 'makeinfo + (lambda _ + (invoke "makeinfo" "doc/git-email.texi")))))) + (inputs (list mu emacs-magit emacs-notmuch emacs-piem)) + (native-inputs (list texinfo)) + (license license:gpl3+) + (home-page "https://suhail.codeberg.page/git-email") + (synopsis "Format and send Git patches in Emacs") + (description "This package provides utilities for formatting and +sending Git patches via Email, without leaving Emacs."))) (define-public emacs-erc-hl-nicks (package diff --git a/gnu/packages/patches/emacs-git-email-missing-parens.patch b/gnu/packages/patches/emacs-git-email-missing-parens.patch deleted file mode 100644 index 051e2bf1eb..0000000000 --- a/gnu/packages/patches/emacs-git-email-missing-parens.patch +++ /dev/null @@ -1,27 +0,0 @@ -From 820ad7eb2e919e3f880bec22bd4f737fa55c4d22 Mon Sep 17 00:00:00 2001 -From: Niklas Eklund -Date: Thu, 5 May 2022 12:43:49 +0200 -Subject: [PATCH] Fix missing parens in git-email-mu4e.el - -The incorrect number of parens in this file lead to Emacs failing to -parse the file. ---- - git-email-mu4e.el | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/git-email-mu4e.el b/git-email-mu4e.el -index d5b8770..9220bf9 100644 ---- a/git-email-mu4e.el -+++ b/git-email-mu4e.el -@@ -51,7 +51,7 @@ from Lisp, enable the mode if ARG is omitted or nil." - ;; built in context feature. - (seq-filter (lambda (header) - (not (eq (car header) 'from))) -- headers) -+ headers)))) - (setq git-email-compose-email-function 'message-mail))) - - (provide 'git-email-mu4e) --- -2.34.0 - base-commit: 07cd046c209f192032b425d2ee44f6025bff63a1 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 15 02:42:00 2024 Received: (at 74231-done) by debbugs.gnu.org; 15 Nov 2024 07:42:00 +0000 Received: from localhost ([127.0.0.1]:48379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBqxr-0006ie-Qu for submit@debbugs.gnu.org; Fri, 15 Nov 2024 02:42:00 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:50620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBqxp-0006iU-JW for 74231-done@debbugs.gnu.org; Fri, 15 Nov 2024 02:41:58 -0500 Received: by mail-wr1-f68.google.com with SMTP id ffacd0b85a97d-3821e0b2262so789099f8f.1 for <74231-done@debbugs.gnu.org>; Thu, 14 Nov 2024 23:41:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731656457; x=1732261257; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=GVZ/pRK8BD5ngntKf0R6/tt1y1T6cXS6ao3pv4a9VGk=; b=e6TVXmAbB8GWKy6xeOc4YYnl1516t8GQx0k2lvz0okxqQz82W+2hanR1jQLdgPlExp A9qQhAH3hMaCVw7Jb4OMfH4cFnXGFmZvFAfqVVyw8WRZIpz5yh2YhJ9Su7/0VQje4+ol 8qLqIAirlWqFX4/Ulsg4nKMkYlVSU9p5OYeI1KG63PG/G+BrVAhB/LWznsyUqPg5jEMF hToLWsr70Mt8hfN+umvRkT5OLKIJvBIS70jNXA5QgqjAxTg2DTY8Wnqn42atXnSsSAAa LbeOwq7gjhUDJZ78SbtiJmVGyUdjmqvdxmRTesFVtFWySebBa1/Ef8OCDp0Ucq081+rE Y2qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731656457; x=1732261257; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GVZ/pRK8BD5ngntKf0R6/tt1y1T6cXS6ao3pv4a9VGk=; b=h7qvs2X8sdRYfpTCWMPSKx+Mp1V8MHhxDVYjSLorCXS7A42r8a0kGddme8HR/vdWY8 mqzA2Hmmvel0F7M6/oc0mrkqChLdasGCjvFw3rc4MwQ6Dd4qGln8JwUbYiZASEv2LHF3 tAKFmW09nELRDX5LG0xBFFOMrjb3HMkXxeO1vCLzROllnFcdqWdK2ZHSuE4/nIR5KHQA Z1EFp/hrt67gmB0qPHJYbcUZSNO0SSD2G+KhVSHt0tT7ouCjLjFG9Yz4I9NGZ95Sotxe IIhnj8HXmZgUDz5jq3DtDCb5Y4xeFEn5YHLO+hQJ0Ml1Ua0uACCppgsX4whma3QZHUp2 flFQ== X-Forwarded-Encrypted: i=1; AJvYcCWlq7LPMvqEnLZs5ti98Ij0H6xyyCWhOhlu5Es22VlErCSq0T7hWsIKvdm136Ln6QBh2tziYXhZtQTi@debbugs.gnu.org X-Gm-Message-State: AOJu0YyOZPmE95iEhEcROvXbfKJm5okoYCocRBJlbsAa5ojFNWc95DY3 b84KKUDAjyHny3Irv0xnKGRJ6Rtr6akyf12ooqEDpoVe4xZ32CDj X-Google-Smtp-Source: AGHT+IGOxbfDJk6pabooWCTpKZ4zoBpAJc3gtbnghdC01lcRZPdRdk6w09lf71kVIqyaTYkzc0FGLg== X-Received: by 2002:a5d:64e2:0:b0:37d:50e7:8c56 with SMTP id ffacd0b85a97d-38225a428demr1337282f8f.11.1731656456488; Thu, 14 Nov 2024 23:40:56 -0800 (PST) Received: from lumine.fritz.box (85-127-114-32.dsl.dynamic.surfer.at. [85.127.114.32]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3821ae3127bsm3572419f8f.101.2024.11.14.23.40.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2024 23:40:56 -0800 (PST) Message-ID: Subject: Re: [bug#74231] [PATCH v2] gnu: emacs-git-email: Update to 0.6.0. From: Liliana Marie Prikler To: Suhail Singh , 74231-done@debbugs.gnu.org Date: Fri, 15 Nov 2024 08:41:18 +0100 In-Reply-To: <4dda52df4c7e1da9c03cdf6d97c224b777c8fa59.1731521500.git.suhail@bayesians.ca> References: <578f2ae3ba7cc4838ffdbc0929e6d3a5c8a6a9cc.1730918803.git.suhail@bayesians.ca> <4dda52df4c7e1da9c03cdf6d97c224b777c8fa59.1731521500.git.suhail@bayesians.ca> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74231-done Cc: Katherine Cox-Buday , Andrew Tropin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Am Mittwoch, dem 06.11.2024 um 13:37 -0500 schrieb Suhail Singh: > * gnu/packages/emacs-xyz.scm (emacs-git-email): Update to 0.6.0 on > actively > maintained fork.=C2=A0 Update homepage.=C2=A0 Add emacs-piem as a build-t= ime > dependency. > Don't propagate mu, emacs-magit, and emacs-notmuch since they are > optional. > * gnu/local.mk (dist_patch_DATA): Delete emacs-git-email-missing- > parens.patch, > since it's no longer needed. > * gnu/packages/patches/emacs-git-email-missing-parens.patch: Delete > unnecessary patch. >=20 > Change-Id: I47f5aa12cfa676772e281a45cdc9ec3bb3eae544 Reworded and pushed. Thanks From unknown Thu Aug 14 18:37:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 13 Dec 2024 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator