GNU bug report logs - #74230
30.0.92; eshell-emit-prompt clobbers text properties

Previous Next

Full log

Message #11 received at 74230 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: ashton <at> wiersdorfmail.net, 74230 <at> debbugs.gnu.org
Subject: Re: bug#74230: 30.0.92; eshell-emit-prompt clobbers text properties
Date: Thu, 14 Nov 2024 10:52:21 +0200

> Date: Thu, 7 Nov 2024 10:16:16 -0800
> Cc: eliz <at> gnu.org
> From: Jim Porter <jporterbugs <at> gmail.com>
> 
> On 11/6/2024 10:21 AM, Ashton Wiersdorf wrote:
> > In Emacs 29.4, the function did *not* overwrite the text properties of
> > the prompt `rear-nonsticky (read-only)`. The new version overwrites the
> > rear-nonsticky property so that it is only `(field)`.
> 
> Thanks for noticing this.
> 
> > If I set `eshell-highlight-prompt' to `t', then I get the read-only
> > behavior that I want, but now I cannot get the pleasant component
> > highlighting that `fancy-shell' is meant to provide.
> 
> If you set the 'face' attribute instead of the 'font-lock-face' 
> attribute, you should get the highlighting you want (that's what I do) 
> while 'eshell-highlight-prompt' is non-nil.
> 
> Here's a patch to fix this though so that we're more careful about not 
> clobbering stickiness properties. Eli, what do you think about this 
> patch? It fixes a regression from Emacs 29, but the diff is fairly large 
> for so late in the Emacs 30 cycle. Unfortunately, I can't think of a 
> better solution that doesn't just shuffle the bug around to a different 
> spot. On the plus side, this code already has regression tests, and it 
> was easy to add a new one for this case.
> 
> Personally, I'd be ok with having this be a known bug (there's a 
> workaround for Emacs 30) and fixing it on master. But if you think this 
> change is ok for the release branch, I'd also be ok with installing 
> there; then people don't need to deal with the workaround.

I agree, let's fix this on master.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.