GNU bug report logs - #74225
[PATCH] lint: Check for more types of custom 'check phases.

Previous Next

Full log

View this message in rfc822 format

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Dariqq <dariqq <at> posteo.net>, 74225 <at> debbugs.gnu.org
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, Mathieu Othacehe <othacehe <at> gnu.org>, Ludovic Courtès <ludo <at> gnu.org>, Tobias Geerinckx-Rice <me <at> tobias.gr>, Dariqq <dariqq <at> posteo.net>, Christopher Baines <guix <at> cbaines.net>
Subject: [bug#74225] [PATCH] lint: Check for more types of custom 'check phases.
Date: Sat, 16 Nov 2024 09:07:54 +0100

Hi,

On Wed, 06 Nov 2024 at 10:46, Dariqq <dariqq <at> posteo.net> wrote:

> diff --git a/guix/lint.scm b/guix/lint.scm
> index 8c6c20c723..4ba728da33 100644
> --- a/guix/lint.scm
> +++ b/guix/lint.scm
> @@ -1433,6 +1433,10 @@ (define (check-optional-tests package)
>      (match delta
>        (`(replace 'check ,expression)
>         (check-check-procedure expression))
> +      (`(add-after ,_ 'check ,expression)
> +       (check-check-procedure expression))
> +      (`(add-before ,_ 'check ,expression)
> +       (check-check-procedure expression))

Please note that 'check here is up to packagers.  They might pick the
symbol 'tests or 'run-check or 'adjusted-tests or 'custom-tests or
whatever else.  To my knowledge, there is no real convention.

Well, I do not know.

Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.