GNU bug report logs - #74225
[PATCH] lint: Check for more types of custom 'check phases.

Previous Next

Full log

View this message in rfc822 format

From: Dariqq <dariqq <at> posteo.net>
To: Simon Tournier <zimon.toutoune <at> gmail.com>, 74225 <at> debbugs.gnu.org
Cc: Christopher Baines <guix <at> cbaines.net>, Josselin Poiret <dev <at> jpoiret.xyz>, Tobias Geerinckx-Rice <me <at> tobias.gr>, Ludovic Courtès <ludo <at> gnu.org>, Mathieu Othacehe <othacehe <at> gnu.org>
Subject: [bug#74225] [PATCH] lint: Check for more types of custom 'check phases.
Date: Tue, 19 Nov 2024 14:32:33 +0000

Hi Simon,

On 16.11.24 09:07, Simon Tournier wrote:
> Hi,
> 
> On Wed, 06 Nov 2024 at 10:46, Dariqq <dariqq <at> posteo.net> wrote:
> 
>> diff --git a/guix/lint.scm b/guix/lint.scm
>> index 8c6c20c723..4ba728da33 100644
>> --- a/guix/lint.scm
>> +++ b/guix/lint.scm
>> @@ -1433,6 +1433,10 @@ (define (check-optional-tests package)
>>       (match delta
>>         (`(replace 'check ,expression)
>>          (check-check-procedure expression))
>> +      (`(add-after ,_ 'check ,expression)
>> +       (check-check-procedure expression))
>> +      (`(add-before ,_ 'check ,expression)
>> +       (check-check-procedure expression))
> 
> Please note that 'check here is up to packagers.  They might pick the
> symbol 'tests or 'run-check or 'adjusted-tests or 'custom-tests or
> whatever else.  To my knowledge, there is no real convention.
> 

Of course this is not perfect because the name of the phase to run the 
tests is arbitrary but this (simple) change catches this problem in 38 
packages currently in guix (and 'check seems to be convention in guix)

This came out of a frustration with failing tests in u-boot-tools which 
implements a custom 'check phase after 'install which before 
e6ec657c497cdfe9130b7bf5bdfb717a823bf02b were unskipable but passed the 
lint check.



> Well, I do not know.
> 
> Cheers,
> simon

Dariqq

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.