Subject: bug#74225: closed (Re: [bug#74225] [PATCH] lint: Check for more types of custom 'check phases.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 18 Dec 2024 10:47:02 +0000

Your bug report

#74225: [PATCH] lint: Check for more types of custom 'check phases.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
74225: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74225
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#74225] [PATCH] lint: Check for more types of custom 'check phases.
From: Ludovic Courtès <[email-masked]>
To: Dariqq <[email-masked]>
Cc: Josselin Poiret <[email-masked]>, Simon Tournier <[email-masked]>, Mathieu Othacehe <[email-masked]>, Tobias Geerinckx-Rice <[email-masked]>, Christopher Baines <[email-masked]>, [email-masked]
Date: Wed, 18 Dec 2024 11:45:50 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Dariqq <[email-masked]> skribis:

> * guix/lint.scm (check-optional-tests): Also check for add-before and
> add-after when adding custom 'check phases.
>
> Change-Id: Idc959f90d7e9aa9d5001f34e00f88b41aa20fb2a

Applied, thanks!

Subject: [PATCH] lint: Check for more types of custom 'check phases.
From: Dariqq <[email-masked]>
To: [email-masked]
Cc: Dariqq <[email-masked]>
Date: Wed, 6 Nov 2024 10:46:48 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

* guix/lint.scm (check-optional-tests): Also check for add-before and
add-after when adding custom 'check phases.

Change-Id: Idc959f90d7e9aa9d5001f34e00f88b41aa20fb2a
---
Hi,
Stumbled upon a test failure in u-boot-utils today which is not using #:tests? for its custom 'check phase but not being detected by the linter. Reason is that the 'check phase is added after 'install and not just replacing it.

This little patch makes it it possible to detect it and adds 38 more warnings.

 guix/lint.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/guix/lint.scm b/guix/lint.scm
index 8c6c20c723..4ba728da33 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -1433,6 +1433,10 @@ (define (check-optional-tests package)
     (match delta
       (`(replace 'check ,expression)
        (check-check-procedure expression))
+      (`(add-after ,_ 'check ,expression)
+       (check-check-procedure expression))
+      (`(add-before ,_ 'check ,expression)
+       (check-check-procedure expression))
       (_ '())))
   (define (check-phases-deltas deltas)
     (append-map check-phases-delta deltas))

base-commit: 0c1a6db8094dc6b20762eceae369daae545fc5e4
-- 
2.46.0