From unknown Fri Aug 15 04:07:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#74225] [PATCH] lint: Check for more types of custom 'check phases. Resent-From: Dariqq Original-Sender: "Debbugs-submit" Resent-CC: guix@cbaines.net, dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org, zimon.toutoune@gmail.com, me@tobias.gr, guix-patches@gnu.org Resent-Date: Wed, 06 Nov 2024 11:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74225 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74225@debbugs.gnu.org Cc: Dariqq , Christopher Baines , Josselin Poiret , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Christopher Baines , Josselin Poiret , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Received: via spool by submit@debbugs.gnu.org id=B.17308910675344 (code B ref -1); Wed, 06 Nov 2024 11:05:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Nov 2024 11:04:27 +0000 Received: from localhost ([127.0.0.1]:39827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8dpq-0001O7-Ri for submit@debbugs.gnu.org; Wed, 06 Nov 2024 06:04:27 -0500 Received: from lists.gnu.org ([209.51.188.17]:52142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8dpp-0001O0-5l for submit@debbugs.gnu.org; Wed, 06 Nov 2024 06:04:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8dpo-00050K-2a for guix-patches@gnu.org; Wed, 06 Nov 2024 06:04:24 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8dpl-0003Pv-V9 for guix-patches@gnu.org; Wed, 06 Nov 2024 06:04:23 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5B6BB240101 for ; Wed, 6 Nov 2024 12:04:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1730891058; bh=MeVpO/FJe0uvlSAVeGsygioCK66q4Tysb/ENi28fL7c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=LpTUtv/Qqc5FQW0Sk4ayxWo4KxYYgshMb3e76TASbS2WNi1LCkLlLNP1oDGkgDy7M al+V6smaA+8S+5Fexv2ytcMED83sthtEMlfBwDguX3RZlw0QxE5ZC4p/tUbpEfXAYT LfxQSaqwCXb6XRagIKwBt4JE0HclhiYWZBE2fpg7hCr6/bzufJO2lnzhNISy6IyPA+ ytJV3QxBZ/dQzTkbSzNmSuSshekAfIFDXi2TGAAz9oC/qJ+BwKcaF3mk23oNDZ5ysh WZQKj5mL68tzJXTpamTmcaFpK/KAiOXv/smLfqISiDrfRaNHvjbnFWG31IGkfSWWHp 2TAqmez5u6agQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Xk2QT5tf4z9rxQ; Wed, 6 Nov 2024 12:04:17 +0100 (CET) From: Dariqq Date: Wed, 6 Nov 2024 10:46:48 +0000 Message-ID: <705438b285d013ee05c5ae1d73b1c80aff2aa4fa.1730890007.git.dariqq@posteo.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=dariqq@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * guix/lint.scm (check-optional-tests): Also check for add-before and add-after when adding custom 'check phases. Change-Id: Idc959f90d7e9aa9d5001f34e00f88b41aa20fb2a --- Hi, Stumbled upon a test failure in u-boot-utils today which is not using #:tests? for its custom 'check phase but not being detected by the linter. Reason is that the 'check phase is added after 'install and not just replacing it. This little patch makes it it possible to detect it and adds 38 more warnings. guix/lint.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/guix/lint.scm b/guix/lint.scm index 8c6c20c723..4ba728da33 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -1433,6 +1433,10 @@ (define (check-optional-tests package) (match delta (`(replace 'check ,expression) (check-check-procedure expression)) + (`(add-after ,_ 'check ,expression) + (check-check-procedure expression)) + (`(add-before ,_ 'check ,expression) + (check-check-procedure expression)) (_ '()))) (define (check-phases-deltas deltas) (append-map check-phases-delta deltas)) base-commit: 0c1a6db8094dc6b20762eceae369daae545fc5e4 -- 2.46.0 From unknown Fri Aug 15 04:07:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#74225] [PATCH] lint: Check for more types of custom 'check phases. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 16 Nov 2024 11:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74225 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Dariqq , 74225@debbugs.gnu.org Cc: Josselin Poiret , Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Dariqq , Christopher Baines Received: via spool by 74225-submit@debbugs.gnu.org id=B74225.173175474916557 (code B ref 74225); Sat, 16 Nov 2024 11:00:02 +0000 Received: (at 74225) by debbugs.gnu.org; 16 Nov 2024 10:59:09 +0000 Received: from localhost ([127.0.0.1]:52237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCGWC-0004Iy-U4 for submit@debbugs.gnu.org; Sat, 16 Nov 2024 05:59:09 -0500 Received: from mail-pl1-f176.google.com ([209.85.214.176]:49324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCGWA-0004Iq-LY for 74225@debbugs.gnu.org; Sat, 16 Nov 2024 05:59:07 -0500 Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-20caccadbeeso17045615ad.2 for <74225@debbugs.gnu.org>; Sat, 16 Nov 2024 02:59:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731754686; x=1732359486; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=AmXbB0uQigtSCn3fSGRu6n2Sx9nRsUIVQavHRLTxKZE=; b=ND2LN/jewtX/fDwGIYEuuBBGADJwGhjwDoUgSvRQdUHzS3pju2kdl/meyleCh1zv1x QC+x3LbcWSLrINF5kNHX5uIKerdP7FeYTgvzsCH/8cuV+BXfu1E7EeEPL5mSGmtSP3JN U2TN1nx9Ot52sYfQRzWycsclpDl59Y7J5YRu7pZjtAsdt1eCr6tZO5NioFLD1P89d1J7 i+3Wgz2/iX/x+eA+rlRm9lx3t45RNsnqWz0O5EYA5C9DerM5NEeUVw5NOdwofN3BZ2uN G9/7YHXHIKLVkeGSGtyLPCBVGuEZLDeFg4IWUB30PVJfzX6uTOmA7N9QXNr9Z3tMNR7s 4mmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731754686; x=1732359486; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AmXbB0uQigtSCn3fSGRu6n2Sx9nRsUIVQavHRLTxKZE=; b=hkUCg6h1LtHS7evcStkdAauQm5UrVlzlOkaMFrzDdScq5zSJnlcwxFCUbGvx3disWv JNCurpqyDeQq6pg3s8/kwnrGdfJp1GLJJSza9tceIiY3De1mcuXQUOc3s3+umGsMmPpo HXbR0kCv2TjFRWaNd+osgT3rwcg7ccXFH+22cuXean58rgDomh1tUJkPml16hovjB5sJ 3ziC3BLiyLdzSErlSX+qX0DsfLPXGI+agYNwr62vy0oStsMivzVAfeJLEgw5NEZhZFTQ o2ZjpLpFyav/DXYva+wMwwdK66ub7h0hqrZRy4Wpaqa58uuY3e8or8XS+RkU4Bvwb0pP GXHQ== X-Forwarded-Encrypted: i=1; AJvYcCVrfJ5Mp/ZkBvGttvanlaYAzpOWgdEyVufHCXDQ+S8YerSy4vu2DQaOAoAdARRVTOM3q7JLYA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx1vRmWH8b9rmdI9/JtzCdMfC4bRCE58w71KG03mbS4+ARhB6US G4qGOXXDRss7Byv2SDKxbbsnPkxSgwLQwBYULZa3jQ1mJZ+zwAo2 X-Google-Smtp-Source: AGHT+IGLU1Ip6pUA/X64Z6gwG4v8KAvZXVskNNKYlFGJUhKi34W71cuii2jdypR/PpE9taAP0bsDNA== X-Received: by 2002:a17:902:da92:b0:20b:5be:a403 with SMTP id d9443c01a7336-211d0d5eafdmr77721865ad.11.1731754685956; Sat, 16 Nov 2024 02:58:05 -0800 (PST) Received: from lili ([147.127.248.1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211d0ec937esm25690685ad.91.2024.11.16.02.57.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Nov 2024 02:58:05 -0800 (PST) From: Simon Tournier In-Reply-To: <705438b285d013ee05c5ae1d73b1c80aff2aa4fa.1730890007.git.dariqq@posteo.net> References: <705438b285d013ee05c5ae1d73b1c80aff2aa4fa.1730890007.git.dariqq@posteo.net> Date: Sat, 16 Nov 2024 09:07:54 +0100 Message-ID: <87ed3bbnz9.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, On Wed, 06 Nov 2024 at 10:46, Dariqq wrote: > diff --git a/guix/lint.scm b/guix/lint.scm > index 8c6c20c723..4ba728da33 100644 > --- a/guix/lint.scm > +++ b/guix/lint.scm > @@ -1433,6 +1433,10 @@ (define (check-optional-tests package) > (match delta > (`(replace 'check ,expression) > (check-check-procedure expression)) > + (`(add-after ,_ 'check ,expression) > + (check-check-procedure expression)) > + (`(add-before ,_ 'check ,expression) > + (check-check-procedure expression)) Please note that 'check here is up to packagers. They might pick the symbol 'tests or 'run-check or 'adjusted-tests or 'custom-tests or whatever else. To my knowledge, there is no real convention. Well, I do not know. Cheers, simon From unknown Fri Aug 15 04:07:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#74225] [PATCH] lint: Check for more types of custom 'check phases. Resent-From: Dariqq Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 19 Nov 2024 14:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74225 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier , 74225@debbugs.gnu.org Cc: Christopher Baines , Josselin Poiret , Tobias Geerinckx-Rice , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe Received: via spool by 74225-submit@debbugs.gnu.org id=B74225.17320267762305 (code B ref 74225); Tue, 19 Nov 2024 14:33:02 +0000 Received: (at 74225) by debbugs.gnu.org; 19 Nov 2024 14:32:56 +0000 Received: from localhost ([127.0.0.1]:41637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDPHj-0000b7-9l for submit@debbugs.gnu.org; Tue, 19 Nov 2024 09:32:55 -0500 Received: from mout01.posteo.de ([185.67.36.65]:58827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDPHg-0000ag-87 for 74225@debbugs.gnu.org; Tue, 19 Nov 2024 09:32:52 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 0EF2B240028 for <74225@debbugs.gnu.org>; Tue, 19 Nov 2024 15:32:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1732026766; bh=t6jlU7zv5VsB4JF+rXwP+tH6CvjDFZdoReZTrpI1Anw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=X4n7hBv77nZiwnAmLXyMGaH3EHSCHSSXanL4Gi4UXFbwN1umN0+zNZfYnAa+L2AO+ /3W75s2YxTRyFm+xgtFGUo6yEQ1PnLGnixCcoO8mCwFlBAsSasIauH+WMaELrzmG3u xw1B7PEwGY82umEIhhGtq512Je6IqGkhxh8tfzUCqGufGxgiwAb0fQRjZ/iu2K24rB VC9QWi9Zzem5izNcOC8hBUtqKOWFSWS/fwQnvip8Lf4f9H88rppjdbZo1B4oU1PQnc q26pSeUhTUuO6QoO0Rjn+DhZ5s2aP6/SKVqVIJjssjslkF9ZvwaP2cCA33W8Mo4ooa Yw5WTEXBNu7lw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Xt6Qz124Rz6v0H; Tue, 19 Nov 2024 15:32:43 +0100 (CET) Message-ID: Date: Tue, 19 Nov 2024 14:32:33 +0000 MIME-Version: 1.0 References: <705438b285d013ee05c5ae1d73b1c80aff2aa4fa.1730890007.git.dariqq@posteo.net> <87ed3bbnz9.fsf@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <87ed3bbnz9.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Simon, On 16.11.24 09:07, Simon Tournier wrote: > Hi, > > On Wed, 06 Nov 2024 at 10:46, Dariqq wrote: > >> diff --git a/guix/lint.scm b/guix/lint.scm >> index 8c6c20c723..4ba728da33 100644 >> --- a/guix/lint.scm >> +++ b/guix/lint.scm >> @@ -1433,6 +1433,10 @@ (define (check-optional-tests package) >> (match delta >> (`(replace 'check ,expression) >> (check-check-procedure expression)) >> + (`(add-after ,_ 'check ,expression) >> + (check-check-procedure expression)) >> + (`(add-before ,_ 'check ,expression) >> + (check-check-procedure expression)) > > Please note that 'check here is up to packagers. They might pick the > symbol 'tests or 'run-check or 'adjusted-tests or 'custom-tests or > whatever else. To my knowledge, there is no real convention. > Of course this is not perfect because the name of the phase to run the tests is arbitrary but this (simple) change catches this problem in 38 packages currently in guix (and 'check seems to be convention in guix) This came out of a frustration with failing tests in u-boot-tools which implements a custom 'check phase after 'install which before e6ec657c497cdfe9130b7bf5bdfb717a823bf02b were unskipable but passed the lint check. > Well, I do not know. > > Cheers, > simon Dariqq From unknown Fri Aug 15 04:07:28 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Dariqq Subject: bug#74225: closed (Re: [bug#74225] [PATCH] lint: Check for more types of custom 'check phases.) Message-ID: References: <87ldwdmfq9.fsf@gnu.org> <705438b285d013ee05c5ae1d73b1c80aff2aa4fa.1730890007.git.dariqq@posteo.net> X-Gnu-PR-Message: they-closed 74225 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 74225@debbugs.gnu.org Date: Wed, 18 Dec 2024 10:47:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1734518822-14979-1" This is a multi-part message in MIME format... ------------=_1734518822-14979-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #74225: [PATCH] lint: Check for more types of custom 'check phases. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 74225@debbugs.gnu.org. --=20 74225: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74225 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1734518822-14979-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 74225-done) by debbugs.gnu.org; 18 Dec 2024 10:46:53 +0000 Received: from localhost ([127.0.0.1]:33599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNrZt-0003tH-5I for submit@debbugs.gnu.org; Wed, 18 Dec 2024 05:46:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNrZn-0003ss-C8 for 74225-done@debbugs.gnu.org; Wed, 18 Dec 2024 05:46:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNrZg-00059g-2K; Wed, 18 Dec 2024 05:46:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=kDQankiJ52/n0qNXBoS4wFusPZfoqYKcVsf25xAttpo=; b=IGrV/20whv13N2MVj7XF a2/tRNV1Di/OuYNw+4bml6AkWLJugOzJMkn4xYjWnlA22eblJZWnC8EGTt1hMXH8uWM1mA9KcEw/s DZX4jqA88AvuCPNSVlzhBvFBg9tTdBIPQ7zz3ONj/v1+cnL1DC34/ZHf7kISU3SszO5wlbv0doLs1 oMa1C9Oe2mr1VobPDI15HMszQHi7F0iXXggJBOhrrTMLcQxDz+VVepZxviwHeBpyEU/JlBqPDBYoo blkUSk4LXgXi4fGrtdlJvINTdhK+A25/8rk1c+k+j+HZVeznm2fj2Qn8Lkd9WWOsqK4a8TH7MjJGZ 39m3eLoVQ2uVfw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Dariqq Subject: Re: [bug#74225] [PATCH] lint: Check for more types of custom 'check phases. In-Reply-To: <705438b285d013ee05c5ae1d73b1c80aff2aa4fa.1730890007.git.dariqq@posteo.net> (dariqq@posteo.net's message of "Wed, 6 Nov 2024 10:46:48 +0000") References: <705438b285d013ee05c5ae1d73b1c80aff2aa4fa.1730890007.git.dariqq@posteo.net> Date: Wed, 18 Dec 2024 11:45:50 +0100 Message-ID: <87ldwdmfq9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74225-done Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Christopher Baines , 74225-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Dariqq skribis: > * guix/lint.scm (check-optional-tests): Also check for add-before and > add-after when adding custom 'check phases. > > Change-Id: Idc959f90d7e9aa9d5001f34e00f88b41aa20fb2a Applied, thanks! ------------=_1734518822-14979-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Nov 2024 11:04:27 +0000 Received: from localhost ([127.0.0.1]:39827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8dpq-0001O7-Ri for submit@debbugs.gnu.org; Wed, 06 Nov 2024 06:04:27 -0500 Received: from lists.gnu.org ([209.51.188.17]:52142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8dpp-0001O0-5l for submit@debbugs.gnu.org; Wed, 06 Nov 2024 06:04:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8dpo-00050K-2a for guix-patches@gnu.org; Wed, 06 Nov 2024 06:04:24 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8dpl-0003Pv-V9 for guix-patches@gnu.org; Wed, 06 Nov 2024 06:04:23 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5B6BB240101 for ; Wed, 6 Nov 2024 12:04:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1730891058; bh=MeVpO/FJe0uvlSAVeGsygioCK66q4Tysb/ENi28fL7c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=LpTUtv/Qqc5FQW0Sk4ayxWo4KxYYgshMb3e76TASbS2WNi1LCkLlLNP1oDGkgDy7M al+V6smaA+8S+5Fexv2ytcMED83sthtEMlfBwDguX3RZlw0QxE5ZC4p/tUbpEfXAYT LfxQSaqwCXb6XRagIKwBt4JE0HclhiYWZBE2fpg7hCr6/bzufJO2lnzhNISy6IyPA+ ytJV3QxBZ/dQzTkbSzNmSuSshekAfIFDXi2TGAAz9oC/qJ+BwKcaF3mk23oNDZ5ysh WZQKj5mL68tzJXTpamTmcaFpK/KAiOXv/smLfqISiDrfRaNHvjbnFWG31IGkfSWWHp 2TAqmez5u6agQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Xk2QT5tf4z9rxQ; Wed, 6 Nov 2024 12:04:17 +0100 (CET) From: Dariqq To: guix-patches@gnu.org Subject: [PATCH] lint: Check for more types of custom 'check phases. Date: Wed, 6 Nov 2024 10:46:48 +0000 Message-ID: <705438b285d013ee05c5ae1d73b1c80aff2aa4fa.1730890007.git.dariqq@posteo.net> MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=dariqq@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Dariqq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * guix/lint.scm (check-optional-tests): Also check for add-before and add-after when adding custom 'check phases. Change-Id: Idc959f90d7e9aa9d5001f34e00f88b41aa20fb2a --- Hi, Stumbled upon a test failure in u-boot-utils today which is not using #:tests? for its custom 'check phase but not being detected by the linter. Reason is that the 'check phase is added after 'install and not just replacing it. This little patch makes it it possible to detect it and adds 38 more warnings. guix/lint.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/guix/lint.scm b/guix/lint.scm index 8c6c20c723..4ba728da33 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -1433,6 +1433,10 @@ (define (check-optional-tests package) (match delta (`(replace 'check ,expression) (check-check-procedure expression)) + (`(add-after ,_ 'check ,expression) + (check-check-procedure expression)) + (`(add-before ,_ 'check ,expression) + (check-check-procedure expression)) (_ '()))) (define (check-phases-deltas deltas) (append-map check-phases-delta deltas)) base-commit: 0c1a6db8094dc6b20762eceae369daae545fc5e4 -- 2.46.0 ------------=_1734518822-14979-1--