From unknown Sun Aug 17 09:11:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#74224 <74224@debbugs.gnu.org> To: bug#74224 <74224@debbugs.gnu.org> Subject: Status: [PATCH][scratch/igc] pgtk: fix crashing bug in atimer used for checking scaling Reply-To: bug#74224 <74224@debbugs.gnu.org> Date: Sun, 17 Aug 2025 16:11:02 +0000 retitle 74224 [PATCH][scratch/igc] pgtk: fix crashing bug in atimer used fo= r checking scaling reassign 74224 emacs submitter 74224 Fejfighter severity 74224 normal tag 74224 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 03:05:04 2024 Received: (at submit) by debbugs.gnu.org; 6 Nov 2024 08:05:04 +0000 Received: from localhost ([127.0.0.1]:39174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8b2G-0001ox-1R for submit@debbugs.gnu.org; Wed, 06 Nov 2024 03:05:04 -0500 Received: from lists.gnu.org ([209.51.188.17]:35848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8b2D-0001no-GZ for submit@debbugs.gnu.org; Wed, 06 Nov 2024 03:05:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8b2B-0008NU-48 for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2024 03:04:59 -0500 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t8b29-0003JS-79 for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2024 03:04:58 -0500 Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2fb5638dd57so60771761fa.0 for ; Wed, 06 Nov 2024 00:04:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730880294; x=1731485094; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=BCvyO4du6y3C6LWKNN+wvU15wdbX3V+hMaSVhobG8bE=; b=KCgzqqbs3DRhC+SpbF8MGgBL04Uw/4Ql5Q2ck3URvYZgQ3UlbyU5wTlTZIjIcQwnu0 uuLLqYZu/o/KVOmHv8BkpAhcdhIvsAa/nCY3wd9ehEeFAXW6zYIu/EqbIPKWDyezLn9i Xqg9HDjr4PX3jhtKzmLldUgQJi91D+dLNOojDxA8gRp+39CIIchvtPp1y1GFow5Zsx3U 5RQdbbKrGp/MyDL8iYEEqaXwoPxGfMhPW06Yz9gerTWAPnauQRYVDOWwDayKqnH2bKPE /XESb+b02AX5U2fbKtE7wGWCKCO0jTNN271mrggqSM+SQpn8SfihZw1JlUpfxc7dmw0k szSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730880294; x=1731485094; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BCvyO4du6y3C6LWKNN+wvU15wdbX3V+hMaSVhobG8bE=; b=VqX7FBEdOsBWfKBxFp2s5gsGui8JsY+ZGKDlfGqmDK5sFimQEE2PKY/nrHeY7FrmvD mzIrnS6On4TCuOzwmCrgxA+VbUNsMybl1bkrkZ7oIb4KnXumtKrHAS2c3/a0q2jSFc3v tZA68DodDYU4ibAxrt4NVreSjL3/oL7hXuQNCnLRKKCyi6+qyfwfJn66eQjmPdTTHth1 grLKNcbr2JF6Ne91Gbr6+ft2WH9PJq0UOq9pdwtu9VwMWykoUHCJvfXN2b1uUUoO01lt sPI8AzjcSwAXrqWIzh8KprdkXJUXnONGwU8kLcbWfZv/tDkmDaIokoodGN9Mug04Zwcj 2tuA== X-Gm-Message-State: AOJu0YwiMuF7cMNPtUhDvxWHodT5e6/P4sBOLDIdG5aY+MA4MdawN9yN cusvMjVbRZmMFm8YlJlUtk+BJzOVYuD7o1JVz+pwjl+Pt5zJ83fC3VyR4/L/AER9xoJ1vcfCx/u PtOiNsODbrDTfo9tsnMqozoX1f6Ik1SJ1 X-Google-Smtp-Source: AGHT+IH/+RtDTyddY7+oOGIziGo6cmmGPH3U5mf8uCAQr7t7yfua9KUvgo3/RTxvAXU92gS/qAiVv6IBFXohpW5nULE= X-Received: by 2002:a05:651c:1546:b0:2fa:c18c:faba with SMTP id 38308e7fff4ca-2fcbe07ac05mr179508841fa.30.1730880294078; Wed, 06 Nov 2024 00:04:54 -0800 (PST) MIME-Version: 1.0 From: Fejfighter Date: Wed, 6 Nov 2024 19:04:42 +1100 Message-ID: Subject: [PATCH][scratch/igc] pgtk: fix crashing bug in atimer used for checking scaling To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="00000000000013ebab062639f99d" Received-SPF: pass client-ip=2a00:1450:4864:20::230; envelope-from=fejfighter@gmail.com; helo=mail-lj1-x230.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --00000000000013ebab062639f99d Content-Type: multipart/alternative; boundary="00000000000013eba9062639f99b" --00000000000013eba9062639f99b Content-Type: text/plain; charset="UTF-8" This patch marks 2 outstanding ambiguous roots and appears to solve crashing bugs I had been experiencing with igc/mps and pgtk. I have run this locally today, and I would have normally faced crashes at timer expiration, this appears to be holding up. In GNU Emacs 31.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.0) of 2024-11-06 built on solidus.local Repository revision: 96de0bf0ba9161af5d3f783b45a5a9de530b6f95 Repository branch: scratch/igc System Description: Fedora Linux 41 (Sway) Configured using: 'configure --with-pgtk --with-mps CFLAGS=-O2' --00000000000013eba9062639f99b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This patch marks 2 outstanding ambiguous roots and appears= to solve
crashing bugs I had been experiencing with igc/mps and pgtk.
I have run this locally today, and I would have normally faced crashe= s at timer expiration, this appears to be holding up.



In GNU= Emacs 31.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version
=C2=A03.24.43= , cairo version 1.18.0) of 2024-11-06 built on solidus.local
Repository = revision: 96de0bf0ba9161af5d3f783b45a5a9de530b6f95
Repository branch: sc= ratch/igc
System Description: Fedora Linux 41 (Sway)

Configured u= sing:
=C2=A0'configure --with-pgtk --with-mps CFLAGS=3D-O2'=


--00000000000013eba9062639f99b-- --00000000000013ebab062639f99d Content-Type: text/x-patch; charset="US-ASCII"; name="mps-igc-pgtk.patch" Content-Disposition: attachment; filename="mps-igc-pgtk.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m35lereq0 ZGlmZiAtLWdpdCBhL3NyYy9hdGltZXIuYyBiL3NyYy9hdGltZXIuYwppbmRleCA4MjUzYWUzYTE2 Ni4uNWJkMjgyYTMxMGQgMTAwNjQ0Ci0tLSBhL3NyYy9hdGltZXIuYworKysgYi9zcmMvYXRpbWVy LmMKQEAgLTE3LDYgKzE3LDcgQEAKIGFsb25nIHdpdGggR05VIEVtYWNzLiAgSWYgbm90LCBzZWUg PGh0dHBzOi8vd3d3LmdudS5vcmcvbGljZW5zZXMvPi4gICovCiAKICNpbmNsdWRlIDxjb25maWcu aD4KKyNpbmNsdWRlICJpZ2MuaCIKIAogI2lmZGVmIFdJTkRPV1NOVAogI2RlZmluZSByYWlzZShz KSB3MzJfcmFpc2UocykKQEAgLTEzMiw3ICsxMzMsMTMgQEAgc3RhcnRfYXRpbWVyIChlbnVtIGF0 aW1lcl90eXBlIHR5cGUsIHN0cnVjdCB0aW1lc3BlYyB0aW1lc3RhbXAsCiAgICAgICBmcmVlX2F0 aW1lcnMgPSB0LT5uZXh0OwogICAgIH0KICAgZWxzZQotICAgIHQgPSB4bWFsbG9jIChzaXplb2Yg KnQpOworICAgIHsKKyNpZmRlZiBIQVZFX01QUworICAgICAgdCA9IGlnY194emFsbG9jX2FtYmln IChzaXplb2YgKnQpOworI2Vsc2UKKyAgICAgIHQgPSB4bWFsbG9jIChzaXplb2YgKnQpOworI2Vu ZGlmCisgICAgfQogCiAgIC8qIEZpbGwgdGhlIGF0aW1lciBzdHJ1Y3R1cmUuICAqLwogICBtZW1z ZXQgKHQsIDAsIHNpemVvZiAqdCk7CmRpZmYgLS1naXQgYS9zcmMvcGd0a3Rlcm0uYyBiL3NyYy9w Z3RrdGVybS5jCmluZGV4IGVmOTQwNTA5NjI2Li5jMGVkNjhkNjgyMCAxMDA2NDQKLS0tIGEvc3Jj L3BndGt0ZXJtLmMKKysrIGIvc3JjL3BndGt0ZXJtLmMKQEAgLTcxNjYsNyArNzE2NiwxMSBAQCAj ZGVmaW5lIE5VTV9BUkdWIDEwCiAgIGlmIChja2RfYWRkICgmbmJ5dGVzLCBTQllURVMgKFZpbnZv Y2F0aW9uX25hbWUpLCBTQllURVMgKHN5c3RlbV9uYW1lKSArIDIpKQogICAgIG1lbW9yeV9mdWxs IChTSVpFX01BWCk7CiAgIGRweWluZm8tPnhfaWQgPSArK3hfZGlzcGxheV9pZDsKKyNpZmRlZiBI QVZFX01QUworICBkcHlpbmZvLT54X2lkX25hbWUgPSBpZ2NfeHphbGxvY19hbWJpZyAobmJ5dGVz KTsKKyNlbHNlCiAgIGRweWluZm8tPnhfaWRfbmFtZSA9IHhtYWxsb2MgKG5ieXRlcyk7CisjZW5k aWYKICAgY2hhciAqbmFtZXRhaWwgPSBsaXNwc3RwY3B5IChkcHlpbmZvLT54X2lkX25hbWUsIFZp bnZvY2F0aW9uX25hbWUpOwogICAqbmFtZXRhaWwrKyA9ICdAJzsKICAgbGlzcHN0cGNweSAobmFt ZXRhaWwsIHN5c3RlbV9uYW1lKTsKQEAgLTczMDIsNyArNzMwNiwxNCBAQCBwZ3RrX2RlbGV0ZV9k aXNwbGF5IChzdHJ1Y3QgcGd0a19kaXNwbGF5X2luZm8gKmRweWluZm8pCiAgICAgfQogCiAgIHBn dGtfZnJlZV9kZXZpY2VzIChkcHlpbmZvKTsKKworI2lmZGVmIEhBVkVfTVBTCisgIGlnY194ZnJl ZSAoZHB5aW5mby0+eF9pZF9uYW1lKTsKKyAgaWdjX3hmcmVlIChkcHlpbmZvKTsKKyNlbHNlCisg IHhmcmVlIChkcHlpbmZvLT54X2lkX25hbWUpOwogICB4ZnJlZSAoZHB5aW5mbyk7CisjZW5kaWYK IH0KIAogY2hhciAqCg== --00000000000013ebab062639f99d-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 03:57:28 2024 Received: (at 74224) by debbugs.gnu.org; 6 Nov 2024 08:57:28 +0000 Received: from localhost ([127.0.0.1]:39586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8bqx-0004Fg-TI for submit@debbugs.gnu.org; Wed, 06 Nov 2024 03:57:28 -0500 Received: from mail-wr1-f54.google.com ([209.85.221.54]:42333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8bqw-0004FR-CY for 74224@debbugs.gnu.org; Wed, 06 Nov 2024 03:57:27 -0500 Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-37d41894a32so312387f8f.1 for <74224@debbugs.gnu.org>; Wed, 06 Nov 2024 00:57:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730883380; x=1731488180; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=PtWnxolvQ6nuOoByHVeZoOhRLsln5NCN6yQbyc0uOuc=; b=ji4Z+e0LpCJe4Z3PKh3KtgmagjjwZFwdq3rftwqi64AXP4cFeL0E8HLq2eJT8yCQgI 00LsEtjEftDVwPEE7qIQK2AHl6mQDgD0DScpT7CGRx0mySZ+HGjz4FDRaFLUflyOHUM2 34X8ihDwDUbD2oVW+mB0UTrPOe9hrI+hmuBTR32avv6EPUAnlmYCUJcOrGuUB0L512im easpQD7gx4YMoFizamtxBgmLKIDiuJhqZJhZog895T+UOr31mv9AtdNC+kdacuvfj+TF bVQmpR6ZYhQU9sJ34vVDzevs4/9iW4DCuw6GH8EN016u0B94FH7VnGWs9Z9ZQ1tbguQZ /dGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730883380; x=1731488180; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PtWnxolvQ6nuOoByHVeZoOhRLsln5NCN6yQbyc0uOuc=; b=Ison9WlGAoIAdc4TUeSQfHnr8mYu7xr4yIYFXDzu6x8gW4pIsXSi83YikqVW2x/f7l dOkeQR9MdDMYLEKFl5RxGt+zkkPLXs4uw+BnRhcTpfkJKa4iWkpl8EtmYsOWAp/S9X9r lfUHA/U1Rl7simseW8Kk5VQqIyZktjBmajd7Uaz4X/QDufVX6p29hGcOr7y/VJrX5ibv nyVyvtn8orS66OoAkQ+mIy/soltlnNY1SHykc6Q9ldQJYdccGs7gCEn5+7q3XqWuz9lR QARQzUSRTW+MAN77Ni1vhM4BeBQU0dOmqLPDItseraCKVORauscN7JItwf6nHQX8e4c8 poYw== X-Gm-Message-State: AOJu0YzW3OL4CImT60cheZF7T+LVZTg3ZsJ+hF8B6TbJRoxUowUmBuxC e6JuJv7cYPieh2DVeQ49KzdeJO27+I44bLxSI2N+yOm+G1u+gGIgHJKH1Q== X-Google-Smtp-Source: AGHT+IGHQFtoEcYztTKcPXYcD+Li3ZHKOQAX2c8592Us0448NXr8/HxXqxeX/TmJ3lNhvON3hWmgqA== X-Received: by 2002:a5d:47cb:0:b0:371:6fc7:d45d with SMTP id ffacd0b85a97d-381e81c5e1emr1259334f8f.2.1730883380146; Wed, 06 Nov 2024 00:56:20 -0800 (PST) Received: from pro2 (pd9e36633.dip0.t-ipconnect.de. [217.227.102.51]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c10e7280sm18469430f8f.59.2024.11.06.00.56.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2024 00:56:19 -0800 (PST) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: Fejfighter Subject: Re: bug#74224: [PATCH][scratch/igc] pgtk: fix crashing bug in atimer used for checking scaling In-Reply-To: (fejfighter@gmail.com's message of "Wed, 6 Nov 2024 19:04:42 +1100") References: Date: Wed, 06 Nov 2024 09:56:18 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74224 Cc: 74224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fejfighter writes: > This patch marks 2 outstanding ambiguous roots and appears to solve > crashing bugs I had been experiencing with igc/mps and pgtk. > > I have run this locally today, and I would have normally faced crashes > at timer expiration, this appears to be holding up. Thanks for the report, Jeff! Nice to see that someone besides me is using this :-). I think I see why the change in atimer.c is necessary: pgtk stores a struct frame * as client_data in an atimer structure. That's a Lisp object that can move during GC. Understood. The other change in pgtkterm.c I don't understand. AFAICS, x_id_name of the display_info structure is indeed only used as a character buffer into which characters from Lisp strings are memcpy'd. Could you please explain that one? (I'm macOS only, so I don't know anything about pgtk, if that matters.) From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 04:31:18 2024 Received: (at 74224) by debbugs.gnu.org; 6 Nov 2024 09:31:18 +0000 Received: from localhost ([127.0.0.1]:39645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8cNi-0005ir-7Q for submit@debbugs.gnu.org; Wed, 06 Nov 2024 04:31:18 -0500 Received: from mail-lj1-f177.google.com ([209.85.208.177]:52583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8cNf-0005ih-Ek for 74224@debbugs.gnu.org; Wed, 06 Nov 2024 04:31:17 -0500 Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2feeb1e8edfso56198891fa.1 for <74224@debbugs.gnu.org>; Wed, 06 Nov 2024 01:31:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730885414; x=1731490214; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VC5o2hMRDXvqcMao+TNuh7NZ7XlClOmx24Odg7cF8PY=; b=YzahiEnR9WX62gFaJIqmEL9SOca4l3QGTn4qfre486EjO/6LbR54vJt1cYibHpMFq9 vv30aobp3eIfZ+1Kj13CfCQGw+4IBTYFZRW3RRxxwg4ceofRN2D++GczZI266vwMpCYH HYEBPHvVV8IEbbHDpygVsjhvx4vV2v/b2H0SYonRMc88bqUAkYlbu+hg6nMgGiQR9EtE WaD+zNNXDoD0xm61bAMYDnCYdQnpDqGwz7tR9KK9DWbcyE72Gyjzs0MMk/eovZRyo6FY 4mnGs2VemfbneB1RINWSYo3spVWgyxMOtYJZ1JWBQh6OMIY0Lt1Wyvg7sRCzl/SHfDmv OOEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730885414; x=1731490214; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VC5o2hMRDXvqcMao+TNuh7NZ7XlClOmx24Odg7cF8PY=; b=Fzh3cxBJOpKACfNKq0bNr9pIFypgGzl1Q3oJMt/YHbb33FVL6lGKd48q8WAkLBIz47 JlvLEPZmg/QolijvYtGjxZFYmb0oJCCBfILITw4UKTz6F1Zewu+0eiVj8myg6fKmLNxq f9HpEXJTA3SR8v4qFUq0hcJ2id9O/Q1dP+OFapnlPGDCjyxJnF8Gkt2Hz7fvyE66r1h6 LoTJKO3VwdmEsYyxaUiHS9F0kCax/ckqMmqskxemRKpGm/KCdWrjgNP1Q+ic2YqYFOoM WzE7FtkYl9dl2o7z3wH64osE4HsfsjUpCzbTsxHZLV1lCbU61u1lu8WKZxbs1O826bjT oAyg== X-Gm-Message-State: AOJu0YwAtiet3ka6613ts2CA72a2f/J8ZLU9FF3FoKde7lAHADb4UcmS oroOvel3Kz+ytyjQ0cKUQAn6j41jKDbWMM8c8/laX2t+wvhwvBa75BRYPN2ofrk4p7XhrHa8GSG E/b3r+2Td9CavLGdgnLIlfTTxcFk= X-Google-Smtp-Source: AGHT+IFnDt6T3L4Qkd61BVObNJj7Vgf1gJYi39J5nqmqCqGGXFMBp9xwLfVpeI89u24IomjV+XgdbP5CVOqK7pM7/Eo= X-Received: by 2002:a05:651c:1148:b0:2fb:61c0:137 with SMTP id 38308e7fff4ca-2fedb82fc8fmr161008491fa.40.1730885413995; Wed, 06 Nov 2024 01:30:13 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jeff Walsh Date: Wed, 6 Nov 2024 20:30:02 +1100 Message-ID: Subject: Re: bug#74224: [PATCH][scratch/igc] pgtk: fix crashing bug in atimer used for checking scaling To: =?UTF-8?Q?Gerd_M=C3=B6llmann?= Content-Type: multipart/mixed; boundary="0000000000003faf0806263b2a5f" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74224 Cc: 74224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000003faf0806263b2a5f Content-Type: multipart/alternative; boundary="0000000000003faf0706263b2a5d" --0000000000003faf0706263b2a5d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Gerd, No problems, I'd love to see this go in one day, it's just hard enough to carve out time to debug crash dumps I got overzealous with the change in pgtkterm.c, with the call from `lispstpcpy` (and your explanation there makes sense) looking at xterm, I see we have not marked that as a root , which is where I think that code was ported from originally. I have attached an updated patch, using a rebuilt igc-emacs from that commit, which is holding up. Thanks, On Wed, Nov 6, 2024 at 7:56=E2=80=AFPM Gerd M=C3=B6llmann wrote: > Fejfighter writes: > > > This patch marks 2 outstanding ambiguous roots and appears to solve > > crashing bugs I had been experiencing with igc/mps and pgtk. > > > > I have run this locally today, and I would have normally faced crashes > > at timer expiration, this appears to be holding up. > > Thanks for the report, Jeff! Nice to see that someone besides me is > using this :-). > > I think I see why the change in atimer.c is necessary: pgtk stores a > struct frame * as client_data in an atimer structure. That's a Lisp > object that can move during GC. Understood. > > The other change in pgtkterm.c I don't understand. AFAICS, x_id_name of > the display_info structure is indeed only used as a character buffer > into which characters from Lisp strings are memcpy'd. Could you please > explain that one? (I'm macOS only, so I don't know anything about pgtk, > if that matters.) > --0000000000003faf0706263b2a5d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Hi Gerd,

No problems, I'd love to see this go in one day, it= 9;s just hard enough to carve out time to debug crash dumps

<= /div>
I got overzealous with the change in pgtkterm.c, with the call fr= om `lispstpcpy` (and your explanation there makes sense)
look= ing at xterm, I see we have not marked that as a root , which is where I th= ink that code was ported from originally.

I have a= ttached an updated patch, using a rebuilt igc-emacs from that commit, which= is holding up.

Thanks,

=
On Wed= , Nov 6, 2024 at 7:56=E2=80=AFPM Gerd M=C3=B6llmann <gerd.moellmann@gmail.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">Fejfighter <fejfighter@gmail.com>= writes:

> This patch marks 2 outstanding ambiguous roots and appears to solve > crashing bugs I had been experiencing with igc/mps and pgtk.
>
> I have run this locally today, and I would have normally faced crashes=
> at timer expiration, this appears to be holding up.

Thanks for the report, Jeff! Nice to see that someone besides me is
using this :-).

I think I see why the change in atimer.c is necessary: pgtk stores a
struct frame * as client_data in an atimer structure. That's a Lisp
object that can move during GC. Understood.

The other change in pgtkterm.c I don't understand. AFAICS, x_id_name of=
the display_info structure is indeed only used as a character buffer
into which characters from Lisp strings are memcpy'd. Could you please<= br> explain that one? (I'm macOS only, so I don't know anything about p= gtk,
if that matters.)
--0000000000003faf0706263b2a5d-- --0000000000003faf0806263b2a5f Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Mark-atimer-allocation-as-ambiguous-root.patch" Content-Disposition: attachment; filename="0001-Mark-atimer-allocation-as-ambiguous-root.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m35ods6g0 RnJvbSAwODA1NDFhZTU0NjNlZGE5YjIwZDllYzkyY2I0MTIwMmJhMjFkODdjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIFdhbHNoIDxmZWpmaWdodGVyQGdtYWlsLmNvbT4KRGF0 ZTogVHVlLCA1IE5vdiAyMDI0IDIzOjA5OjU2ICsxMTAwClN1YmplY3Q6IFtQQVRDSF0gTWFyayBh dGltZXIgYWxsb2NhdGlvbiBhcyBhbWJpZ3VvdXMgcm9vdAoKKiBzcmMvYXRpbWVyLmMgKHN0YXJ0 X2F0aW1lcik6IFRpbWUgY291bGQgYmUgcGFzc2VkIGEgbGlzcCBvYmplY3QgZm9yCmRhdGEsIHdl IHNob3VsZCBhbGxvY2F0ZSB0aGlzIGFzIGFuIGFtYmlndW91cyByb290Ci0tLQogc3JjL2F0aW1l ci5jIHwgOSArKysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDEgZGVs ZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMvYXRpbWVyLmMgYi9zcmMvYXRpbWVyLmMKaW5kZXgg ODI1M2FlM2ExNjYuLjViZDI4MmEzMTBkIDEwMDY0NAotLS0gYS9zcmMvYXRpbWVyLmMKKysrIGIv c3JjL2F0aW1lci5jCkBAIC0xNyw2ICsxNyw3IEBACiBhbG9uZyB3aXRoIEdOVSBFbWFjcy4gIElm IG5vdCwgc2VlIDxodHRwczovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uICAqLwogCiAjaW5jbHVk ZSA8Y29uZmlnLmg+CisjaW5jbHVkZSAiaWdjLmgiCiAKICNpZmRlZiBXSU5ET1dTTlQKICNkZWZp bmUgcmFpc2UocykgdzMyX3JhaXNlKHMpCkBAIC0xMzIsNyArMTMzLDEzIEBAIHN0YXJ0X2F0aW1l ciAoZW51bSBhdGltZXJfdHlwZSB0eXBlLCBzdHJ1Y3QgdGltZXNwZWMgdGltZXN0YW1wLAogICAg ICAgZnJlZV9hdGltZXJzID0gdC0+bmV4dDsKICAgICB9CiAgIGVsc2UKLSAgICB0ID0geG1hbGxv YyAoc2l6ZW9mICp0KTsKKyAgICB7CisjaWZkZWYgSEFWRV9NUFMKKyAgICAgIHQgPSBpZ2NfeHph bGxvY19hbWJpZyAoc2l6ZW9mICp0KTsKKyNlbHNlCisgICAgICB0ID0geG1hbGxvYyAoc2l6ZW9m ICp0KTsKKyNlbmRpZgorICAgIH0KIAogICAvKiBGaWxsIHRoZSBhdGltZXIgc3RydWN0dXJlLiAg Ki8KICAgbWVtc2V0ICh0LCAwLCBzaXplb2YgKnQpOwotLSAKMi40Ny4wCgo= --0000000000003faf0806263b2a5f-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 05:36:08 2024 Received: (at 74224) by debbugs.gnu.org; 6 Nov 2024 10:36:08 +0000 Received: from localhost ([127.0.0.1]:39752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8dOS-0008V5-1o for submit@debbugs.gnu.org; Wed, 06 Nov 2024 05:36:08 -0500 Received: from mail-lf1-f49.google.com ([209.85.167.49]:59794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8dOM-0008UX-8h for 74224@debbugs.gnu.org; Wed, 06 Nov 2024 05:36:07 -0500 Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-539e5c15fd3so6375289e87.3 for <74224@debbugs.gnu.org>; Wed, 06 Nov 2024 02:36:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730889296; x=1731494096; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=qTEn+XIX/SZaWIpj1v9U7nW+/DP3f1qwL9pwn82ogKE=; b=izeN/55eqdE1ijErK7YZZsoBWQrHLR5LQqn+hIKRlVAWFVd8kx4i8T04ByiLTxkkGf 6GllRjKCLbPcBEaamKMI5z80UZ7I6plpvRjVXd3jbNiGOp3bhpI0fb9Yd3L/7lxQDjep 68Hq4XUzLoaMSBAzr3lwZnJjgD1eOhadGCiM88091Q5hnz0EW9MXRkwZEd3g5SGuyFL+ Z97M/RwolVzNIlLnzAEEcEhzWeMqb0LTwK3V332zWyfK5x0gxcq3pQ+AySuD+P9cFsjM rllUXrm6Ni3R7OUlNuxQxGXhHArDLa2k80hrW7CJnHiKqDcm9OOIBZ3feseYh1lI5WGA LydA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730889296; x=1731494096; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qTEn+XIX/SZaWIpj1v9U7nW+/DP3f1qwL9pwn82ogKE=; b=eb5UeJwLf8zZ28OWeVbl8wBfoNRgyc0STw2GRxilRZLY+tEmCyIhB5PPyh+rF9jPHi GPRNL3/iQF8TjwcMO+Co7NsWfNnXEk6wFoaFjh7goUSh7St38CHOumVgd0UmmfGZNFh/ Ob1M4BDbxJplwIaCPUFpC1Y/1Z9HNNVqWsnjdkZAergcaQGzIeJdkJkkKC4nTm94vduc ikXG9+b+aNuVshvouyl2GodLL7ToQxqZzyajoutkfTGPBwbyK05/etcfSw4u/+tzOmaP KhgAsJWP57CWqP2Tthw8v/Ddj9z50XloWytFjO9r3uHAMQznJlN3RX/QdTlRCvKT/q/6 3S/w== X-Gm-Message-State: AOJu0YzefZOXVFv5au/oSvr+hDtyaVZszwjIv7O54TFH3xJ+FqNybAt8 O0kMxskmIWKrCfSHfGKup9UKRlzU2ZvJ/e6ZI62W7ALABhvTs4R6XJ0kBg== X-Google-Smtp-Source: AGHT+IFjlV6F9rKfq2RMUUsFkE49bbAu1mmMlU03EiVRGxkRqpa2qiqgpMlRfXi2Q9DaVBWWMRjhDw== X-Received: by 2002:a05:6512:3b0f:b0:539:fc42:e5ee with SMTP id 2adb3069b0e04-53b348e3390mr19502021e87.29.1730889295766; Wed, 06 Nov 2024 02:34:55 -0800 (PST) Received: from pro2 (pd9e36633.dip0.t-ipconnect.de. [217.227.102.51]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432aa6ae58dsm17118265e9.2.2024.11.06.02.34.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2024 02:34:55 -0800 (PST) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: Jeff Walsh Subject: Re: bug#74224: [PATCH][scratch/igc] pgtk: fix crashing bug in atimer used for checking scaling In-Reply-To: (Jeff Walsh's message of "Wed, 6 Nov 2024 20:30:02 +1100") References: Date: Wed, 06 Nov 2024 11:34:54 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74224 Cc: 74224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jeff Walsh writes: > I have attached an updated patch, using a rebuilt igc-emacs from that > commit, which is holding up. LGTM. Can you commit that yourself to the branch? From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 05:37:33 2024 Received: (at 74224) by debbugs.gnu.org; 6 Nov 2024 10:37:33 +0000 Received: from localhost ([127.0.0.1]:39756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8dPp-000060-GO for submit@debbugs.gnu.org; Wed, 06 Nov 2024 05:37:33 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:47432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8dPn-00005r-TN for 74224@debbugs.gnu.org; Wed, 06 Nov 2024 05:37:32 -0500 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-37d6ff1cbe1so4766118f8f.3 for <74224@debbugs.gnu.org>; Wed, 06 Nov 2024 02:37:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730889391; x=1731494191; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=61d7LyJfRIcJgAZrh7onaZe6Box73X4AWEUvxbdjaEU=; b=PgIDPaKC5VpZs9hcbOm3q5V8g7MWhplht+AQZV1HR2qnIAofiBpoIfshsbOMxuV2O2 UDHOKXV1zy0qlncBXlJ8Pt3etTdq7vdS6g6U97Ub8Ic1pTQBU0y0bymT1ZPxxVmknxyF Et/EkqT+Rd34oKCQAXBmndu6Z+kqqfegS7XztwNkgVQHnU3sxxyyHG03LPqfV9paz5xs Fx8Hv0x4m2W7u9d075XFq8nSGsFpZRpOjpJ7FAhoFkLx1jkAVG/Yo6+V4POKu6Btoyr/ SST87r4mkqr1tl8DLmzKv40hlq9N1wqvjKDddWZQcl524KyN1GBzX1HKJs2GUJypndSa PzRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730889391; x=1731494191; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=61d7LyJfRIcJgAZrh7onaZe6Box73X4AWEUvxbdjaEU=; b=h+oEQ+vMoeUfUF1WZ7p/c9VIqi27EGbOL3wmQ+DGRzw3bvq6kAl4y6SlIXugD/RZmN stZoPkVJposHc/9PG9EQz4w4STcrBQzEPy047bX4vdlfdv88YhixyR3d9CTSBp2CaV8A S/y+sfWrhgujfG5nRf5Iem64GFIV67QCNjXBf3GqYlzrUqEZyDoaEF+yzu4grpWUnJ2H FMeIXUA67UtvLMAX+cvor7pzqs17lL51qt41hvOOICfrsClOQArSc63LVkh1dzFbzvUh 6IJu2OgSjqnv8EzzYtg0lz+MyNxKQmt3au+Rwlz9DmvgNkEw4ZTRygY3omQD5VbTAtX5 zt/g== X-Gm-Message-State: AOJu0YyBiAD3CSNu5gJG+khNZSUSTXTeMcbmIaV3udmAqbijVCGYUIQc tfXE4T15lfrRts0cUqwAn/p7C4wO6838ojmQD2CS6gPeIUWy7HmkuhfLZQ== X-Google-Smtp-Source: AGHT+IHXyWLtRABsqsvT6lH4yk9JUNydfEzfNIAoPWYB68vgv6VCjkG65CbgwIDFrnH11CCHPDgLJw== X-Received: by 2002:a05:6000:42c2:b0:37d:f4b:b6ab with SMTP id ffacd0b85a97d-381bea29202mr15243135f8f.59.1730889390739; Wed, 06 Nov 2024 02:36:30 -0800 (PST) Received: from pro2 (pd9e36633.dip0.t-ipconnect.de. [217.227.102.51]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c1168afcsm18699370f8f.91.2024.11.06.02.36.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2024 02:36:30 -0800 (PST) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: Jeff Walsh Subject: Re: bug#74224: [PATCH][scratch/igc] pgtk: fix crashing bug in atimer used for checking scaling In-Reply-To: (Jeff Walsh's message of "Wed, 6 Nov 2024 20:30:02 +1100") References: Date: Wed, 06 Nov 2024 11:36:29 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74224 Cc: 74224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jeff Walsh writes: > #ifdef WINDOWSNT > #define raise(s) w32_raise(s) > @@ -132,7 +133,13 @@ start_atimer (enum atimer_type type, struct timespec timestamp, > free_atimers = t->next; > } > else > - t = xmalloc (sizeof *t); > + { > +#ifdef HAVE_MPS > + t = igc_xzalloc_ambig (sizeof *t); > +#else > + t = xmalloc (sizeof *t); > +#endif > + } > > /* Fill the atimer structure. */ > memset (t, 0, sizeof *t); On second thought, and I don't know if it's relevant, do we need to igc_xfree that? From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 05:46:16 2024 Received: (at 74224) by debbugs.gnu.org; 6 Nov 2024 10:46:17 +0000 Received: from localhost ([127.0.0.1]:39769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8dYG-0000Xb-GE for submit@debbugs.gnu.org; Wed, 06 Nov 2024 05:46:16 -0500 Received: from mail-lj1-f182.google.com ([209.85.208.182]:43444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8dY9-0000XN-Ul for 74224@debbugs.gnu.org; Wed, 06 Nov 2024 05:46:14 -0500 Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2fb470a8b27so6887631fa.1 for <74224@debbugs.gnu.org>; Wed, 06 Nov 2024 02:46:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730889909; x=1731494709; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ljnY/GtuFfkfdLzmWobgZlJokK6aEt74be9DsclyRb8=; b=PkArGmFxmvRHMO8hrseZwH+mMqRXfqd7rhXgxIF9I82zujX715U027sGxUmSxAUBgE q4IkaHQjUTc3FYI+Dqnnj9v6WE2witq+UfWmqeE1zw6mSMronTAunYBJfFlEr70KJII7 TYCPBgDn7QEeIJ1M3CLQjkKMp6JcLUxmCIxIALK39mHhJjsPYQe72/2yYJZrpXppq3JN OYGqXsYbYJvFKya8mpwFpaL+qncbqIQanWbxeDhwY8EVPq7vBLB0m05h9mowuwc5v3tM PUMKjGaXfhDpChrp5KpkBBYwRlH1fX/wseWp1l77JJrFTUMgQJwsRCUGRxo7jNZ+1k2p T/PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730889909; x=1731494709; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ljnY/GtuFfkfdLzmWobgZlJokK6aEt74be9DsclyRb8=; b=M29ztES2JQLa87PM06MlrDr2MN2k6aVn+DjYPDxZ74O/b413Ic+5XlvILNl2hh381G srRcf0yYrnS3Xe9YpNpG/7hqx5tMuAKZqrF+erAjwN5fznyQcxb+hcfMGOANI1biWFsS u7xyWeV9Yee5aE5UIM7lfMfsqGMH9HCJ0Jzeb/FpMwBYhHFR0/aptB68FfN2Fk2bCFWV i3BbbfpCLPHTyjhjjvKTH4GCNzBQ8On4FiVdRQxbnOGWFtscKpp4X3HaDBZxH8FpToAW lOVJ/vwiwkY7goUqtiBsSLfXHdOFrbiBz+qSFRVsfLx9M1w976/5zwkcsP8Uz2cxUmxt SSpw== X-Gm-Message-State: AOJu0Yyvl+KRmPKiojlW72BD7MfX3szW/kjgKVZL4JOANFTGQeB0W5sp yJsU3YE74zUbU21efGXoEkT87nVtRBWZ3RakXJDNyd9HXYNNa2AXWd/LcU5X05GFb0j2Bxyc2OH px9XmqpD9AESRYr4Q26aSp5JdGAVHEhJA X-Google-Smtp-Source: AGHT+IHdNzmvrCxIYzSc7GEZB/kesFWsjSvLhJo5jvVmo+BwTgdG4sNJbJ5qjFQBaysIqv4fF6jEDhXWq4XzIqVKPMs= X-Received: by 2002:a05:651c:b08:b0:2fa:ce87:b7da with SMTP id 38308e7fff4ca-2ff0cd02995mr5238141fa.18.1730889908700; Wed, 06 Nov 2024 02:45:08 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jeff Walsh Date: Wed, 6 Nov 2024 21:44:57 +1100 Message-ID: Subject: Re: bug#74224: [PATCH][scratch/igc] pgtk: fix crashing bug in atimer used for checking scaling To: =?UTF-8?Q?Gerd_M=C3=B6llmann?= Content-Type: multipart/alternative; boundary="00000000000027549d06263c3685" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74224 Cc: 74224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000027549d06263c3685 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > LGTM. Can you commit that yourself to the branch? I don't have a savannah account for emacs, but I have just registered and will chase up approvals. timers are cleaned up by cancel_atimer(), then they get put on a free list (`free_atimers` on line 132 in the snippet). It appears that we rely on the OS to cleanup at emacs shutdown. On Wed, Nov 6, 2024 at 9:36=E2=80=AFPM Gerd M=C3=B6llmann wrote: > Jeff Walsh writes: > > > #ifdef WINDOWSNT > > #define raise(s) w32_raise(s) > > @@ -132,7 +133,13 @@ start_atimer (enum atimer_type type, struct > timespec timestamp, > > free_atimers =3D t->next; > > } > > else > > - t =3D xmalloc (sizeof *t); > > + { > > +#ifdef HAVE_MPS > > + t =3D igc_xzalloc_ambig (sizeof *t); > > +#else > > + t =3D xmalloc (sizeof *t); > > +#endif > > + } > > > > /* Fill the atimer structure. */ > > memset (t, 0, sizeof *t); > > On second thought, and I don't know if it's relevant, do we need to > igc_xfree that? > --00000000000027549d06263c3685 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> LGTM. Can you commit that yourself to the branch= ?

I don't have a savannah account for emacs, b= ut I have just registered and will chase up approvals.

timers are cleaned up by cancel_atimer(), then they get put on a f= ree list (`free_atimers` on line 132 in the snippet).
It appears = that we rely on the OS to cleanup at emacs shutdown.


On= Wed, Nov 6, 2024 at 9:36=E2=80=AFPM Gerd M=C3=B6llmann <gerd.moellmann@gmail.com> wrote:
Jeff Walsh <fejfighter@gmail.com= > writes:

>=C2=A0 #ifdef WINDOWSNT
>=C2=A0 #define raise(s) w32_raise(s)
> @@ -132,7 +133,13 @@ start_atimer (enum atimer_type type, struct times= pec timestamp,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 free_atimers =3D t->next;
>=C2=A0 =C2=A0 =C2=A0 }
>=C2=A0 =C2=A0 else
> -=C2=A0 =C2=A0 t =3D xmalloc (sizeof *t);
> +=C2=A0 =C2=A0 {
> +#ifdef HAVE_MPS
> +=C2=A0 =C2=A0 =C2=A0 t =3D igc_xzalloc_ambig (sizeof *t);
> +#else
> +=C2=A0 =C2=A0 =C2=A0 t =3D xmalloc (sizeof *t);
> +#endif
> +=C2=A0 =C2=A0 }
>=C2=A0
>=C2=A0 =C2=A0 /* Fill the atimer structure.=C2=A0 */
>=C2=A0 =C2=A0 memset (t, 0, sizeof *t);

On second thought, and I don't know if it's relevant, do we need to=
igc_xfree that?
--00000000000027549d06263c3685-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 05:50:07 2024 Received: (at 74224) by debbugs.gnu.org; 6 Nov 2024 10:50:08 +0000 Received: from localhost ([127.0.0.1]:39784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8dbz-0000iD-IN for submit@debbugs.gnu.org; Wed, 06 Nov 2024 05:50:07 -0500 Received: from mail-wm1-f44.google.com ([209.85.128.44]:60778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8dbw-0000gn-V1 for 74224@debbugs.gnu.org; Wed, 06 Nov 2024 05:50:05 -0500 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-431ac30d379so53214165e9.1 for <74224@debbugs.gnu.org>; Wed, 06 Nov 2024 02:50:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730890144; x=1731494944; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T3cRkMmWpEQ5m8lcvCq60clc1p4hpmpVntAp5FKbESM=; b=K8Nf0RvYVMiRS1kFCMrYbxvZztBhelj34Jf4bdQSp4JOVBs8OgT9vT2chlOC9RqAEx +Sxo/oQ8N5Q5TbhCLAdiPVZfD2ykiXIifdPYxcQ971PVAAN7KOEXmCmGG1J2rzNG6uDp hkP7tLdE/+S1rIMQ7VXRydef+p6SMTTWEAUa5/jNAX9jCYhcFOvP3K75aEQZxecr8T/5 vR3cLRqaYY8ELqG/Rd8+OLGLBDmGr7AIN/zOxCwZ/pddIInjbhEEVje80/9HRQrFAT1A DuUSfABeecjFTBxBrlJ+IqnqaGUOPIuomIRUissY8hXE+9HCJlFMtFwVw9JLXXrjpnht 6Kcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730890144; x=1731494944; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T3cRkMmWpEQ5m8lcvCq60clc1p4hpmpVntAp5FKbESM=; b=AgndGHC9m0SZuODVaMFSKJm/dOMBAtGXnz3YDnF/zx3ZcKBYH+asuj987Urf3MkLRb mjLExMxMLSCLPOMa9WdzN43ftNqDz0GBVP+dyc9c9ZuKYHT2kbAf/nJjqdBoSa4Q+cHi p9YlgSA2pPZYe5va9YSsCC+oCiJbra7n3JPpTE9wik1p6jsAkhJARZhG93EOXsaRmuFi LWeUEibvaYXKR/19r1gKroPGh6p00uc0llX9bWMb9RI8U9FHZauPKm5rpFwtxwNr9ZWC E4MbjfJ2rBJqqJBRWLyU7sSV43DWx9tc2adX8a6SGzN6DHbun+32vWY42yV+k4ZCP1TG 7oSQ== X-Gm-Message-State: AOJu0YxAh42H3QGbWBRk6lzepmSNhQx4zn+S2zQhPmaOUla38tRRmhyb DLZy+VSz3nPIe939aLA4O840UFv616etF2xDoGUJzvZsu3I7CIsZUwzo9w== X-Google-Smtp-Source: AGHT+IH512EbdUlRy/Uz3w6KjsGXlQs42/Ff8y6MasSEIGii9SQjWEIGqFK39NId6ixs1Wnrx8qdfw== X-Received: by 2002:a05:600c:1c03:b0:42c:af2a:dcf4 with SMTP id 5b1f17b1804b1-4319ad141admr321216625e9.27.1730890143701; Wed, 06 Nov 2024 02:49:03 -0800 (PST) Received: from pro2 (pd9e36633.dip0.t-ipconnect.de. [217.227.102.51]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432aa6c0414sm17661375e9.23.2024.11.06.02.49.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2024 02:49:03 -0800 (PST) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: Jeff Walsh Subject: Re: bug#74224: [PATCH][scratch/igc] pgtk: fix crashing bug in atimer used for checking scaling In-Reply-To: (Jeff Walsh's message of "Wed, 6 Nov 2024 21:44:57 +1100") References: Date: Wed, 06 Nov 2024 11:49:02 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74224 Cc: 74224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jeff Walsh writes: >> LGTM. Can you commit that yourself to the branch? > > I don't have a savannah account for emacs, but I have just registered and= will chase up approvals. > > timers are cleaned up by cancel_atimer(), then they get put on a free lis= t (`free_atimers` on line 132 in the snippet). > It appears that we rely on the OS to cleanup at emacs shutdown. Very good, thanks! I'll commit that for you, then, and close this bug when done. > > On Wed, Nov 6, 2024 at 9:36=E2=80=AFPM Gerd M=C3=B6llmann wrote: > > Jeff Walsh writes: > > > #ifdef WINDOWSNT > > #define raise(s) w32_raise(s) > > @@ -132,7 +133,13 @@ start_atimer (enum atimer_type type, struct times= pec timestamp, > > free_atimers =3D t->next; > > } > > else > > - t =3D xmalloc (sizeof *t); > > + { > > +#ifdef HAVE_MPS > > + t =3D igc_xzalloc_ambig (sizeof *t); > > +#else > > + t =3D xmalloc (sizeof *t); > > +#endif > > + } > >=20=20 > > /* Fill the atimer structure. */ > > memset (t, 0, sizeof *t); > > On second thought, and I don't know if it's relevant, do we need to > igc_xfree that? From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 05:59:08 2024 Received: (at control) by debbugs.gnu.org; 6 Nov 2024 10:59:08 +0000 Received: from localhost ([127.0.0.1]:39811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8dkh-000177-Mk for submit@debbugs.gnu.org; Wed, 06 Nov 2024 05:59:07 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:53488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8dkg-00016d-2U for control@debbugs.gnu.org; Wed, 06 Nov 2024 05:59:06 -0500 Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-37d4ac91d97so5527030f8f.2 for ; Wed, 06 Nov 2024 02:59:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730890680; x=1731495480; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:subject:from:to:message-id :date:from:to:cc:subject:date:message-id:reply-to; bh=QUsElY8oFv3vMnyrMOsKbjiRq53oFKOuX70tWwsbtzI=; b=nT4K7+j/2JY4Mc11gjxmEuUdiXiGjnrNvy/bTJ8o1smIyQ2KhajD1bGKJoypLA/Ozc wbnsAyTCItcQcd1zjwh+YQWmwoN0Hk8+kumw4DuXhaCQSmGcWBYHhBpqDHsM3keSoIjy zqEzuuXDsHjBOlhEz3rp9o5V+j5yo5OLsTxlnzI2//wUy9ph/QhOErhvRZR6uo4wGCMB jq9d8F4XhVB5UZNsS4YR7s+pa41dYPSTt4Q++RQTJ2QdOqhssTXapdpA8bnIZ8LU/dg9 /iLDoKRwzZokPa2uYdEh6qrnEPFwaLkIh1DW3BKM/bgckb3kEDefBayvGgykSm9GvBto iXig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730890680; x=1731495480; h=content-transfer-encoding:mime-version:subject:from:to:message-id :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QUsElY8oFv3vMnyrMOsKbjiRq53oFKOuX70tWwsbtzI=; b=oKnpxUwbM/v5Ir4q4pz600pyn6GLlHZ11gzqQrIKF1pxayUA9XhjBwtbRNbH1cORQm V9PEz8Yx3jp8D5nD30fQRAFVnJLAYZYeAfVQPolhzeMD5+p+L1hRyakB+fTT7StNI02Y F5Ez9jJRtCs7ETZXvhBH1XIM1E8bJIw4LMUACIsq7TO5X9ehSZmjFeWI5paI2dsj7Z8/ h43fqcpd1xQTD7TYj659ZZSkBIEDsN3yfeNEOTwSX56vQ/qtLJCubvbJoDaWy9HHmt9y EztzLsNr+kJHhFYcXEgkKv+B5MnXjNw94+faA697H4+LQwjgEn/MMlOLC/3ghJVt41rc vPyg== X-Gm-Message-State: AOJu0YwphC0eHSADzkHbtdsCQeVHzdEoOTVe+qtMPUh3Cn4CgiwImQGf CpYuYc29nTneqZ5Tm7DDkUVYNxx09Fv2XEjLcIGFPbse/KvLiFmfCoYMHw== X-Google-Smtp-Source: AGHT+IG5iv6ixYval1SCDIp5rKdyLjYOQgZ2armbPeMLecO/dQ16F3Yfx2IIrBThMgsFE6PHcRLUFw== X-Received: by 2002:a5d:5e87:0:b0:37d:39d8:b54b with SMTP id ffacd0b85a97d-381c7ae1552mr17486345f8f.58.1730890679892; Wed, 06 Nov 2024 02:57:59 -0800 (PST) Received: from pro2 (pd9e36633.dip0.t-ipconnect.de. [217.227.102.51]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432aa70a2ccsm18550415e9.31.2024.11.06.02.57.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2024 02:57:59 -0800 (PST) Date: Wed, 06 Nov 2024 11:57:58 +0100 Message-Id: To: control@debbugs.gnu.org From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Subject: control message for bug #74224 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 74224 31.1 quit From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 08:18:00 2024 Received: (at 74224) by debbugs.gnu.org; 6 Nov 2024 13:18:00 +0000 Received: from localhost ([127.0.0.1]:40074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8fv6-000750-Ch for submit@debbugs.gnu.org; Wed, 06 Nov 2024 08:18:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8fv4-00074d-55 for 74224@debbugs.gnu.org; Wed, 06 Nov 2024 08:17:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8fuy-0006cR-Mt; Wed, 06 Nov 2024 08:17:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=aPvkFOg8jmggA6ivOJYxZGoodtqLbb5Pw6UfOtlxf9Y=; b=Ml2Ge5FWb0kdhJd2zuFr d3QpSHMR8x1AKXkK3iDqAUfWmR4U5/XL2eEypxg2RIDJLQIKkWVgD+nNVO+NPzD+/2WTgQz34iSID dn29N2BGHq1sNDE1s1QYMEwdc60MIcR1mB3JOeRlH5HxctAif4YMQGyooAqNFpdvzQNZp/NN0/qwK /W6XwIPp5opYE6SaClCVKFKWsamjy1YbvlMkW+58RczMWJRJ+Wr0WwQMmpVJUCveUbTKlPS3Kpye1 qEDXZ/Bh7njnoP3JSsxbb/1+AB4Tz3AMg0zxFokoBgrz13vKaoAtSSpQUXiIgTICmODnz4C287Us1 shD/az/CNquvjg==; Date: Wed, 06 Nov 2024 15:17:34 +0200 Message-Id: <86h68ksdqp.fsf@gnu.org> From: Eli Zaretskii To: Gerd =?utf-8?Q?M=C3=B6llmann?= In-Reply-To: (message from Gerd =?utf-8?Q?M?= =?utf-8?Q?=C3=B6llmann?= on Wed, 06 Nov 2024 11:49:02 +0100) Subject: Re: bug#74224: [PATCH][scratch/igc] pgtk: fix crashing bug in atimer used for checking scaling References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74224 Cc: 74224@debbugs.gnu.org, fejfighter@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 74224@debbugs.gnu.org > From: Gerd Möllmann > Date: Wed, 06 Nov 2024 11:49:02 +0100 > > I'll commit that for you, then, and close this bug when done. Thanks, but it seems like you committed this to the wrong branch (tty-child-frames instead of igc). From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 08:40:14 2024 Received: (at 74224) by debbugs.gnu.org; 6 Nov 2024 13:40:14 +0000 Received: from localhost ([127.0.0.1]:40115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8gGb-000883-TI for submit@debbugs.gnu.org; Wed, 06 Nov 2024 08:40:14 -0500 Received: from mail-wr1-f44.google.com ([209.85.221.44]:46432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8gGY-00086i-Tn for 74224@debbugs.gnu.org; Wed, 06 Nov 2024 08:40:11 -0500 Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-37d447de11dso5124225f8f.1 for <74224@debbugs.gnu.org>; Wed, 06 Nov 2024 05:40:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730900350; x=1731505150; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uu2L74CYd13eY5B6xW1488wI3iayc/iN4PaM4A01PkE=; b=Toas4bOL4h9eV9RBbMy2ORDdPx+xCF79Nh5I+QFTHHGBxuFyYv3YT+ziQ0mN5LrFto oL97odmTuukQlFbGfM//Si29/IOXICOxcaOQ8MimPwPLX2EpYnbgzFAwOXT1OEwyNgHZ j8B+4m0h80jTTeXNezj/3pomNHa6cZ5IvD4vRdy1yys/Fqpgl2XDJUIBnlibnJoF1LDS p3SWXcvbn5XRZ5QolAXEFij6DkdunDBLD9RD2qeU4H/uA8bcG70zPRczOhL9Bs0tzVZn tDcW/C+lwQaq9eX3g1X6XKV+bcmsrNsOnmoD4mihUwp+X10EMUpJCtG6m9ip/+QqUqJN Cv4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730900350; x=1731505150; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uu2L74CYd13eY5B6xW1488wI3iayc/iN4PaM4A01PkE=; b=f9Wsd7SSeXk488IYIOf+HGA/KVRVxGRlOVg+2kh1c6plB1KVLoDCR5Pmh2xukO8LJG FCAsYgrgoH4qnSikVDvHnNX9sZtJgOjVa/bhTowthUWmgPDPXiaM9sDPECDgHfH9NSgJ GWzxuwgSsk9XbcUITQ24Ge8EUcHLVEd1nDFiDR5YRWq5VuE8LPn9PJqgSs0tVmf6NwLH /7NrL43FKmjBrWqN3pJcz5NZ+hUwzkOQDqARiFzh2WsVYj59Aa3XESVdNuQ1nIezPVZi 4tkbXAUbFfKYM5F5Q0kaIar8LxsmFhWwcK9MlEWzsLVY+eMH+7r1Pk01NeflNq9YlcRf 7VjQ== X-Forwarded-Encrypted: i=1; AJvYcCUXXtVcFLvt3TXQVjhPHxg0wm7pQOAyxgPmI27xNXSu1KlCjv2bmd/AEZtxsp7Eq2E1k8+icw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxMFS2flTerxFzEiDgvUwJa0sjYK4AdFU7aOqi6sk4SbXxV0nHh IghmzzgvJNgVQM7yM6agx91Y+k0Hx2YZAvnE4QPFLLbmmdwHtKy8un6pqA== X-Google-Smtp-Source: AGHT+IGAN01LBr3hHYUOWw1BhGdmTRLI5EQgVRHsntuUOHEuTYUyz1HEPJko1cM3yAHGtu6iReK1vA== X-Received: by 2002:a5d:6da3:0:b0:37d:4f1b:35a with SMTP id ffacd0b85a97d-381be7ae2acmr17281563f8f.3.1730900349676; Wed, 06 Nov 2024 05:39:09 -0800 (PST) Received: from pro2 (pd9e36633.dip0.t-ipconnect.de. [217.227.102.51]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432aa6f868asm23178925e9.44.2024.11.06.05.39.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2024 05:39:09 -0800 (PST) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: Eli Zaretskii Subject: Re: bug#74224: [PATCH][scratch/igc] pgtk: fix crashing bug in atimer used for checking scaling In-Reply-To: <86h68ksdqp.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 06 Nov 2024 15:17:34 +0200") References: <86h68ksdqp.fsf@gnu.org> Date: Wed, 06 Nov 2024 14:39:08 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74224 Cc: 74224@debbugs.gnu.org, fejfighter@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Cc: 74224@debbugs.gnu.org >> From: Gerd M=C3=B6llmann >> Date: Wed, 06 Nov 2024 11:49:02 +0100 >>=20 >> I'll commit that for you, then, and close this bug when done. > > Thanks, but it seems like you committed this to the wrong branch > (tty-child-frames instead of igc). Oops. Should be fixed now. From unknown Sun Aug 17 09:11:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 05 Dec 2024 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator