From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 19:56:08 2024 Received: (at submit) by debbugs.gnu.org; 6 Nov 2024 00:56:08 +0000 Received: from localhost ([127.0.0.1]:38608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8ULA-00008r-94 for submit@debbugs.gnu.org; Tue, 05 Nov 2024 19:56:08 -0500 Received: from lists.gnu.org ([209.51.188.17]:52412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8UL8-00008j-3m for submit@debbugs.gnu.org; Tue, 05 Nov 2024 19:56:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8UL6-0001j1-Az for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2024 19:56:04 -0500 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8UL2-0004ye-BS for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2024 19:56:04 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 6950A240002; Wed, 6 Nov 2024 00:55:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fabionatali.com; s=gm1; t=1730854554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=tIINFY529tJCvhAgX9D95hitdRwmU3or7KrqIaspDQA=; b=MMlomVYoiD2HWqjflZHuXXtFLpjGiZQJTtP/8p2XeOWVwsKjk6W31i4cRWegmjqtK71k88 jEqVanUYvxVsv7AZJiNzHa/k5OCyHDDpA25oC8aPib307Pt/AtDwCOexuzE/gC8oAEOJjr caKOAw8UPeYmHz8GMQsFJmRpDgCkyPa0R5PXLVoOZtmSJdGXC1q430fZKNbpYr0t++wyYq YyvnEIRKZBzhOBYuqwFhLw/6/ZJ8nlBf0GAYGgQiTQtaZuNVy8hc8GJV21S2KmONgyT1BZ MNbgYVCDn2xOwAp3yuM8hOMXkYJ/6ULbvnQjEbDuci4Cv0vNZTYWSYueWI6qug== From: Fabio Natali To: bug-gnu-emacs@gnu.org Subject: [PATCH] Ask confirmation before sending region to search engine. Date: Wed, 6 Nov 2024 00:46:46 +0000 Message-ID: <20241106005544.26516-1-me@fabionatali.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-GND-Sasl: me@fabionatali.com Received-SPF: pass client-ip=2001:4b98:dc4:8::221; envelope-from=me@fabionatali.com; helo=relay1-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: Fabio Natali X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) * lisp/net/eww.el (eww-search-confirm-send-region, eww-search-words): With 'eww-search-words' (by default bound to 'M-s M-w') a user can type in some search terms and get back the results of a web search from a predefined search engine. If a region is selected, 'eww-search-words' will use that for the web search instead of prompting the user. In its current form, 'eww-search-words' presents a security and usability problem. It is relatively too easy to mistakenly launch the function and, if a region of text is selected, have potentially sensitive data sent out to a third-party service. This commit changes the search function's default behaviour so that explicit confirmation is required before a region is sent to a search engine. The behaviour can be adjusted via the newly-introduced 'eww-search-confirm-send-region' variable, which is set to true by default. --- Hiya, This is to change the default behaviour of the 'eww-search-words' function. The provided commit message provides some context around why I think the change is necessary. I tentatively marked 'eww-search-confirm-send-region' as introduced in 30.0. Let me know if and when you think it makes sense to merge this and therefore whether 30.0 should be changed to any later number. I hope the commit looks alright but should any change be needed, please just let me know. This is my first commit to Emacs - any feedback is more than welcome! Thanks, best wishes, Fabio. lisp/net/eww.el | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 2d351dff88f..8f503757f68 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -52,6 +52,15 @@ :group 'eww :type 'string) +(defcustom eww-search-confirm-send-region t + "Non-nil if Emacs should confirm sending the selected region to +the configured search engine. This is the default to mitigate the +risk of accidental data leak. Set this variable to nil to send +the region to the search engine straightaway." + :version "30.0" + :group 'eww + :type 'boolean) + (defcustom eww-search-prefix "https://duckduckgo.com/html/?q=" "Prefix URL to search engine." :version "24.4" @@ -603,10 +612,15 @@ user for a search string. See the variable `eww-search-prefix' for the search engine used." (interactive) (if (use-region-p) - (let ((region-string (buffer-substring (region-beginning) (region-end)))) - (if (not (string-match-p "\\`[ \n\t\r\v\f]*\\'" region-string)) - (eww region-string) - (call-interactively #'eww))) + (when (or (not eww-search-confirm-send-region) + (yes-or-no-p + (format-message + "Send region to the configured search engine? "))) + (let ((region-string (buffer-substring (region-beginning) + (region-end)))) + (if (not (string-match-p "\\`[ \n\t\r\v\f]*\\'" region-string)) + (eww region-string) + (call-interactively #'eww)))) (call-interactively #'eww))) (defun eww--open-url-in-new-buffer (url) -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 07:34:54 2024 Received: (at 74218) by debbugs.gnu.org; 6 Nov 2024 12:34:54 +0000 Received: from localhost ([127.0.0.1]:39925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8fFO-000586-DA for submit@debbugs.gnu.org; Wed, 06 Nov 2024 07:34:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8fFL-00057t-4u for 74218@debbugs.gnu.org; Wed, 06 Nov 2024 07:34:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8fFC-00071w-98; Wed, 06 Nov 2024 07:34:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xQ3PFr0VM68zngxQ4/wA1llLVOEfQ2koYLdLwklcvJs=; b=Gf6TFqaCNT9C 4lQF3hVEXWe6xd74ahnImacQMNcxWHdS7hNvbFY3VdWfm9M1pr/uAh95MV3Dolcxv2eks6kDDvR2b LkdGvHJPYrxwluKZ/mbvt29AmXBFtL6/X1AdY5Xm1kKLQMYqv+LF2f0btWG23/CbZRl0A85OU5Wof qJxbkFRZRg4N7oftldZyLcTkXXx10OhVJFFCVlIubIUFCbYaAlItUBRgYJZ/ik5GZtwAEW/6zyN0a giTTxKObn4EnpE3v02baOmBqMbwmTJ0133MKNf+ehbxcZylblnDzivTchRI21FcgM8Osttt96y51G UwP8fKPhvlGlVuS0HGknXA==; Date: Wed, 06 Nov 2024 14:34:33 +0200 Message-Id: <86pln8sfqe.fsf@gnu.org> From: Eli Zaretskii To: Fabio Natali In-Reply-To: <20241106005544.26516-1-me@fabionatali.com> (bug-gnu-emacs@gnu.org) Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. References: <20241106005544.26516-1-me@fabionatali.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Fabio Natali > Date: Wed, 6 Nov 2024 00:46:46 +0000 > From: Fabio Natali via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > * lisp/net/eww.el (eww-search-confirm-send-region, > eww-search-words): With 'eww-search-words' (by default bound to 'M-s > M-w') a user can type in some search terms and get back the results > of a web search from a predefined search engine. If a region is > selected, 'eww-search-words' will use that for the web search > instead of prompting the user. This should be reformatted according to our conventions, see CONTRIBUTE. > +(defcustom eww-search-confirm-send-region t > + "Non-nil if Emacs should confirm sending the selected region to > +the configured search engine. This is the default to mitigate the The first line of a doc string should be a single complete sentence, and should attempt to summarize what the function/variable does, because some "apropos" commands show only the first line of each doc string. > +risk of accidental data leak. Set this variable to nil to send > +the region to the search engine straightaway." > + :version "30.0" This should be "31.1". > + (when (or (not eww-search-confirm-send-region) > + (yes-or-no-p > + (format-message > + "Send region to the configured search engine? "))) IMO, this should somehow try to indicate the problematic aspect of doing this. For example, maybe it should say Really send the entire region to the search engine? It is also possible that short regions should be sent without any need for confirmation. In which case perhaps the variable should allow integer values, not just nil and t. In addition, I don't see any need to ask for confirmation when we are not going to send anything to the search engine, so I think the test for white-space region should be before the confirmation prompt, and only if the region is going to be sent. Last, but not least: this contribution almost exhausts the amount of changes we can accept from you without a copyright assignment. Would you like to start at this time your legal paperwork of assigning the copyright to the FSF, so that we could accept your future contributions without limitations? If so, I will send you the form to fill and the instructions to go with it. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 08:18:57 2024 Received: (at 74218) by debbugs.gnu.org; 6 Nov 2024 13:18:57 +0000 Received: from localhost ([127.0.0.1]:40079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8fw0-00076d-RO for submit@debbugs.gnu.org; Wed, 06 Nov 2024 08:18:57 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:40639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8fvy-00076O-Vu for 74218@debbugs.gnu.org; Wed, 06 Nov 2024 08:18:56 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 1A92040004; Wed, 6 Nov 2024 13:18:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fabionatali.com; s=gm1; t=1730899109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ASowfo0RKB/v4FV7laBYFAhq4RVB1QYMZvXRN0r1SAc=; b=eutNScEOjnVSJIrXwrwKrjDz8bfnvpgq9ojq60Vg7Wn1Ugh6KDQlwMKJcTlAxgnG1moDGz 8bXEbMbiQuvFPWMrokMCe55w4JK633BP5tSs+2IDtXRcJWslbBO/SDjzAwDKmwSKOm+K/P qyudbDRSwYg1bV7oQcOvuKmvO94O3jfF43ZlMmTqD+Ds1FJUmJul7g+gnwcU0rh/muG3+f NJdYfFZilfnwIufzcg3DYG5TDELVqgWMDSiOKFeq7G9mHg6qskGimUTBb+Yn79B47iaw8q nlz3OXf7TKwjmEYmaGHNFeVVWBJTjEeZ8VI40BykqTSH470ZspQ3+CTobWGz+Q== From: Fabio Natali To: Eli Zaretskii Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. In-Reply-To: <86pln8sfqe.fsf@gnu.org> References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> Date: Wed, 06 Nov 2024 13:18:27 +0000 Message-ID: <87ses4h55o.fsf@fabionatali.com> MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: me@fabionatali.com X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2024-11-06, 14:34 +0200, Eli Zaretskii wrote: > Last, but not least: this contribution almost exhausts the amount of > changes we can accept from you without a copyright assignment. Would > you like to start at this time your legal paperwork of assigning the > copyright to the FSF, so that we could accept your future > contributions without limitations? If so, I will send you the form to > fill and the instructions to go with it. Hi Eli, Thanks for your quick and thorough reply. All points that you mention make sense to me, I'll work towards a v2 that addresses all of them. In the meanwhile, I'd be very glad to fill out the copyright assignment paperwork, would you be able to send me the form and/or point me to any relevant instructions? Thanks, have a lovely day, Fabio. -- Fabio Natali https://fabionatali.com From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 08:38:20 2024 Received: (at 74218) by debbugs.gnu.org; 6 Nov 2024 13:38:20 +0000 Received: from localhost ([127.0.0.1]:40108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8gEm-0007zM-Cc for submit@debbugs.gnu.org; Wed, 06 Nov 2024 08:38:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8gEj-0007z8-GX for 74218@debbugs.gnu.org; Wed, 06 Nov 2024 08:38:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8gEd-0002FL-8T; Wed, 06 Nov 2024 08:38:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GuNNHaFY/dCdzczRt4zN1em8lyYSb3rmcDd64KoyixA=; b=j4sIR3NZi68M Q95mkiNZ5q0eQ4HiIPxLWxWvGwuWkaQP/suLQ6c1ACTQ4q9GEyhU0FHCIOdryyvXs1lcqCMuy7wOz 7O3d3bz5NqITc29R6HpEDu3927gCeFku8rnLOZmVhQDfnBJnjnKjTNXZdB1VoGPCCv2WqS+/VHicP hOdlig7wK0XwXd0QZyHJ0FcGCdv6O4+e4UjNoni2xcx5xNfN5rvyey2D/KRXQRiE6zh2UsAm+F6vY Rub5ql8TvsvOiBnSmlzep/YOEfT/PamwMpGMRd+zexDsA4c3nCDyagnVG8PThXosbx09w4cUBc3+s KNIEFO1plNqGXCyPTvioHQ==; Date: Wed, 06 Nov 2024 15:38:09 +0200 Message-Id: <868qtwscse.fsf@gnu.org> From: Eli Zaretskii To: Fabio Natali In-Reply-To: <87ses4h55o.fsf@fabionatali.com> (message from Fabio Natali on Wed, 06 Nov 2024 13:18:27 +0000) Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ses4h55o.fsf@fabionatali.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Fabio Natali > Cc: 74218@debbugs.gnu.org > Date: Wed, 06 Nov 2024 13:18:27 +0000 > > On 2024-11-06, 14:34 +0200, Eli Zaretskii wrote: > > Last, but not least: this contribution almost exhausts the amount of > > changes we can accept from you without a copyright assignment. Would > > you like to start at this time your legal paperwork of assigning the > > copyright to the FSF, so that we could accept your future > > contributions without limitations? If so, I will send you the form to > > fill and the instructions to go with it. > > Hi Eli, > > Thanks for your quick and thorough reply. > > All points that you mention make sense to me, I'll work towards a v2 > that addresses all of them. > > In the meanwhile, I'd be very glad to fill out the copyright assignment > paperwork, would you be able to send me the form and/or point me to any > relevant instructions? Thanks, form sent off-list. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 10:27:14 2024 Received: (at 74218) by debbugs.gnu.org; 6 Nov 2024 15:27:14 +0000 Received: from localhost ([127.0.0.1]:45103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8hwA-0005hQ-6t for submit@debbugs.gnu.org; Wed, 06 Nov 2024 10:27:14 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:51257) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8hw7-0005hC-TL for 74218@debbugs.gnu.org; Wed, 06 Nov 2024 10:27:12 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 4D9A21BF20B; Wed, 6 Nov 2024 15:27:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fabionatali.com; s=gm1; t=1730906825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oiQz1ZM6BNz1PXBIjpy0y858C/DK6SBSc4GQlEZDi8A=; b=NI5YjIqmfPwdXI/f3fB5QJDc4/E4s8wa8+erqWrK2n5ZT7pVCv+NHOvswUXQ32diQZcKu7 vcwJx11x0S9u/YiFmsnqr/L3yRZOSPoSJSmSh33QPANoKpb+oNKiwXzKtMgUfay6hdkAIs JprUFSKsXyFsGTXBR84+YKNhnKF8Iz2Lw5DmKmuUEXENYqLBbFV2heQR5x1eWuHcng6hkG sD8s7w80RQdBKD3dgDNnktbRpDQyYIMDezdYzAcrtWxvHywrA0Je96YcZ5PkaPsR4psi4p +tdI4VGF5Izj0RYfV9PGE9zQUnxQlteCs5P+GHq8ekxEpuVtzyfcqfxElOZABA== From: Fabio Natali To: Eli Zaretskii Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. In-Reply-To: <86pln8sfqe.fsf@gnu.org> References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> Date: Wed, 06 Nov 2024 15:27:04 +0000 Message-ID: <87ikt0gz7b.fsf@fabionatali.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-GND-Sasl: me@fabionatali.com X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Hi Eli, Please find attached a v2 that - hopefully - addresses the points mentioned in your email. Please see my further comments inline below. Thanks for all the help, cheers, Fabio. On 2024-11-06, 14:34 +0200, Eli Zaretskii wrote: >> * lisp/net/eww.el (eww-search-confirm-send-region, >> eww-search-words): With 'eww-search-words' (by default bound to 'M-s >> M-w') a user can type in some search terms and get back the results >> of a web search from a predefined search engine. If a region is >> selected, 'eww-search-words' will use that for the web search >> instead of prompting the user. > > This should be reformatted according to our conventions, see > CONTRIBUTE. Ok, here's what I've changed: - Set max line length to 63 chars. - Slightly reordered the text so that some broader explanation comes first and the ChangeLog entries later. - Micro-improvements to the ChangeLog entries. I hope it looks better now - but I'm still a little unsure. If there's anything else that's left to fix, please let me know. > The first line of a doc string should be a single complete sentence, > and should attempt to summarize what the function/variable does, > because some "apropos" commands show only the first line of each doc > string. Ha! True, sorry, that's also fixed now. >> + :version "30.0" > > This should be "31.1". Fixed. >> + (format-message >> + "Send region to the configured search engine? "))) > > IMO, this should somehow try to indicate the problematic aspect of > doing this. For example, maybe it should say > > Really send the entire region to the search engine? Good one, fixed. > It is also possible that short regions should be sent without any need > for confirmation. In which case perhaps the variable should allow > integer values, not just nil and t. I think I disagree on this one. The functionality you suggest is a superset of what I implemented and it goes in the direction of giving more freedom to the user. On the other hand, however, I don't see a strong correlation between the sensitivity of a piece of information and its length. For the sake of simplicity, I'd have a preference to maintain the boolean logic as per my original patch. > In addition, I don't see any need to ask for confirmation when we are > not going to send anything to the search engine, so I think the test > for white-space region should be before the confirmation prompt, and > only if the region is going to be sent. Ha, another good one! Thanks, fixed. > Would you like to start at this time your legal paperwork of assigning > the copyright to the FSF, so that we could accept your future > contributions without limitations? Sent separately, thanks. -- Fabio Natali https://fabionatali.com --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=v2-0001-Ask-confirmation-before-sending-region-to-search-.patch >From cdd17053befac8298a04d0cdfc4cafe5a410166b Mon Sep 17 00:00:00 2001 From: Fabio Natali Date: Tue, 5 Nov 2024 23:52:30 +0000 Subject: [PATCH v2] Ask confirmation before sending region to search engine With 'eww-search-words' (by default bound to 'M-s M-w') a user can type in some search terms and get back the results of a web search from a predefined search engine. If a region is selected, 'eww-search-words' will use that for the web search instead of prompting the user. In its current form, 'eww-search-words' presents a security and usability problem. It is relatively too easy to mistakenly launch the function and, if a region of text is selected, have potentially sensitive data sent out to a third-party service. This commit changes the search function's default behaviour so that explicit confirmation is required before a region is sent to a search engine. The behaviour can be adjusted via the newly-introduced 'eww-search-confirm-send-region' variable, which is set to true by default. * lisp/net/eww.el (eww-search-confirm-send-region): Add. (eww-search-words): Update default 'eww-search-words' behaviour so as to ask confirmation before sending a region to a search engine. --- lisp/net/eww.el | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 2d351dff88f..cbf989f4a6a 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -52,6 +52,17 @@ :group 'eww :type 'string) +(defcustom eww-search-confirm-send-region t + "Whether to confirm before sending a region to a search engine. +Non-nil if EWW should ask confirmation before sending the +selected region to the configured search engine. This is the +default to mitigate the risk of accidental data leak. Set this +variable to nil to send the region to the search engine +straightaway." + :version "31.1" + :group 'eww + :type 'boolean) + (defcustom eww-search-prefix "https://duckduckgo.com/html/?q=" "Prefix URL to search engine." :version "24.4" @@ -605,7 +616,12 @@ for the search engine used." (if (use-region-p) (let ((region-string (buffer-substring (region-beginning) (region-end)))) (if (not (string-match-p "\\`[ \n\t\r\v\f]*\\'" region-string)) - (eww region-string) + (when + (or (not eww-search-confirm-send-region) + (yes-or-no-p + (format-message + "Really send the entire region to the search engine? "))) + (eww region-string)) (call-interactively #'eww))) (call-interactively #'eww))) -- 2.46.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 20:52:32 2024 Received: (at 74218) by debbugs.gnu.org; 7 Nov 2024 01:52:32 +0000 Received: from localhost ([127.0.0.1]:46643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8rhH-0002lj-Ls for submit@debbugs.gnu.org; Wed, 06 Nov 2024 20:52:32 -0500 Received: from mail-ej1-f50.google.com ([209.85.218.50]:46391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8rhE-0002lV-C8 for 74218@debbugs.gnu.org; Wed, 06 Nov 2024 20:52:29 -0500 Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a9e44654ae3so52622666b.1 for <74218@debbugs.gnu.org>; Wed, 06 Nov 2024 17:52:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730944283; x=1731549083; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=jRggsLe0aDjkornMi5li3nQfQiybXIUqpJMyEJqfweI=; b=HF4f++ZTgtazMJyUUSwProystfBMRlmjSY3ek/HFx+gzq/L+UV/jltcQDA5LY4ZLI/ qc2TmF0laQBLPvDUmgSOMZG5696V8CWOfJUFFeW5Ahgb2glqIB8GBGB5kIFZp9Uk2gWL H9V8nPvkHDLetHaUAWlR4z34Lb+cenrzts/phvr9dYqBYz7JlBvegG6UGKSAgte9ZJ3U vDKFNKd0Tl9W7Z66oL+ef0MIz+fFoeyMMD4bh+Osn0MZS+2SdH3pvxd03gjGyc3GflNo aNOJXmmzBmtoHb5o0T/ICmwScuq+Mx/QXJ9Xw6Purfp0O1mf3MngYK3cjxEUnWk9oN4n 0fOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730944283; x=1731549083; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jRggsLe0aDjkornMi5li3nQfQiybXIUqpJMyEJqfweI=; b=sJAOpHU0bIh2Dj7DRLFhsI5FTBGZCY35BRY2dZklGriR85UuZ+P5fOBzOLbem13SVu 2+7//T3vCx549pHdydukWiMDIfNv6EejftApiJLEWSXEemD1X1+X6DJxlPNPsGfD4fE1 PyUX4iaRc57RmAKCjreEGKV0kbrueG2rwajKUU45wdf2w6g77ThtCfA788j03f6qZPhl tFkG6cpgtycZdHy/H5XVvYAwHaOszuO+h3EAydmwUJ+5FnXcsP184SD9XlvwP6XWImVe lngMDNmJxoaqoSm+cTYyAB6vHYZhGQH0Pb/F5/o0cegmn5hHHM1fh+uC2SVApCrH5uDa yfaA== X-Gm-Message-State: AOJu0YzxvltJWkw4ZgSmLjb02nSVS4WQTcCddw75JfR2n5BmSNDeKGU1 1uToKuhW2EeK8A6yYY5lvx+fNyOXKVRYu0/cHxsNQfd27O2zNbJoStqucIRlhHhMEkEVz+zQ99u H1bqKS9/hY4UkmL91wpqMjoa+SYQ= X-Google-Smtp-Source: AGHT+IGGO+jvjEDpOp4qQzIQGOMVx0kFPvo7jV6iqyA3ATqiGBjUXnKv8hgbwSePdNDn1SdADRHvZIlyWpI4DxOxu94= X-Received: by 2002:a17:907:7f03:b0:a9a:3cf:cdb8 with SMTP id a640c23a62f3a-a9ee2376f91mr20220966b.36.1730944282656; Wed, 06 Nov 2024 17:51:22 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 6 Nov 2024 17:51:22 -0800 From: Stefan Kangas In-Reply-To: <87ikt0gz7b.fsf@fabionatali.com> References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> MIME-Version: 1.0 Date: Wed, 6 Nov 2024 17:51:22 -0800 Message-ID: Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. To: Fabio Natali , Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fabio Natali via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > From cdd17053befac8298a04d0cdfc4cafe5a410166b Mon Sep 17 00:00:00 2001 > From: Fabio Natali > Date: Tue, 5 Nov 2024 23:52:30 +0000 > Subject: [PATCH v2] Ask confirmation before sending region to search engine > > With 'eww-search-words' (by default bound to 'M-s M-w') a user > can type in some search terms and get back the results of a web > search from a predefined search engine. If a region is selected, > 'eww-search-words' will use that for the web search instead of > prompting the user. > > In its current form, 'eww-search-words' presents a security and > usability problem. It is relatively too easy to mistakenly > launch the function and, if a region of text is selected, have > potentially sensitive data sent out to a third-party service. > > This commit changes the search function's default behaviour so > that explicit confirmation is required before a region is sent > to a search engine. The behaviour can be adjusted via the > newly-introduced 'eww-search-confirm-send-region' variable, > which is set to true by default. This is a good addition, thanks. I think it should be announced in etc/NEWS, too. > * lisp/net/eww.el (eww-search-confirm-send-region): Add. > (eww-search-words): Update default 'eww-search-words' behaviour > so as to ask confirmation before sending a region to a search > engine. > --- > lisp/net/eww.el | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/lisp/net/eww.el b/lisp/net/eww.el > index 2d351dff88f..cbf989f4a6a 100644 > --- a/lisp/net/eww.el > +++ b/lisp/net/eww.el > @@ -52,6 +52,17 @@ > :group 'eww > :type 'string) > > +(defcustom eww-search-confirm-send-region t > + "Whether to confirm before sending a region to a search engine. We avoid the word "Whether" in the beginning of the docstring of a defcustom, since it doesn't make clear which value means what. So this should read something like: If non-nil, prompt before sending region to a search engine. > +Non-nil if EWW should ask confirmation before sending the > +selected region to the configured search engine. This is the > +default to mitigate the risk of accidental data leak. Set this > +variable to nil to send the region to the search engine > +straightaway." I suggest reformulating this like so: This user option mitigates the risk of accidental data leak. Set this variable to nil to send the region to a search engine without prompting. Note that the first sentence in that paragraph now just repeats the first line, and so can be removed. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 03:42:36 2024 Received: (at 74218) by debbugs.gnu.org; 7 Nov 2024 08:42:36 +0000 Received: from localhost ([127.0.0.1]:47084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8y67-0003YV-Iw for submit@debbugs.gnu.org; Thu, 07 Nov 2024 03:42:36 -0500 Received: from mail.eshelyaron.com ([107.175.124.16]:52000 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8y64-0003YM-O9 for 74218@debbugs.gnu.org; Thu, 07 Nov 2024 03:42:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1730968952; bh=FDTBX8K5JJf0XNJvhzzPrcaMPfgjbixBZgz/AQz06tc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=vpYIp1UtYLv77lhwZ2/Tz0wraPm09ZyUj5Mf1I57r2JVe36sq5bMzCmoDqjrIzxd1 44jchp29g7+gvUH8s14Hr16a1LaSFkIqOurfnYCqL+HzY0n73NxsgDiGUK36Pk6Kwa 7tIUFh/BrvljtXcBsjSjYYFHNXcEKeo1wOZUi5ne5SVGO65fZeMKl8Ep4wE1zB/1xw aBKW/oqHGrfxPB2OB+r2nPNKbOW201Xeeoo+rf5iF8z3Gij2KAc0vYa1MtylB5tYLb FVGcDFuVAgMF2F+W/ufmg8TxMYR1VuhXKkgnF0TIxNfegXQnn3xtJdm8khNn56PxO6 CwDlReA8U3Fog== From: Eshel Yaron To: Stefan Kangas Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. In-Reply-To: (Stefan Kangas's message of "Wed, 6 Nov 2024 17:51:22 -0800") References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> Date: Thu, 07 Nov 2024 09:42:29 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org, Eli Zaretskii , Fabio Natali X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Stefan Kangas writes: > Fabio Natali writes: > >> From cdd17053befac8298a04d0cdfc4cafe5a410166b Mon Sep 17 00:00:00 2001 >> From: Fabio Natali >> Date: Tue, 5 Nov 2024 23:52:30 +0000 >> Subject: [PATCH v2] Ask confirmation before sending region to search engine >> >> With 'eww-search-words' (by default bound to 'M-s M-w') a user >> can type in some search terms and get back the results of a web >> search from a predefined search engine. If a region is selected, >> 'eww-search-words' will use that for the web search instead of >> prompting the user. >> >> In its current form, 'eww-search-words' presents a security and >> usability problem. It is relatively too easy to mistakenly >> launch the function and, if a region of text is selected, have >> potentially sensitive data sent out to a third-party service. >> >> This commit changes the search function's default behaviour so >> that explicit confirmation is required before a region is sent >> to a search engine. The behaviour can be adjusted via the >> newly-introduced 'eww-search-confirm-send-region' variable, >> which is set to true by default. > > This is a good addition, thanks. I too agree that it's a good idea to optionally require confirmation. However, I suspect that a yes/no question is not the best interface in this case. Instead, it's better to simply prepopulate the minibuffer with the contents of the region. Then you confirm with RET and cancel with C-g. In addition, this lets you examine and edit your input. Namely, we can implement eww-search-words along the following lines: --8<---------------cut here---------------start------------->8--- (defun eww-search-words () "..." (interactive) (eww (eww-read-url-or-search-string (and (use-region-p) (string-trim (buffer-substring-no-properties (point) (mark))))))) --8<---------------cut here---------------end--------------->8--- Where eww-read-url-or-search-string is a new function extracted from the interactive spec of eww: --8<---------------cut here---------------start------------->8--- (defun eww-read-url-or-search-string (&optional initial-input) (let ((uris (eww-suggested-uris))) (completing-read (format-prompt "Enter URL or keywords" uris) (seq-uniq (append eww-prompt-history uris)) nil nil initial-input 'eww-prompt-history uris))) --8<---------------cut here---------------end--------------->8--- Just my 2c, Eshel From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 03:53:37 2024 Received: (at 74218) by debbugs.gnu.org; 7 Nov 2024 08:53:37 +0000 Received: from localhost ([127.0.0.1]:47100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8yGn-00042g-Ca for submit@debbugs.gnu.org; Thu, 07 Nov 2024 03:53:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8yGk-00042S-CC for 74218@debbugs.gnu.org; Thu, 07 Nov 2024 03:53:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8yGd-0002Wv-9P; Thu, 07 Nov 2024 03:53:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6QWSysG718oRaiuOeleYbUje7bvCYOVqpbhWv4ztJgI=; b=gHzXvGsxVLDG xBnziAGrNU0e14PJUM8/+RjhxO2HovgVdbDsDXGdbhdv0mnk00sqxO/2mwsgpLMKXIej+OZ2M7/T4 4OCfF6GwSqiEuAUK/j+l5CQCW3myxFM3/EcGajj4FkxDedlwh2Xrazf+9YLp/0jR91bDKzcaM01lR 1sNzHVcOIe1rHGnoNZu3L5nqWMrK/suP1D1XVKjpU26N3ec7s7205mfvzUxs44QYaXhiwWrkrljIy 8WzxPzSKK3EfP7s9aW4jJBcga2oCSPTws4jUEEcz2xReWjEy4mwU44QMPeYTFj8mktv327q74DpGF f6YFv2mNiVR0Xv4XWAzJ9w==; Date: Thu, 07 Nov 2024 10:53:23 +0200 Message-Id: <86bjyrqvb0.fsf@gnu.org> From: Eli Zaretskii To: Eshel Yaron In-Reply-To: (message from Eshel Yaron on Thu, 07 Nov 2024 09:42:29 +0100) Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org, stefankangas@gmail.com, me@fabionatali.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eshel Yaron > Cc: Fabio Natali , Eli Zaretskii , > 74218@debbugs.gnu.org > Date: Thu, 07 Nov 2024 09:42:29 +0100 > > I too agree that it's a good idea to optionally require confirmation. > However, I suspect that a yes/no question is not the best interface in > this case. Instead, it's better to simply prepopulate the minibuffer > with the contents of the region. Then you confirm with RET and cancel > with C-g. In addition, this lets you examine and edit your input. Why copy the region into the mini-window when it is already shown in the current buffer's window? By default, it will be highlighted, but if not (e.g., transient-mark-mode was disabled), we could forcibly highlight it. Why is that not enough? Copying stuff into the minibuffer has the disadvantage of resizing the mini-window, and then it could hit the limits on such resizes, which will prevent the user from seeing large portions of the text, if the region is large. Also, does anyone have an opinion about asking for confirmation only for regions that are large enough? E.g., when the region is a single word, do we want to ask for confirmation anyway? From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 04:03:06 2024 Received: (at 74218) by debbugs.gnu.org; 7 Nov 2024 09:03:06 +0000 Received: from localhost ([127.0.0.1]:47150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8yPy-0004WZ-DQ for submit@debbugs.gnu.org; Thu, 07 Nov 2024 04:03:06 -0500 Received: from mail-wr1-f48.google.com ([209.85.221.48]:55805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8yPv-0004WQ-Nq for 74218@debbugs.gnu.org; Thu, 07 Nov 2024 04:03:04 -0500 Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-37d51055097so450344f8f.3 for <74218@debbugs.gnu.org>; Thu, 07 Nov 2024 01:03:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730970122; x=1731574922; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=zOnmLQW+NBy0SVJMfu7v88HPEE61N0epWKHFUsYqNNI=; b=AsbE9oJTjvya5hESjq9eAOHD+go2zXJeWgtzEpNmDH2ieRwj96L91iTybDGSXX8K+O /HYdmu5zGXT7Gvs3zWxY96TVAatHyT7xnDbm4iGSVJ2T0Y1vtnd0kwcWLFzH1FnMN+WJ fL+X2ELYsHRHD4l2pFFYQqGl4eETmtTuFW1QvRdpwE1gATorM8TT9FjNF875aYUn3neA bV4UU583uXXEjvMeH+yKijNJuSNsHSe6ZCjkTHVoO/KHaKUyKUMZlstPzph/EAuly/9n DubTUhAMzayXGNULvUOyiRk207BxeMtSj3AVymmdN9rbYyrmxsvnnopgxyh2ZO5poSgY sCcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730970122; x=1731574922; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zOnmLQW+NBy0SVJMfu7v88HPEE61N0epWKHFUsYqNNI=; b=pJVjHqtUW8GIVIwTNpiDA6z7NB4+vWISYMG6uD+ahtwq40CD2Xj9EP49n3vt3k0N5b 6ww4DdGmXuFb3i1+zNRi1AvOyJ1Y/zEDe7q9b+uzSHhze2ZmX41xEZ6OlXugslr6oL92 OOebUatcDPVSBQS4e4/7Nc9+N40nScRorBy4FBC9OcZZba58RPWt0ZTcptR4QzQd9xkF kP1hNPqCc++fzimArC5Ty34Lp+Z41dX4URxNxA/Fq2YtU1EblWSE+CwoHn4cp1yh8Awi Kju7zYksvtrvLF9lD41YRMlGUAy1xHi/2/uLOk2+ylkwtqgajE9rFgLFNCxiTD/sk9Dv MLWg== X-Forwarded-Encrypted: i=1; AJvYcCVTGpS054zLFEbP1c+xxMKHEJOgi1c9Z6+H1U/cP9gbAWdElsEzSotOyywkQuPHfySDnNV1eA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyB8A5YbOgFC6lRpsabMajl6f6vDqx5c/3+WNtmdsLGtvayOhAB E1coiEoku6HoOR4XC+FfZ6XhkAVufed/Te9ut+GQVKGFWk8yciYA X-Google-Smtp-Source: AGHT+IG7KD97NHn2B6i3iDqawoLfSuiXDO7tJjYx9xCL3rwlApKJg/aRMYS6qzVqZPydvSC6F7fuOw== X-Received: by 2002:a05:6000:1865:b0:37c:fde2:93b6 with SMTP id ffacd0b85a97d-381c7a3a51emr17358865f8f.11.1730970122247; Thu, 07 Nov 2024 01:02:02 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb51:cfd4:b576:ecc8:5796]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381ed97ce1bsm1122732f8f.36.2024.11.07.01.02.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2024 01:02:01 -0800 (PST) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. In-Reply-To: <86bjyrqvb0.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Nov 2024 10:53:23 +0200") References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> <86bjyrqvb0.fsf@gnu.org> Date: Thu, 07 Nov 2024 10:02:00 +0100 Message-ID: <877c9fmn7b.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org, Eshel Yaron , stefankangas@gmail.com, me@fabionatali.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 07 Nov 2024 10:53:23 +0200, Eli Zaretskii said: Eli> Also, does anyone have an opinion about asking for confirmation only Eli> for regions that are large enough? E.g., when the region is a single Eli> word, do we want to ask for confirmation anyway? The default for sending stuff to remote servers should be not to do it unless explicitly authorized, even if the amount of data is small: the submission itself provides data about your machine, IP, location etc. Robert -- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 04:13:02 2024 Received: (at 74218) by debbugs.gnu.org; 7 Nov 2024 09:13:02 +0000 Received: from localhost ([127.0.0.1]:47173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8yZa-0004wq-1w for submit@debbugs.gnu.org; Thu, 07 Nov 2024 04:13:02 -0500 Received: from mail.eshelyaron.com ([107.175.124.16]:47392 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8yZV-0004wO-LR for 74218@debbugs.gnu.org; Thu, 07 Nov 2024 04:13:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1730970777; bh=doIOJkfSxD7oWaYZmaKVnp5CCen5M6L2z9jQq+sSLm4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HrWDcAcz60TGngfrP/K6QSOsJ0fheH//tZYvlNB7Ze4bJgGc+W5KtUBJrKkcEijCx 27aj5wq2iwMWaNOsURl7IGJRQMNPWFBH6Sye6bjqFdMb1x0GxM0SCtOElSFuhjT+9E ZBdQ8eWwIRUk9LNbqi+++Pzqs7n4Xcz1Pjh/NUFibvzxLKfUNafpWd6sl9b5JTGiXf b5W8FXcuRkJKOSiYIpLAjLz+4hvK0ybCbrmo6YqxHuyO8ubRUEB2evZdFkP6LgET9J GSgF+uGSXLKPfjrsfwtRavxfp6/h8G7f/aO9GjrfgLaglH/2CgT1Xd+0HvvNgC3+GD MUDFpwniJOAFw== From: Eshel Yaron To: Eli Zaretskii Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. In-Reply-To: <86bjyrqvb0.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Nov 2024 10:53:23 +0200") References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> <86bjyrqvb0.fsf@gnu.org> Date: Thu, 07 Nov 2024 10:12:53 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org, stefankangas@gmail.com, me@fabionatali.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Eshel Yaron >> Cc: Fabio Natali , Eli Zaretskii , >> 74218@debbugs.gnu.org >> Date: Thu, 07 Nov 2024 09:42:29 +0100 >> >> I too agree that it's a good idea to optionally require confirmation. >> However, I suspect that a yes/no question is not the best interface in >> this case. Instead, it's better to simply prepopulate the minibuffer >> with the contents of the region. Then you confirm with RET and cancel >> with C-g. In addition, this lets you examine and edit your input. > > Why copy the region into the mini-window when it is already shown in > the current buffer's window? By default, it will be highlighted, but > if not (e.g., transient-mark-mode was disabled), we could forcibly > highlight it. Why is that not enough? While point is always visible, mark can be out of view, so the region need not be fully visible in the selected window. But more importantly, using the minibuffer provides a smoother and more consistent UX compared to an additional yes/no question, IMO. > Copying stuff into the minibuffer has the disadvantage of resizing the > mini-window, and then it could hit the limits on such resizes, which > will prevent the user from seeing large portions of the text, if the > region is large. > > Also, does anyone have an opinion about asking for confirmation only > for regions that are large enough? E.g., when the region is a single > word, do we want to ask for confirmation anyway? I think it makes sense to have an option that is sensitive to the size of the region, although personally I'd probably stick to "always ask", especially if the prompt for confirmation isn't too obtrusive. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 05:50:00 2024 Received: (at 74218) by debbugs.gnu.org; 7 Nov 2024 10:50:00 +0000 Received: from localhost ([127.0.0.1]:47326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t905P-0000jN-Jz for submit@debbugs.gnu.org; Thu, 07 Nov 2024 05:49:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t905N-0000jB-M0 for 74218@debbugs.gnu.org; Thu, 07 Nov 2024 05:49:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t905H-00075R-TF; Thu, 07 Nov 2024 05:49:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=yYuFVweS+R6jwEdSmRLEfLQL7cqpNsMsLtLxmvL3iiY=; b=i11MKL8PSMxmi41/90Et MnOcFakimf1puJvYxiBnEPpAtXSfDnQYP2u03f5IuhrMyo5ZR14Hy+jWb+SIkIgNJgVN/qUMSxxY5 xmpiBtlOt2mP0xJXKH4+8B00KOZDPAqGXErZC4vp87R2ugx2CHdJtbKZkoycjG38+CcbC+OYTCKDd FzKM/MsPDD8boV4Bp+Y9c/XM44x8YYLN12D5jvRxpSS7L0DKOUxWjh/Qzf5aWKbpF0xdikHDKjtS2 OMv7D9zRp6OnqAxzHXxJhZOziNRa/lPdscy80+AcuExzuMnpcUqf2ZjZ6qHHp7yuRwSZvwdzFjUX4 /lxC3AadpFMQpA==; Date: Thu, 07 Nov 2024 12:49:47 +0200 Message-Id: <867c9fqpx0.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <877c9fmn7b.fsf@gmail.com> (message from Robert Pluim on Thu, 07 Nov 2024 10:02:00 +0100) Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> <86bjyrqvb0.fsf@gnu.org> <877c9fmn7b.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org, me@eshelyaron.com, stefankangas@gmail.com, me@fabionatali.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: Eshel Yaron , 74218@debbugs.gnu.org, > stefankangas@gmail.com, me@fabionatali.com > Date: Thu, 07 Nov 2024 10:02:00 +0100 > > >>>>> On Thu, 07 Nov 2024 10:53:23 +0200, Eli Zaretskii said: > > Eli> Also, does anyone have an opinion about asking for confirmation only > Eli> for regions that are large enough? E.g., when the region is a single > Eli> word, do we want to ask for confirmation anyway? > > The default for sending stuff to remote servers should be not to do it > unless explicitly authorized, even if the amount of data is small: the > submission itself provides data about your machine, IP, location etc. We are talking about a command which is document as follows: (eww-search-words) Search the web for the text in the region. If region is active (and not whitespace), search the web for the text between region beginning and end. Else, prompt the user for a search string. See the variable ‘eww-search-prefix’ for the search engine used. It should be clear from this that a Web search engine is used, and that the word or the region are sent to it. Since the user invokes this command, how is it reasonable not to do what the user requested? If the user doesn't want to reveal details to the Internet, the user can avoid invoking the command in the first place. I feel that I'm missing something here. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 05:52:55 2024 Received: (at 74218) by debbugs.gnu.org; 7 Nov 2024 10:52:56 +0000 Received: from localhost ([127.0.0.1]:47337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t908F-0000tl-H2 for submit@debbugs.gnu.org; Thu, 07 Nov 2024 05:52:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t908C-0000tV-ON for 74218@debbugs.gnu.org; Thu, 07 Nov 2024 05:52:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9087-0007Zk-3O; Thu, 07 Nov 2024 05:52:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ldjfgmuYZnP0NMYfgnGw/MPVHUuvems1Nc1VTKs36IQ=; b=CMitBVGzZp9D IZmTzhfVZUMkdwvJNPaOVTV4SZWiPIxgGZAa6b6RGx5QNyfhB0PoFnrLTdMHj6LHa7idgvFZ+ywZE A3mwiN8SQupvL7I+F6uPLroSZ6fs0ypsSIHLpN9hRdMN5/0QJhPNXdVjjv3nqVc0IODgxvZa9SV+V 0w3RLBvWs+/V3cfvDmYwWJKbJJwhMjkO5eFxRQUOR77FFL/LCPqlU8GLDDq47BrDMZvEXmPMFwp3j ReT+gRkHIZY1g7Vm0MkB7YqvYcWdPxxsJedxPXWbs90KDUqvS9eGu5NGSemEvGBMtJJwoxQSIhiQ8 dIxterIOpACDmRoTSSD1LQ==; Date: Thu, 07 Nov 2024 12:52:44 +0200 Message-Id: <864j4jqps3.fsf@gnu.org> From: Eli Zaretskii To: Eshel Yaron In-Reply-To: (message from Eshel Yaron on Thu, 07 Nov 2024 10:12:53 +0100) Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> <86bjyrqvb0.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org, stefankangas@gmail.com, me@fabionatali.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eshel Yaron > Cc: 74218@debbugs.gnu.org, stefankangas@gmail.com, me@fabionatali.com > Date: Thu, 07 Nov 2024 10:12:53 +0100 > > Eli Zaretskii writes: > > >> From: Eshel Yaron > >> Cc: Fabio Natali , Eli Zaretskii , > >> 74218@debbugs.gnu.org > >> Date: Thu, 07 Nov 2024 09:42:29 +0100 > >> > >> I too agree that it's a good idea to optionally require confirmation. > >> However, I suspect that a yes/no question is not the best interface in > >> this case. Instead, it's better to simply prepopulate the minibuffer > >> with the contents of the region. Then you confirm with RET and cancel > >> with C-g. In addition, this lets you examine and edit your input. > > > > Why copy the region into the mini-window when it is already shown in > > the current buffer's window? By default, it will be highlighted, but > > if not (e.g., transient-mark-mode was disabled), we could forcibly > > highlight it. Why is that not enough? > > While point is always visible, mark can be out of view, so the region > need not be fully visible in the selected window. But more importantly, > using the minibuffer provides a smoother and more consistent UX compared > to an additional yes/no question, IMO. Not all the region is always visible, but I'm sure you will agree that in most cases _more_ of it will be visible in its buffer than if copied to minibuffer. To say nothing of the fact that resizing the mini-window has adverse effect on visibility of other windows, and thus on the window where the current buffer is displayed. > > Also, does anyone have an opinion about asking for confirmation only > > for regions that are large enough? E.g., when the region is a single > > word, do we want to ask for confirmation anyway? > > I think it makes sense to have an option that is sensitive to the size > of the region, although personally I'd probably stick to "always ask", > especially if the prompt for confirmation isn't too obtrusive. We can argue about defaults later, but personally I fail to see how asking for confirmation when a single word is sent would be TRT. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 06:04:27 2024 Received: (at 74218) by debbugs.gnu.org; 7 Nov 2024 11:04:27 +0000 Received: from localhost ([127.0.0.1]:47348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t90JO-0001Me-VJ for submit@debbugs.gnu.org; Thu, 07 Nov 2024 06:04:27 -0500 Received: from mail-wr1-f49.google.com ([209.85.221.49]:59573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t90JL-0001MU-4p for 74218@debbugs.gnu.org; Thu, 07 Nov 2024 06:04:25 -0500 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-37d533b5412so540171f8f.2 for <74218@debbugs.gnu.org>; Thu, 07 Nov 2024 03:04:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730977402; x=1731582202; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=rk3daiX8wwANLst62sCmNZhNoXcWYCbOLXCsADI5xXk=; b=AnSCz5pHp7JqkugrvSEfALsWyfyeNmjullBBTy7zn0kDtwguACgmB1qTPOrgd/CqOj imZhujayWovV1lishntuDpy6utNjoBMEW9gl0vYOsFBXjPW92E7YDRuGe6z0EiCFNsxo gkqGQlXL9Wv3TQEt4Fpqhk29GevWnMDpY+SwtCqUlKWE1kbKyf6oVYvaJREQ6P65fqA8 I9Yy/A+9LI20+nBZZkVJe5swno8ajL5iTKnCDwJOmowVv3L4q5OzfnUoh+CGPCCBs+qc oaZKXFOEtdVks+sdNfpW34K3cHe4+PvWKfV/bNF6/qSSjwfKdLCppTqypSJPgY2w7Q+8 VUtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730977402; x=1731582202; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rk3daiX8wwANLst62sCmNZhNoXcWYCbOLXCsADI5xXk=; b=hSXkozeqH72wmYJRvSJ+71P8bnklbO/gP3ot9YqrgzJvU7bMxeZO047L4/bj05GI6H /cVHaTaOcVNhD0xD+Dq1P6VDNHCDKgnHzOCMxnL/PDHEbfJ6c1QtaYhX2x7yFeCpWLo+ KCylZptzpBZJUhYwqiP1mPNEZEWcW46p/ZEFB1e8ebDi0pcwizs86f3Leas11dhPMG5z Pi6FZgs02hJJDU24yvtbzdn8qSri+wkA5CII8k5RzxXkgBv2ymmIjsZ2FlAI94OJFhbb cfFBiV9d70xCNlYKQGMKUsa+XtHF9hJHILdUV4CPwIt2dQv3dhR6arMEcTtn3TugG0ve 7FPA== X-Forwarded-Encrypted: i=1; AJvYcCUDY8pRZAzDmkNDAR3vTJ7qALv3cT+gPJnZqhOZWJv4vhVXxAfSsYXb/Im9zXlMTLPEyMu4nQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy+cm/ErvHo9bR7HaZK+K0wCO5Yk/bGGaI8cnt66V8IELG0D70l LrydCic9F2wQYrga4vAe+IIWDyUBBd+0luhVQG67Omchsl8ZcDJ/ X-Google-Smtp-Source: AGHT+IGc+3mYRUIQp2V1v7tI5vnCrAdcRZnjhIWiu2V5VJQRzLFRsFFHIYNUOTrhaTRSNfIlKXUblg== X-Received: by 2002:a5d:6192:0:b0:37d:4956:b0b4 with SMTP id ffacd0b85a97d-3806122fc7emr31122428f8f.59.1730977401973; Thu, 07 Nov 2024 03:03:21 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb51:cfd4:b576:ecc8:5796]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381eda13780sm1381255f8f.109.2024.11.07.03.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2024 03:03:21 -0800 (PST) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. In-Reply-To: <867c9fqpx0.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Nov 2024 12:49:47 +0200") References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> <86bjyrqvb0.fsf@gnu.org> <877c9fmn7b.fsf@gmail.com> <867c9fqpx0.fsf@gnu.org> Date: Thu, 07 Nov 2024 12:03:20 +0100 Message-ID: <87v7wzl30n.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org, me@eshelyaron.com, stefankangas@gmail.com, me@fabionatali.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 07 Nov 2024 12:49:47 +0200, Eli Zaretskii said: >> From: Robert Pluim >> Cc: Eshel Yaron , 74218@debbugs.gnu.org, >> stefankangas@gmail.com, me@fabionatali.com >> Date: Thu, 07 Nov 2024 10:02:00 +0100 >>=20 >> >>>>> On Thu, 07 Nov 2024 10:53:23 +0200, Eli Zaretskii said: >>=20 Eli> Also, does anyone have an opinion about asking for confirmation on= ly Eli> for regions that are large enough? E.g., when the region is a sin= gle Eli> word, do we want to ask for confirmation anyway? >>=20 >> The default for sending stuff to remote servers should be not to do = it >> unless explicitly authorized, even if the amount of data is small: t= he >> submission itself provides data about your machine, IP, location etc. Eli> We are talking about a command which is document as follows: Eli> (eww-search-words) Eli> Search the web for the text in the region. Eli> If region is active (and not whitespace), search the web for Eli> the text between region beginning and end. Else, prompt the Eli> user for a search string. See the variable =E2=80=98eww-search-= prefix=E2=80=99 Eli> for the search engine used. Eli> It should be clear from this that a Web search engine is used, and Eli> that the word or the region are sent to it. Since the user invokes Eli> this command, how is it reasonable not to do what the user request= ed? Eli> If the user doesn't want to reveal details to the Internet, the us= er Eli> can avoid invoking the command in the first place. Eli> I feel that I'm missing something here. And so am I. Why are we discussing adding a confirmation to an explicit request from the user? Or is the intent to leave it as 'off', but allow customizing it to 'ask'? Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 06:05:55 2024 Received: (at 74218) by debbugs.gnu.org; 7 Nov 2024 11:05:55 +0000 Received: from localhost ([127.0.0.1]:47356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t90Ko-0001Ug-HC for submit@debbugs.gnu.org; Thu, 07 Nov 2024 06:05:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t90Km-0001UP-01 for 74218@debbugs.gnu.org; Thu, 07 Nov 2024 06:05:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t90Kg-0001eA-3C; Thu, 07 Nov 2024 06:05:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=2n1h+IAs6R+9vo8e3EjUUdoaaL3lrS04xxylS71GhjQ=; b=cvVbdZpwwVhxyNOoB/tD v6jJf6CFqBVHQZid4Afab42gfXhB3Ku7L1L9FnfJnFUlBPbh4Ptn0ye8TTuX3uWRBzIPWqGWDLuuW iSWvQEQzCzAtgSsKXXNhfevm8GAzmQX4cM/Yw3XOTcplReIkGXu9d8oK7gbt4T/MpjNcqDDBV5FfX Mz6DxzkQSnDyudDhSakqNZFGM9cBOCYrM8hUceOyb6VYoY/FkrvhOlHXQeTKtKH8RQ3AUfZRdswVz N2OdMfIr4ivMWMmbgD/dTktCo6Kk1/kvSAY5qUf4nLiVc7l4UMkwpSMMq6vl7jU7//X9hjDoLzalO oA5ucD3YWHdK/g==; Date: Thu, 07 Nov 2024 13:05:43 +0200 Message-Id: <86zfmbpam0.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <87v7wzl30n.fsf@gmail.com> (message from Robert Pluim on Thu, 07 Nov 2024 12:03:20 +0100) Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> <86bjyrqvb0.fsf@gnu.org> <877c9fmn7b.fsf@gmail.com> <867c9fqpx0.fsf@gnu.org> <87v7wzl30n.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org, me@eshelyaron.com, stefankangas@gmail.com, me@fabionatali.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: me@eshelyaron.com, 74218@debbugs.gnu.org, stefankangas@gmail.com, > me@fabionatali.com > Date: Thu, 07 Nov 2024 12:03:20 +0100 > > >>>>> On Thu, 07 Nov 2024 12:49:47 +0200, Eli Zaretskii said: > > >> From: Robert Pluim > >> Cc: Eshel Yaron , 74218@debbugs.gnu.org, > >> stefankangas@gmail.com, me@fabionatali.com > >> Date: Thu, 07 Nov 2024 10:02:00 +0100 > >> > >> >>>>> On Thu, 07 Nov 2024 10:53:23 +0200, Eli Zaretskii said: > >> > Eli> Also, does anyone have an opinion about asking for confirmation only > Eli> for regions that are large enough? E.g., when the region is a single > Eli> word, do we want to ask for confirmation anyway? > >> > >> The default for sending stuff to remote servers should be not to do it > >> unless explicitly authorized, even if the amount of data is small: the > >> submission itself provides data about your machine, IP, location etc. > > Eli> We are talking about a command which is document as follows: > > Eli> (eww-search-words) > > Eli> Search the web for the text in the region. > Eli> If region is active (and not whitespace), search the web for > Eli> the text between region beginning and end. Else, prompt the > Eli> user for a search string. See the variable ‘eww-search-prefix’ > Eli> for the search engine used. > > Eli> It should be clear from this that a Web search engine is used, and > Eli> that the word or the region are sent to it. Since the user invokes > Eli> this command, how is it reasonable not to do what the user requested? > Eli> If the user doesn't want to reveal details to the Internet, the user > Eli> can avoid invoking the command in the first place. > > Eli> I feel that I'm missing something here. > > And so am I. Why are we discussing adding a confirmation to an > explicit request from the user? Or is the intent to leave it as 'off', > but allow customizing it to 'ask'? My take on it is that the user might not realize that the region is very large and includes parts she didn't intend to send. IOW, a cockpit error. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 06:20:24 2024 Received: (at 74218) by debbugs.gnu.org; 7 Nov 2024 11:20:24 +0000 Received: from localhost ([127.0.0.1]:47376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t90Ym-00028U-Nz for submit@debbugs.gnu.org; Thu, 07 Nov 2024 06:20:24 -0500 Received: from mail-lf1-f52.google.com ([209.85.167.52]:61825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t90Yj-00022x-I7 for 74218@debbugs.gnu.org; Thu, 07 Nov 2024 06:20:19 -0500 Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-539f84907caso760997e87.3 for <74218@debbugs.gnu.org>; Thu, 07 Nov 2024 03:20:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730978350; x=1731583150; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=kyeUfDn4JBc8Y0mL6KTRfMe0o7q9oNIDcIPobPPxDOk=; b=IKPkTO+KthyGj/wdDKI93DmdCSCSAuoOuK/a8rbxDCsQdMIoxXp08NNqg/PAkgPhL0 rhQNDIN3u91EgQfLxgmTfetZxsTEfo9DlbwM4fJldbZGhlCF1nSoZi04k3nPWW4yB6h/ //5QytYdIPd4zxoiXhZEaJEhUE/+daGCVleDcqXms5ULK6oiNyKYC1L0mvd7ZJgf/vvE xJB6/o792bSW/n3ytRLSpoDMCVYhOr7INptMFXEbIwnP/uoAQdTsKptfBRlx73tEu0/O cmTHLLU010KummYB7agEB+XiPXbRlsFpzMre1zJ8kgyDNe6UvLYBICsjAHtz7hSX478J uYgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730978350; x=1731583150; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kyeUfDn4JBc8Y0mL6KTRfMe0o7q9oNIDcIPobPPxDOk=; b=it0TvLwDwz0qo4GBPiNi6EU/8SynpOJINU3T7fBk/L+WizsbVDNv+1Fi8OO5bYeVDN z+k9FaPr5VY2l7GBBG8YdxerOftF+Dd0BMPqcs6jfGQUpc5TsvYNDmcVdizZ8kCYJo2q tsVMswcj1gxR6wNvNR3vR4Q1FGMaZNKHITVs6QvCGjQ/5cdN2oB2uX53KNyVCrpA6E1M qSPDX0JzqEXzA5UCdw581m7npYYnbjwVdS3eEpgFyWJStnrwEWU/ZqXcyDSTPyGrb3nf UOjntdFxeEzclTxxQL01lNu0Ex6reR9CC1C2iCg1G2nYorDBTOkYgeg1dHbfkNWrxKFm QHLQ== X-Forwarded-Encrypted: i=1; AJvYcCU42NaxiIh3qsXLVHydhfo1QLrrJCc55Tk5y4ZY4XYTzjqMB9t3wPpiWNDCxuVwXGKZSjFVtg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzbwyEwBJkoNlTQ/PQCPLACZ+Uu4SYsumD5EhXmSVN4EeKr5s4J E0w7OJRI6KkhIgbtEUIMkBilWo+FRLMEUHhBIDz3FKjfNU834wQO X-Google-Smtp-Source: AGHT+IGAnnOHTxCA0CihlBqy/atN85QZsz4snA8mvro51Jlrd7enPOH71/Z3DhryBHcsOLtEX55pTQ== X-Received: by 2002:a05:6512:3e14:b0:539:8ad5:5093 with SMTP id 2adb3069b0e04-53b34a1943amr19167657e87.35.1730978350042; Thu, 07 Nov 2024 03:19:10 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb51:cfd4:b576:ecc8:5796]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381ed97c6b6sm1431967f8f.24.2024.11.07.03.19.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2024 03:19:09 -0800 (PST) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. In-Reply-To: <86zfmbpam0.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Nov 2024 13:05:43 +0200") References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> <86bjyrqvb0.fsf@gnu.org> <877c9fmn7b.fsf@gmail.com> <867c9fqpx0.fsf@gnu.org> <87v7wzl30n.fsf@gmail.com> <86zfmbpam0.fsf@gnu.org> Date: Thu, 07 Nov 2024 12:19:08 +0100 Message-ID: <87msibl2ab.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org, me@eshelyaron.com, stefankangas@gmail.com, me@fabionatali.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 07 Nov 2024 13:05:43 +0200, Eli Zaretskii said: >> And so am I. Why are we discussing adding a confirmation to an >> explicit request from the user? Or is the intent to leave it as 'off', >> but allow customizing it to 'ask'? Eli> My take on it is that the user might not realize that the region is Eli> very large and includes parts she didn't intend to send. IOW, a Eli> cockpit error. Hmm, ok. As long as it defaults to off. Robert -- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 06:29:50 2024 Received: (at 74218) by debbugs.gnu.org; 7 Nov 2024 11:29:50 +0000 Received: from localhost ([127.0.0.1]:47397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t90hy-0002T4-7m for submit@debbugs.gnu.org; Thu, 07 Nov 2024 06:29:50 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:34349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t90hv-0002Sq-FG for 74218@debbugs.gnu.org; Thu, 07 Nov 2024 06:29:48 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id CD518C000B; Thu, 7 Nov 2024 11:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fabionatali.com; s=gm1; t=1730978981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e0nVqp01KvjxmdUVJgZlIgaNBdmZZ3XoYi0FV+crvvM=; b=V3m6bkd3CUKdVMFSuf09tqG1FMvYF7v2UQ8X84fe2RAONbNcye/9Kt9L+3IhXrIV4lB02r /Ler25j4Ut00rYX/88Y6MPfyK/795ZGGh3wK+x4ea8nIugqMXjuQspIxlJ7BZC79hcQhd+ vxgxicj/T85N1tUY2MUcOIokKk1G9tjKO4LTaUhcB3mGWp4r98QCBq6Tlheoon3nCBeHqO ZApQnDTJElo7z5iMCFwUcV0TqXW5M5O7ybU6mek0KrpTWeiJiAUhBtNFrA+iqoukLPQi0g EG3Ry3/qF6r3/Yz6EkfPH8ZEIopYZQqE+FBruTcNR37BIBJTfUbyR77nWj69qA== From: Fabio Natali To: Eli Zaretskii , Robert Pluim Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. In-Reply-To: <86zfmbpam0.fsf@gnu.org> References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> <86bjyrqvb0.fsf@gnu.org> <877c9fmn7b.fsf@gmail.com> <867c9fqpx0.fsf@gnu.org> <87v7wzl30n.fsf@gmail.com> <86zfmbpam0.fsf@gnu.org> Date: Thu, 07 Nov 2024 11:29:37 +0000 Message-ID: <87fro3gu3i.fsf@fabionatali.com> MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: me@fabionatali.com X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org, me@eshelyaron.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2024-11-07, 13:05 +0200, Eli Zaretskii wrote: > My take on it is that the user might not realize that the region is > very large and includes parts she didn't intend to send. IOW, a > cockpit error. It's not only that. Commands can be typed by mistake. The fact that the command's docstring warns about its effects is not enough. By default, 'eww-search-words' is bound to 'M-s M-w'. The probability of accidentally mistyping that combination is not at all negligible. I did discover the command's beheaviour via view-lossage after mistyping 'M-s M-w', for example. One might argue that, no matter how long, all sequences of keys and commands could be mistyped, but that'd be a bit misleading. I think that adding a warning and a yes-or-no confirmation request would make 'eww-search-words' sufficiently safe, that's the assumption behind my patch. As I said above, I don't think that the sensitivity of a block of text is a function of its length. Case in point, a password, an address, any piece of Personally Identifiable Information. Users can always override the default and might decide to customise 'eww-search-words' as they like - but I still think it's important to provide a safe default, something safer than what we have today. Just my 2 cents. Thanks for giving this patch attention. Have a lovely day, cheers, Fabio. -- Fabio Natali https://fabionatali.com From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 06:56:13 2024 Received: (at 74218) by debbugs.gnu.org; 7 Nov 2024 11:56:14 +0000 Received: from localhost ([127.0.0.1]:47428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t917V-0003fO-Fj for submit@debbugs.gnu.org; Thu, 07 Nov 2024 06:56:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t917T-0003f8-7H for 74218@debbugs.gnu.org; Thu, 07 Nov 2024 06:56:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t917N-00029x-9q; Thu, 07 Nov 2024 06:56:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=b7ofx/7cB3N6b/1Dy+OhRqx4hCPfWnt2bXW+f3qfTlM=; b=hjWqP6pRBZ3s wVzOwVBL5gDHn76TnpDDdCb5Tx1tMz3cr4Mi8yHaOhEQiVrP5GXNfZ2KskqUfwpswSwQDlPmtgz9N CwwvftM0M8q3raok7qUBF5seh88bcoTsCXdApPYxCfnQoPY2z3x0H56YSioGB/xkSgSJoQGikXCO2 KxFZA/U637MaXYJCu6J81kH0BulFOC9IiH0zp01XfsWZlsbFRthrgaHWOEpuFQKiu2QlNe+unawQL I9MWW1rnSVkttvNT0QyrO3xPVoTsuB6tOsGbXLLtc4nW8Erf6xILTFS9cgTsOI7PnW57cgG7Jlrq/ USLo/qVGupqhLiH13lI43A==; Date: Thu, 07 Nov 2024 13:56:00 +0200 Message-Id: <86v7wzp8a7.fsf@gnu.org> From: Eli Zaretskii To: Fabio Natali In-Reply-To: <87fro3gu3i.fsf@fabionatali.com> (message from Fabio Natali on Thu, 07 Nov 2024 11:29:37 +0000) Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> <86bjyrqvb0.fsf@gnu.org> <877c9fmn7b.fsf@gmail.com> <867c9fqpx0.fsf@gnu.org> <87v7wzl30n.fsf@gmail.com> <86zfmbpam0.fsf@gnu.org> <87fro3gu3i.fsf@fabionatali.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org, rpluim@gmail.com, me@eshelyaron.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Fabio Natali > Cc: me@eshelyaron.com, 74218@debbugs.gnu.org, stefankangas@gmail.com > Date: Thu, 07 Nov 2024 11:29:37 +0000 > > On 2024-11-07, 13:05 +0200, Eli Zaretskii wrote: > > My take on it is that the user might not realize that the region is > > very large and includes parts she didn't intend to send. IOW, a > > cockpit error. > > It's not only that. Commands can be typed by mistake. The fact that the > command's docstring warns about its effects is not enough. > > By default, 'eww-search-words' is bound to 'M-s M-w'. The probability of > accidentally mistyping that combination is not at all negligible. I did > discover the command's beheaviour via view-lossage after mistyping 'M-s > M-w', for example. Those are still "cockpit errors", aren't they? Did it happen to you that you typed incorrect phrase into a browser's search window? Does a browser always unconditionally ask you whether you really meant that? > One might argue that, no matter how long, all sequences of keys and > commands could be mistyped, but that'd be a bit misleading. I think that > adding a warning and a yes-or-no confirmation request would make > 'eww-search-words' sufficiently safe, that's the assumption behind my > patch. You ask a valid question, but don't answer it. Indeed, why would we treat this particular command differently from others? "Would be misleading" doesn't provide an answer to the question; instead, it seems to claim that the question itself is invalid. Why is it? > As I said above, I don't think that the sensitivity of a block of text > is a function of its length. Case in point, a password, an address, any > piece of Personally Identifiable Information. Is this the only command which sends user-typed text to the Internet? I don't think so: the first example I could think about is sending email. Do we ask the user for confirmation each time the user types the command to send a message? Why not, and how is this command different, in the general sense? > Users can always override the default and might decide to customise > 'eww-search-words' as they like - but I still think it's important to > provide a safe default, something safer than what we have today. I'm asking why requesting a confirmation in every case is a reasonable default. It is safe, I agree, but it is also annoying in many cases. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 09:05:00 2024 Received: (at 74218) by debbugs.gnu.org; 7 Nov 2024 14:05:00 +0000 Received: from localhost ([127.0.0.1]:47608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9387-0000gX-8L for submit@debbugs.gnu.org; Thu, 07 Nov 2024 09:04:59 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:35029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9383-0000gI-Sp for 74218@debbugs.gnu.org; Thu, 07 Nov 2024 09:04:57 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id E750EE0008; Thu, 7 Nov 2024 14:04:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fabionatali.com; s=gm1; t=1730988289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V70D4QVFyPpCocjL9WxlNhybTNAfwl/fK2v0nqZcPOc=; b=GOa+EtdWiWlRBxlB1Yzz5E6/e2o8zdJzitpRcQ2nE5ivJbsl1YQmRjEwUG3Yn8U/oCJr8P 5pkoA83xyufc1Hc49KBbHSj1bGguHKF144u6AjSfagp2a5soluVqjeE1RAPXH/I7rCCCJ6 x5QLFzbltSha0FIUAqRqgzx695T+N3pGq8FztrQEnQzCJXD0lupZlucBu6IQwUeLI1cRmD ejerhcG1iFuc414D1+3XNMHOuzxj95Sb0pgQgos/i5/nyCuJBVg0qsElwNoP08bTvIP6pH Gu7DBC2ykFTw052xLsXZz3CHOu+MS+ebcgulXhpZABG1DM8D0UaHe0ogFRSxww== From: Fabio Natali To: Eli Zaretskii Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. In-Reply-To: <86v7wzp8a7.fsf@gnu.org> References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> <86bjyrqvb0.fsf@gnu.org> <877c9fmn7b.fsf@gmail.com> <867c9fqpx0.fsf@gnu.org> <87v7wzl30n.fsf@gmail.com> <86zfmbpam0.fsf@gnu.org> <87fro3gu3i.fsf@fabionatali.com> <86v7wzp8a7.fsf@gnu.org> Date: Thu, 07 Nov 2024 14:04:46 +0000 Message-ID: <87cyj7gmwx.fsf@fabionatali.com> MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: me@fabionatali.com X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org, rpluim@gmail.com, me@eshelyaron.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Eli, Thanks for getting back to me. On 2024-11-07, 13:56 +0200, Eli Zaretskii wrote: >> From: Fabio Natali >> Cc: me@eshelyaron.com, 74218@debbugs.gnu.org, stefankangas@gmail.com >> Date: Thu, 07 Nov 2024 11:29:37 +0000 >> >> On 2024-11-07, 13:05 +0200, Eli Zaretskii wrote: >> > My take on it is that the user might not realize that the region is >> > very large and includes parts she didn't intend to send. IOW, a >> > cockpit error. >> >> It's not only that. Commands can be typed by mistake. The fact that the >> command's docstring warns about its effects is not enough. >> >> By default, 'eww-search-words' is bound to 'M-s M-w'. The probability of >> accidentally mistyping that combination is not at all negligible. I did >> discover the command's beheaviour via view-lossage after mistyping 'M-s >> M-w', for example. > > Those are still "cockpit errors", aren't they? True, you're right. What I meant is that there are at least two scenarios that might lead to an involuntary data leak. - I deliberately type 'M-x eww-search-words', it's just that I haven't read how the function behaves, I haven't taken the time to read its docstring. - I clumsily mistype 'M-s M-w' while I wanted to do something else. I suppose they might both fall under the cockpit error umbrella, but they're somehow different. I'm particularly worried about the latter scenario. (Which is what happened to me by the way, so I know this *can* happen.) > Did it happen to you that you typed incorrect phrase into a browser's > search window? Does a browser always unconditionally ask you whether > you really meant that? As I said, there's always a chance to mistype a series of keys, steps, or commands, no matter how long/complicated the combination is. Yes, you're right, I might have copy-and-paste'd sensitive information in my browser's URL bar at some point. However, I think that the data leak risk associated with 'eww-search-words', in its current implementation, is higher that similar other examples and that this should be fixed. I suppose the correct way of going at this would be to involve a security and usability expert to assess the severity of this particular scenario and to compare it to others. I'm not a usability expert, but I do have first-hand experience of fumbling up a 'M-s M-w'! :) >> One might argue that, no matter how long, all sequences of keys and >> commands could be mistyped, but that'd be a bit misleading. I think >> that adding a warning and a yes-or-no confirmation request would make >> 'eww-search-words' sufficiently safe, that's the assumption behind my >> patch. > > You ask a valid question, but don't answer it. Indeed, why would we > treat this particular command differently from others? "Would be > misleading" doesn't provide an answer to the question; instead, it > seems to claim that the question itself is invalid. Why is it? The answer is: because this scenario is more risky. It's easier to mistype 'M-s M-w' as opposed to other commands and the consequences of such mistake are more serious than other commands. It's the very definition of risk, i.e. likelihood times severity. >> As I said above, I don't think that the sensitivity of a block of >> text is a function of its length. Case in point, a password, an >> address, any piece of Personally Identifiable Information. > > Is this the only command which sends user-typed text to the Internet? > I don't think so: the first example I could think about is sending > email. Do we ask the user for confirmation each time the user types > the command to send a message? Why not, and how is this command > different, in the general sense? The way my email client is configured, it takes more steps to mistakenly leak sensitive information. For the sake of argument, if I type 'M-x notmuch-mua-new-mail' when a region is selected, that doesn't lead to that region being sent straightaway to the first contact in my email address book! However, should there be cases similar to 'eww-search-words' I'd be definitely up for having them fixed. You're orders of magnitude more familiar with Emacs than I am, but 'eww-search-words' is the first command that struck me as so risky - we're only a selected region and a 'M-s M-w' away from sending data to a third-party. >> Users can always override the default and might decide to customise >> 'eww-search-words' as they like - but I still think it's important to >> provide a safe default, something safer than what we have today. > > I'm asking why requesting a confirmation in every case is a reasonable > default. It is safe, I agree, but it is also annoying in many cases. If the user makes heavy use of 'eww-search-words', they can still permanently or temporarily disable the confirmation step. But I think that the default should be the safer alternative, not the more convenient (but risky!) one. I hope this brings further context and clarifies my point of view. Thanks, cheers, Fabio. -- Fabio Natali https://fabionatali.com From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 07:48:21 2024 Received: (at 74218) by debbugs.gnu.org; 26 Nov 2024 12:48:21 +0000 Received: from localhost ([127.0.0.1]:48053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFuzN-0000Sh-94 for submit@debbugs.gnu.org; Tue, 26 Nov 2024 07:48:21 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:53557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFuzJ-0000SP-8l for 74218@debbugs.gnu.org; Tue, 26 Nov 2024 07:48:19 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id D4B9340005; Tue, 26 Nov 2024 12:48:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fabionatali.com; s=gm1; t=1732625291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qN+ysNWaGQ3Ky7Jf1CmoqDWMtdkOdgnUCLEE7TpXSDI=; b=Yoa16KHDPkKtNZikBtcuHuuWyN+9VM8+AJyqvxVveg/vqHooQWbuKCxnMMeJmhXlVe56BM WiQX8Vv/xm5vp6hpTHtV0f9VqFRqKGJnJmIwBnFJlV1MVFrHMbCupaO3M/TapOd+BKn70D tkYC0iqOrzXINHrZ4PlknyVBgGJxPzqupl/fv1LK5xAZE0mQ2c9gg/lZJ8uwXS/MBPMWcQ 4jOP3n+Yww52jazCw0bvKn8PxpdIgxvRYD7u3PSIlyVSIWaHfyNBPg5G2ZKhlZ+u/DcV6J tBTKNEQarl3TpRGQR4bXL3F7nxcyaQygaHxHKJ0bx/YT79JMuSugSYuPjM2mxA== From: Fabio Natali To: Eli Zaretskii Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. In-Reply-To: <87cyj7gmwx.fsf@fabionatali.com> References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> <86bjyrqvb0.fsf@gnu.org> <877c9fmn7b.fsf@gmail.com> <867c9fqpx0.fsf@gnu.org> <87v7wzl30n.fsf@gmail.com> <86zfmbpam0.fsf@gnu.org> <87fro3gu3i.fsf@fabionatali.com> <86v7wzp8a7.fsf@gnu.org> <87cyj7gmwx.fsf@fabionatali.com> Date: Tue, 26 Nov 2024 12:48:12 +0000 Message-ID: <87o7226u0j.fsf@fabionatali.com> MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: me@fabionatali.com X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org, rpluim@gmail.com, me@eshelyaron.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi All, I was wondering if there was any further feedback on this and what the general feeling was with regard to my v2 patch of 6th Nov. If there's anything that you think I should adjust in the patch, let me know and I'll be glad to look into it. Thanks, cheers, Fabio. -- Fabio Natali https://fabionatali.com From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 30 05:48:23 2024 Received: (at 74218) by debbugs.gnu.org; 30 Nov 2024 10:48:23 +0000 Received: from localhost ([127.0.0.1]:45644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHL1S-0001G8-PM for submit@debbugs.gnu.org; Sat, 30 Nov 2024 05:48:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHL1Q-0001Fv-GR for 74218@debbugs.gnu.org; Sat, 30 Nov 2024 05:48:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHL1K-0000Ll-U9; Sat, 30 Nov 2024 05:48:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Woxe6T3LgxAjuorF4liz+oV78Hf5ozkroCefYXzhahU=; b=AOaMXs4Cg8Dv 7QCQ4ojORoxrg/xEjRTpROknP0lGa7Fzq8Nqq0t81rW8ekmZMn8CM8b85uHfhopk4iOyp8eWHtlqq wbQcn70XxLsF1jIN5OlyF/JS9lqBtp5yMxVaa4i17ccXSH03hFvwhznfrR5vpf8P6qI2NL0efEMcZ 0ekGLOo0NV8DextRMp0HdFQ7sXmB42fsAKLRkQ5A0CqtPmyqhbgHssZ3Wn9rhP8s6ikBjjTEiGzMT XTmjF5FKDXnfI0hSFkc1qMndIjgrCowlrwn+kGH6SpAfQlDCSBYR0eJ3+EhBdcttgqnyfGMouZDhe mmj28ehOfNlbavQgE4+yXA==; Date: Sat, 30 Nov 2024 12:48:11 +0200 Message-Id: <865xo580b8.fsf@gnu.org> From: Eli Zaretskii To: Fabio Natali In-Reply-To: <87o7226u0j.fsf@fabionatali.com> (message from Fabio Natali on Tue, 26 Nov 2024 12:48:12 +0000) Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> <86bjyrqvb0.fsf@gnu.org> <877c9fmn7b.fsf@gmail.com> <867c9fqpx0.fsf@gnu.org> <87v7wzl30n.fsf@gmail.com> <86zfmbpam0.fsf@gnu.org> <87fro3gu3i.fsf@fabionatali.com> <86v7wzp8a7.fsf@gnu.org> <87cyj7gmwx.fsf@fabionatali.com> <87o7226u0j.fsf@fabionatali.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org, rpluim@gmail.com, me@eshelyaron.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Fabio Natali > Cc: rpluim@gmail.com, me@eshelyaron.com, 74218@debbugs.gnu.org, > stefankangas@gmail.com > Date: Tue, 26 Nov 2024 12:48:12 +0000 > > Hi All, > > I was wondering if there was any further feedback on this and what the > general feeling was with regard to my v2 patch of 6th Nov. > > If there's anything that you think I should adjust in the patch, let me > know and I'll be glad to look into it. The latest patch LGTM, but your legal paperwork of copyright assignment is not yet complete, is it? So we are waiting for it to be completed, and will install at that time. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 04 08:08:54 2024 Received: (at 74218) by debbugs.gnu.org; 4 Dec 2024 13:08:54 +0000 Received: from localhost ([127.0.0.1]:34616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIp7e-0000LM-Hi for submit@debbugs.gnu.org; Wed, 04 Dec 2024 08:08:54 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:34397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIp7c-0000Ky-RH for 74218@debbugs.gnu.org; Wed, 04 Dec 2024 08:08:53 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 0F410240002; Wed, 4 Dec 2024 13:08:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fabionatali.com; s=gm1; t=1733317726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=afunRvX4DwefcSzchVIF3cLf8WJwNI/sS/O60/e6+vM=; b=gTFQn7aMA+75dRY5AU75B7AY3ijMQEENzJwria4QSlFs5ZEeGa2IFPK4p+YoHJbShxzUQn WMGirFZhvRLO8VH/wFfwG88SNB4XQmIJBuKvI6CzJLRh099dWlYJo1LJzlyJEx2A3nnCIc 7mGnXuWlsQHYSlfdXxxMue219VTY+ZPumsKdALvSFbXR/bN3sOwo3xZnM0PDEDZSM1URBa fypXehMNaD5gpOJa3lo+TyAm/W/xoBrImhOr22tZGZK15mg4xLALDGor+4CiQZaf26aPUz KQFvYja7QI4/ofmCXWYdJZj0FWSoyhkpIvruMJsiB7m8/sCwn2JZShT/luG3wA== From: Fabio Natali To: Eli Zaretskii Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. In-Reply-To: <865xo580b8.fsf@gnu.org> References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> <86bjyrqvb0.fsf@gnu.org> <877c9fmn7b.fsf@gmail.com> <867c9fqpx0.fsf@gnu.org> <87v7wzl30n.fsf@gmail.com> <86zfmbpam0.fsf@gnu.org> <87fro3gu3i.fsf@fabionatali.com> <86v7wzp8a7.fsf@gnu.org> <87cyj7gmwx.fsf@fabionatali.com> <87o7226u0j.fsf@fabionatali.com> <865xo580b8.fsf@gnu.org> Date: Wed, 04 Dec 2024 13:08:44 +0000 Message-ID: <87zflba943.fsf@fabionatali.com> MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: me@fabionatali.com X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org, rpluim@gmail.com, me@eshelyaron.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2024-11-30, 12:48 +0200, Eli Zaretskii wrote: > The latest patch LGTM, but your legal paperwork of copyright > assignment is not yet complete, is it? So we are waiting for it to be > completed, and will install at that time. Hi Eli, you're right, sorry, I hadn't acted on that yet. It's all done now, although I guess it might take a few days for things to be processed and for you to see the assignment (or the assignment-related A-OK) at your end. Unless I hear anything, I'll follow-up here in a couple of weeks (say early Jan?) to make sure the assignment has been received and the patch can be merged. Thanks, have a lovely day, Fabio. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 18 12:51:36 2024 Received: (at 74218) by debbugs.gnu.org; 18 Dec 2024 17:51:36 +0000 Received: from localhost ([127.0.0.1]:35888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNyCu-0000BU-Go for submit@debbugs.gnu.org; Wed, 18 Dec 2024 12:51:36 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:40759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNyCr-0000BE-Mu for 74218@debbugs.gnu.org; Wed, 18 Dec 2024 12:51:34 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 6F194FF802; Wed, 18 Dec 2024 17:51:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fabionatali.com; s=gm1; t=1734544286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gw92aKdUxwmtMA6YpE7BNiHetgD2JVPMgdCbKOxsUm8=; b=Y8ihXNKOlhCiV6l+qMRsMcs1/+F+r7ScjU6E78n/EZNOjp/jhkyNBa+Db/8m/m182yJH9I iWJGHsgucHP0ItN3cc8/y7aYBhjXW/QntI4xodzKOitznxDyol4iEPxv4sFTiYLvstXeu1 Z5F14nwkHIldus8x0CuAZ7XcxKoN64tbNCxTXKiYnWUXq9WzaZ3oxQeMX8MhsgZ/1vFFCu 9hvmS8bRgplWb94pPkUt05+3T9TV28dKTRH7OGpu/Qc/h5czQN7H4KCL/l6f5beOE4Y+mS I27D+ajJGgoHM5W0vx9M3hA7ByEMgsoMWc/3416SYmrrX+ceY/chvUCBRcJL+Q== From: Fabio Natali To: Eli Zaretskii Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. In-Reply-To: <87zflba943.fsf@fabionatali.com> References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> <86bjyrqvb0.fsf@gnu.org> <877c9fmn7b.fsf@gmail.com> <867c9fqpx0.fsf@gnu.org> <87v7wzl30n.fsf@gmail.com> <86zfmbpam0.fsf@gnu.org> <87fro3gu3i.fsf@fabionatali.com> <86v7wzp8a7.fsf@gnu.org> <87cyj7gmwx.fsf@fabionatali.com> <87o7226u0j.fsf@fabionatali.com> <865xo580b8.fsf@gnu.org> <87zflba943.fsf@fabionatali.com> Date: Wed, 18 Dec 2024 17:51:24 +0000 Message-ID: <87a5csswv7.fsf@fabionatali.com> MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: me@fabionatali.com X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74218 Cc: 74218@debbugs.gnu.org, rpluim@gmail.com, me@eshelyaron.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2024-12-04, 13:08 +0000, Fabio Natali wrote: > On 2024-11-30, 12:48 +0200, Eli Zaretskii wrote: >> The latest patch LGTM, but your legal paperwork of copyright >> assignment is not yet complete, is it? So we are waiting for it to be >> completed, and will install at that time. (No rush, but I wanted to share that the copyright assignment process has now been completed, as confirmed to me by the FSF copyright-clerk@fsf.org. Cheers, Fabio.) From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 21 03:59:11 2024 Received: (at 74218-done) by debbugs.gnu.org; 21 Dec 2024 08:59:11 +0000 Received: from localhost ([127.0.0.1]:45200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOvKI-0005nK-Kj for submit@debbugs.gnu.org; Sat, 21 Dec 2024 03:59:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOvKF-0005n4-Gn for 74218-done@debbugs.gnu.org; Sat, 21 Dec 2024 03:59:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOvK9-0007Nu-KY; Sat, 21 Dec 2024 03:59:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lI9fbz1Y6LnsIPrZKPY2dvCbYUeJi/6mNeJWvZdpzCQ=; b=qFMvlmxdKDR8 031WNIWlDKB0lJjXu2Jw/K3wNElIJ1V3ik7KtAgjfJRsMOg3IZcpFJzD5yirrQ6iw1CPRbeZTcd3A KWZeYF4LcOeKRYpFWt1GU7LtLoKrqBU6LZwE+O+bkNABYzvZYlV88D/Epq63hQP2STRpsSKixRVQX rS58D4b5YIUP58ZD8cf+R++rUFg+WvulYaAzmycQ0RVuPbTbR0APaB3O26w5GzsPlcV+DxIQ99G1N 1RA0sqbL1w8Gb7bf+P5WJuRkER2YM+y+z35MgZFd3yqndw/YXgYxqZjbAqBIL/w0a2TWWiY2Z4t0p p5QoaZahylkDSRtalS8Pvw==; Date: Sat, 21 Dec 2024 10:58:57 +0200 Message-Id: <86msgp8l9q.fsf@gnu.org> From: Eli Zaretskii To: Fabio Natali In-Reply-To: <87a5csswv7.fsf@fabionatali.com> (message from Fabio Natali on Wed, 18 Dec 2024 17:51:24 +0000) Subject: Re: bug#74218: [PATCH] Ask confirmation before sending region to search engine. References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> <86bjyrqvb0.fsf@gnu.org> <877c9fmn7b.fsf@gmail.com> <867c9fqpx0.fsf@gnu.org> <87v7wzl30n.fsf@gmail.com> <86zfmbpam0.fsf@gnu.org> <87fro3gu3i.fsf@fabionatali.com> <86v7wzp8a7.fsf@gnu.org> <87cyj7gmwx.fsf@fabionatali.com> <87o7226u0j.fsf@fabionatali.com> <865xo580b8.fsf@gnu.org> <87zflba943.fsf@fabionatali.com> <87a5csswv7.fsf@fabionatali.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74218-done Cc: rpluim@gmail.com, 74218-done@debbugs.gnu.org, me@eshelyaron.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Fabio Natali > Cc: rpluim@gmail.com, me@eshelyaron.com, 74218@debbugs.gnu.org, > stefankangas@gmail.com > Date: Wed, 18 Dec 2024 17:51:24 +0000 > > On 2024-12-04, 13:08 +0000, Fabio Natali wrote: > > On 2024-11-30, 12:48 +0200, Eli Zaretskii wrote: > >> The latest patch LGTM, but your legal paperwork of copyright > >> assignment is not yet complete, is it? So we are waiting for it to be > >> completed, and will install at that time. > > (No rush, but I wanted to share that the copyright assignment process > has now been completed, as confirmed to me by the FSF > copyright-clerk@fsf.org. Cheers, Fabio.) Thanks, I've now installed the changes on the master branch, and I'm closing this bug. From unknown Thu Aug 14 21:50:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 18 Jan 2025 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator