GNU bug report logs - #74207
[PATCH] make-mode: Add the missing GNU Make functions

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74207 in the body.
You can then email your comments to 74207 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: <ola.nilsson <at> gmail.com>
To: <bug-gnu-emacs <at> gnu.org>
Cc: Ola Nilsson <ola.nilsson <at> gmail.com>
Subject: [PATCH] make-mode: Add the missing GNU Make functions
Date: Mon, 4 Nov 2024 23:33:09 +0100

From: Ola Nilsson <ola.nilsson <at> gmail.com>

Add and reorder functions according to The GNU Make Manual 0.75 for GNU
make 4.3.

* lisp/progmodes/make-mode.el (makefile-gnumake-functions-alist):
Add missing GNU make functions
---
 lisp/progmodes/make-mode.el | 34 +++++++++++++++++++++++++++-------
 1 file changed, 27 insertions(+), 7 deletions(-)

diff --git a/lisp/progmodes/make-mode.el b/lisp/progmodes/make-mode.el
index 60b87142850..5441903738d 100644
--- a/lisp/progmodes/make-mode.el
+++ b/lisp/progmodes/make-mode.el
@@ -704,7 +704,7 @@ makefile-mode-hook
 ;; Each "ARG" is used as a prompt for a required argument.
 (defconst makefile-gnumake-functions-alist
   '(
-    ;; Text functions
+    ;; Functions for String Substitution and Analysis
     ("subst" "From" "To" "In")
     ("patsubst" "Pattern" "Replacement" "In")
     ("strip" "Text")
@@ -712,22 +712,42 @@ makefile-gnumake-functions-alist
     ("filter" "Pattern" "Text")
     ("filter-out" "Pattern" "Text")
     ("sort" "List")
-    ;; Filename functions
+    ("word" "Index" "Text")
+    ("wordlist" "S" "E" "Text")
+    ("words" "Text")
+    ("firstword" "Text")
+    ("lastword" "Names")
+    ;; Functions for File Names
     ("dir" "Names")
     ("notdir" "Names")
     ("suffix" "Names")
     ("basename" "Names")
-    ("addprefix" "Prefix" "Names")
     ("addsuffix" "Suffix" "Names")
+    ("addprefix" "Prefix" "Names")
     ("join" "List 1" "List 2")
-    ("word" "Index" "Text")
-    ("words" "Text")
-    ("firstword" "Text")
     ("wildcard" "Pattern")
+    ("realpath" "Names")
+    ("abspath" "Names")
+    ;; Functions for Conditionals
+    ("if" "Condition" "Then-part" "Else-part")
+    ("or"  "Condition 1" "Condition 2" "Condition 3" "Condition 4")
+    ("and" "Condition 1" "Condition 2" "Condition 3" "Condition 4")
     ;; Misc functions
     ("foreach" "Variable" "List" "Text")
+    ("file" "Op" "Filename" "Text")
+    ("call" "Variable" "Param 1" "Param 2" "Param 3" "Param 4" "Param 5")
+    ("value" "Variable")
+    ("eval" "statement")
     ("origin" "Variable")
-    ("shell" "Command")))
+    ("flavor" "Variable")
+    ("shell" "Command")
+    ("guile" "Program")
+    ;; Functions that control make
+    ("error" "Text")
+    ("warning" "Text")
+    ("info" "Text")
+    )
+  "Alist of GNU Make functions and their arguments.")
 
 
 ;;; ------------------------------------------------------------
-- 
2.45.2

Message #10 received at 74207-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: ola.nilsson <at> gmail.com
Cc: 74207-done <at> debbugs.gnu.org
Subject: Re: bug#74207: [PATCH] make-mode: Add the missing GNU Make functions
Date: Sat, 09 Nov 2024 13:09:58 +0200

> Cc: Ola Nilsson <ola.nilsson <at> gmail.com>
> From: <ola.nilsson <at> gmail.com>
> Date: Mon, 4 Nov 2024 23:33:09 +0100
> 
> From: Ola Nilsson <ola.nilsson <at> gmail.com>
> 
> Add and reorder functions according to The GNU Make Manual 0.75 for GNU
> make 4.3.
> 
> * lisp/progmodes/make-mode.el (makefile-gnumake-functions-alist):
> Add missing GNU make functions

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.