Subject: Re: bug#74200: [PATCH] Add song viewer to 'mpc'

From: Eli Zaretskii <[email-masked]>
Date: Mon, 04 Nov 2024 14:46:02 +0200

> Cc: [email-masked]
> From: john muhl <[email-masked]>
> Date: Sun, 03 Nov 2024 21:29:53 -0600
> 
> >From 861491d591a4e03bf4d4ceff001fd5036c0afef7 Mon Sep 17 00:00:00 2001
> From: john muhl <[email-masked]>
> Date: Sat, 19 Oct 2024 18:25:41 -0500
> Subject: [PATCH] Add song viewer to 'mpc' (Bug#74200)
> 
> * lisp/mpc.el (mpc-describe-song): New command.
> (mpc-mode-map): Bind "i" to 'mpc-describe-song'.
> (mpc-mode-menu): Add menu item.
> (mpc-secs-to-time): Ensure secs argument is an integer.
> (mpc-song-viewer-empty, mpc-song-viewer-tag):
> (mpc-song-viewer-value): New face.
> (mpc-song-viewer-tags): New option.
> (mpc-song-viewer-tagtypes): New constant.
> ---
>  etc/NEWS    |   7 ++++
>  lisp/mpc.el | 106 +++++++++++++++++++++++++++++++++++++++++++++++++++-
>  2 files changed, 111 insertions(+), 2 deletions(-)

Thanks, a few minor comments.

> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -619,6 +619,13 @@ When non-nil, MPC will crossfade between songs for the specified number
>  of seconds.  Crossfading can be toggled using the command
>  'mpc-toggle-crossfade' or from the MPC menu.
>  
> +*** New command 'mpc-describe-song'.
> +This command displays information about the currently playing song or
> +song at point in the MPC-Songs buffer.  The list of tags to display can
> +be customized using the new user option 'mpc-song-viewer-tags' and the
> +appearance of the list with the new faces 'mpc-song-viewer-tag',
> +'mpc-song-viewer-value', and 'mpc-song-viewer-empty'.

This entry should be marked with "---", as we don't intend to document
this in any manual.

> +(defcustom mpc-song-viewer-tags
> +  '("Title" "Artist" "Album" "Performer" "Composer"
> +    "Date" "Duration" "Disc" "Track" "Genre" "File")
> +  "The list of tags to display with `mpc-describe-song'.

Each new defcustom should have a :version tag.