Subject: Re: bug#74196: maint: assume proper behavior of tolower

From: Simon Josefsson <[email-masked]>
Date: Tue, 05 Nov 2024 10:01:35 +0100

Collin Funk <[email-masked]> writes:

> -#  define casemap(c) tolow(c) /* Force file names to lower case */

This is for MSDOS/OS2/WIN32/ATARI only as far as I can tell -- do we
know that tolower() works as expected on these architectures?  What
problem is caused by the current behaviour?  I think it would be nice to
establish that first.

> @@ -228,7 +228,7 @@ strlwr (char *s)
...
> -      *t = tolow ((unsigned char) *t);
> +      *t = tolower ((unsigned char) *t);

This changes strlwr(), it would be good to audit all usages of it to
understand impact of a change.

/Simon