GNU bug report logs - #74180
[PATCH] gnu: add bash-preexec

Previous Next

Full log

Message #11 received at 74180 <at> debbugs.gnu.org (full text, mbox):

From: Javier Olaechea <pirata <at> gmail.com>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 74180 <at> debbugs.gnu.org
Subject: Re: [bug#74180] [PATCH] gnu: add bash-preexec
Date: Mon, 4 Nov 2024 04:27:45 +0000

[Message part 1 (text/plain, inline)]

> > +
> > +       (sha256
> > +        (base32
> "0nx0m1bhm4f4v033ngi2m9zq3vppimsmn8kmwqbvyqr4n6gkjmgq"))))
> > +    (build-system gnu-build-system)
>
> Looks like you can simply use the copy-build-system here, no?
>

Good call, I've updated the the package to do so. One thing I changed as
well is the location for bash-preexec.sh. I saw arch (
https://gitlab.archlinux.org/archlinux/packaging/packages/bash-preexec/-/blob/main/PKGBUILD?ref_type=heads#L30)
and nix package it under share/ instance of bin/.

Another thing I did was filtering the test files from the package. As they
require the bats package to run.


> > +    (description
> > +     "preexec and precmd hook functions for Bash 3.1+ in the style of
> > Zsh.")
>
> The description should be more descriptive. You can describe the two
> functions like they do in the README.  Use @command{bash/zsh}.  Prefix
> with "This package provides".
>

Updated accordingly. Let me know if there are any other improvements

-- 
"I object to doing things that computers can do." — Olin Shivers

[Message part 2 (text/html, inline)]

[v2-0001-gnu-add-bash-preexec.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.