From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 02 01:35:14 2024 Received: (at submit) by debbugs.gnu.org; 2 Nov 2024 05:35:14 +0000 Received: from localhost ([127.0.0.1]:52862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t76n4-0005Yh-Ed for submit@debbugs.gnu.org; Sat, 02 Nov 2024 01:35:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:59134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t76n1-0005YZ-Sv for submit@debbugs.gnu.org; Sat, 02 Nov 2024 01:35:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t76n1-00074X-Jh for guix-patches@gnu.org; Sat, 02 Nov 2024 01:35:11 -0400 Received: from mail-yw1-x1130.google.com ([2607:f8b0:4864:20::1130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t76mz-0004R4-8H for guix-patches@gnu.org; Sat, 02 Nov 2024 01:35:10 -0400 Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-6e38fc62b9fso22927897b3.2 for ; Fri, 01 Nov 2024 22:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730525707; x=1731130507; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=vVyI4ZDZgxaoa79O1VXmV76EbB3hGaAvdq3gR7QDGpk=; b=YswbI1VH0PK5ajrT9OLE8ryZINSSZRNLw3248S1XLcKnXpDkJLvyDG5Nm14eoPrKMF VhOgum6Zec215KDJqc9dBgyFkIb+KCZFk3cef17uhItBUX35BqETwM/b69CrGeiH3nup +p+8zJ4rH27C2EBd8oeRfjDysSqc01Fqx7AcMqhu/+l6KgV6+5DgrWlKUNBD1as0bA1f Dx6lfZB+6FtYc/OBT3/IgyR9j0fjyiBvNeqWCLBBPCgdMUsfg2qH91p6MUW5BZRBiUkr nwgxKLtHK2up8fGYSAgPqycuMSLb+zGelYFNIleX4NWwPpTPeE/lyygkdV6b60ifmvEV JWPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730525707; x=1731130507; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=vVyI4ZDZgxaoa79O1VXmV76EbB3hGaAvdq3gR7QDGpk=; b=BYRJp/CEiglh7an/LU/4qd9KSLRmSVZcwlvUy1hnFan7CxZCBtS7tJhITkQ70Sbff1 PSqOQBhG6xoVaX1psctFkJGJwGncn6RfFNuDlwRbEGGTmbmwA8bGEW6ZwtRN1o1RmmfW A6X0nn/x6YiWAno/m0ZPdTSS4kHybfECyay5naDWuYeYSYni8/tDQKvi75nC1J9N8jou HV9VTubOesodOjlfgWuz4isE6ADSZJv97i+TsFWbIRcVlFLYkfnuwI4csSQnV66SXOvy k4PkRrXFJAQJjpky2mMUcQbxdgDBCnxBgZibDgb7TZl56SPIlpS8Eo7+erIfqqkaR0Fe W8dQ== X-Gm-Message-State: AOJu0YwvHYrtA+RjeB8gaVY3tEdXsbM4zoyKvDbRrCyn3JaZ1XVEGwJz Zh1/A6AWbodGDBMzTiCx44rrkHz1D5fzDLouS97l9ta3OlTM4/WXGdcNkbIvrg01CzJGILINfUF k9a9/kQzYrdmyOu8S/YFdh7wH1HEEmA== X-Google-Smtp-Source: AGHT+IF6FMYDytxNzAaHQr3f9pj6Wsm19zowtpHwRyfBVnCoz6y8uvBvgUN8B05LxTZqU/3quouF0+6+RroNj3vWXbw= X-Received: by 2002:a05:690c:c07:b0:6c7:a120:e0ec with SMTP id 00721157ae682-6ea64b11504mr67481897b3.22.1730525707111; Fri, 01 Nov 2024 22:35:07 -0700 (PDT) MIME-Version: 1.0 From: Javier Olaechea Date: Sat, 2 Nov 2024 05:34:56 +0000 Message-ID: Subject: [PATCH] gnu: Add emacs-eslint-flymake. To: guix-patches@gnu.org Content-Type: multipart/mixed; boundary="0000000000000c2d850625e76a24" Received-SPF: pass client-ip=2607:f8b0:4864:20::1130; envelope-from=pirata@gmail.com; helo=mail-yw1-x1130.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --0000000000000c2d850625e76a24 Content-Type: multipart/alternative; boundary="0000000000000c2d840625e76a22" --0000000000000c2d840625e76a22 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Attached is a patch to add the eslint-flymake package. It is a flymake backend for ESLint. Cheers --=20 "I object to doing things that computers can do." =E2=80=94 Olin Shivers --0000000000000c2d840625e76a22 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Attached is a patch to a= dd the eslint-flymake package. It is a flymake backend for ESLint.

Cheers

--
"I object to doing things that computers can do= ." =E2=80=94 Olin Shivers
--0000000000000c2d840625e76a22-- --0000000000000c2d850625e76a24 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gnu-Add-emacs-eslint-flymake.patch" Content-Disposition: attachment; filename="0001-gnu-Add-emacs-eslint-flymake.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m2zq7b760 RnJvbSA0MjE3ZDVjZjE1MTkzZDkwNTg0ZGM2M2E5ZmU4NTlkZjU2ZmY4YjVmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlEOiA8NDIxN2Q1Y2YxNTE5M2Q5MDU4NGRjNjNhOWZlODU5 ZGY1NmZmOGI1Zi4xNzMwNTI1NDYzLmdpdC5waXJhdGFAZ21haWwuY29tPgpGcm9tOiBKYXZpZXIg T2xhZWNoZWEgPHBpcmF0YUBnbWFpbC5jb20+CkRhdGU6IFNhdCwgMiBOb3YgMjAyNCAwMDoyNjoy MiAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIGdudTogQWRkIGVtYWNzLWVzbGludC1mbHltYWtlLgoK KiBnbnUvcGFja2FnZXMvZW1hY3MteHl6LnNjbSAoZW1hY3MtZXNsaW50LWZseW1ha2UpOiBOZXcg dmFyaWFibGUuCgpDaGFuZ2UtSWQ6IEkwYzViYjEyNzk0NzNkMjVjZTE2ZjdjZjEyNTYyMGU4MTk1 MzliYmZkCi0tLQogZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20gfCAyMiArKysrKysrKysrKysr KysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBh L2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtIGIvZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20K aW5kZXggNDg4YjRjYjVkNy4uYTk5NGU0YWIzMyAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL2Vt YWNzLXh5ei5zY20KKysrIGIvZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20KQEAgLTE0ODQsNiAr MTQ4NCwyOCBAQCAoZGVmaW5lLXB1YmxpYyBlbWFjcy1mbHltYWtlCiBjYWxsZWQgYmFja2VuZHMs IGFuZCB2aXN1YWxseSBhbm5vdGF0ZXMgdGhlIHJlbGV2YW50IHBvcnRpb25zIGluIHRoZSBidWZm ZXIuIikKICAgICAobGljZW5zZSBsaWNlbnNlOmdwbDMrKSkpCiAKKyhkZWZpbmUtcHVibGljIGVt YWNzLWVzbGludC1mbHltYWtlCisgIChsZXQgKChjb21taXQgImM3ODI0NjMzMGVlM2FjMWUwZTA3 YTcwOTQ3M2Q5OGExMTNkMjY4ZTUiKQorICAgICAgICAocmV2aXNpb24gIjEiKSkKKyAgICAocGFj a2FnZQorICAgICAgKG5hbWUgImVtYWNzLWVzbGludC1mbHltYWtlIikKKyAgICAgICh2ZXJzaW9u ICIwLjIuMCIpCisgICAgICAoc291cmNlCisgICAgICAgKG9yaWdpbgorICAgICAgICAgKG1ldGhv ZCBnaXQtZmV0Y2gpCisgICAgICAgICAodXJpIChnaXQtcmVmZXJlbmNlCisgICAgICAgICAgICAg ICAodXJsICJodHRwczovL2dpdGh1Yi5jb20vZW1hY3MtcGUvZXNsaW50LWZseW1ha2UiKQorICAg ICAgICAgICAgICAgKGNvbW1pdCBjb21taXQpKSkKKyAgICAgICAgIChzaGEyNTYKKyAgICAgICAg ICAoYmFzZTMyICIxOWg5NWs1N2hyc3lzbXZxemlsbHpmbjZ3Y2ludmNpZHYxNGZ2YmFxeGdpZ3dm d2owam53IikpKSkKKyAgICAgIChidWlsZC1zeXN0ZW0gZW1hY3MtYnVpbGQtc3lzdGVtKQorICAg ICAgKHByb3BhZ2F0ZWQtaW5wdXRzIChsaXN0IGVtYWNzLWZseW1ha2UpKQorICAgICAgKGhvbWUt cGFnZSAiaHR0cHM6Ly9naXRodWIuY29tL2VtYWNzLXBlL2VzbGludC1mbHltYWtlIikKKyAgICAg IChzeW5vcHNpcyAiQW4gRVNMaW50IGJhY2tlbmQgZm9yIEZseW1ha2UiKQorICAgICAgKGRlc2Ny aXB0aW9uCisgICAgICAgIlRoaXMgcGFja2FnZSBsZXRzIGZseW1ha2UgcnVuIEVTTGludCBvbiB0 aGUgY3VycmVudCBidWZmZXIuIikKKyAgICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMyspKSkpCisK IDs7IFBhY2thZ2UgaGFzIG5vIHJlbGVhc2UuICBWZXJzaW9uIGlzIGV4dHJhY3RlZCBmcm9tICJW ZXJzaW9uOiIga2V5d29yZCBpbgogOzsgbWFpbiBmaWxlLgogKGRlZmluZS1wdWJsaWMgZW1hY3Mt cHJvamVjdC1tb2RlLWxpbmUtdGFnCgpiYXNlLWNvbW1pdDogYmI1Y2NiZmM3MGU4MzNkYWRiMGU2 NDQ1NDIyYzYyNTRhOWRlMzAwMgotLSAKMi40Ni4wCgo= --0000000000000c2d850625e76a24-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 03 15:01:36 2024 Received: (at 74173) by debbugs.gnu.org; 3 Nov 2024 20:01:36 +0000 Received: from localhost ([127.0.0.1]:34345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7gn1-00031S-Uf for submit@debbugs.gnu.org; Sun, 03 Nov 2024 15:01:36 -0500 Received: from 16.mo561.mail-out.ovh.net ([188.165.56.217]:34939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7gmy-00031M-D9 for 74173@debbugs.gnu.org; Sun, 03 Nov 2024 15:01:33 -0500 Received: from director4.ghost.mail-out.ovh.net (unknown [10.109.148.6]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id 4XhQTk4swsz1Nlb for <74173@debbugs.gnu.org>; Sun, 3 Nov 2024 20:01:30 +0000 (UTC) Received: from ghost-submission-5b5ff79f4f-sfhfs (unknown [10.108.42.28]) by director4.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 3C5FA1FE04 for <74173@debbugs.gnu.org>; Sun, 3 Nov 2024 20:01:29 +0000 (UTC) Received: from ngraves.fr ([37.59.142.107]) by ghost-submission-5b5ff79f4f-sfhfs with ESMTPSA id O58cH5nWJ2egixUAWhdPeA (envelope-from ) for <74173@debbugs.gnu.org>; Sun, 03 Nov 2024 20:01:29 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-107S001bfc43684-7fe3-482a-b2d0-e8369ab3cbe0, AE4F9A324CDBAF4B52618B2723BB28A1C21EBFEF) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 86.246.19.221 From: Nicolas Graves To: 74173@debbugs.gnu.org Subject: [PATCH] gnu: Add emacs-eslint-flymake. Date: Sun, 03 Nov 2024 21:01:29 +0100 Message-ID: <87cyjcozmu.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 15463672270633755181 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeeftddrvdelgedgudefvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvufffkfggtgesthdtredttddttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeeujeelieeljeffhfelteejtdeljeehveduffelvefgudefkeehgfdvvdevgeevfeenucfkphepuddvjedrtddrtddruddpkeeirddvgeeirdduledrvddvuddpfeejrdehledrudegvddruddtjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepjeegudejfeesuggvsggsuhhgshdrghhnuhdrohhrghdpoffvtefjohhsthepmhhoheeiuddpmhhouggvpehsmhhtphhouhht DKIM-Signature: a=rsa-sha256; bh=LvNPRapKWswJ4WQ6FLKcuPwAeCYgP3QHbq2Pc9u2HiA=; c=relaxed/relaxed; d=ngraves.fr; h=From; s=ovhmo4487190-selector1; t=1730664090; v=1; b=J5onZEe99FTK0Q/wKlbCNCSD2FDTP/9/SM3Ck6JhBIXbrPHL2j2r5fK4sy1tuz+TuQFPWg/L kO+OACNvAjN0nkW86LA7iXqZjKg8wxAc9H8/3mgt+XkgOHQH5/ikbQZOO3b5sC4dQq/x8a3CC+o VLk1elmwXfJn+bcZOow2Sokqav9+UG/9LO4knoa4TKkbR9vLLHbi5TrMOFhwIoUUrWfuINlbixi 624qQDrn6z1b9NaTdqJpo9LlZg0uyjrFEwZlkKdvW33TEhNN3rdACdSpqD6IQmOhJtHdEGD+xsp 3lEkKZkyLjZbh1B0HWJB5w5lqTJNQHfpIJ5VmpMt78Uvw== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74173 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Javier, I just took a quick look at the package and haven't tried to build it yet. Shouldn't it hardcode the eslint binary and add eslint as an input? I guess this would be necessary since we would probably expect that such a package should work without requiring the user to explicitely install eslint in its profile. -- Best regards, Nicolas Graves From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 04 00:00:55 2024 Received: (at 74173) by debbugs.gnu.org; 4 Nov 2024 05:00:55 +0000 Received: from localhost ([127.0.0.1]:37253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7pCw-0003hD-Pz for submit@debbugs.gnu.org; Mon, 04 Nov 2024 00:00:55 -0500 Received: from mail-yb1-f174.google.com ([209.85.219.174]:44128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7pCu-0003h7-GP for 74173@debbugs.gnu.org; Mon, 04 Nov 2024 00:00:53 -0500 Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-e30cef4ac5dso3377254276.0 for <74173@debbugs.gnu.org>; Sun, 03 Nov 2024 21:00:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730696392; x=1731301192; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=Mw6wInM+NQlHGIwsnZQXzgWdXLwP0e2onp3COkp1zgE=; b=S2qCEQcsUm3dXs5EOkoaUW+/LRc3bO6NHJW0hBkLmC6kGGNQ2m0Duvx7mLDsVM1+AQ x8alA0p4ClFPlEUobK1NvAovd+gE3UtSAxY0IrIe5NVqLTRbqMH4ijp5kNgN6gj8U7xA ddEct9FfaMzux2e5m2sqnn+4wxDt8Q8BXv7Jqbs/E0cemgph8/us+XDwxJ274RLqFcz9 OeLplbYQN1vWcHGBnIy9o583PxMZUd15TQ0Th/rS33eKwdQKR4aVYi0N4VIYbOzhkT8g DZsxkueJ6bLpHVzNsnwYBthCAndOqKh/Tw2aablphOufV3MlUHcSFIBY38mGlEq+Iv4Z YOXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730696392; x=1731301192; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Mw6wInM+NQlHGIwsnZQXzgWdXLwP0e2onp3COkp1zgE=; b=vo8aWXHo2+HZwoBEn0jm+v/RjIE66TkPfIMvBqDRXhtSafLlzCZ/FSyASkt/OeA2MN 5IDpaid4rkRuFh59F2XAZCeuFz21BusA27t64proMDVtSx0E19POJ9Pg6ozQ/Fcxz5Bf jETWnwPcOQWAosC1ZO7iBipPkoI6j3f4G8AlW3UD/TR3Ij+ltGTXWxu7j76JR+XjZWFp t+9hkZBKtpbRTqF9Rs+VGyd07FNTDjKkmH39H+nY4rik9djuqUe4baQN8U35fR8xvx3K XYAVAIH88aMgxlnK+AdctGHfvmC0HKAPyNuFtt0hcrjPPhOEj5il/wc+D53XJxFhrMKa CAzA== X-Gm-Message-State: AOJu0YxDnrLeS3KKIrj1IejF4SrOJcpdHjisvypJDfrxUo+I7WnRJAyy 6VqB555FuSMmLEovC+ajgyajy8KbCntsxZ44BppHPqf+r/es3yCZ7yDSxf18ZJPf0P86hTmtZDh uRL1oaK2Kjemwfn2ZHjeZXQ9+q3hLTG8/ X-Google-Smtp-Source: AGHT+IH/mZjwuVxW+ON3gpQFfF8TOKdAlWx0Ye4TlIYW2RnjEmqpmbJRWeF4bKTNnBP+F9L7RpLnoAKYunGbNy4Mvow= X-Received: by 2002:a05:690c:89:b0:6e6:248:341e with SMTP id 00721157ae682-6ea3b72366amr198123797b3.0.1730696391904; Sun, 03 Nov 2024 20:59:51 -0800 (PST) MIME-Version: 1.0 From: Javier Olaechea Date: Mon, 4 Nov 2024 04:59:41 +0000 Message-ID: Subject: [PATCH] gnu: Add emacs-eslint-flymake. To: 74173@debbugs.gnu.org Content-Type: multipart/alternative; boundary="000000000000a754f806260f272d" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74173 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000a754f806260f272d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Shouldn't it hardcode the eslint binary and add eslint as an input? I can see the argument for both cases. In favor of listing as a dependency is that the minor mode can be enabled globally out of the box and it will run successfully. I also checked other flymake packages included by GUIX, https://packages.guix.gnu.org/search/?query=3Dflymake, like proselint and percritic and we _do_ include programs they depend on as a dependency. So including eslint as dependency seems aligned with our practices. If we end up deciding to do this, should we include rubocop as a dependency of emacs-flymake? The flymake package ships with a rubocop backend. The argument against is that ESlint is a program one runs in the context of developing software for a specific project. ESlint has multiple versions with different defaults. And one always wants to run the same version of ESLint that is specified by the package.json. As that is the version that will be used by CI. Personally I use npx to ensure that the version of ESLint being used is the project specific one w/o having to resort to project specific configuration. My personal preference would be to not include it, but I'm fine either way. Let me know what you think. A more practical consideration for not including ESLint as an input right now is that we don't have a package for it! I can look into packaging ESLint but I'd rather we block this patch until we package ESLint. It seems RDE has a package for it. Cheers --=20 "I object to doing things that computers can do." =E2=80=94 Olin Shivers --000000000000a754f806260f272d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Shouldn't it hardc= ode the eslint binary and add eslint as an input?

I can= see the argument for both cases. In favor of listing as a dependency is th= at the minor mode can be enabled globally out of the box and it will run su= ccessfully. I also checked other flymake packages included by GUIX, https://packages= .guix.gnu.org/search/?query=3Dflymake, like proselint and percritic and= we _do_ include programs they depend on as a dependency. So including esli= nt as dependency seems aligned with our practices.=C2=A0 If we end up decid= ing to do this, should we include rubocop as a dependency of emacs-flymake?= The flymake package ships with a rubocop backend.

The argument against is that ESlint is a program one runs in the cont= ext of developing software for a specific project. ESlint has multiple vers= ions with different defaults. And one always wants to run the same version = of ESLint that is specified by the package.json. As that is the version tha= t will be used by CI. Personally I use npx to ensure that the version of ES= Lint being used is the project specific one w/o having to resort to project= specific configuration.

My personal preference wo= uld be to not include it, but I'm fine either way. Let me know what you= think.

A more practical consideration for not= including ESLint as an input right now is that we don't have a package= for it! I can look into packaging ESLint but I'd rather we block this = patch until we package ESLint. It seems RDE has a package for it.

Cheers

--
"I object to doing things that computers can do.= " =E2=80=94 Olin Shivers
--000000000000a754f806260f272d-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 03 06:09:41 2025 Received: (at 74173-done) by debbugs.gnu.org; 3 Jan 2025 11:09:41 +0000 Received: from localhost ([127.0.0.1]:49757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTfYj-0000tY-2n for submit@debbugs.gnu.org; Fri, 03 Jan 2025 06:09:41 -0500 Received: from msg-4.mailo.com ([213.182.54.15]:53090 helo=mailo.com) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tTfYg-0000tH-6k for 74173-done@debbugs.gnu.org; Fri, 03 Jan 2025 06:09:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nicolasgoaziou.fr; s=mailo; t=1735902571; bh=nCIfTOrYvNb1vTKp9dWcC2nx/NKwJzRfoLnGHX6j1PI=; h=X-EA-Auth:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type; b=BkgeIg+o6z0zRvKlpzWJVby3g2m3hiIrGcgJ8osDFQ+KAvRxE13ALPI5OA55XkUON J8keZ9xtp2jTgtPfKeCsEJ5Bf+wTzJQvH1eGXb82j8tYbkEYTHyMix1hVYL8iJ4y0m uZf4cZTE2nMWwQ9DVEV2YW+FU8sq0n2ykDUt9F1M= Received: by b221-2.in.mailobj.net [192.168.90.22] with ESMTP via ip-20.mailobj.net [213.182.54.20] Fri, 3 Jan 2025 12:09:31 +0100 (CET) X-EA-Auth: qJvsCMJ4k9T/p1/y70xfCpf2k9LZ15soVB214oM7aB3vqWLtclevvU1aPY0E5hjn1gnkAkmDqyQZkJf4FFAbsamL7rb5KJ+qx2p4y8HBa+4= From: Nicolas Goaziou To: Javier Olaechea Subject: Re: [bug#74173] [PATCH] gnu: Add emacs-eslint-flymake. In-Reply-To: (Javier Olaechea's message of "Sat, 2 Nov 2024 05:34:56 +0000") References: Date: Fri, 03 Jan 2025 12:09:15 +0100 Message-ID: <87h66g9msk.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74173-done Cc: 74173-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Javier Olaechea writes: > Attached is a patch to add the eslint-flymake package. It is a flymake > backend for ESLint. Applied. Thank you. Regards, -- Nicolas Goaziou From unknown Fri Sep 05 20:55:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 31 Jan 2025 12:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator