GNU bug report logs - #74141
[PATCH] daemon: Fix --with-libgcrypt-* args of the configure script

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andreas Enge <andreas <at> enge.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74141: closed ([PATCH] daemon: Fix --with-libgcrypt-* args of
 the configure script)
Date: Fri, 22 Nov 2024 19:18:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 22 Nov 2024 20:16:59 +0100
with message-id <Z0DYq79HKnauNVmb <at> jurong>
and subject line Close
has caused the debbugs.gnu.org bug report #74141,
regarding [PATCH] daemon: Fix --with-libgcrypt-* args of the configure script
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74141: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74141
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Doğan Çeçen <sepeth <at> fastmail.com>
To: guix-patches <at> gnu.org
Cc: Doğan Çeçen <sepeth <at> fastmail.com>
Subject: [PATCH] daemon: Fix --with-libgcrypt-* args of the configure script
Date: Wed, 30 Oct 2024 22:41:06 +0200

This change fixes the LDFLAGS pointing to a previously nonexistent
var (LIBGCRYPT_LDFLAGS). The name for this var was LIBGCRYPT_LIBS.

Also, CFLAGS was not the correct destination since the checks were done
with g++ and the env var for it is CXXFLAGS.

Another issue was with the save_CFLAGS and save_LDFLAGS trick. While
this is thoughtful, LDFLAGS and CXXFLAGS still need to be modified for
`make` to find the correct lib.

* config-daemon.ac: Fix LDFLAGS and CXXFLAGS for --with-libgcrypt-*
args of the configure script.

Change-Id: I0f3867491e46608e71b1ea0b3214674bca64b31d
---
 config-daemon.ac | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/config-daemon.ac b/config-daemon.ac
index 9854f1d694..1ac204ceed 100644
--- a/config-daemon.ac
+++ b/config-daemon.ac
@@ -39,28 +39,26 @@ if test "x$guix_build_daemon" = "xyes"; then
 
   case "$LIBGCRYPT_PREFIX" in
     no)
-      LIBGCRYPT_CFLAGS=""
+      LIBGCRYPT_CXXFLAGS=""
       ;;
     *)
-      LIBGCRYPT_CFLAGS="-I$LIBGCRYPT_PREFIX/include"
+      LIBGCRYPT_CXXFLAGS="-I$LIBGCRYPT_PREFIX/include"
       ;;
   esac
 
   case "$LIBGCRYPT_LIBDIR" in
     no | "")
-      LIBGCRYPT_LIBS="-lgcrypt"
+      LIBGCRYPT_LDFLAGS="-lgcrypt"
       ;;
     *)
-      LIBGCRYPT_LIBS="-L$LIBGCRYPT_LIBDIR -lgcrypt"
+      LIBGCRYPT_LDFLAGS="-L$LIBGCRYPT_LIBDIR -lgcrypt"
       ;;
   esac
 
-  AC_SUBST([LIBGCRYPT_CFLAGS])
-  AC_SUBST([LIBGCRYPT_LIBS])
+  AC_SUBST([LIBGCRYPT_CXXFLAGS])
+  AC_SUBST([LIBGCRYPT_LDFLAGS])
 
-  save_CFLAGS="$CFLAGS"
-  save_LDFLAGS="$LDFLAGS"
-  CFLAGS="$CFLAGS $LIBGCRYPT_CFLAGS"
+  CXXFLAGS="$CXXFLAGS $LIBGCRYPT_CXXFLAGS"
   LDFLAGS="$LDFLAGS $LIBGCRYPT_LDFLAGS"
 
   have_gcrypt=yes
@@ -70,9 +68,6 @@ if test "x$guix_build_daemon" = "xyes"; then
     AC_MSG_ERROR([GNU libgcrypt not found; please install it.])
   fi
 
-  CFLAGS="$save_CFLAGS"
-  LDFLAGS="$save_LDFLAGS"
-
   dnl Chroot support.
   AC_CHECK_FUNCS([chroot unshare])
   AC_CHECK_HEADERS([sched.h sys/param.h sys/mount.h sys/syscall.h])

base-commit: 6e50b0c56a8cc767bd3acb26638f78c450bde718
-- 
2.46.0

[Message part 3 (message/rfc822, inline)]

From: Andreas Enge <andreas <at> enge.fr>
To: 74141-done <at> debbugs.gnu.org
Subject: Close
Date: Fri, 22 Nov 2024 20:16:59 +0100

Applied, thanks a lot for the patch!

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.