GNU bug report logs - #74140
[PATCH] Add :continue-only directive for repeat maps in bind-keys, use-package

Previous Next

Package: emacs;

Reported by: Paul Nelson <ultrono <at> gmail.com>

Date: Thu, 31 Oct 2024 17:37:02 UTC

Severity: wishlist

Tags: patch

Fixed in version 31.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: "Paul D. Nelson" <ultrono <at> gmail.com>
Cc: 74140 <at> debbugs.gnu.org, eliz <at> gnu.org
Subject: bug#74140: [PATCH] Add :continue-only directive for repeat maps in bind-keys, use-package
Date: Mon, 24 Feb 2025 19:29:20 +0200
>> I was trying to keep the existing function signature for 'repeat-get-map'
>> that was without arguments.  But maybe it's fine to add a new required
>> argument.  Then refactoring was straightforward, and now even modified
>> tests passed.  Please try it out.
>
> Thanks, Juri.  I've refactored my original patch to use the
> 'repeat-continue' property that you've added.  Any further comments
> would be welcome.

Thanks, I tried to run tests with your patch
on the following part of 'repeat-tests-bind-keys'
that was previously commented out:

      ;; 'C-M-o' should not activate
      (repeat-tests--check
       "C-M-o c z"
       '((1 o)) "cz")

but this test fails.  I haven't yet investigated the reason.




This bug report was last modified 141 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.