GNU bug report logs - #74140
[PATCH] Add :continue-only directive for repeat maps in bind-keys, use-package

Previous Next

Full log

Message #70 received at 74140 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: 74140 <at> debbugs.gnu.org, eliz <at> gnu.org
Subject: Re: bug#74140: [PATCH] Add :continue-only directive for repeat maps
 in bind-keys, use-package
Date: Tue, 17 Dec 2024 20:58:40 +0200

> I think the repeat-map property is fine as is, but the logic should be a
> bit different:
>
> - If a command is called while repeat map MAP is active, then:
>
>   - If the command's repeat-continue-only property contains MAP, then
>     MAP remains active (i.e., that map "continues").  [Maybe a better
>     name for the property would be simply "repeat-continue".]

So the property is renamed now to 'repeat-continue'.

>   - Otherwise, if the command has a repeat-map property, then that
>     becomes the new repeat map.
>
>   - Otherwise, the repeat map deactivates.
>
> - If a command is called while no repeat map is active, then we proceed
>   as before.
>
> Do you agree that this is the desired behavior?  The difference is that
> with the current implementation, only the repeat-map property is
> relevant for determining which repeat map a command activates or
> continues.

Thanks for the clear explanation.  Now this is completely implemented
with tests.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.