Subject: Re: [bug#74136] [PATCH 2/2] gnu: Update emacs-popwin to 1.0.2.-2.58adcd0.

From: Ian Eure <[email-masked]>
Date: Sat, 05 Apr 2025 12:35:29 -0700

Hi Rostislav,

Rostislav Svoboda <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-popwin): Update to 
> 1.0.2.-2.58adcd0.
>
> Change-Id: Ie7ee892b737310a002a6e74bd5138b041eaf30bd
> ---
>  gnu/packages/emacs-xyz.scm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm 
> b/gnu/packages/emacs-xyz.scm
> index 46fee0b7d6..d13d92731f 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -15770,8 +15770,8 @@ (define-public 
> emacs-find-file-in-project
>      (license license:gpl3+)))
>  
>  (define-public emacs-popwin
> -  (let ((commit "215d6cb509b11c63394a20666565cd9e9b2c2eab")
> -        (revision "1"))
> +  (let ((commit "58adcd0ca7c3dbd58626ec7019252d64cbc73042")
> +        (revision "2"))
>      (package
>        (name "emacs-popwin")
>        (version (git-version "1.0.2" revision commit))
> @@ -15783,7 +15783,7 @@ (define-public emacs-popwin
>                 (commit commit)))
>           (file-name (git-file-name name version))
>           (sha256
> -          (base32 
> "1x1iimzbwb5izbia6aj6xv49jybzln2qxm5ybcrcq7xync5swiv1"))))
> +          (base32 
> "1mqwzc6fwhwq1kl8b3i1hm2ylfh8blrxrw6mzr5wyifbwpg7dq10"))))
>        (build-system emacs-build-system)
>        (home-page "https://github.com/emacsorphanage/popwin")
>        (synopsis "Popup window manager for Emacs")

This patch doesn’t apply to Guix master.  The emacs-popwin package 
in master builds the 1.0.2 tag and doesn’t have a `let' around it 
specifying a commit.  Since the guix package hasn’t changed since 
2023, it makes me wonder if your patch is based off a local fork, 
rather than master.

If you’d like to send a v2 that applies to master, I’d be happy to 
push it.  Looks like there have been a few commits since you sent 
this patch, though they don’t change functionality at all -- 
you’re welcome to include them or not.

Thanks,

  -- Ian